Issues in Config.php - Fixed Issues - Inspection of "Refactor Config methods inside, add some Config Un..." - godbout/alfred-time - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da5576...d20c63 )

by Guillaume

created 2017-05-24 18:14 UTC

src/Config.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AlfredTime;

/**
 * Config
 */
class Config
{
    /**
     * @var mixed
     */
    private $config = [];

    /**
     * @var array
     */
    private $services = [
        'toggl',
        'harvest',
    ];

    /**
     * @param $filename
     */
    public function __construct($filename = null)
    {
        if ($filename !== null) {
            $this->load($filename);
        }
    }

    /**
     * @return mixed
     */
    public function activatedServices()

    {
        $activatedServices = [];

        foreach ($this->services as $service) {
            if ($this->get($service, 'is_active') === true) {
                array_push($activatedServices, $service);
            }
        }

        return $activatedServices;
    }

    public function generateDefaultConfigurationFile()
    {
        $this->config = [
            'timer'   => [
                'primary_service' => 'toggl',
                'is_running'      => false,
                'toggl_id'        => null,
                'harvest_id'      => null,
                'description'     => '',
            ],
            'toggl'   => [
                'is_active' => true,
                'api_token' => '',
            ],
            'harvest' => [

                'is_active' => true,
                'domain'    => '',
                'api_token' => '',
            ],
        ];

        $this->save();
    }

    /**
     * @param  $section
     * @param  null       $param
     * @return mixed
     */
    public function get($section = null, $param = null)
    {
        if ($section === null) {
            return $this->config;
        } elseif ($param === null) {
            return $this->config[$section];
        }

        return $this->config[$section][$param];
    }

    /**
     * @return boolean
     */
    public function isConfigured()
    {
        return empty($this->config) === false;
    }

    /**
     * @return mixed
     */
    public function runningServices()

    {
        $services = [];

        foreach ($this->activatedServices() as $service) {
            if ($this->get('timer', $service . '_id') !== null) {
                array_push($services, $service);
            }
        }

        return $services;
    }

    /**
     * @param $section
     * @param $param
     * @param $value
     */
    public function update($section, $param, $value)
    {
        $this->config[$section][$param] = $value;
        $this->save();
    }

    /**
     * @return mixed
     */
    private function load($filename)
    {
        if (file_exists($filename)) {
            $this->config = json_decode(file_get_contents($filename), true);
        }
    }

    private function save()
    {
        $workflowDir = getenv('alfred_workflow_data');
        $configFile = $workflowDir . '/config.json';

        if (file_exists($workflowDir) === false) {
            mkdir($workflowDir);
        }

        file_put_contents($configFile, json_encode($this->config, JSON_PRETTY_PRINT));
    }
}


1		<?php
2
3		namespace AlfredTime;
4
5		/**
6		* Config
7		*/
8		class Config
9		{
10		/**
11		* @var mixed
12		*/
13		private $config = [];
14
15		/**
16		* @var array
17		*/
18		private $services = [
19		'toggl',
20		'harvest',
21		];
22
23		/**
24		* @param $filename
25		*/
26		public function __construct($filename = null)
27		{
28		if ($filename !== null) {
29		$this->load($filename);
30		}
31		}
32
33		/**
34		* @return mixed
35		*/
36	View Code Duplication	public function activatedServices()
		0 ignored issues – show Duplication introduced 2017-05-12 08:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$activatedServices = [];
39
40		foreach ($this->services as $service) {
41		if ($this->get($service, 'is_active') === true) {
42		array_push($activatedServices, $service);
43		}
44		}
45
46		return $activatedServices;
47		}
48
49		public function generateDefaultConfigurationFile()
50		{
51		$this->config = [
52		'timer' => [
53		'primary_service' => 'toggl',
54		'is_running' => false,
55		'toggl_id' => null,
56		'harvest_id' => null,
57		'description' => '',
58		],
59		'toggl' => [
60		'is_active' => true,
61		'api_token' => '',
62		],
63		'harvest' => [
64
65		'is_active' => true,
66		'domain' => '',
67		'api_token' => '',
68		],
69		];
70
71		$this->save();
72		}
73
74		/**
75		* @param $section
76		* @param null $param
77		* @return mixed
78		*/
79		public function get($section = null, $param = null)
80		{
81		if ($section === null) {
82		return $this->config;
83		} elseif ($param === null) {
84		return $this->config[$section];
85		}
86
87		return $this->config[$section][$param];
88		}
89
90		/**
91		* @return boolean
92		*/
93		public function isConfigured()
94		{
95		return empty($this->config) === false;
96		}
97
98		/**
99		* @return mixed
100		*/
101	View Code Duplication	public function runningServices()
		0 ignored issues – show Duplication introduced 2017-05-18 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102		{
103		$services = [];
104
105		foreach ($this->activatedServices() as $service) {
106		if ($this->get('timer', $service . '_id') !== null) {
107		array_push($services, $service);
108		}
109		}
110
111		return $services;
112		}
113
114		/**
115		* @param $section
116		* @param $param
117		* @param $value
118		*/
119		public function update($section, $param, $value)
120		{
121		$this->config[$section][$param] = $value;
122		$this->save();
123		}
124
125		/**
126		* @return mixed
127		*/
128		private function load($filename)
129		{
130		if (file_exists($filename)) {
131		$this->config = json_decode(file_get_contents($filename), true);
132		}
133		}
134
135		private function save()
136		{
137		$workflowDir = getenv('alfred_workflow_data');
138		$configFile = $workflowDir . '/config.json';
139
140		if (file_exists($workflowDir) === false) {
141		mkdir($workflowDir);
142		}
143
144		file_put_contents($configFile, json_encode($this->config, JSON_PRETTY_PRINT));
145		}
146		}
147

godbout / alfred-time

Push — master ( da5576...d20c63 )

src/Config.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like