Harvest::deleteTimer() - Code Metrics - Inspection of "Refactor Harvest class with using guzzle" - godbout/alfred-time - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 749838...dd43ff )

by Guillaume

created 2017-05-02 14:57 UTC

Harvest::deleteTimer() A

↳ Parent: Harvest

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	9
nc	2
nop	1
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0

<?php

require __DIR__ . '/../vendor/autoload.php';

use GuzzleHttp\Client;

/**
 *
 */
class Harvest
{
    private $message;
    private $domain;


    public function __construct($domain = null, $apiToken = null)

    {
        $this->client = new Client([
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'base_uri' => 'https://' . $domain . '.harvestapp.com/daily/',
            'headers' => [
                'Content-type' => 'application/json',
                'Accept' => 'application/json',
                'Authorization' => 'Basic ' . $apiToken,
            ],
        ]);
        $this->message = '';
    }

    public function startTimer($description, $projectId, $taskId)
    {
        $harvestId = null;

        $item = [
            'notes' => $description,
            'project_id' => $projectId,
            'task_id' => $taskId,
        ];

        $response = $this->client->post('add', [
            'json' => $item,
        ]);

        if ($response->getStatusCode() !== 201) {

            $this->message = '- Cannot start Harvest timer!';
        } else {
            $data = json_decode($response->getBody(), true);
            $harvestId = $data['id'];
            $this->message = '- Harvest timer started';
        }

        return $harvestId;
    }

    public function stopTimer($timerId = null)
    {
        $res = false;

        if ($this->isTimerRunning($timerId) === true) {
            $response = $this->client->get('timer/' . $timerId);

            if ($response->getStatusCode() !== 200) {
                $this->message = '- Could not stop Harvest timer!';
            } else {
                $this->message = '- Harvest timer stopped';
                $res = true;
            }
        } else {
            $this->message = '- Harvest timer was not running';
        }

        return $res;
    }

    public function getLastMessage()
    {
        return $this->message;
    }

    public function deleteTimer($timerId = null)
    {
        $res = false;

        $response = $this->client->delete('delete/' . $timerId);

        if ($response->getStatusCode() !== 200) {
            $this->message = '- Could not delete Harvest timer!';
        } else {
            $this->message = '- Harvest timer deleted';
            $res = true;
        }

        return $res;
    }

    private function isTimerRunning($timerId)
    {
        $res = false;

        $response = $this->client->get('show/' . $timerId);

        if ($response->getStatusCode() === 200) {
            $data = json_decode($response->getBody(), true);
            if (isset($data['timer_started_at']) === true) {
                $res = true;
            }
        }

        return $res;
    }
}


1		<?php
2
3		require __DIR__ . '/../vendor/autoload.php';
4
5		use GuzzleHttp\Client;
6
7		/**
8		*
9		*/
10		class Harvest
11		{
12		private $message;
13		private $domain;
		0 ignored issues – show Unused Code introduced 2017-05-02 15:00 UTC by Report Bug Copy Issue Report The property `$domain` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14
15	View Code Duplication	public function __construct($domain = null, $apiToken = null)
		0 ignored issues – show Duplication introduced 2017-05-02 15:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		$this->client = new Client([
		0 ignored issues – show Bug introduced 2017-05-02 15:00 UTC by Report Bug Copy Issue Report The property `client` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18		'base_uri' => 'https://' . $domain . '.harvestapp.com/daily/',
19		'headers' => [
20		'Content-type' => 'application/json',
21		'Accept' => 'application/json',
22		'Authorization' => 'Basic ' . $apiToken,
23		],
24		]);
25		$this->message = '';
26		}
27
28		public function startTimer($description, $projectId, $taskId)
29		{
30		$harvestId = null;
31
32		$item = [
33		'notes' => $description,
34		'project_id' => $projectId,
35		'task_id' => $taskId,
36		];
37
38		$response = $this->client->post('add', [
39		'json' => $item,
40		]);
41
42	View Code Duplication	if ($response->getStatusCode() !== 201) {
		0 ignored issues – show Duplication introduced 2017-05-02 15:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		$this->message = '- Cannot start Harvest timer!';
44		} else {
45		$data = json_decode($response->getBody(), true);
46		$harvestId = $data['id'];
47		$this->message = '- Harvest timer started';
48		}
49
50		return $harvestId;
51		}
52
53		public function stopTimer($timerId = null)
54		{
55		$res = false;
56
57		if ($this->isTimerRunning($timerId) === true) {
58		$response = $this->client->get('timer/' . $timerId);
59
60		if ($response->getStatusCode() !== 200) {
61		$this->message = '- Could not stop Harvest timer!';
62		} else {
63		$this->message = '- Harvest timer stopped';
64		$res = true;
65		}
66		} else {
67		$this->message = '- Harvest timer was not running';
68		}
69
70		return $res;
71		}
72
73		public function getLastMessage()
74		{
75		return $this->message;
76		}
77
78		public function deleteTimer($timerId = null)
79		{
80		$res = false;
81
82		$response = $this->client->delete('delete/' . $timerId);
83
84		if ($response->getStatusCode() !== 200) {
85		$this->message = '- Could not delete Harvest timer!';
86		} else {
87		$this->message = '- Harvest timer deleted';
88		$res = true;
89		}
90
91		return $res;
92		}
93
94		private function isTimerRunning($timerId)
95		{
96		$res = false;
97
98		$response = $this->client->get('show/' . $timerId);
99
100		if ($response->getStatusCode() === 200) {
101		$data = json_decode($response->getBody(), true);
102		if (isset($data['timer_started_at']) === true) {
103		$res = true;
104		}
105		}
106
107		return $res;
108		}
109		}
110

godbout / alfred-time

Push — master ( 749838...dd43ff )

Harvest::deleteTimer() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like