godbout / alfred-time

src/Services/Harvest.php

<?php

namespace Godbout\Alfred\Time\Services;

use Carbon\Carbon;
use Carbon\CarbonInterval;
use Required\Harvest\Client;
use Required\Harvest\Exception\NotFoundException;
use Required\Harvest\Exception\AuthenticationException;
use Required\Harvest\Exception\ValidationFailedException;

class Harvest extends TimerService
{
    public $allowsEmptyProject = false;

    public $allowsEmptyTag = false;

    private $client;


    public function __construct($accountId, $apiToken)
    {
        $this->client = new Client();

        $this->client->authenticate($accountId, $apiToken);
    }

    public function projects()
    {
        try {
            return array_column($this->client->projects()->all(['']), 'name', 'id');
        } catch (AuthenticationException $e) {
            return [];
        }
    }

    public function tags()
    {
        try {
            $taskAssignments = $this->client->projects()->taskAssignments()->all(
                (int) getenv('timer_project_id'),
                ['is_active' => true]
            );

            array_walk($taskAssignments, function ($taskAssignment) use (&$tags) {

It seems like $taskAssignments can also be of type string; however, parameter $array of array_walk() does only seem to accept array, maybe add an additional type check?

                $tags[$taskAssignment['task']['id']] = $taskAssignment['task']['name'];
            });

            return $tags;
        } catch (AuthenticationException $e) {
            return [];
        }
    }

    public function pastTimers()
    {
        try {
            $harvestTimers = $this->client->timeEntries()->all([
                'from' => Carbon::today()->subDays(30),
                'to' => Carbon::today()
            ]);

            return $this->convertToPastTimers($harvestTimers);
        } catch (AuthenticationException $e) {
            return [];
        }
    }

    public function startTimer()
    {
        try {
            $timer = $this->client->timeEntries()->create([
                'notes' => getenv('timer_description'),
                'project_id' => (int) getenv('timer_project_id'),
                'task_id' => (int) getenv('timer_tag_id'),
                'spent_date' => date('Y-m-d')
            ]);

            if (! isset($timer['id'])) {
                return false;
            }
        } catch (ValidationFailedException $e) {
            return false;
        }

        return $timer['id'];
    }

    public function stopCurrentTimer()
    {
        if ($timerId = $this->runningTimer()) {
            $timer = $this->client->timeEntries()->stop($timerId);

            if (! isset($timer['id'])) {
                throw new \Exception("Can't stop current running timer.", 1);
            }

            return true;
        }

        return false;
    }

    public function runningTimer()
    {
        try {
            $timer = $this->client->timeEntries()->all(['is_running' => true]);

            return $timer[0]['id'] ?? false;
        } catch (\Exception $e) {
            return false;
        }
    }

    public function continueTimer($timerId)
    {
        $timer = $this->client->timeEntries()->restart($timerId);

        return $timer['id'] ?? false;
    }

    public function deleteTimer($timerId)
    {
        try {
            $this->client->timeEntries()->remove($timerId);
        } catch (NotFoundException $e) {
            return false;
        }

        return true;
    }

    protected function convertToPastTimers($harvestTimers)
    {
        return array_map(function ($harvestTimer) {
            return $this->buildPastTimerObject($harvestTimer);
        }, $harvestTimers);
    }

    protected function buildPastTimerObject($harvestTimer)
    {
        $pastTimer['id'] = $harvestTimer['id'];

$pastTimer was never initialized. Although not strictly required by PHP, it is generally a good practice to add $pastTimer = array(); before regardless.

        $pastTimer['description'] = $harvestTimer['notes'];
        $pastTimer['project_id'] = $harvestTimer['project']['id'];
        $pastTimer['project_name'] = $harvestTimer['project']['name'];
        $pastTimer['tag_id'] = $harvestTimer['task']['id'];
        $pastTimer['tags'] = $harvestTimer['task']['name'];
        $pastTimer['duration'] = CarbonInterval::seconds(

The method Carbon\CarbonInterval::seconds() is not static, but was called statically.

            floor($harvestTimer['hours'] * 3600)
        )->cascade()->format('%H:%I:%S');

        return (object) $pastTimer;
    }
}