godbout / alfred-time

src/Services/Everhour.php

<?php

namespace Godbout\Alfred\Time\Services;

use GuzzleHttp\Client;
use Carbon\CarbonInterval;

class Everhour extends TimerService
{
    private $client;

    private $data = null;

The private property $data is not used, and could be removed.

    public function __construct($apiToken)
    {
        $this->client = new Client([
            'base_uri' => 'https://api.everhour.com/',
            'headers' => [
                'X-Api-Key' => $apiToken
            ]
        ]);
    }

    public function projects()
    {
        try {
            $response = $this->client->get('projects');
            $projects = json_decode($response->getBody()->getContents());

            return array_column($projects, 'name', 'id');
        } catch (\Exception $e) {
            return [];
        }
    }

    public function tags()
    {
        try {
            $projectId = getenv('timer_project_id');
            $response = $this->client->get("projects/$projectId/tasks");
            $tasks = json_decode($response->getBody()->getContents());

            array_walk($tasks, function ($task) use (&$tags) {
                $tags[$task->id] = $task->name;
            });

            return $tags;
        } catch (\Exception $e) {
            return [];
        }
    }

    public function pastTimers()
    {
        try {
            $pastTimers = [];

The assignment to $pastTimers is dead and can be removed.

            $response = $this->client->get('users/me');
            $me = json_decode($response->getBody()->getContents());

            $response = $this->client->get("users/{$me->id}/time?limit=20&offset=0");
            $everhourTimers = json_decode($response->getBody()->getContents());

            return $this->convertToPastTimers($everhourTimers);
        } catch (\Exception $e) {
            return [];
        }
    }

    public function startTimer()
    {
        try {
            $response = $this->client->post('timers', [
                'json' => [
                    'task' => getenv('timer_tag_id'),
                    'comment' => getenv('timer_description')
                ]
            ]);

            $timer = json_decode($response->getBody()->getContents());

            if (! isset($timer->status) || $timer->status !== 'active') {
                return false;
            }
        } catch (\Exception $e) {
            return false;
        }

        return true;
    }

    public function stopCurrentTimer()
    {
        try {
            $response = $this->client->delete('timers/current');

            $timer = json_decode($response->getBody()->getContents());

            if (! isset($timer->taskTime) || $timer->status !== 'stopped') {
                return false;
            }
        } catch (\Exception $e) {
            return false;
        }

        return true;
    }

    public function runningTimer()
    {
        try {
            $response = $this->client->get('timers/current');

            $timer = json_decode($response->getBody()->getContents());

            if (! isset($timer->duration) || $timer->status !== 'active') {
                return false;
            }
        } catch (\Exception $e) {
            return false;
        }

        return true;
    }

    public function continueTimer($timerId = null)
    {
        /**
         * Timer attributes are stored in env variables
         * gathered in startTimer.
         */

        return $this->startTimer();
    }

    public function deleteTimer($timerId)
    {
        return false;
    }

    protected function convertToPastTimers($everhourTimers)
    {
        $projects = $this->projects();

        return array_map(function ($everhourTimer) use ($projects) {
            return $this->buildPastTimerObject($everhourTimer, $projects);
        }, $everhourTimers);
    }

    protected function buildPastTimerObject($everhourTimer, $projects)
    {
        $pastTimer['id'] = $everhourTimer->id;

$pastTimer was never initialized. Although not strictly required by PHP, it is generally a good practice to add $pastTimer = array(); before regardless.

        $pastTimer['description'] = $everhourTimer->comment ?? '';

        if (isset($everhourTimer->task)) {
            $pastTimer['project_id'] = $everhourTimer->task->projects[0];
            $pastTimer['project_name'] = $projects[$everhourTimer->task->projects[0]];
            $pastTimer['tag_id'] = $everhourTimer->task->id;
            $pastTimer['tags'] = $everhourTimer->task->name;
        }

        $pastTimer['duration'] = CarbonInterval::seconds(

The method Carbon\CarbonInterval::seconds() is not static, but was called statically.

            floor($everhourTimer->time)
        )->cascade()->format('%H:%I:%S');

        return (object) $pastTimer;
    }
}