Completed
Pull Request — master (#69)
by David
02:45 queued 25s
created
src/ReflectionClass.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
     /**
29 29
      * Initializes reflection instance
30 30
      *
31
-     * @param string|object $argument Class name or instance of object
31
+     * @param string|null $argument Class name or instance of object
32 32
      * @param ClassLike $classLikeNode AST node for class
33 33
      * @param ReflectionParser $reflectionParser AST parser
34 34
      */
Please login to merge, or discard this patch.
src/Traits/ReflectionClassLikeTrait.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -139,17 +139,17 @@  discard block
 block discarded – undo
139 139
             }
140 140
         }
141 141
 
142
-        $buildString = function (array $items, $indentLevel = 4) {
142
+        $buildString = function(array $items, $indentLevel = 4) {
143 143
             if (!count($items)) {
144 144
                 return '';
145 145
             }
146
-            $indent = "\n" . str_repeat(' ', $indentLevel);
147
-            return $indent . implode($indent, explode("\n", implode("\n", $items)));
146
+            $indent = "\n".str_repeat(' ', $indentLevel);
147
+            return $indent.implode($indent, explode("\n", implode("\n", $items)));
148 148
         };
149
-        $buildConstants = function (array $items, $indentLevel = 4) {
149
+        $buildConstants = function(array $items, $indentLevel = 4) {
150 150
             $str = '';
151 151
             foreach ($items as $name => $value) {
152
-                $str .= "\n" . str_repeat(' ', $indentLevel);
152
+                $str .= "\n".str_repeat(' ', $indentLevel);
153 153
                 $str .= sprintf(
154 154
                     'Constant [ %s %s ] { %s }',
155 155
                     gettype($value),
@@ -173,8 +173,8 @@  discard block
 block discarded – undo
173 173
             ($isObject ? 'Object of class' : 'Class'),
174 174
             $modifiers,
175 175
             $this->getName(),
176
-            false !== $parentClass ? (' extends ' . $parentClass->getName()) : '',
177
-            $interfaceNames ? (' implements ' . implode(', ', $interfaceNames)) : '',
176
+            false !== $parentClass ? (' extends '.$parentClass->getName()) : '',
177
+            $interfaceNames ? (' implements '.implode(', ', $interfaceNames)) : '',
178 178
             $this->getFileName(),
179 179
             $this->getStartLine(),
180 180
             $this->getEndLine(),
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
     public function getConstants()
215 215
     {
216 216
         if (!isset($this->constants)) {
217
-            $this->constants = $this->recursiveCollect(function (array &$result, \ReflectionClass $instance) {
217
+            $this->constants = $this->recursiveCollect(function(array &$result, \ReflectionClass $instance) {
218 218
                 $result += $instance->getConstants();
219 219
             });
220 220
             $this->collectSelfConstants();
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
         $staticOrder   = [true, false];
252 252
         foreach ($staticOrder as $shouldBeStatic) {
253 253
             foreach ($properties as $property) {
254
-                $isStaticProperty     = $property->isStatic();
254
+                $isStaticProperty = $property->isStatic();
255 255
                 if ($shouldBeStatic !== $isStaticProperty) {
256 256
                     continue;
257 257
                 }
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     public function getInterfaces()
316 316
     {
317 317
         if (!isset($this->interfaceClasses)) {
318
-            $this->interfaceClasses = $this->recursiveCollect(function (array &$result, \ReflectionClass $instance) {
318
+            $this->interfaceClasses = $this->recursiveCollect(function(array &$result, \ReflectionClass $instance) {
319 319
                 if ($instance->isInterface()) {
320 320
                     $result[$instance->name] = $instance;
321 321
                 }
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
     {
353 353
         if (!isset($this->methods)) {
354 354
             $directMethods = ReflectionMethod::collectFromClassNode($this->classLikeNode, $this, $this->reflectionParser);
355
-            $parentMethods = $this->recursiveCollect(function (array &$result, \ReflectionClass $instance, $isParent) {
355
+            $parentMethods = $this->recursiveCollect(function(array &$result, \ReflectionClass $instance, $isParent) {
356 356
                 $reflectionMethods = [];
357 357
                 foreach ($instance->getMethods() as $reflectionMethod) {
358 358
                     if (!$isParent || !$reflectionMethod->isPrivate()) {
@@ -422,9 +422,9 @@  discard block
 block discarded – undo
422 422
      */
423 423
     public function getName()
424 424
     {
425
-        $namespaceName = $this->namespaceName ? $this->namespaceName . '\\' : '';
425
+        $namespaceName = $this->namespaceName ? $this->namespaceName.'\\' : '';
426 426
 
427
-        return $namespaceName . $this->getShortName();
427
+        return $namespaceName.$this->getShortName();
428 428
     }
429 429
 
430 430
     /**
@@ -468,7 +468,7 @@  discard block
 block discarded – undo
468 468
     {
469 469
         if (!isset($this->properties)) {
470 470
             $directProperties = ReflectionProperty::collectFromClassNode($this->classLikeNode, $this->getName(), $this->reflectionParser);
471
-            $parentProperties = $this->recursiveCollect(function (array &$result, \ReflectionClass $instance, $isParent) {
471
+            $parentProperties = $this->recursiveCollect(function(array &$result, \ReflectionClass $instance, $isParent) {
472 472
                 $reflectionProperties = [];
473 473
                 foreach ($instance->getProperties() as $reflectionProperty) {
474 474
                     if (!$isParent || !$reflectionProperty->isPrivate()) {
@@ -548,7 +548,7 @@  discard block
 block discarded – undo
548 548
                         break;
549 549
                     }
550 550
                 }
551
-                $aliases[$adaptation->newName] = $traitName . '::'. $methodName;
551
+                $aliases[$adaptation->newName] = $traitName.'::'.$methodName;
552 552
             }
553 553
         }
554 554
 
Please login to merge, or discard this patch.
src/ValueResolver/NodeExpressionResolver.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
             ++$this->nodeLevel;
121 121
 
122 122
             $nodeType   = $node->getType();
123
-            $methodName = 'resolve' . str_replace('_', '', $nodeType);
123
+            $methodName = 'resolve'.str_replace('_', '', $nodeType);
124 124
             if (method_exists($this, $methodName)) {
125 125
                 $value = $this->$methodName($node);
126 126
             }
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
     protected function resolveScalarMagicConstMethod()
150 150
     {
151 151
         if ($this->context instanceof \ReflectionMethod) {
152
-            $fullName = $this->context->getDeclaringClass()->getName() . '::' . $this->context->getShortName();
152
+            $fullName = $this->context->getDeclaringClass()->getName().'::'.$this->context->getShortName();
153 153
 
154 154
             return $fullName;
155 155
         }
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
                 $fileNamespace = new ReflectionFileNamespace($fileName, $namespaceName, null, $this->reflectionParser);
244 244
                 if ($fileNamespace->hasConstant($constantName)) {
245 245
                     $constantValue = $fileNamespace->getConstant($constantName);
246
-                    $constantName  = $fileNamespace->getName() . '\\' . $constantName;
246
+                    $constantName  = $fileNamespace->getName().'\\'.$constantName;
247 247
                     $isResolved    = true;
248 248
                 }
249 249
             }
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
         }
273 273
 
274 274
         $this->isConstant = true;
275
-        $this->constantName = (string)$node->class . '::' . $constantName;
275
+        $this->constantName = (string) $node->class.'::'.$constantName;
276 276
 
277 277
         return $refClass->getConstant($constantName);
278 278
     }
@@ -356,7 +356,7 @@  discard block
 block discarded – undo
356 356
 
357 357
     protected function resolveExprBinaryOpConcat(Expr\BinaryOp\Concat $node)
358 358
     {
359
-        return $this->resolve($node->left) . $this->resolve($node->right);
359
+        return $this->resolve($node->left).$this->resolve($node->right);
360 360
     }
361 361
 
362 362
     protected function resolveExprTernary(Expr\Ternary $node)
Please login to merge, or discard this patch.
src/ReflectionFileNamespace.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
         foreach ($this->namespaceNode->stmts as $namespaceLevelNode) {
327 327
             if ($namespaceLevelNode instanceof ClassLike) {
328 328
                 $classShortName = $namespaceLevelNode->name;
329
-                $className = $namespaceName ? $namespaceName .'\\' . $classShortName : $classShortName;
329
+                $className = $namespaceName ? $namespaceName.'\\'.$classShortName : $classShortName;
330 330
 
331 331
                 $namespaceLevelNode->setAttribute('fileName', $this->fileName);
332 332
                 $classes[$className] = new ReflectionClass($className, $namespaceLevelNode, $this->reflectionParser);
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
         foreach ($this->namespaceNode->stmts as $namespaceLevelNode) {
351 351
             if ($namespaceLevelNode instanceof Function_) {
352 352
                 $funcShortName = $namespaceLevelNode->name;
353
-                $functionName  = $namespaceName ? $namespaceName .'\\' . $funcShortName : $funcShortName;
353
+                $functionName  = $namespaceName ? $namespaceName.'\\'.$funcShortName : $funcShortName;
354 354
 
355 355
                 $namespaceLevelNode->setAttribute('fileName', $this->fileName);
356 356
                 $functions[$funcShortName] = new ReflectionFunction($functionName, $namespaceLevelNode);
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
             foreach ($this->namespaceNode->stmts as $namespaceLevelNode) {
390 390
                 if ($namespaceLevelNode instanceof FuncCall
391 391
                     && $namespaceLevelNode->name instanceof Name
392
-                    && (string)$namespaceLevelNode->name === 'define'
392
+                    && (string) $namespaceLevelNode->name === 'define'
393 393
                 ) {
394 394
                     $expressionSolver->process($namespaceLevelNode->args[0]->value);
395 395
                     $constantName = $expressionSolver->getValue();
Please login to merge, or discard this patch.
src/ReflectionParser.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
      *
94 94
      * @param string $fullName Full name of the class
95 95
      *
96
-     * @return void
96
+     * @return \ReflectionClass
97 97
      */
98 98
     public function getClassReflection($fullName)
99 99
     {
@@ -267,6 +267,9 @@  discard block
 block discarded – undo
267 267
 
268 268
     /**
269 269
      * Provides back compatibility with static ReflectionEngine
270
+     * @param null|integer $maximumCachedFiles
271
+     * @param null|Parser $parser
272
+     * @param null|NodeTraverser $traverser
270 273
      * @return void
271 274
      */
272 275
     public function initStaticEngine(&$parsedFiles, &$maximumCachedFiles, &$parser, &$traverser)
Please login to merge, or discard this patch.
src/ReflectionProperty.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
         PropertyProperty $propertyNode = null,
68 68
         ReflectionParser $reflectionParser = null
69 69
     ) {
70
-        $this->className    = $className;
70
+        $this->className = $className;
71 71
         $this->reflectionParser = $reflectionParser ?: ReflectionEngine::getReflectionParser();
72 72
         if (!$propertyType || !$propertyNode) {
73 73
             list ($propertyType, $propertyNode) = $this->reflectionParser->parseClassProperty($className, $propertyName);
Please login to merge, or discard this patch.
src/ReflectionParameter.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
         $this->parameterNode     = $parameterNode;
96 96
         $this->parameterIndex    = $parameterIndex;
97 97
         $this->declaringFunction = $declaringFunction;
98
-        $this->reflectionParser           = $reflectionParser ?: ReflectionEngine::getReflectionParser();
98
+        $this->reflectionParser = $reflectionParser ?: ReflectionEngine::getReflectionParser();
99 99
 
100 100
         if ($this->isDefaultValueAvailable()) {
101 101
             if ($declaringFunction instanceof \ReflectionMethod) {
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
         if ($hasDefaultValue) {
137 137
             $defaultValue = $this->getDefaultValue();
138 138
             if (is_string($defaultValue) && strlen($defaultValue) > 15) {
139
-                $defaultValue = substr($defaultValue, 0, 15) . '...';
139
+                $defaultValue = substr($defaultValue, 0, 15).'...';
140 140
             }
141 141
             /* @see https://3v4l.org/DJOEb for behaviour changes */
142 142
             if (is_double($defaultValue) && fmod($defaultValue, 1.0) === 0.0) {
@@ -150,11 +150,11 @@  discard block
 block discarded – undo
150 150
             'Parameter #%d [ %s %s%s%s$%s%s ]',
151 151
             $this->parameterIndex,
152 152
             $isOptional ? '<optional>' : '<required>',
153
-            $parameterType ? ReflectionType::convertToDisplayType($parameterType) . ' ' : '',
153
+            $parameterType ? ReflectionType::convertToDisplayType($parameterType).' ' : '',
154 154
             $this->isVariadic() ? '...' : '',
155 155
             $this->isPassedByReference() ? '&' : '',
156 156
             $this->getName(),
157
-            ($isOptional && $hasDefaultValue) ? (' = ' . $defaultValue) : ''
157
+            ($isOptional && $hasDefaultValue) ? (' = '.$defaultValue) : ''
158 158
         );
159 159
     }
160 160
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 
205 205
                 throw new ReflectionException("Can not resolve a class name for parameter");
206 206
             }
207
-            $className   = $parameterType->toString();
207
+            $className = $parameterType->toString();
208 208
             return $this->reflectionParser->getClassReflection($className);
209 209
         }
210 210
 
Please login to merge, or discard this patch.