goaop / framework

demos/Demo/Example/LoggingDemo.php

Doc Comments +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
      * Executes a task and logs all incoming arguments
      *
      * @Loggable
-     * @param mixed $task Some specific argument
+     * @param string $task Some specific argument
      */
     public function execute($task)
     {

src/Aop/Framework/BaseAdvice.php

Doc Comments +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
      * @param Aspect $aspect Instance of aspect
      * @param ReflectionMethod $refMethod Reflection method of aspect
      *
-     * @return callable|object
+     * @return \Closure
      */
     public static function fromAspectReflection(Aspect $aspect, ReflectionMethod $refMethod)
     {

Spacing +4 added lines, -4 removed lines

@@ -152,7 +152,7 @@ 
         if ($useClosure) {
             return $refMethod->getClosure($aspect);
         } else {
-            return function () use ($aspect, $refMethod) {
+            return function() use ($aspect, $refMethod) {
                 return $refMethod->invokeArgs($aspect, func_get_args());
             };
         }
@@ -175,7 +175,7 @@ 
                 return $adviceCallback;
 
             case 'proxy':
-                return function (Joinpoint $joinpoint) use ($aspect, $adviceCallback) {
+                return function(Joinpoint $joinpoint) use ($aspect, $adviceCallback) {
                     $instance    = $joinpoint->getThis();
                     $isNotObject = $instance !== (object) $instance;
                     $target      = $isNotObject ? $instance : get_class($instance);
@@ -185,7 +185,7 @@ 
                 };
 
             case 'target':
-                return function (Joinpoint $joinpoint) use ($aspect, $adviceCallback) {
+                return function(Joinpoint $joinpoint) use ($aspect, $adviceCallback) {
                     $instance    = $joinpoint->getThis();
                     $isNotObject = $instance !== (object) $instance;
                     $target      = $isNotObject ? $instance : get_parent_class($instance);
@@ -195,7 +195,7 @@ 
                 };
 
             default:
-                return function (Joinpoint $joinpoint) use ($aspect, $adviceCallback, $scope) {
+                return function(Joinpoint $joinpoint) use ($aspect, $adviceCallback, $scope) {
                     $callback = $adviceCallback->bindTo($aspect, $scope);
 
                     return $callback($joinpoint);

src/Aop/Framework/ReflectionConstructorInvocation.php

Doc Comments +2 added lines, -1 removed lines

@@ -53,6 +53,7 @@ 
      *
      * @param string $className Class name
      * @param $advices array List of advices for this invocation
+     * @param string $type
      */
     public function __construct($className, $type, array $advices)
     {
@@ -123,7 +124,7 @@ 
     /**
      * Returns the static part of this joinpoint.
      *
-     * @return object
+     * @return null|ReflectionMethod
      */
     public function getStaticPart()
     {

src/Aop/Pointcut/FunctionPointcut.php

Doc Comments +3 added lines

@@ -90,6 +90,9 @@
         return $this->nsFilter;
     }
 
+    /**
+     * @param \Go\Aop\Support\SimpleNamespaceFilter $nsFilter
+     */
     public function setNamespaceFilter($nsFilter)
     {
         $this->nsFilter = $nsFilter;

src/Aop/Pointcut/NotPointcut.php

Unused Use Statements -2 removed lines

@@ -11,8 +11,6 @@
 namespace Go\Aop\Pointcut;
 
 use Go\Aop\Pointcut;
-use Go\Aop\PointFilter;
-use Go\Aop\Support\TruePointFilter;
 
 /**
  * Signature method pointcut checks method signature (modifiers and name) to match it

src/Aop/Pointcut/PointcutGrammar.php

Doc Comments +2 added lines, -2 removed lines

@@ -305,7 +305,7 @@ 
     /**
      * Returns callable for converting node(s) to the string
      *
-     * @return callable
+     * @return \Closure
      */
     private function getNodeToStringConverter()
     {
@@ -326,7 +326,7 @@ 
     /**
      * Returns callable for converting node value for modifiers to the constant value
      *
-     * @return callable
+     * @return \Closure
      */
     private function getModifierConverter()
     {

Spacing +30 added lines, -30 removed lines

@@ -40,28 +40,28 @@ 
 
         $this('pointcutExpression')
             ->is('pointcutExpression', '||', 'conjugatedExpression')
-            ->call(function ($first, $_0, $second) {
+            ->call(function($first, $_0, $second) {
                 return new OrPointcut($first, $second);
             })
             ->is('conjugatedExpression');
 
         $this('conjugatedExpression')
             ->is('conjugatedExpression', '&&', 'negatedExpression')
-            ->call(function ($first, $_0, $second) {
+            ->call(function($first, $_0, $second) {
                 return new AndPointcut($first, $second);
             })
             ->is('negatedExpression');
 
         $this('negatedExpression')
             ->is('!', 'brakedExpression')
-            ->call(function ($_0, $item) {
+            ->call(function($_0, $item) {
                 return new NotPointcut($item);
             })
             ->is('brakedExpression');
 
         $this('brakedExpression')
             ->is('(', 'pointcutExpression', ')')
-            ->call(function ($_0, $e, $_1) {
+            ->call(function($_0, $e, $_1) {
                 return $e;
             })
             ->is('singlePointcut');
@@ -81,23 +81,23 @@ 
 
         $this('accessPointcut')
             ->is('access', '(', 'propertyAccessReference', ')')
-            ->call(function ($_0, $_1, $propertyReference) {
+            ->call(function($_0, $_1, $propertyReference) {
                 return $propertyReference;
             });
 
         $this('executionPointcut')
             ->is('execution', '(', 'methodExecutionReference', ')')
-            ->call(function ($_0, $_1, $methodReference) {
+            ->call(function($_0, $_1, $methodReference) {
                 return $methodReference;
             })
             ->is('execution', '(', 'functionExecutionReference', ')')
-            ->call(function ($_0, $_1, $functionReference) {
+            ->call(function($_0, $_1, $functionReference) {
                 return $functionReference;
             });
 
         $this('withinPointcut')
             ->is('within', '(', 'classFilter', ')')
-            ->call(function ($_0, $_1, $classFilter) {
+            ->call(function($_0, $_1, $classFilter) {
                 $pointcut = new TruePointcut(PointFilter::KIND_ALL);
                 $pointcut->setClassFilter($classFilter);
 
@@ -106,21 +106,21 @@ 
 
         $this('annotatedAccessPointcut')
             ->is('annotation', 'access', '(', 'namespaceName', ')')
-            ->call(function ($_0, $_1, $_2, $annotationClassName) use ($annotationReader) {
+            ->call(function($_0, $_1, $_2, $annotationClassName) use ($annotationReader) {
                 $kindProperty = PointFilter::KIND_PROPERTY;
                 return new AnnotationPointcut($kindProperty, $annotationReader, $annotationClassName);
             });
 
         $this('annotatedExecutionPointcut')
             ->is('annotation', 'execution', '(', 'namespaceName', ')')
-            ->call(function ($_0, $_1, $_2, $annotationClassName) use ($annotationReader) {
+            ->call(function($_0, $_1, $_2, $annotationClassName) use ($annotationReader) {
                 $kindMethod = PointFilter::KIND_METHOD;
                 return new AnnotationPointcut($kindMethod, $annotationReader, $annotationClassName);
             });
 
         $this('annotatedWithinPointcut')
             ->is('annotation', 'within', '(', 'namespaceName', ')')
-            ->call(function ($_0, $_1, $_2, $annotationClassName) use ($annotationReader) {
+            ->call(function($_0, $_1, $_2, $annotationClassName) use ($annotationReader) {
                 $pointcut    = new TruePointcut(PointFilter::KIND_ALL);
                 $kindClass   = PointFilter::KIND_CLASS;
                 $classFilter = new AnnotationPointcut($kindClass, $annotationReader, $annotationClassName);
@@ -131,7 +131,7 @@ 
 
         $this('initializationPointcut')
             ->is('initialization', '(', 'classFilter', ')')
-            ->call(function ($_0, $_1, $classFilter){
+            ->call(function($_0, $_1, $classFilter) {
                 $pointcut = new TruePointcut(PointFilter::KIND_INIT + PointFilter::KIND_CLASS);
                 $pointcut->setClassFilter($classFilter);
 
@@ -140,7 +140,7 @@ 
 
         $this('staticInitializationPointcut')
             ->is('staticinitialization', '(', 'classFilter', ')')
-            ->call(function ($_0, $_1, $classFilter){
+            ->call(function($_0, $_1, $classFilter) {
                 $pointcut = new TruePointcut(PointFilter::KIND_STATIC_INIT + PointFilter::KIND_CLASS);
                 $pointcut->setClassFilter($classFilter);
 
@@ -149,14 +149,14 @@ 
 
         $this('cflowbelowPointcut')
             ->is('cflowbelow', '(', 'executionPointcut', ')')
-            ->call(function ($_0, $_1, $pointcut) {
+            ->call(function($_0, $_1, $pointcut) {
                 return new CFlowBelowMethodPointcut($pointcut);
             });
 
         $this('dynamicExecutionPointcut')
             // ideally, this should be 'dynamic', 'methodExecutionReference'
             ->is('dynamic', '(', 'memberReference', '(', 'argumentList', ')', ')')
-            ->call(function ($_0, $_1, ClassMemberReference $reference) {
+            ->call(function($_0, $_1, ClassMemberReference $reference) {
                 $memberFilter = $reference->getVisibilityFilter();
                 $memberFilter = $memberFilter->merge($reference->getAccessTypeFilter());
                 $pointcut     = new MagicMethodPointcut(
@@ -169,13 +169,13 @@ 
 
         $this('pointcutReference')
             ->is('namespaceName', '->', 'namePatternPart')
-            ->call(function ($className, $_0, $name) use ($container) {
+            ->call(function($className, $_0, $name) use ($container) {
                 return new PointcutReference($container, "{$className}->{$name}");
             });
 
         $this('propertyAccessReference')
             ->is('memberReference')
-            ->call(function (ClassMemberReference $reference) {
+            ->call(function(ClassMemberReference $reference) {
                 $memberFilter = $reference->getVisibilityFilter();
                 $memberFilter = $memberFilter->merge($reference->getAccessTypeFilter());
                 $pointcut     = new SignaturePointcut(
@@ -190,7 +190,7 @@ 
 
         $this('methodExecutionReference')
             ->is('memberReference', '(', 'argumentList', ')')
-            ->call(function (ClassMemberReference $reference) {
+            ->call(function(ClassMemberReference $reference) {
 
                 $memberFilter = $reference->getVisibilityFilter();
                 $memberFilter = $memberFilter->merge($reference->getAccessTypeFilter());
@@ -206,7 +206,7 @@ 
 
         $this('functionExecutionReference')
             ->is('namespacePattern', 'nsSeparator', 'namePatternPart', '(', 'argumentList', ')')
-            ->call(function ($namespacePattern, $_0, $namePattern) {
+            ->call(function($namespacePattern, $_0, $namePattern) {
                 $nsFilter = new SimpleNamespaceFilter($namespacePattern);
                 $pointcut = new FunctionPointcut($namePattern);
                 $pointcut->setNamespaceFilter($nsFilter);
@@ -216,7 +216,7 @@ 
 
         $this('memberReference')
             ->is('memberModifiers', 'classFilter', 'memberAccessType', 'namePatternPart')
-            ->call(function (
+            ->call(function(
                 ModifierMatcherFilter $memberModifiers,
                 PointFilter $classFilter,
                 ModifierMatcherFilter $memberAccessType,
@@ -233,7 +233,7 @@ 
 
         $this('classFilter')
             ->is('namespacePattern')
-            ->call(function ($pattern) {
+            ->call(function($pattern) {
                 $truePointFilter = TruePointFilter::getInstance();
 
                 return $pattern === '**'
@@ -241,7 +241,7 @@ 
                     : new SignaturePointcut(PointFilter::KIND_CLASS, $pattern, $truePointFilter);
             })
             ->is('namespacePattern', '+')
-            ->call(function ($parentClassName) {
+            ->call(function($parentClassName) {
                 return new InheritanceClassFilter($parentClassName);
             });
 
@@ -250,11 +250,11 @@ 
 
         $this('memberAccessType')
             ->is('::')
-            ->call(function () {
+            ->call(function() {
                 return new ModifierMatcherFilter(\ReflectionMethod::IS_STATIC);
             })
             ->is('->')
-            ->call(function () {
+            ->call(function() {
                 $modifierMatcherFilter = new ModifierMatcherFilter();
                 $modifierMatcherFilter->notMatch(\ReflectionMethod::IS_STATIC);
 
@@ -279,16 +279,16 @@ 
             ->is('namespaceName', 'nsSeparator', 'namePart')->call($stringConverter);
 
         $this('memberModifiers')
-            ->is('memberModifier','|','memberModifiers')
-            ->call(function ($modifier, $_0, ModifierMatcherFilter $matcher) {
+            ->is('memberModifier', '|', 'memberModifiers')
+            ->call(function($modifier, $_0, ModifierMatcherFilter $matcher) {
                 return $matcher->orMatch($modifier);
             })
             ->is('memberModifier', 'memberModifiers')
-            ->call(function ($modifier, ModifierMatcherFilter $matcher) {
+            ->call(function($modifier, ModifierMatcherFilter $matcher) {
                 return $matcher->andMatch($modifier);
             })
             ->is('memberModifier')
-            ->call(function ($modifier) {
+            ->call(function($modifier) {
                 return new ModifierMatcherFilter($modifier);
             });
 
@@ -309,7 +309,7 @@ 
      */
     private function getNodeToStringConverter()
     {
-        return function () {
+        return function() {
             $value = '';
             foreach (func_get_args() as $node) {
                 if (is_scalar($node)) {
@@ -330,7 +330,7 @@ 
      */
     private function getModifierConverter()
     {
-        return function (Token $token) {
+        return function(Token $token) {
             $name = strtoupper($token->getValue());
 
             return constant("ReflectionMethod::IS_{$name}");

src/Aop/Support/DeclareParentsAdvisor.php

Doc Comments +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
     /**
      * Returns an advice to apply
      *
-     * @return Advice|IntroductionInfo|null
+     * @return null|IntroductionInfo
      */
     public function getAdvice()
     {

src/Core/AbstractAspectLoaderExtension.php

Doc Comments +2 added lines, -2 removed lines

@@ -76,7 +76,7 @@ 
      *
      * @param Aspect $aspect Instance of aspect
      * @param ReflectionMethod|ReflectionProperty $reflection
-     * @param $metaInformation
+     * @param Annotation\BaseAnnotation $metaInformation
      *
      * @return TokenStream
      * @throws \UnexpectedValueException
@@ -109,7 +109,7 @@ 
      * Performs parsing of pointcut
      *
      * @param ReflectionMethod|ReflectionProperty $reflection
-     * @param $metaInformation
+     * @param Annotation\BaseAnnotation $metaInformation
      * @param TokenStream $stream
      * @return Pointcut
      *

src/Instrument/ClassLoading/CachePathManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
 
     /**
      * @param string $resource
-     * @return bool|string
+     * @return false|string
      */
     public function getCachePathForResource($resource)
     {

Spacing +3 added lines, -3 removed lines

@@ -57,7 +57,7 @@ 
      */
     protected $newCacheState = array();
 
-    public function __construct (AspectKernel $kernel)
+    public function __construct(AspectKernel $kernel)
     {
         $this->kernel   = $kernel;
         $this->options  = $kernel->getOptions();
@@ -78,7 +78,7 @@ 
                 throw new \InvalidArgumentException("Cache directory {$this->cacheDir} is not writable");
             }
 
-            if (file_exists($this->cacheDir. self::CACHE_FILE_NAME)) {
+            if (file_exists($this->cacheDir . self::CACHE_FILE_NAME)) {
                 $this->cacheState = include $this->cacheDir . self::CACHE_FILE_NAME;
             }
         }
@@ -124,7 +124,7 @@ 
      *
      * @return array|null Information or null if no record in the cache
      */
-    public function queryCacheState($resource=null)
+    public function queryCacheState($resource = null)
     {
         if (!$resource) {
             return $this->cacheState;