giggsey / libphonenumber-for-php

Completed

Pull Request — master (#144)

by Joshua

created 2016-11-10 12:34 UTC

2,273 ⁺⁴⁶ Covered Lines

2,376 ⁺⁴⁶ Total Lines

95.7 ^% ^+0.086% Code Coverage

PHP Classes Changes

100%	↘	66.67%	RegexBasedMatcher got worse
84.95%	↗	96.19%	PhoneNumberDesc improved
98.39%	↘	97.73%	PhoneMetadata got worse
95.77%	↘	95.44%	PhoneNumberUtil got worse
91.84%	↗	91.92%	ShortNumberInfo improved

CRAP Changes

	⇢	2	PhoneMetadata::clearNationalPrefix() added
	⇢	1	PhoneMetadata::clearPreferredExtnPrefix() added
	⇢	1	PhoneMetadata::clearNationalPrefixTransformRule() added
	⇢	1	PhoneMetadata::clearSameMobileAndFixedLinePattern(... added
	⇢	1	PhoneMetadata::clearLeadingZeroPossible() added
	⇢	1	PhoneMetadata::clearMobileNumberPortableRegion() added
	⇢	1	PhoneNumberDesc::clearNationalNumberPattern() added
	⇢	1	PhoneNumberDesc::clearPossibleNumberPattern() added
	⇢	1	PhoneNumberDesc::clearExampleNumber() added
	⇢	1	PhoneMetadata::clearMainCountryForCode() added
⋮			view more
12	↗	12.0117	PhoneNumberUtil::getNumberDescByType() got worse
5.1158	↗	5.1502	ShortNumberInfo::isPossibleShortNumberForRegion() got worse
9.0945	↗	10.0862	ShortNumberInfo::getExpectedCostForRegion() got worse
1	↗	2	RegexBasedMatcher::matchesPossibleNumber() got worse
4.25	↗	6.0106	PhoneNumberUtil::getExampleNumberForNonGeoEntity() got worse
11.4763	↗	17.0498	PhoneNumberUtil::getExampleNumberForType() got worse
20	↘	4	PhoneNumberDesc::mergeFrom() improved