Completed
Push — upstream-8.3.0 ( 6d22b3...36447c )
by Joshua
29:18 queued 18:23
created
build/GeneratePhonePrefixData.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -318,6 +318,9 @@
 block discarded – undo
318 318
         $this->compressAccordingToEnglishData($this->englishMaps[$countryCode], $mappings);
319 319
     }
320 320
 
321
+    /**
322
+     * @param string $textFile
323
+     */
321 324
     private function getEnglishDataPath($textFile)
322 325
     {
323 326
         return "en" . DIRECTORY_SEPARATOR . substr($textFile, 3);
Please login to merge, or discard this patch.
src/geocoding/PhoneNumberOfflineGeocoder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
      * Returns the customary display name in the given language for the given region.
122 122
      *
123 123
      * @param $regionCode
124
-     * @param $locale
124
+     * @param string $locale
125 125
      * @return string
126 126
      */
127 127
     protected function getRegionDisplayName($regionCode, $locale)
Please login to merge, or discard this patch.
src/prefixmapper/MappingFileProvider.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@
 block discarded – undo
42 42
         return "";
43 43
     }
44 44
 
45
+    /**
46
+     * @param string $countryCallingCode
47
+     */
45 48
     protected function inMap($language, $countryCallingCode)
46 49
     {
47 50
         return (array_key_exists($language, $this->map) && in_array($countryCallingCode, $this->map[$language]));
Please login to merge, or discard this patch.
tests/buildtools/BuildMetadataFromXmlTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
     }
82 82
 
83 83
     /**
84
-     * @param $xmlString
84
+     * @param string $xmlString
85 85
      * @return \DOMElement
86 86
      */
87 87
     private function parseXMLString($xmlString)
Please login to merge, or discard this patch.
tests/Issues/Issue68Test.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
         $this->assertFalse($shortNumberInfo->isPossibleShortNumberForRegion($exampleNumber, 'NE'));
26 26
     }
27 27
 
28
+    /**
29
+     * @param string $region
30
+     */
28 31
     private function getExampleNumber($region)
29 32
     {
30 33
         $phoneUtil = PhoneNumberUtil::getInstance();
Please login to merge, or discard this patch.
src/PhoneNumberUtil.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1820,7 +1820,7 @@  discard block
 block discarded – undo
1820 1820
      * Normalizes a string of characters representing a phone number. This converts wide-ascii and
1821 1821
      * arabic-indic numerals to European numerals, and strips punctuation and alpha characters.
1822 1822
      *
1823
-     * @param $number string  a string of characters representing a phone number
1823
+     * @param string $number string  a string of characters representing a phone number
1824 1824
      * @return string the normalized string version of the phone number
1825 1825
      */
1826 1826
     public static function normalizeDigitsOnly($number)
@@ -2797,7 +2797,7 @@  discard block
 block discarded – undo
2797 2797
      *
2798 2798
      * @param PhoneNumber $number the phone number to be formatted
2799 2799
      * @param int $numberFormat the format the phone number should be formatted into
2800
-     * @param array $userDefinedFormats formatting rules specified by clients
2800
+     * @param NumberFormat[] $userDefinedFormats formatting rules specified by clients
2801 2801
      * @return String the formatted phone number
2802 2802
      */
2803 2803
     public function formatByPattern(PhoneNumber $number, $numberFormat, array $userDefinedFormats)
@@ -3205,6 +3205,10 @@  discard block
 block discarded – undo
3205 3205
         $this->stringEndsWithString($secondNumberNationalNumber, $firstNumberNationalNumber);
3206 3206
     }
3207 3207
 
3208
+    /**
3209
+     * @param string $hayStack
3210
+     * @param string $needle
3211
+     */
3208 3212
     protected function stringEndsWithString($hayStack, $needle)
3209 3213
     {
3210 3214
         $revNeedle = strrev($needle);
Please login to merge, or discard this patch.