Completed
Push — phoneNumberMatcher ( 6b28c4 )
by Joshua
18:40
created
build/GeneratePhonePrefixData.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -318,6 +318,9 @@
 block discarded – undo
318 318
         $this->compressAccordingToEnglishData($this->englishMaps[$countryCode], $mappings);
319 319
     }
320 320
 
321
+    /**
322
+     * @param string $textFile
323
+     */
321 324
     private function getEnglishDataPath($textFile)
322 325
     {
323 326
         return "en" . DIRECTORY_SEPARATOR . substr($textFile, 3);
Please login to merge, or discard this patch.
src/geocoding/PhoneNumberOfflineGeocoder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
      * Returns the customary display name in the given language for the given region.
122 122
      *
123 123
      * @param $regionCode
124
-     * @param $locale
124
+     * @param string $locale
125 125
      * @return string
126 126
      */
127 127
     protected function getRegionDisplayName($regionCode, $locale)
Please login to merge, or discard this patch.
src/prefixmapper/MappingFileProvider.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@
 block discarded – undo
42 42
         return "";
43 43
     }
44 44
 
45
+    /**
46
+     * @param string $countryCallingCode
47
+     */
45 48
     protected function inMap($language, $countryCallingCode)
46 49
     {
47 50
         return (array_key_exists($language, $this->map) && in_array($countryCallingCode, $this->map[$language]));
Please login to merge, or discard this patch.
tests/buildtools/BuildMetadataFromXmlTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
     }
82 82
 
83 83
     /**
84
-     * @param $xmlString
84
+     * @param string $xmlString
85 85
      * @return \DOMElement
86 86
      */
87 87
     private function parseXMLString($xmlString)
Please login to merge, or discard this patch.
tests/Issues/Issue68Test.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
         $this->assertFalse($shortNumberInfo->isPossibleShortNumberForRegion($exampleNumber, 'NE'));
26 26
     }
27 27
 
28
+    /**
29
+     * @param string $region
30
+     */
28 31
     private function getExampleNumber($region)
29 32
     {
30 33
         $phoneUtil = PhoneNumberUtil::getInstance();
Please login to merge, or discard this patch.
src/PhoneNumberMatcher.php 1 patch
Doc Comments   +14 added lines, -2 removed lines patch added patch discarded remove patch
@@ -181,6 +181,9 @@  discard block
 block discarded – undo
181 181
         static::$initialized = true;
182 182
     }
183 183
 
184
+    /**
185
+     * @param integer $lower
186
+     */
184 187
     private static function limit($lower, $upper)
185 188
     {
186 189
         if (($lower < 0) || ($upper <= 0) || ($upper < $lower)) {
@@ -274,6 +277,9 @@  discard block
 block discarded – undo
274 277
         }
275 278
     }
276 279
 
280
+    /**
281
+     * @param integer $index
282
+     */
277 283
     private function find($index)
278 284
     {
279 285
         $matcher = new Matcher(self::$pattern, $this->text);
@@ -337,6 +343,9 @@  discard block
 block discarded – undo
337 343
         || preg_match('/\pM+/u', $letter);
338 344
     }
339 345
 
346
+    /**
347
+     * @param string $character
348
+     */
340 349
     private static function isInvalidPunctuationSymbol($character)
341 350
     {
342 351
         return $character == '%' || preg_match('/\p{Sc}/u', $character);
@@ -706,6 +715,9 @@  discard block
 block discarded – undo
706 715
         return true;
707 716
     }
708 717
 
718
+    /**
719
+     * @param string $candidate
720
+     */
709 721
     public static function containsOnlyValidXChars(PhoneNumber $number, $candidate, PhoneNumberUtil $util)
710 722
     {
711 723
         // The characters 'x' and 'X' can be (1) a carrier code, in which case they always precede the
@@ -794,7 +806,7 @@  discard block
 block discarded – undo
794 806
     private static $callingCodeToAlternateFormatsMap = array();
795 807
 
796 808
     /**
797
-     * @param $countryCallingCode
809
+     * @param integer|null $countryCallingCode
798 810
      * @return PhoneMetadata|null
799 811
      */
800 812
     private static function getAlternateFormatsForCountry($countryCallingCode)
@@ -860,7 +872,7 @@  discard block
 block discarded – undo
860 872
     /**
861 873
      * Return the key of the current element
862 874
      * @link http://php.net/manual/en/iterator.key.php
863
-     * @return mixed scalar on success, or null on failure.
875
+     * @return integer scalar on success, or null on failure.
864 876
      * @since 5.0.0
865 877
      */
866 878
     public function key()
Please login to merge, or discard this patch.
src/PhoneNumberUtil.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1876,7 +1876,7 @@  discard block
 block discarded – undo
1876 1876
      * Normalizes a string of characters representing a phone number. This converts wide-ascii and
1877 1877
      * arabic-indic numerals to European numerals, and strips punctuation and alpha characters.
1878 1878
      *
1879
-     * @param $number string  a string of characters representing a phone number
1879
+     * @param string|null $number string  a string of characters representing a phone number
1880 1880
      * @return string the normalized string version of the phone number
1881 1881
      */
1882 1882
     public static function normalizeDigitsOnly($number)
@@ -2850,7 +2850,7 @@  discard block
 block discarded – undo
2850 2850
      *
2851 2851
      * @param PhoneNumber $number the phone number to be formatted
2852 2852
      * @param int $numberFormat the format the phone number should be formatted into
2853
-     * @param array $userDefinedFormats formatting rules specified by clients
2853
+     * @param NumberFormat[] $userDefinedFormats formatting rules specified by clients
2854 2854
      * @return String the formatted phone number
2855 2855
      */
2856 2856
     public function formatByPattern(PhoneNumber $number, $numberFormat, array $userDefinedFormats)
@@ -3244,6 +3244,10 @@  discard block
 block discarded – undo
3244 3244
         $this->stringEndsWithString($secondNumberNationalNumber, $firstNumberNationalNumber);
3245 3245
     }
3246 3246
 
3247
+    /**
3248
+     * @param string $hayStack
3249
+     * @param string $needle
3250
+     */
3247 3251
     protected function stringEndsWithString($hayStack, $needle)
3248 3252
     {
3249 3253
         $revNeedle = strrev($needle);
Please login to merge, or discard this patch.