Completed
Pull Request — master (#145)
by Graham
09:30
created
src/libphonenumber/PhoneNumberUtil.php 1 patch
Doc Comments   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -829,7 +829,7 @@  discard block
 block discarded – undo
829 829
      * This version exists since calculating the phone number type is expensive; if we have already
830 830
      * done this, we don't want to do it again.
831 831
      *
832
-     * @param PhoneNumber|int $phoneNumberObjOrType A PhoneNumber object, or a PhoneNumberType integer
832
+     * @param integer $phoneNumberObjOrType A PhoneNumber object, or a PhoneNumberType integer
833 833
      * @param int|null $countryCallingCode Used when passing a PhoneNumberType
834 834
      * @return bool
835 835
      */
@@ -1781,7 +1781,7 @@  discard block
 block discarded – undo
1781 1781
      * Normalizes a string of characters representing a phone number. This converts wide-ascii and
1782 1782
      * arabic-indic numerals to European numerals, and strips punctuation and alpha characters.
1783 1783
      *
1784
-     * @param $number string  a string of characters representing a phone number
1784
+     * @param string $number string  a string of characters representing a phone number
1785 1785
      * @return string the normalized string version of the phone number
1786 1786
      */
1787 1787
     public static function normalizeDigitsOnly($number)
@@ -2743,7 +2743,7 @@  discard block
 block discarded – undo
2743 2743
      *
2744 2744
      * @param PhoneNumber $number the phone number to be formatted
2745 2745
      * @param int $numberFormat the format the phone number should be formatted into
2746
-     * @param array $userDefinedFormats formatting rules specified by clients
2746
+     * @param NumberFormat[] $userDefinedFormats formatting rules specified by clients
2747 2747
      * @return String the formatted phone number
2748 2748
      */
2749 2749
     public function formatByPattern(PhoneNumber $number, $numberFormat, array $userDefinedFormats)
@@ -3136,6 +3136,10 @@  discard block
 block discarded – undo
3136 3136
         $this->stringEndsWithString($secondNumberNationalNumber, $firstNumberNationalNumber);
3137 3137
     }
3138 3138
 
3139
+    /**
3140
+     * @param string $hayStack
3141
+     * @param string $needle
3142
+     */
3139 3143
     protected function stringEndsWithString($hayStack, $needle)
3140 3144
     {
3141 3145
         $revNeedle = strrev($needle);
Please login to merge, or discard this patch.
src/libphonenumber/prefixmapper/MappingFileProvider.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@
 block discarded – undo
42 42
         return "";
43 43
     }
44 44
 
45
+    /**
46
+     * @param string $countryCallingCode
47
+     */
45 48
     protected function inMap($language, $countryCallingCode)
46 49
     {
47 50
         return (array_key_exists($language, $this->map) && in_array($countryCallingCode, $this->map[$language]));
Please login to merge, or discard this patch.
build/libphonenumber/buildtools/GeneratePhonePrefixData.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -318,6 +318,9 @@
 block discarded – undo
318 318
         $this->compressAccordingToEnglishData($this->englishMaps[$countryCode], $mappings);
319 319
     }
320 320
 
321
+    /**
322
+     * @param string $textFile
323
+     */
321 324
     private function getEnglishDataPath($textFile)
322 325
     {
323 326
         return "en" . DIRECTORY_SEPARATOR . substr($textFile, 3);
Please login to merge, or discard this patch.
src/libphonenumber/geocoding/PhoneNumberOfflineGeocoder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
      * Returns the customary display name in the given language for the given region.
122 122
      *
123 123
      * @param $regionCode
124
-     * @param $locale
124
+     * @param string $locale
125 125
      * @return string
126 126
      */
127 127
     protected function getRegionDisplayName($regionCode, $locale)
Please login to merge, or discard this patch.