IndexIterator::__construct() - Code Metrics - Inspection of "Refactor a bit." - gielfeldt/iterators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0c8b13...b1ee3a )

by Thomas

created 2017-04-27 22:25 UTC

IndexIterator::__construct() A

↳ Parent: IndexIterator

Complexity

Conditions	3
Paths	4

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
ccs	8
cts	8
cp	1
cc	3
eloc	7
nc	4
nop	2
crap	3

<?php

namespace Gielfeldt\Iterators;

class IndexIterator extends TraversableIterator implements \Countable
{
    private $indexingIterator;
    private $valid;
    private $count;


    public function __construct(\Traversable $iterator, iterable $indexes)
    {
        if ($indexes instanceof \Traversable) {
            $indexes = iterator_to_array(new \IteratorIterator($indexes), false);
        }
        sort($indexes);
        $this->indexingIterator = new \ArrayIterator($indexes);

        $iterator = $iterator instanceof \Countable ? $iterator : new CountableIterator($iterator, CountableIterator::CACHE_COUNT);
        parent::__construct($iterator);
    }

    public function count()
    {
        return min(count($this->getInnerIterator()), count($this->indexingIterator));
    }

    public function rewind()
    {
        parent::rewind();
        $this->indexingIterator->rewind();
        $this->next();
    }

    public function next()
    {
        $this->valid = $this->indexingIterator->valid();
        $index = $this->indexingIterator->current();
        while (parent::valid() && $this->getIndex() < $index) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            parent::next();
        }
        $this->indexingIterator->next();
    }

    public function valid()
    {
        return $this->valid && parent::valid();
    }
}


1		<?php
2
3		namespace Gielfeldt\Iterators;
4
5		class IndexIterator extends TraversableIterator implements \Countable
6		{
7		private $indexingIterator;
8		private $valid;
9		private $count;
		0 ignored issues – show Unused Code introduced 2017-04-27 22:27 UTC by Report Bug Copy Issue Report The property `$count` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10	3
11		public function __construct(\Traversable $iterator, iterable $indexes)
12	3	{
13	3	if ($indexes instanceof \Traversable) {
14	3	$indexes = iterator_to_array(new \IteratorIterator($indexes), false);
15		}
16	3	sort($indexes);
17		$this->indexingIterator = new \ArrayIterator($indexes);
18	3
19	3	$iterator = $iterator instanceof \Countable ? $iterator : new CountableIterator($iterator, CountableIterator::CACHE_COUNT);
20	3	parent::__construct($iterator);
21	3	}
22
23	3	public function count()
24		{
25	3	return min(count($this->getInnerIterator()), count($this->indexingIterator));
26	3	}
27	3
28	3	public function rewind()
29		{
30	3	parent::rewind();
31	3	$this->indexingIterator->rewind();
32		$this->next();
33	3	}
34
35	3	public function next()
36		{
37		$this->valid = $this->indexingIterator->valid();
38		$index = $this->indexingIterator->current();
39		while (parent::valid() && $this->getIndex() < $index) {
		0 ignored issues – show Comprehensibility Bug introduced 2017-04-23 08:41 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`valid()` instead of `next()`). Are you sure this is correct? If so, you might want to change this to `$this->valid()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
40		parent::next();
41		}
42		$this->indexingIterator->next();
43		}
44
45		public function valid()
46		{
47		return $this->valid && parent::valid();
48		}
49		}
50

gielfeldt / iterators

GitHub Access Token became invalid

Push — master ( 0c8b13...b1ee3a )

IndexIterator::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like