Gielfeldt\Iterators\IndexIterator

Complexity

Total Complexity

10

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	3
A	count()	0	4	1
A	rewind()	0	6	1
A	next()	0	9	3
A	valid()	0	4	2

<?php

namespace Gielfeldt\Iterators;

class IndexIterator extends TraversableIterator implements \Countable
{
    private $indexingIterator;
    private $valid;
    private $count;

The property $count is not used and could be removed.

    public function __construct(\Traversable $iterator, iterable $indexes)
    {
        if ($indexes instanceof \Traversable) {
            $indexes = iterator_to_array(new \IteratorIterator($indexes), false);
        }
        sort($indexes);
        $this->indexingIterator = new \ArrayIterator($indexes);

        $iterator = $iterator instanceof \Countable ? $iterator : new CountableIterator($iterator, CountableIterator::CACHE_COUNT);
        parent::__construct($iterator);
    }

    public function count()
    {
        return min(count($this->getInnerIterator()), count($this->indexingIterator));
    }

    public function rewind()
    {
        parent::rewind();
        $this->indexingIterator->rewind();
        $this->next();
    }

    public function next()
    {
        $this->valid = $this->indexingIterator->valid();
        $index = $this->indexingIterator->current();
        while (parent::valid() && $this->getIndex() < $index) {

It seems like you call parent on a different method (valid() instead of next()). Are you sure this is correct? If so, you might want to change this to $this->valid().

            parent::next();
        }
        $this->indexingIterator->next();
    }

    public function valid()
    {
        return $this->valid && parent::valid();
    }
}