ggoffy / wggithub

include/update.php

Spacing +20 added lines, -20 removed lines

@@ -39,7 +39,7 @@ 
     $ret = wggithub_check_db($module);
 
     //check upload directory
-    include_once __DIR__ . '/install.php';
+    include_once __DIR__.'/install.php';
     $ret = xoops_module_install_wggithub($module);
 
     $errors = $module->getErrors();
@@ -61,7 +61,7 @@ 
 {
     global $xoopsDB;
     $result = $xoopsDB->query(
-        'SELECT t1.tpl_id FROM ' . $xoopsDB->prefix('tplfile') . ' t1, ' . $xoopsDB->prefix('tplfile') . ' t2 WHERE t1.tpl_refid = t2.tpl_refid AND t1.tpl_module = t2.tpl_module AND t1.tpl_tplset=t2.tpl_tplset AND t1.tpl_file = t2.tpl_file AND t1.tpl_type = t2.tpl_type AND t1.tpl_id > t2.tpl_id'
+        'SELECT t1.tpl_id FROM '.$xoopsDB->prefix('tplfile').' t1, '.$xoopsDB->prefix('tplfile').' t2 WHERE t1.tpl_refid = t2.tpl_refid AND t1.tpl_module = t2.tpl_module AND t1.tpl_tplset=t2.tpl_tplset AND t1.tpl_file = t2.tpl_file AND t1.tpl_type = t2.tpl_type AND t1.tpl_id > t2.tpl_id'
     );
     $tplids = [];
     while (false !== (list($tplid) = $xoopsDB->fetchRow($result))) {
@@ -69,7 +69,7 @@ 
     }
     if (\count($tplids) > 0) {
         $tplfileHandler  = \xoops_getHandler('tplfile');
-        $duplicate_files = $tplfileHandler->getObjects(new \Criteria('tpl_id', '(' . \implode(',', $tplids) . ')', 'IN'));
+        $duplicate_files = $tplfileHandler->getObjects(new \Criteria('tpl_id', '('.\implode(',', $tplids).')', 'IN'));
 
         if (\count($duplicate_files) > 0) {
             foreach (\array_keys($duplicate_files) as $i) {
@@ -77,9 +77,9 @@ 
             }
         }
     }
-    $sql = 'SHOW INDEX FROM ' . $xoopsDB->prefix('tplfile') . " WHERE KEY_NAME = 'tpl_refid_module_set_file_type'";
+    $sql = 'SHOW INDEX FROM '.$xoopsDB->prefix('tplfile')." WHERE KEY_NAME = 'tpl_refid_module_set_file_type'";
     if (!$result = $xoopsDB->queryF($sql)) {
-        xoops_error($xoopsDB->error() . '<br>' . $sql);
+        xoops_error($xoopsDB->error().'<br>'.$sql);
 
         return false;
     }
@@ -92,9 +92,9 @@ 
 
         return true;
     }
-    $sql = 'ALTER TABLE ' . $xoopsDB->prefix('tplfile') . ' ADD UNIQUE tpl_refid_module_set_file_type ( tpl_refid, tpl_module, tpl_tplset, tpl_file, tpl_type )';
+    $sql = 'ALTER TABLE '.$xoopsDB->prefix('tplfile').' ADD UNIQUE tpl_refid_module_set_file_type ( tpl_refid, tpl_module, tpl_tplset, tpl_file, tpl_type )';
     if (!$result = $xoopsDB->queryF($sql)) {
-        xoops_error($xoopsDB->error() . '<br>' . $sql);
+        xoops_error($xoopsDB->error().'<br>'.$sql);
         $module->setErrors("'tpl_refid_module_set_file_type' unique index is not added to 'tplfile' table. Warning: do not use XOOPS until you add this unique index.");
 
         return false;
@@ -118,12 +118,12 @@ 
     // Example: update table (add new field)
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_repositories');
     $field   = 'repo_release';
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
     if (!$numRows) {
         $sql = "ALTER TABLE `$table` ADD `$field` INT(1) NOT NULL DEFAULT '0' AFTER `repo_htmlurl`;";
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
             $module->setErrors("Error when adding '$field' to table '$table'.");
             $ret = false;
         }
@@ -132,12 +132,12 @@ 
     // Example: update table (add new field)
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_repositories');
     $field   = 'repo_prerelease';
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
     if (!$numRows) {
         $sql = "ALTER TABLE `$table` ADD `$field` INT(1) NOT NULL DEFAULT '0' AFTER `repo_htmlurl`;";
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
             $module->setErrors("Error when adding '$field' to table '$table'.");
             $ret = false;
         }
@@ -145,12 +145,12 @@ 
     // Example: update table (add new field)
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_repositories');
     $field   = 'repo_readme';
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
     if (!$numRows) {
         $sql = "ALTER TABLE `$table` ADD `$field` INT(1) NOT NULL DEFAULT '0' AFTER `repo_htmlurl`;";
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
             $module->setErrors("Error when adding '$field' to table '$table'.");
             $ret = false;
         }
@@ -159,12 +159,12 @@ 
     // Example: update table (add new field)
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_directories');
     $field   = 'dir_filterrelease';
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
     if (!$numRows) {
         $sql = "ALTER TABLE `$table` ADD `$field` INT(1) NOT NULL DEFAULT '0' AFTER `dir_online`;";
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
             $module->setErrors("Error when adding '$field' to table '$table'.");
             $ret = false;
         }
@@ -186,7 +186,7 @@ 
               PRIMARY KEY (`log_id`)
                 ) ENGINE=InnoDB;";
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
             $module->setErrors("Error when creating table '$table'.");
             $ret = false;
         }
@@ -195,12 +195,12 @@ 
     // Example: update table (add new field)
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_directories');
     $field   = 'dir_content';
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
     if (!$numRows) {
         $sql = "ALTER TABLE `$table` ADD `$field` INT(10) NOT NULL DEFAULT '0' AFTER `dir_type`;";
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
             $module->setErrors("Error when adding '$field' to table '$table'.");
             $ret = false;
         }
@@ -209,12 +209,12 @@ 
     // Example: update table (add new field)
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_directories');
     $field   = 'dir_descr';
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
     if (!$numRows) {
         $sql = "ALTER TABLE `$table` ADD `$field` TEXT NOT NULL AFTER `dir_type`;";
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
             $module->setErrors("Error when adding '$field' to table '$table'.");
             $ret = false;
         }

admin/directories.php

Spacing +12 added lines, -12 removed lines

@@ -27,7 +27,7 @@ 
     Github\GithubClient
 };
 
-require __DIR__ . '/header.php';
+require __DIR__.'/header.php';
 // It recovered the value of argument op in URL$
 $op    = Request::getCmd('op', 'list');
 $dirId = Request::getInt('dir_id');
@@ -50,7 +50,7 @@ 
         $GLOBALS['xoopsTpl']->assign('directories_count', $directoriesCount);
         $GLOBALS['xoopsTpl']->assign('wggithub_url', WGGITHUB_URL);
         $GLOBALS['xoopsTpl']->assign('wggithub_upload_url', WGGITHUB_UPLOAD_URL);
-        $GLOBALS['xoopsTpl']->assign('wggithub_icons_url_16', WGGITHUB_ICONS_URL . '/16');
+        $GLOBALS['xoopsTpl']->assign('wggithub_icons_url_16', WGGITHUB_ICONS_URL.'/16');
         // Table view directories
         if ($directoriesCount > 0) {
             foreach (\array_keys($directoriesAll) as $i) {
@@ -60,8 +60,8 @@ 
             }
             // Display Navigation
             if ($directoriesCount > $limit) {
-                include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
-                $pagenav = new \XoopsPageNav($directoriesCount, $limit, $start, 'start', 'op=list&limit=' . $limit);
+                include_once XOOPS_ROOT_PATH.'/class/pagenav.php';
+                $pagenav = new \XoopsPageNav($directoriesCount, $limit, $start, 'start', 'op=list&limit='.$limit);
                 $GLOBALS['xoopsTpl']->assign('pagenav', $pagenav->renderNav(4));
             }
         } else {
@@ -101,7 +101,7 @@ 
         $directoriesObj->setVar('dir_submitter', Request::getInt('dir_submitter', 0));
         // Insert Data
         if ($directoriesHandler->insert($directoriesObj)) {
-            \redirect_header('directories.php?op=list&start=' . $start . '&limit=' . $limit, 2, _AM_WGGITHUB_FORM_OK);
+            \redirect_header('directories.php?op=list&start='.$start.'&limit='.$limit, 2, _AM_WGGITHUB_FORM_OK);
         }
         // Get Form
         $GLOBALS['xoopsTpl']->assign('error', $directoriesObj->getHtmlErrors());
@@ -140,7 +140,7 @@ 
                     $crReadmes = new \CriteriaCompo();
                     $crReadmes->add(new \Criteria('rm_repoid', $repoId));
                     if (!$readmesHandler->deleteAll($crReadmes)) {
-                        $errors[] = \_AM_WGGITHUB_ERROR_DELETE_DATA . ' READMES';
+                        $errors[] = \_AM_WGGITHUB_ERROR_DELETE_DATA.' READMES';
                     }
                 }
                 if ($repositoriesAll[$i]->getVar('repo_release') > 0 || $repositoriesAll[$i]->getVar('repo_prerelease') > 0) {
@@ -148,17 +148,17 @@ 
                     $crReleases = new \CriteriaCompo();
                     $crReleases->add(new \Criteria('rel_repoid', $repoId));
                     if (!$releasesHandler->deleteAll($crReleases)) {
-                        $errors[] = \_AM_WGGITHUB_ERROR_DELETE_DATA . ' RELEASES';
+                        $errors[] = \_AM_WGGITHUB_ERROR_DELETE_DATA.' RELEASES';
                     }
                 }
             }
             if (!$repositoriesHandler->deleteAll($crRepositories)) {
-                $errors[] = \_AM_WGGITHUB_ERROR_DELETE_DATA . ' REPOSITORIES';
+                $errors[] = \_AM_WGGITHUB_ERROR_DELETE_DATA.' REPOSITORIES';
             }
             unset($crReadmes, $crReleases, $repositoriesAll);
             //delete directory
             if (!$directoriesHandler->delete($directoriesObj)) {
-                $errors[] = \_AM_WGGITHUB_ERROR_DELETE_DATA . ' DIRECTORIES - ' . $directoriesObj->getHtmlErrors();
+                $errors[] = \_AM_WGGITHUB_ERROR_DELETE_DATA.' DIRECTORIES - '.$directoriesObj->getHtmlErrors();
             }
             if (0 == \count($errors)) {
                 \redirect_header('directories.php', 3, _AM_WGGITHUB_FORM_DELETE_OK);
@@ -179,7 +179,7 @@ 
         $dirName = $directoriesObj->getVar('dir_name');
         $githubClient = GithubClient::getInstance();
         $result = $githubClient->executeUpdate($dirName);
-        $redir = 'directories.php?op=list&start=' . $start . '&limit=' . $limit;
+        $redir = 'directories.php?op=list&start='.$start.'&limit='.$limit;
         if ($result) {
             \redirect_header($redir, 2, \_MA_WGGITHUB_READGH_SUCCESS);
         } else {
@@ -192,9 +192,9 @@ 
             $directoriesObj->setVar(Request::getString('field'), Request::getInt('value', 0));
             // Insert Data
             if ($directoriesHandler->insert($directoriesObj, true)) {
-                \redirect_header('directories.php?op=list&start=' . $start . '&limit=' . $limit, 2, _AM_WGGITHUB_FORM_OK);
+                \redirect_header('directories.php?op=list&start='.$start.'&limit='.$limit, 2, _AM_WGGITHUB_FORM_OK);
             }
         }
         break;
 }
-require __DIR__ . '/footer.php';
+require __DIR__.'/footer.php';

class/RepositoriesHandler.php

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
         $submitter = isset($GLOBALS['xoopsUser']) && \is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
         // add/update all items from table repositories
         foreach ($repos as $key => $repo) {
-            $fork = (bool)$repo['fork'];
+            $fork = (bool) $repo['fork'];
             if (Constants::DIRECTORY_CONTENT_ALL == $dirContent || false === $fork) {
                 $crRepositories = new \CriteriaCompo();
                 $crRepositories->add(new \Criteria('repo_nodeid', $repo['node_id']));

class/Directories.php

Spacing +5 added lines, -5 removed lines

@@ -157,11 +157,11 @@ 
         $ret = $this->getValues($keys, $format, $maxDepth);
         $ret['id']          = $this->getVar('dir_id');
         $ret['name']        = $this->getVar('dir_name');
-        $ret['descr']        = $this->getVar('dir_descr');
+        $ret['descr'] = $this->getVar('dir_descr');
         $ret['type']        = $this->getVar('dir_type');
         $ret['type_text']   = Constants::DIRECTORY_TYPE_USER == $this->getVar('dir_type') ? \_AM_WGGITHUB_DIRECTORY_TYPE_USER : \_AM_WGGITHUB_DIRECTORY_TYPE_ORG;
         $content            = $this->getVar('dir_content');
-        $ret['content']      = $content;
+        $ret['content'] = $content;
         switch ($content) {
             case Constants::DIRECTORY_CONTENT_ALL:
             default:
@@ -172,9 +172,9 @@ 
                 break;
         }
         $ret['content_shorttext'] = Utility::truncateHtml($content_text);
-        $ret['autoupdate']  = (int)$this->getVar('dir_autoupdate') > 0 ? _YES : _NO;
-        $ret['online']      = (int)$this->getVar('dir_online') > 0 ? _YES : _NO;
-        $ret['filterrelease'] = (int)$this->getVar('dir_filterrelease') > 0 ? _YES : _NO;
+        $ret['autoupdate']  = (int) $this->getVar('dir_autoupdate') > 0 ? _YES : _NO;
+        $ret['online']      = (int) $this->getVar('dir_online') > 0 ? _YES : _NO;
+        $ret['filterrelease'] = (int) $this->getVar('dir_filterrelease') > 0 ? _YES : _NO;
         $ret['datecreated'] = \formatTimestamp($this->getVar('dir_datecreated'), 's');
         $ret['submitter']   = \XoopsUser::getUnameFromId($this->getVar('dir_submitter'));
         return $ret;

class/Readmes.php

Spacing +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
         $helper  = \XoopsModules\Wggithub\Helper::getInstance();
         $utility = new \XoopsModules\Wggithub\Utility();
         $ret = $this->getValues($keys, $format, $maxDepth);
-        $ret['id']            = $this->getVar('rm_id');
+        $ret['id'] = $this->getVar('rm_id');
         $repositoriesHandler = $helper->getHandler('Repositories');
         $repositoriesObj = $repositoriesHandler->get($this->getVar('rm_repoid'));
         if (\is_object($repositoriesObj)) {

class/Constants.php

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
     public const DIRECTORY_TYPE_USER = 1;
     public const DIRECTORY_TYPE_ORG  = 2;
 
-    public const DIRECTORY_CONTENT_ALL  = 0;
+    public const DIRECTORY_CONTENT_ALL = 0;
     public const DIRECTORY_CONTENT_OWN = 1;
 
     // Constants for status
@@ -57,7 +57,7 @@ 
     public const PERM_README_UPDATE = 3;
 
     // Constants for log type
-    public const LOG_TYPE_NONE  = 0;
+    public const LOG_TYPE_NONE = 0;
     public const LOG_TYPE_UPDATE_START = 1;
     public const LOG_TYPE_UPDATE_END   = 2;
     public const LOG_TYPE_REQUEST      = 3;

class/Releases.php

Spacing +3 added lines, -3 removed lines

@@ -136,9 +136,9 @@ 
      */
     public function getValuesReleases($keys = null, $format = null, $maxDepth = null)
     {
-        $helper  = \XoopsModules\Wggithub\Helper::getInstance();
+        $helper = \XoopsModules\Wggithub\Helper::getInstance();
         $ret = $this->getValues($keys, $format, $maxDepth);
-        $ret['id']          = $this->getVar('rel_id');
+        $ret['id'] = $this->getVar('rel_id');
         $repositoriesHandler = $helper->getHandler('Repositories');
         $repositoriesObj = $repositoriesHandler->get($this->getVar('rel_repoid'));
         if (\is_object($repositoriesObj)) {
@@ -148,7 +148,7 @@ 
         }
         $ret['type']        = $this->getVar('rel_type');
         $ret['name']        = $this->getVar('rel_name');
-        $ret['prerelease']  = (int)$this->getVar('rel_prerelease') > 0 ? _YES : _NO;
+        $ret['prerelease']  = (int) $this->getVar('rel_prerelease') > 0 ? _YES : _NO;
         $ret['publishedat'] = \formatTimestamp($this->getVar('rel_publishedat'), 'm');
         $ret['tarballurl']  = $this->getVar('rel_tarballurl');
         $ret['zipballurl']  = $this->getVar('rel_zipballurl');