Inspection of "cleaning" - ggoffy/wggithub - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 59dd06...8b564e )

by Goffy

created 2021-03-25 06:02 UTC

Status

Indentation +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -29,16 +29,16 @@  discard block
 block discarded – undo
  */
 function wggithubCommentsUpdate($itemId, $itemNumb)
 {
-	// Get instance of module
-	$helper = \XoopsModules\Wggithub\Helper::getInstance();
-	$repositoriesHandler = $helper->getHandler('Repositories');
-	$repoId = (int)$itemId;
-	$repositoriesObj = $repositoriesHandler->get($repoId);
-	$repositoriesObj->setVar('repo_comments', (int)$itemNumb);
-	if ($repositoriesHandler->insert($repositoriesObj)) {
-		return true;
-	}
-	return false;
+    // Get instance of module
+    $helper = \XoopsModules\Wggithub\Helper::getInstance();
+    $repositoriesHandler = $helper->getHandler('Repositories');
+    $repoId = (int)$itemId;
+    $repositoriesObj = $repositoriesHandler->get($repoId);
+    $repositoriesObj->setVar('repo_comments', (int)$itemNumb);
+    if ($repositoriesHandler->insert($repositoriesObj)) {
+        return true;
+    }
+    return false;
 }
 
 /**
@@ -49,21 +49,21 @@  discard block
 block discarded – undo
  */
 function wggithubCommentsApprove($comment)
 {
-	// Notification event
-	// Get instance of module
-	$helper = \XoopsModules\Wggithub\Helper::getInstance();
-	$repositoriesHandler = $helper->getHandler('Repositories');
-	$repoId = $comment->getVar('com_itemid');
-	$repositoriesObj = $repositoriesHandler->get($repoId);
-	$repoName = $repositoriesObj->getVar('repo_name');
+    // Notification event
+    // Get instance of module
+    $helper = \XoopsModules\Wggithub\Helper::getInstance();
+    $repositoriesHandler = $helper->getHandler('Repositories');
+    $repoId = $comment->getVar('com_itemid');
+    $repositoriesObj = $repositoriesHandler->get($repoId);
+    $repoName = $repositoriesObj->getVar('repo_name');
 
-	$tags = [];
-	$tags['ITEM_NAME'] = $repoName;
-	$tags['ITEM_URL']  = \XOOPS_URL . '/modules/wggithub/repositories.php?op=show&repo_id=' . $repoId;
-	$notificationHandler = \xoops_getHandler('notification');
-	// Event modify notification
-	$notificationHandler->triggerEvent('global', 0, 'global_comment', $tags);
-	$notificationHandler->triggerEvent('repositories', $repoId, 'repository_comment', $tags);
-	return true;
+    $tags = [];
+    $tags['ITEM_NAME'] = $repoName;
+    $tags['ITEM_URL']  = \XOOPS_URL . '/modules/wggithub/repositories.php?op=show&repo_id=' . $repoId;
+    $notificationHandler = \xoops_getHandler('notification');
+    // Event modify notification
+    $notificationHandler->triggerEvent('global', 0, 'global_comment', $tags);
+    $notificationHandler->triggerEvent('repositories', $repoId, 'repository_comment', $tags);
+    return true;
 
 }

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -32,9 +32,9 @@  discard block
 block discarded – undo
 	// Get instance of module
 	$helper = \XoopsModules\Wggithub\Helper::getInstance();
 	$repositoriesHandler = $helper->getHandler('Repositories');
-	$repoId = (int)$itemId;
+	$repoId = (int) $itemId;
 	$repositoriesObj = $repositoriesHandler->get($repoId);
-	$repositoriesObj->setVar('repo_comments', (int)$itemNumb);
+	$repositoriesObj->setVar('repo_comments', (int) $itemNumb);
 	if ($repositoriesHandler->insert($repositoriesObj)) {
 		return true;
 	}
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
 
 	$tags = [];
 	$tags['ITEM_NAME'] = $repoName;
-	$tags['ITEM_URL']  = \XOOPS_URL . '/modules/wggithub/repositories.php?op=show&repo_id=' . $repoId;
+	$tags['ITEM_URL']  = \XOOPS_URL.'/modules/wggithub/repositories.php?op=show&repo_id='.$repoId;
 	$notificationHandler = \xoops_getHandler('notification');
 	// Event modify notification
 	$notificationHandler->triggerEvent('global', 0, 'global_comment', $tags);

Please login to merge, or discard this patch.

		@@ -29,16 +29,16 @@ discard block
		block discarded – undo
29	29	*/
30	30	function wggithubCommentsUpdate($itemId, $itemNumb)
31	31	{
32		- // Get instance of module
33		- $helper = \XoopsModules\Wggithub\Helper::getInstance();
34		- $repositoriesHandler = $helper->getHandler('Repositories');
35		- $repoId = (int)$itemId;
36		- $repositoriesObj = $repositoriesHandler->get($repoId);
37		- $repositoriesObj->setVar('repo_comments', (int)$itemNumb);
38		- if ($repositoriesHandler->insert($repositoriesObj)) {
39		- return true;
40		- }
41		- return false;
	32	+ // Get instance of module
	33	+ $helper = \XoopsModules\Wggithub\Helper::getInstance();
	34	+ $repositoriesHandler = $helper->getHandler('Repositories');
	35	+ $repoId = (int)$itemId;
	36	+ $repositoriesObj = $repositoriesHandler->get($repoId);
	37	+ $repositoriesObj->setVar('repo_comments', (int)$itemNumb);
	38	+ if ($repositoriesHandler->insert($repositoriesObj)) {
	39	+ return true;
	40	+ }
	41	+ return false;
42	42	}
43	43
44	44	/**
		@@ -49,21 +49,21 @@ discard block
		block discarded – undo
49	49	*/
50	50	function wggithubCommentsApprove($comment)
51	51	{
52		- // Notification event
53		- // Get instance of module
54		- $helper = \XoopsModules\Wggithub\Helper::getInstance();
55		- $repositoriesHandler = $helper->getHandler('Repositories');
56		- $repoId = $comment->getVar('com_itemid');
57		- $repositoriesObj = $repositoriesHandler->get($repoId);
58		- $repoName = $repositoriesObj->getVar('repo_name');
	52	+ // Notification event
	53	+ // Get instance of module
	54	+ $helper = \XoopsModules\Wggithub\Helper::getInstance();
	55	+ $repositoriesHandler = $helper->getHandler('Repositories');
	56	+ $repoId = $comment->getVar('com_itemid');
	57	+ $repositoriesObj = $repositoriesHandler->get($repoId);
	58	+ $repoName = $repositoriesObj->getVar('repo_name');
59	59
60		- $tags = [];
61		- $tags['ITEM_NAME'] = $repoName;
62		- $tags['ITEM_URL'] = \XOOPS_URL . '/modules/wggithub/repositories.php?op=show&repo_id=' . $repoId;
63		- $notificationHandler = \xoops_getHandler('notification');
64		- // Event modify notification
65		- $notificationHandler->triggerEvent('global', 0, 'global_comment', $tags);
66		- $notificationHandler->triggerEvent('repositories', $repoId, 'repository_comment', $tags);
67		- return true;
	60	+ $tags = [];
	61	+ $tags['ITEM_NAME'] = $repoName;
	62	+ $tags['ITEM_URL'] = \XOOPS_URL . '/modules/wggithub/repositories.php?op=show&repo_id=' . $repoId;
	63	+ $notificationHandler = \xoops_getHandler('notification');
	64	+ // Event modify notification
	65	+ $notificationHandler->triggerEvent('global', 0, 'global_comment', $tags);
	66	+ $notificationHandler->triggerEvent('repositories', $repoId, 'repository_comment', $tags);
	67	+ return true;
68	68
69	69	}

		@@ -32,9 +32,9 @@ discard block
		block discarded – undo
32	32	// Get instance of module
33	33	$helper = \XoopsModules\Wggithub\Helper::getInstance();
34	34	$repositoriesHandler = $helper->getHandler('Repositories');
35		- $repoId = (int)$itemId;
	35	+ $repoId = (int) $itemId;
36	36	$repositoriesObj = $repositoriesHandler->get($repoId);
37		- $repositoriesObj->setVar('repo_comments', (int)$itemNumb);
	37	+ $repositoriesObj->setVar('repo_comments', (int) $itemNumb);
38	38	if ($repositoriesHandler->insert($repositoriesObj)) {
39	39	return true;
40	40	}
		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59
60	60	$tags = [];
61	61	$tags['ITEM_NAME'] = $repoName;
62		- $tags['ITEM_URL'] = \XOOPS_URL . '/modules/wggithub/repositories.php?op=show&repo_id=' . $repoId;
	62	+ $tags['ITEM_URL'] = \XOOPS_URL.'/modules/wggithub/repositories.php?op=show&repo_id='.$repoId;
63	63	$notificationHandler = \xoops_getHandler('notification');
64	64	// Event modify notification
65	65	$notificationHandler->triggerEvent('global', 0, 'global_comment', $tags);

ggoffy / wggithub

Push — master ( 59dd06...8b564e )

Status

Category

Indentation +25 added lines, -25 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch