@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -include_once __DIR__ . '/ServerAwareTestCase.php'; |
|
3 | +include_once __DIR__.'/ServerAwareTestCase.php'; |
|
4 | 4 | |
5 | 5 | /** |
6 | 6 | * Tests involving the Client class features (and mostly no server). |
@@ -62,7 +62,7 @@ discard block |
||
62 | 62 | $this->client->server .= 'XXX'; |
63 | 63 | $dnsinfo = @dns_get_record($this->client->server); |
64 | 64 | if ($dnsinfo) { |
65 | - $this->markTestSkipped('Seems like there is a catchall DNS in effect: host ' . $this->client->server . ' found'); |
|
65 | + $this->markTestSkipped('Seems like there is a catchall DNS in effect: host '.$this->client->server.' found'); |
|
66 | 66 | } else { |
67 | 67 | $m = new xmlrpcmsg('examples.echo', array( |
68 | 68 | new xmlrpcval('hello', 'string'), |
@@ -91,7 +91,7 @@ discard block |
||
91 | 91 | |
92 | 92 | // now test a successful connection |
93 | 93 | $server = explode(':', $this->args['HTTPSERVER']); |
94 | - if (count($server) > 1) { |
|
94 | + if (count($server)>1) { |
|
95 | 95 | $this->client->port = $server[1]; |
96 | 96 | } |
97 | 97 | $this->client->server = $server[0]; |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -include_once __DIR__ . '/LoggerAwareTestCase.php'; |
|
3 | +include_once __DIR__.'/LoggerAwareTestCase.php'; |
|
4 | 4 | |
5 | 5 | /** |
6 | 6 | * Tests involving xml parsing. |
@@ -101,7 +101,7 @@ discard block |
||
101 | 101 | |
102 | 102 | public function testI8() |
103 | 103 | { |
104 | - if (PHP_INT_SIZE == 4 ) { |
|
104 | + if (PHP_INT_SIZE == 4) { |
|
105 | 105 | $this->markTestSkipped('Can not test i8 as php is compiled in 32 bit mode'); |
106 | 106 | } |
107 | 107 | |
@@ -175,7 +175,7 @@ discard block |
||
175 | 175 | |
176 | 176 | public function testUnicodeInMemberName() |
177 | 177 | { |
178 | - $str = "G" . chr(252) . "nter, El" . chr(232) . "ne"; |
|
178 | + $str = "G".chr(252)."nter, El".chr(232)."ne"; |
|
179 | 179 | $v = array($str => new xmlrpcval(1)); |
180 | 180 | $r = new xmlrpcresp(new xmlrpcval($v, 'struct')); |
181 | 181 | $r = $r->serialize(); |
@@ -191,7 +191,7 @@ discard block |
||
191 | 191 | $response = @utf8_encode( |
192 | 192 | '<?xml version="1.0"?> |
193 | 193 | <!-- covers what happens when lib receives UTF8 chars in response text and comments --> |
194 | -<!-- ' . chr(224) . chr(252) . chr(232) . 'àüè --> |
|
194 | +<!-- ' . chr(224).chr(252).chr(232).'àüè --> |
|
195 | 195 | <methodResponse> |
196 | 196 | <fault> |
197 | 197 | <value> |
@@ -202,7 +202,7 @@ discard block |
||
202 | 202 | </member> |
203 | 203 | <member> |
204 | 204 | <name>faultString</name> |
205 | -<value><string>' . chr(224) . chr(252) . chr(232) . 'àüè</string></value> |
|
205 | +<value><string>' . chr(224).chr(252).chr(232).'àüè</string></value> |
|
206 | 206 | </member> |
207 | 207 | </struct> |
208 | 208 | </value> |
@@ -211,7 +211,7 @@ discard block |
||
211 | 211 | $m = $this->newRequest('dummy'); |
212 | 212 | $r = $m->parseResponse($response); |
213 | 213 | $v = $r->faultString(); |
214 | - $this->assertEquals(chr(224) . chr(252) . chr(232) . chr(224) . chr(252) . chr(232), $v); |
|
214 | + $this->assertEquals(chr(224).chr(252).chr(232).chr(224).chr(252).chr(232), $v); |
|
215 | 215 | } |
216 | 216 | |
217 | 217 | public function testBrokenRequests() |
@@ -468,8 +468,8 @@ discard block |
||
468 | 468 | $i = \PhpXmlRpc\PhpXmlRpc::$xmlrpc_reject_invalid_values; |
469 | 469 | \PhpXmlRpc\PhpXmlRpc::$xmlrpc_reject_invalid_values = true; |
470 | 470 | |
471 | - foreach($values as $value) { |
|
472 | - $f = '<?xml version="1.0"?><methodResponse><params><param><value>' . $value . '</value></param></params></methodResponse> '; |
|
471 | + foreach ($values as $value) { |
|
472 | + $f = '<?xml version="1.0"?><methodResponse><params><param><value>'.$value.'</value></param></params></methodResponse> '; |
|
473 | 473 | $r = $s->parseResponse($f); |
474 | 474 | $v = $r->faultCode(); |
475 | 475 | $this->assertEquals(2, $v, "Testing $value"); |
@@ -574,11 +574,11 @@ discard block |
||
574 | 574 | |
575 | 575 | public function testUTF8Response() |
576 | 576 | { |
577 | - $string = chr(224) . chr(252) . chr(232); |
|
577 | + $string = chr(224).chr(252).chr(232); |
|
578 | 578 | |
579 | 579 | $s = $this->newRequest('dummy'); |
580 | - $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=UTF-8\r\n\r\n" . '<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member> |
|
581 | -<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . @utf8_encode($string) . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse> |
|
580 | + $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=UTF-8\r\n\r\n".'<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member> |
|
581 | +<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . @utf8_encode($string).'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse> |
|
582 | 582 | '; |
583 | 583 | $r = $s->parseResponse($f, false, 'phpvals'); |
584 | 584 | $v = $r->value(); |
@@ -586,7 +586,7 @@ discard block |
||
586 | 586 | $this->assertEquals($string, $v); |
587 | 587 | |
588 | 588 | $f = '<?xml version="1.0" encoding="UTF-8"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member> |
589 | -<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . @utf8_encode($string) . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse> |
|
589 | +<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . @utf8_encode($string).'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse> |
|
590 | 590 | '; |
591 | 591 | $r = $s->parseResponse($f, false, 'phpvals'); |
592 | 592 | $v = $r->value(); |
@@ -602,11 +602,11 @@ discard block |
||
602 | 602 | |
603 | 603 | public function testLatin1Response() |
604 | 604 | { |
605 | - $string = chr(224) . chr(252) . chr(232); |
|
605 | + $string = chr(224).chr(252).chr(232); |
|
606 | 606 | |
607 | 607 | $s = $this->newRequest('dummy'); |
608 | - $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=ISO-8859-1\r\n\r\n" . '<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member> |
|
609 | -<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse> |
|
608 | + $f = "HTTP/1.1 200 OK\r\nContent-type: text/xml; charset=ISO-8859-1\r\n\r\n".'<?xml version="1.0"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member> |
|
609 | +<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string.'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse> |
|
610 | 610 | '; |
611 | 611 | $r = $s->parseResponse($f, false, 'phpvals'); |
612 | 612 | $v = $r->value(); |
@@ -614,7 +614,7 @@ discard block |
||
614 | 614 | $this->assertEquals($string, $v); |
615 | 615 | |
616 | 616 | $f = '<?xml version="1.0" encoding="ISO-8859-1"?><methodResponse><params><param><value><struct><member><name>userid</name><value>311127</value></member> |
617 | -<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string . '</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse> |
|
617 | +<member><name>dateCreated</name><value><dateTime.iso8601>20011126T09:17:52</dateTime.iso8601></value></member><member><name>content</name><value>' . $string.'</value></member><member><name>postid</name><value>7414222</value></member></struct></value></param></params></methodResponse> |
|
618 | 618 | '; |
619 | 619 | $r = $s->parseResponse($f, false, 'phpvals'); |
620 | 620 | $v = $r->value(); |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -include_once __DIR__ . '/ServerAwareTestCase.php'; |
|
3 | +include_once __DIR__.'/ServerAwareTestCase.php'; |
|
4 | 4 | |
5 | 5 | /** |
6 | 6 | * @todo Long-term, this should replace all testing of the legacy API done via the main test-suite... |
@@ -14,7 +14,7 @@ discard block |
||
14 | 14 | { |
15 | 15 | /// @todo pass on as cli args for the executed script all the args that are already parsed by now, plus $this->testId |
16 | 16 | |
17 | - exec('php ' . __DIR__ . '/legacy_loader_test.php', $out, $result); |
|
17 | + exec('php '.__DIR__.'/legacy_loader_test.php', $out, $result); |
|
18 | 18 | |
19 | 19 | /// @todo dump output if in debug mode or if test fails |
20 | 20 |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -include_once __DIR__ . '/08ServerTest.php'; |
|
3 | +include_once __DIR__.'/08ServerTest.php'; |
|
4 | 4 | |
5 | 5 | /** |
6 | 6 | * Tests which stress http features of the library. |
@@ -33,7 +33,7 @@ discard block |
||
33 | 33 | { |
34 | 34 | $methods = array(); |
35 | 35 | // as long as we are descendants, get_class_methods will list private/protected methods |
36 | - foreach(get_class_methods('ServerTest') as $method) |
|
36 | + foreach (get_class_methods('ServerTest') as $method) |
|
37 | 37 | { |
38 | 38 | if (strpos($method, 'test') === 0 && !in_array($method, $this->unsafeMethods)) |
39 | 39 | { |
@@ -151,7 +151,7 @@ discard block |
||
151 | 151 | // this checks for a non-failed call |
152 | 152 | $time = microtime(true); |
153 | 153 | $this->send($m); |
154 | - $time = microtime(true) - $time; |
|
154 | + $time = microtime(true)-$time; |
|
155 | 155 | $this->assertGreaterThan(1.0, $time); |
156 | 156 | $this->assertLessThan(2.0, $time); |
157 | 157 | |
@@ -159,7 +159,7 @@ discard block |
||
159 | 159 | $m = new xmlrpcmsg('tests.sleep', array(new xmlrpcval(5, 'int'))); |
160 | 160 | $time = microtime(true); |
161 | 161 | $r = $this->send($m, array(0, PhpXmlRpc\PhpXmlRpc::$xmlrpcerr['http_error'], PhpXmlRpc\PhpXmlRpc::$xmlrpcerr['curl_fail'])); |
162 | - $time = microtime(true) - $time; |
|
162 | + $time = microtime(true)-$time; |
|
163 | 163 | $this->assertGreaterThan(2.0, $time); |
164 | 164 | $this->assertLessThan(4.0, $time); |
165 | 165 | |
@@ -179,7 +179,7 @@ discard block |
||
179 | 179 | $this->addQueryParams(array('SLOW_LORIS' => 1)); |
180 | 180 | $time = microtime(true); |
181 | 181 | $this->send($m, array(0, PhpXmlRpc\PhpXmlRpc::$xmlrpcerr['http_error'], PhpXmlRpc\PhpXmlRpc::$xmlrpcerr['curl_fail'])); |
182 | - $time = microtime(true) - $time; |
|
182 | + $time = microtime(true)-$time; |
|
183 | 183 | $this->assertGreaterThan(2.0, $time); |
184 | 184 | $this->assertLessThan(4.0, $time); |
185 | 185 | } |
@@ -366,7 +366,7 @@ discard block |
||
366 | 366 | preg_match('/ubunutu([0-9]+)/', $output[0], $matches); |
367 | 367 | $ubuntuVersion = @$matches[1]; |
368 | 368 | } |
369 | - if ($ubuntuVersion >= 20 && $this->args['SSLVERSION'] != 6) { |
|
369 | + if ($ubuntuVersion>=20 && $this->args['SSLVERSION'] != 6) { |
|
370 | 370 | $this->markTestSkipped('HTTPS via Socket known to fail on php less than 7.2 on Ubuntu 20 and higher'); |
371 | 371 | return; |
372 | 372 | } |
@@ -392,7 +392,7 @@ discard block |
||
392 | 392 | $this->client->setOption(\PhpXmlRpc\Client::OPT_EXTRA_SOCKET_OPTS, |
393 | 393 | array('ssl' => array( |
394 | 394 | // security level is available as of php 7.2.0 + openssl 1.1.0 according to the docs |
395 | - 'security_level' => min(1 + $version[1], 5), |
|
395 | + 'security_level' => min(1+$version[1], 5), |
|
396 | 396 | // capture_session_meta was deprecated in php 7.0 |
397 | 397 | //'capture_session_meta' => true, |
398 | 398 | )) |
@@ -541,7 +541,7 @@ discard block |
||
541 | 541 | if (version_compare(PHP_VERSION, '8.0', '>=') && $this->args['SSLVERSION'] == 0) |
542 | 542 | { |
543 | 543 | $version = explode('.', PHP_VERSION); |
544 | - $this->client->setSSLVersion(min(4 + $version[1], 7)); |
|
544 | + $this->client->setSSLVersion(min(4+$version[1], 7)); |
|
545 | 545 | } |
546 | 546 | |
547 | 547 | $this->$method(); |
@@ -313,8 +313,7 @@ discard block |
||
313 | 313 | { |
314 | 314 | $this->markTestSkipped('CURL missing: cannot test https functionality'); |
315 | 315 | return; |
316 | - } |
|
317 | - else if ($this->args['HTTPSSERVER'] == '') |
|
316 | + } else if ($this->args['HTTPSSERVER'] == '') |
|
318 | 317 | { |
319 | 318 | $this->markTestSkipped('HTTPS SERVER definition missing: cannot test https'); |
320 | 319 | return; |
@@ -491,8 +490,7 @@ discard block |
||
491 | 490 | { |
492 | 491 | $this->markTestSkipped('CURL missing: cannot test http 1.1 w. proxy'); |
493 | 492 | return; |
494 | - } |
|
495 | - else if ($this->args['PROXYSERVER'] == '') |
|
493 | + } else if ($this->args['PROXYSERVER'] == '') |
|
496 | 494 | { |
497 | 495 | $this->markTestSkipped('PROXYSERVER definition missing: cannot test proxy w. http 1.1'); |
498 | 496 | return; |
@@ -516,13 +514,11 @@ discard block |
||
516 | 514 | { |
517 | 515 | $this->markTestSkipped('CURL missing: cannot test https w. proxy'); |
518 | 516 | return; |
519 | - } |
|
520 | - else if ($this->args['PROXYSERVER'] == '') |
|
517 | + } else if ($this->args['PROXYSERVER'] == '') |
|
521 | 518 | { |
522 | 519 | $this->markTestSkipped('PROXYSERVER definition missing: cannot test proxy w. https'); |
523 | 520 | return; |
524 | - } |
|
525 | - else if ($this->args['HTTPSSERVER'] == '') |
|
521 | + } else if ($this->args['HTTPSSERVER'] == '') |
|
526 | 522 | { |
527 | 523 | $this->markTestSkipped('HTTPS SERVER definition missing: cannot test https w. proxy'); |
528 | 524 | return; |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -include_once __DIR__ . '/LoggerAwareTestCase.php'; |
|
3 | +include_once __DIR__.'/LoggerAwareTestCase.php'; |
|
4 | 4 | |
5 | 5 | use PHPUnit\Extensions\SeleniumCommon\RemoteCoverage; |
6 | 6 | use PHPUnit\Framework\TestResult; |
@@ -30,7 +30,7 @@ discard block |
||
30 | 30 | */ |
31 | 31 | public function _run($result = NULL) |
32 | 32 | { |
33 | - $this->testId = get_class($this) . '__' . $this->getName(); |
|
33 | + $this->testId = get_class($this).'__'.$this->getName(); |
|
34 | 34 | |
35 | 35 | if ($result === NULL) { |
36 | 36 | $result = $this->createResult(); |
@@ -62,13 +62,13 @@ discard block |
||
62 | 62 | |
63 | 63 | // Set up a database connection or other fixture which needs to be available. |
64 | 64 | self::$randId = uniqid(); |
65 | - file_put_contents(sys_get_temp_dir() . '/phpunit_rand_id.txt', self::$randId); |
|
65 | + file_put_contents(sys_get_temp_dir().'/phpunit_rand_id.txt', self::$randId); |
|
66 | 66 | } |
67 | 67 | |
68 | 68 | public static function tear_down_after_class() |
69 | 69 | { |
70 | - if (is_file(sys_get_temp_dir() . '/phpunit_rand_id.txt')) { |
|
71 | - unlink(sys_get_temp_dir() . '/phpunit_rand_id.txt'); |
|
70 | + if (is_file(sys_get_temp_dir().'/phpunit_rand_id.txt')) { |
|
71 | + unlink(sys_get_temp_dir().'/phpunit_rand_id.txt'); |
|
72 | 72 | } |
73 | 73 | |
74 | 74 | parent::tear_down_after_class(); |
@@ -79,15 +79,15 @@ discard block |
||
79 | 79 | parent::set_up(); |
80 | 80 | |
81 | 81 | // assumes HTTPURI to be in the form /tests/index.php?etc... |
82 | - $this->baseUrl = 'http://' . $this->args['HTTPSERVER'] . preg_replace('|\?.+|', '', $this->args['HTTPURI']); |
|
83 | - $this->coverageScriptUrl = 'http://' . $this->args['HTTPSERVER'] . preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']); |
|
82 | + $this->baseUrl = 'http://'.$this->args['HTTPSERVER'].preg_replace('|\?.+|', '', $this->args['HTTPURI']); |
|
83 | + $this->coverageScriptUrl = 'http://'.$this->args['HTTPSERVER'].preg_replace('|/tests/index\.php(\?.*)?|', '/tests/phpunit_coverage.php', $this->args['HTTPURI']); |
|
84 | 84 | } |
85 | 85 | |
86 | 86 | protected function getClient() |
87 | 87 | { |
88 | 88 | $server = explode(':', $this->args['HTTPSERVER']); |
89 | 89 | /// @todo use the non-legacy API calling convention, except in a dedicated test |
90 | - if (count($server) > 1) { |
|
90 | + if (count($server)>1) { |
|
91 | 91 | $client = new xmlrpc_client($this->args['HTTPURI'], $server[0], $server[1]); |
92 | 92 | } else { |
93 | 93 | $client = new xmlrpc_client($this->args['HTTPURI'], $this->args['HTTPSERVER']); |
@@ -338,10 +338,10 @@ discard block |
||
338 | 338 | $server = $parts['host']; |
339 | 339 | $path = isset($parts['path']) ? $parts['path'] : ''; |
340 | 340 | if (isset($parts['query'])) { |
341 | - $path .= '?' . $parts['query']; |
|
341 | + $path .= '?'.$parts['query']; |
|
342 | 342 | } |
343 | 343 | if (isset($parts['fragment'])) { |
344 | - $path .= '#' . $parts['fragment']; |
|
344 | + $path .= '#'.$parts['fragment']; |
|
345 | 345 | } |
346 | 346 | if (isset($parts['port'])) { |
347 | 347 | $port = $parts['port']; |
@@ -357,7 +357,7 @@ discard block |
||
357 | 357 | } |
358 | 358 | } |
359 | 359 | if ($path == '' || $path[0] != '/') { |
360 | - $this->path = '/' . $path; |
|
360 | + $this->path = '/'.$path; |
|
361 | 361 | } else { |
362 | 362 | $this->path = $path; |
363 | 363 | } |
@@ -389,7 +389,7 @@ discard block |
||
389 | 389 | //$this->accepted_charset_encodings = $ch->knownCharsets(); |
390 | 390 | |
391 | 391 | // initialize user_agent string |
392 | - $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion; |
|
392 | + $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion; |
|
393 | 393 | } |
394 | 394 | |
395 | 395 | /** |
@@ -561,7 +561,7 @@ discard block |
||
561 | 561 | */ |
562 | 562 | public function setSSLVerifyPeer($i) |
563 | 563 | { |
564 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
564 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
565 | 565 | |
566 | 566 | $this->verifypeer = $i; |
567 | 567 | return $this; |
@@ -578,7 +578,7 @@ discard block |
||
578 | 578 | */ |
579 | 579 | public function setSSLVerifyHost($i) |
580 | 580 | { |
581 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
581 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
582 | 582 | |
583 | 583 | $this->verifyhost = $i; |
584 | 584 | return $this; |
@@ -596,7 +596,7 @@ discard block |
||
596 | 596 | */ |
597 | 597 | public function setSSLVersion($i) |
598 | 598 | { |
599 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
599 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
600 | 600 | |
601 | 601 | $this->sslversion = $i; |
602 | 602 | return $this; |
@@ -661,7 +661,7 @@ discard block |
||
661 | 661 | */ |
662 | 662 | public function setRequestCompression($compMethod) |
663 | 663 | { |
664 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
664 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
665 | 665 | |
666 | 666 | $this->request_compression = $compMethod; |
667 | 667 | return $this; |
@@ -711,7 +711,7 @@ discard block |
||
711 | 711 | */ |
712 | 712 | public function setCurlOptions($options) |
713 | 713 | { |
714 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
714 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
715 | 715 | |
716 | 716 | $this->extracurlopts = $options; |
717 | 717 | return $this; |
@@ -725,7 +725,7 @@ discard block |
||
725 | 725 | */ |
726 | 726 | public function setUseCurl($useCurlMode) |
727 | 727 | { |
728 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
728 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
729 | 729 | |
730 | 730 | $this->use_curl = $useCurlMode; |
731 | 731 | return $this; |
@@ -742,7 +742,7 @@ discard block |
||
742 | 742 | */ |
743 | 743 | public function setUserAgent($agentString) |
744 | 744 | { |
745 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
745 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
746 | 746 | |
747 | 747 | $this->user_agent = $agentString; |
748 | 748 | return $this; |
@@ -774,12 +774,12 @@ discard block |
||
774 | 774 | } |
775 | 775 | } |
776 | 776 | |
777 | - $url = $this->method . '://' . $this->server; |
|
777 | + $url = $this->method.'://'.$this->server; |
|
778 | 778 | if ($this->port == 0 || ($this->port == 80 && in_array($this->method, array('http', 'http10', 'http11', 'h2c'))) || |
779 | 779 | ($this->port == 443 && in_array($this->method, array('https', 'h2')))) { |
780 | - return $url . $this->path; |
|
780 | + return $url.$this->path; |
|
781 | 781 | } else { |
782 | - return $url . ':' . $this->port . $this->path; |
|
782 | + return $url.':'.$this->port.$this->path; |
|
783 | 783 | } |
784 | 784 | } |
785 | 785 | |
@@ -822,7 +822,7 @@ discard block |
||
822 | 822 | public function send($req, $timeout = 0, $method = '') |
823 | 823 | { |
824 | 824 | if ($method !== '' || $timeout !== 0) { |
825 | - $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated'); |
|
825 | + $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method ".__METHOD__.' is deprecated'); |
|
826 | 826 | } |
827 | 827 | |
828 | 828 | // if user does not specify http protocol, use native method of this client |
@@ -946,7 +946,7 @@ discard block |
||
946 | 946 | $payload = $a; |
947 | 947 | $encodingHdr = "Content-Encoding: gzip\r\n"; |
948 | 948 | } else { |
949 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request'); |
|
949 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request'); |
|
950 | 950 | } |
951 | 951 | } else if (function_exists('gzcompress')) { |
952 | 952 | $a = @gzcompress($payload); |
@@ -954,14 +954,14 @@ discard block |
||
954 | 954 | $payload = $a; |
955 | 955 | $encodingHdr = "Content-Encoding: deflate\r\n"; |
956 | 956 | } else { |
957 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request'); |
|
957 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request'); |
|
958 | 958 | } |
959 | 959 | } else { |
960 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install'); |
|
960 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install'); |
|
961 | 961 | } |
962 | 962 | } else { |
963 | 963 | if ($opts['request_compression'] != '') { |
964 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported'); |
|
964 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported'); |
|
965 | 965 | } |
966 | 966 | } |
967 | 967 | |
@@ -969,16 +969,16 @@ discard block |
||
969 | 969 | $credentials = ''; |
970 | 970 | if ($opts['username'] != '') { |
971 | 971 | if ($opts['authtype'] != 1) { |
972 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0'); |
|
972 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0'); |
|
973 | 973 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
974 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth is supported with HTTP 1.0'); |
|
974 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth is supported with HTTP 1.0'); |
|
975 | 975 | } |
976 | - $credentials = 'Authorization: Basic ' . base64_encode($opts['username'] . ':' . $opts['password']) . "\r\n"; |
|
976 | + $credentials = 'Authorization: Basic '.base64_encode($opts['username'].':'.$opts['password'])."\r\n"; |
|
977 | 977 | } |
978 | 978 | |
979 | 979 | $acceptedEncoding = ''; |
980 | 980 | if (is_array($opts['accepted_compression']) && count($opts['accepted_compression'])) { |
981 | - $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $opts['accepted_compression']) . "\r\n"; |
|
981 | + $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $opts['accepted_compression'])."\r\n"; |
|
982 | 982 | } |
983 | 983 | |
984 | 984 | if ($port == 0) { |
@@ -999,21 +999,21 @@ discard block |
||
999 | 999 | } elseif ($method === 'h2') { |
1000 | 1000 | $protocol = 'https'; |
1001 | 1001 | } else if (strpos($protocol, ':') !== false) { |
1002 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The protocol requested for the call is: '$protocol'"); |
|
1003 | - return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], PhpXmlRpc::$xmlrpcerr['unsupported_option'] . |
|
1002 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The protocol requested for the call is: '$protocol'"); |
|
1003 | + return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], PhpXmlRpc::$xmlrpcerr['unsupported_option']. |
|
1004 | 1004 | " attempted hacking attempt?. The protocol requested for the call is: '$protocol'"); |
1005 | 1005 | } |
1006 | 1006 | /// @todo this does not work atm (tested at least with an http proxy forwarding to an https server) - we |
1007 | 1007 | /// should implement the CONNECT protocol |
1008 | - $uri = $protocol . '://' . $server . ':' . $port . $path; |
|
1008 | + $uri = $protocol.'://'.$server.':'.$port.$path; |
|
1009 | 1009 | if ($opts['proxy_user'] != '') { |
1010 | 1010 | if ($opts['proxy_authtype'] != 1) { |
1011 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0'); |
|
1011 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0'); |
|
1012 | 1012 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1013 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth to proxy is supported with socket transport'); |
|
1013 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth to proxy is supported with socket transport'); |
|
1014 | 1014 | } |
1015 | - $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($opts['proxy_user'] . ':' . |
|
1016 | - $opts['proxy_pass']) . "\r\n"; |
|
1015 | + $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($opts['proxy_user'].':'. |
|
1016 | + $opts['proxy_pass'])."\r\n"; |
|
1017 | 1017 | } |
1018 | 1018 | } else { |
1019 | 1019 | $connectServer = $server; |
@@ -1030,14 +1030,14 @@ discard block |
||
1030 | 1030 | $version = ''; |
1031 | 1031 | foreach ($opts['cookies'] as $name => $cookie) { |
1032 | 1032 | /// @todo should we sanitize the cookie value on behalf of the user? See setCookie comments |
1033 | - $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";"; |
|
1033 | + $cookieHeader .= ' '.$name.'='.$cookie['value'].";"; |
|
1034 | 1034 | } |
1035 | - $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n"; |
|
1035 | + $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n"; |
|
1036 | 1036 | } |
1037 | 1037 | |
1038 | 1038 | $extraHeaders = ''; |
1039 | 1039 | if (is_array($this->extra_headers) && $this->extra_headers) { |
1040 | - $extraHeaders = implode("\r\n", $this->extra_headers) . "\r\n"; |
|
1040 | + $extraHeaders = implode("\r\n", $this->extra_headers)."\r\n"; |
|
1041 | 1041 | } |
1042 | 1042 | |
1043 | 1043 | // omit port if default |
@@ -1045,24 +1045,24 @@ discard block |
||
1045 | 1045 | if (($port == 80 && in_array($method, array('http', 'http10', 'http11'))) || ($port == 443 && $method == 'https')) { |
1046 | 1046 | $port = ''; |
1047 | 1047 | } else { |
1048 | - $port = ':' . $port; |
|
1049 | - } |
|
1050 | - |
|
1051 | - $op = 'POST ' . $uri . " HTTP/1.0\r\n" . |
|
1052 | - 'User-Agent: ' . $opts['user_agent'] . "\r\n" . |
|
1053 | - 'Host: ' . $server . $port . "\r\n" . |
|
1054 | - $credentials . |
|
1055 | - $proxyCredentials . |
|
1056 | - $acceptedEncoding . |
|
1057 | - $encodingHdr . |
|
1058 | - 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']) . "\r\n" . |
|
1059 | - $cookieHeader . |
|
1060 | - 'Content-Type: ' . $req->getContentType() . "\r\n" . |
|
1061 | - $extraHeaders . |
|
1062 | - 'Content-Length: ' . strlen($payload) . "\r\n\r\n" . |
|
1048 | + $port = ':'.$port; |
|
1049 | + } |
|
1050 | + |
|
1051 | + $op = 'POST '.$uri." HTTP/1.0\r\n". |
|
1052 | + 'User-Agent: '.$opts['user_agent']."\r\n". |
|
1053 | + 'Host: '.$server.$port."\r\n". |
|
1054 | + $credentials. |
|
1055 | + $proxyCredentials. |
|
1056 | + $acceptedEncoding. |
|
1057 | + $encodingHdr. |
|
1058 | + 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])."\r\n". |
|
1059 | + $cookieHeader. |
|
1060 | + 'Content-Type: '.$req->getContentType()."\r\n". |
|
1061 | + $extraHeaders. |
|
1062 | + 'Content-Length: '.strlen($payload)."\r\n\r\n". |
|
1063 | 1063 | $payload; |
1064 | 1064 | |
1065 | - if ($opts['debug'] > 1) { |
|
1065 | + if ($opts['debug']>1) { |
|
1066 | 1066 | $this->getLogger()->debug("---SENDING---\n$op\n---END---"); |
1067 | 1067 | } |
1068 | 1068 | |
@@ -1091,13 +1091,13 @@ discard block |
||
1091 | 1091 | /// https://www.php.net/manual/en/function.stream-socket-enable-crypto.php |
1092 | 1092 | /// https://www.php.net/manual/en/migration56.openssl.php, |
1093 | 1093 | /// https://wiki.php.net/rfc/improved-tls-constants |
1094 | - switch($opts['sslversion']) { |
|
1094 | + switch ($opts['sslversion']) { |
|
1095 | 1095 | case 1: // TLSv1x |
1096 | 1096 | if (version_compare(PHP_VERSION, '7.2.0', '>=')) { |
1097 | 1097 | $contextOptions['ssl']['crypto_method'] = STREAM_CRYPTO_METHOD_TLS_CLIENT; |
1098 | 1098 | } else { |
1099 | 1099 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1100 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': TLS-any only is supported with PHP 7.2 or later'); |
|
1100 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': TLS-any only is supported with PHP 7.2 or later'); |
|
1101 | 1101 | } |
1102 | 1102 | break; |
1103 | 1103 | case 2: // SSLv2 |
@@ -1120,12 +1120,12 @@ discard block |
||
1120 | 1120 | $contextOptions['ssl']['crypto_method'] = STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT; |
1121 | 1121 | } else { |
1122 | 1122 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1123 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': TLS-1.3 only is supported with PHP 7.4 or later'); |
|
1123 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': TLS-1.3 only is supported with PHP 7.4 or later'); |
|
1124 | 1124 | } |
1125 | 1125 | break; |
1126 | 1126 | default: |
1127 | 1127 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1128 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': Unsupported required TLS version'); |
|
1128 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': Unsupported required TLS version'); |
|
1129 | 1129 | } |
1130 | 1130 | } |
1131 | 1131 | } |
@@ -1138,7 +1138,7 @@ discard block |
||
1138 | 1138 | |
1139 | 1139 | $context = stream_context_create($contextOptions); |
1140 | 1140 | |
1141 | - if ($opts['timeout'] <= 0) { |
|
1141 | + if ($opts['timeout']<=0) { |
|
1142 | 1142 | $connectTimeout = ini_get('default_socket_timeout'); |
1143 | 1143 | } else { |
1144 | 1144 | $connectTimeout = $opts['timeout']; |
@@ -1157,7 +1157,7 @@ discard block |
||
1157 | 1157 | $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout, |
1158 | 1158 | STREAM_CLIENT_CONNECT, $context); |
1159 | 1159 | if ($fp) { |
1160 | - if ($opts['timeout'] > 0) { |
|
1160 | + if ($opts['timeout']>0) { |
|
1161 | 1161 | stream_set_timeout($fp, $opts['timeout'], 0); |
1162 | 1162 | } |
1163 | 1163 | } else { |
@@ -1166,8 +1166,8 @@ discard block |
||
1166 | 1166 | $this->errstr = $err['message']; |
1167 | 1167 | } |
1168 | 1168 | |
1169 | - $this->errstr = 'Connect error: ' . $this->errstr; |
|
1170 | - return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')'); |
|
1169 | + $this->errstr = 'Connect error: '.$this->errstr; |
|
1170 | + return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')'); |
|
1171 | 1171 | } |
1172 | 1172 | |
1173 | 1173 | /// @todo from here onwards, we can inject the results of stream_get_meta_data in the response. We could |
@@ -1250,19 +1250,19 @@ discard block |
||
1250 | 1250 | $opts['keepalive'], $opts['key'], $opts['keypass'], $opts['sslversion']); |
1251 | 1251 | |
1252 | 1252 | if (!$curl) { |
1253 | - return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . |
|
1253 | + return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail']. |
|
1254 | 1254 | ': error during curl initialization. Check php error log for details'); |
1255 | 1255 | } |
1256 | 1256 | |
1257 | 1257 | $result = curl_exec($curl); |
1258 | 1258 | |
1259 | - if ($opts['debug'] > 1) { |
|
1259 | + if ($opts['debug']>1) { |
|
1260 | 1260 | $message = "---CURL INFO---\n"; |
1261 | 1261 | foreach (curl_getinfo($curl) as $name => $val) { |
1262 | 1262 | if (is_array($val)) { |
1263 | 1263 | $val = implode("\n", $val); |
1264 | 1264 | } |
1265 | - $message .= $name . ': ' . $val . "\n"; |
|
1265 | + $message .= $name.': '.$val."\n"; |
|
1266 | 1266 | } |
1267 | 1267 | $message .= '---END---'; |
1268 | 1268 | $this->getLogger()->debug($message); |
@@ -1272,8 +1272,8 @@ discard block |
||
1272 | 1272 | /// @todo we should use a better check here - what if we get back '' or '0'? |
1273 | 1273 | |
1274 | 1274 | $this->errstr = 'no response'; |
1275 | - $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . |
|
1276 | - ': ' . curl_error($curl)); |
|
1275 | + $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail']. |
|
1276 | + ': '.curl_error($curl)); |
|
1277 | 1277 | curl_close($curl); |
1278 | 1278 | if ($opts['keepalive']) { |
1279 | 1279 | $this->xmlrpc_curl_handle = null; |
@@ -1331,7 +1331,7 @@ discard block |
||
1331 | 1331 | $payload = $a; |
1332 | 1332 | $encodingHdr = 'Content-Encoding: gzip'; |
1333 | 1333 | } else { |
1334 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request'); |
|
1334 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request'); |
|
1335 | 1335 | } |
1336 | 1336 | } else if (function_exists('gzcompress')) { |
1337 | 1337 | $a = @gzcompress($payload); |
@@ -1339,14 +1339,14 @@ discard block |
||
1339 | 1339 | $payload = $a; |
1340 | 1340 | $encodingHdr = 'Content-Encoding: deflate'; |
1341 | 1341 | } else { |
1342 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request'); |
|
1342 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request'); |
|
1343 | 1343 | } |
1344 | 1344 | } else { |
1345 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install'); |
|
1345 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install'); |
|
1346 | 1346 | } |
1347 | 1347 | } else { |
1348 | 1348 | if ($opts['request_compression'] != '') { |
1349 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported'); |
|
1349 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported'); |
|
1350 | 1350 | } |
1351 | 1351 | } |
1352 | 1352 | |
@@ -1360,12 +1360,12 @@ discard block |
||
1360 | 1360 | // http, https |
1361 | 1361 | $protocol = $method; |
1362 | 1362 | if (strpos($protocol, ':') !== false) { |
1363 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'"); |
|
1363 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'"); |
|
1364 | 1364 | return false; |
1365 | 1365 | } |
1366 | 1366 | } |
1367 | 1367 | } |
1368 | - $curl = curl_init($protocol . '://' . $server . ':' . $port . $path); |
|
1368 | + $curl = curl_init($protocol.'://'.$server.':'.$port.$path); |
|
1369 | 1369 | if (!$curl) { |
1370 | 1370 | return false; |
1371 | 1371 | } |
@@ -1379,7 +1379,7 @@ discard block |
||
1379 | 1379 | // results into variable |
1380 | 1380 | curl_setopt($curl, CURLOPT_RETURNTRANSFER, true); |
1381 | 1381 | |
1382 | - if ($opts['debug'] > 1) { |
|
1382 | + if ($opts['debug']>1) { |
|
1383 | 1383 | curl_setopt($curl, CURLOPT_VERBOSE, true); |
1384 | 1384 | /// @todo redirect curlopt_stderr to some stream which can be piped to the logger |
1385 | 1385 | } |
@@ -1404,7 +1404,7 @@ discard block |
||
1404 | 1404 | } |
1405 | 1405 | } |
1406 | 1406 | // extra headers |
1407 | - $headers = array('Content-Type: ' . $req->getContentType(), 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings'])); |
|
1407 | + $headers = array('Content-Type: '.$req->getContentType(), 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])); |
|
1408 | 1408 | // if no keepalive is wanted, let the server know it in advance |
1409 | 1409 | if (!$opts['keepalive']) { |
1410 | 1410 | $headers[] = 'Connection: close'; |
@@ -1441,7 +1441,7 @@ discard block |
||
1441 | 1441 | if (defined('CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE')) { |
1442 | 1442 | curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE); |
1443 | 1443 | } else { |
1444 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install'); |
|
1444 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install'); |
|
1445 | 1445 | curl_close($curl); |
1446 | 1446 | return false; |
1447 | 1447 | } |
@@ -1452,11 +1452,11 @@ discard block |
||
1452 | 1452 | } |
1453 | 1453 | |
1454 | 1454 | if ($opts['username'] && $opts['password']) { |
1455 | - curl_setopt($curl, CURLOPT_USERPWD, $opts['username'] . ':' . $opts['password']); |
|
1455 | + curl_setopt($curl, CURLOPT_USERPWD, $opts['username'].':'.$opts['password']); |
|
1456 | 1456 | if (defined('CURLOPT_HTTPAUTH')) { |
1457 | 1457 | curl_setopt($curl, CURLOPT_HTTPAUTH, $opts['authtype']); |
1458 | 1458 | } elseif ($opts['authtype'] != 1) { |
1459 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install'); |
|
1459 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install'); |
|
1460 | 1460 | curl_close($curl); |
1461 | 1461 | return false; |
1462 | 1462 | } |
@@ -1501,13 +1501,13 @@ discard block |
||
1501 | 1501 | if ($opts['proxyport'] == 0) { |
1502 | 1502 | $opts['proxyport'] = 8080; // NB: even for HTTPS, local connection is on port 8080 |
1503 | 1503 | } |
1504 | - curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'] . ':' . $opts['proxyport']); |
|
1504 | + curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'].':'.$opts['proxyport']); |
|
1505 | 1505 | if ($opts['proxy_user']) { |
1506 | - curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'] . ':' . $opts['proxy_pass']); |
|
1506 | + curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'].':'.$opts['proxy_pass']); |
|
1507 | 1507 | if (defined('CURLOPT_PROXYAUTH')) { |
1508 | 1508 | curl_setopt($curl, CURLOPT_PROXYAUTH, $opts['proxy_authtype']); |
1509 | 1509 | } elseif ($opts['proxy_authtype'] != 1) { |
1510 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install'); |
|
1510 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install'); |
|
1511 | 1511 | curl_close($curl); |
1512 | 1512 | return false; |
1513 | 1513 | } |
@@ -1519,7 +1519,7 @@ discard block |
||
1519 | 1519 | if (count($opts['cookies'])) { |
1520 | 1520 | $cookieHeader = ''; |
1521 | 1521 | foreach ($opts['cookies'] as $name => $cookie) { |
1522 | - $cookieHeader .= $name . '=' . $cookie['value'] . '; '; |
|
1522 | + $cookieHeader .= $name.'='.$cookie['value'].'; '; |
|
1523 | 1523 | } |
1524 | 1524 | curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2)); |
1525 | 1525 | } |
@@ -1528,7 +1528,7 @@ discard block |
||
1528 | 1528 | curl_setopt($curl, $opt, $val); |
1529 | 1529 | } |
1530 | 1530 | |
1531 | - if ($opts['debug'] > 1) { |
|
1531 | + if ($opts['debug']>1) { |
|
1532 | 1532 | $this->getLogger()->debug("---SENDING---\n$payload\n---END---"); |
1533 | 1533 | } |
1534 | 1534 | |
@@ -1629,7 +1629,7 @@ discard block |
||
1629 | 1629 | $call['methodName'] = new Value($req->method(), 'string'); |
1630 | 1630 | $numParams = $req->getNumParams(); |
1631 | 1631 | $params = array(); |
1632 | - for ($i = 0; $i < $numParams; $i++) { |
|
1632 | + for ($i = 0; $i<$numParams; $i++) { |
|
1633 | 1633 | $params[$i] = $req->getParam($i); |
1634 | 1634 | } |
1635 | 1635 | $call['params'] = new Value($params, 'array'); |
@@ -1651,7 +1651,7 @@ discard block |
||
1651 | 1651 | $response = array(); |
1652 | 1652 | |
1653 | 1653 | if ($this->return_type == 'xml') { |
1654 | - for ($i = 0; $i < count($reqs); $i++) { |
|
1654 | + for ($i = 0; $i<count($reqs); $i++) { |
|
1655 | 1655 | $response[] = new static::$responseClass($rets, 0, '', 'xml', $result->httpResponse()); |
1656 | 1656 | } |
1657 | 1657 | |
@@ -1659,21 +1659,21 @@ discard block |
||
1659 | 1659 | if (!is_array($rets)) { |
1660 | 1660 | // bad return type from system.multicall |
1661 | 1661 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1662 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse()); |
|
1662 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse()); |
|
1663 | 1663 | } |
1664 | 1664 | $numRets = count($rets); |
1665 | 1665 | if ($numRets != count($reqs)) { |
1666 | 1666 | // wrong number of return values. |
1667 | 1667 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1668 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals', |
|
1668 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals', |
|
1669 | 1669 | $result->httpResponse()); |
1670 | 1670 | } |
1671 | 1671 | |
1672 | - for ($i = 0; $i < $numRets; $i++) { |
|
1672 | + for ($i = 0; $i<$numRets; $i++) { |
|
1673 | 1673 | $val = $rets[$i]; |
1674 | 1674 | if (!is_array($val)) { |
1675 | 1675 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1676 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct", |
|
1676 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct", |
|
1677 | 1677 | 'phpvals', $result->httpResponse()); |
1678 | 1678 | } |
1679 | 1679 | switch (count($val)) { |
@@ -1681,7 +1681,7 @@ discard block |
||
1681 | 1681 | if (!isset($val[0])) { |
1682 | 1682 | // Bad value |
1683 | 1683 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1684 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value", |
|
1684 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value", |
|
1685 | 1685 | 'phpvals', $result->httpResponse()); |
1686 | 1686 | } |
1687 | 1687 | // Normal return value |
@@ -1693,20 +1693,20 @@ discard block |
||
1693 | 1693 | if (!is_int($code)) { |
1694 | 1694 | /// @todo should we check that it is != 0? |
1695 | 1695 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1696 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1696 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1697 | 1697 | 'phpvals', $result->httpResponse()); |
1698 | 1698 | } |
1699 | 1699 | $str = @$val['faultString']; |
1700 | 1700 | if (!is_string($str)) { |
1701 | 1701 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1702 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString", |
|
1702 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString", |
|
1703 | 1703 | 'phpvals', $result->httpResponse()); |
1704 | 1704 | } |
1705 | 1705 | $response[$i] = new static::$responseClass(0, $code, $str, 'phpvals', $result->httpResponse()); |
1706 | 1706 | break; |
1707 | 1707 | default: |
1708 | 1708 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1709 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1709 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1710 | 1710 | 'phpvals', $result->httpResponse()); |
1711 | 1711 | } |
1712 | 1712 | } |
@@ -1715,14 +1715,14 @@ discard block |
||
1715 | 1715 | // return type == 'xmlrpcvals' |
1716 | 1716 | if ($rets->kindOf() != 'array') { |
1717 | 1717 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1718 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals', |
|
1718 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals', |
|
1719 | 1719 | $result->httpResponse()); |
1720 | 1720 | } |
1721 | 1721 | $numRets = $rets->count(); |
1722 | 1722 | if ($numRets != count($reqs)) { |
1723 | 1723 | // wrong number of return values. |
1724 | 1724 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1725 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals', |
|
1725 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals', |
|
1726 | 1726 | $result->httpResponse()); |
1727 | 1727 | } |
1728 | 1728 | |
@@ -1731,7 +1731,7 @@ discard block |
||
1731 | 1731 | case 'array': |
1732 | 1732 | if ($val->count() != 1) { |
1733 | 1733 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1734 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1734 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1735 | 1735 | 'phpvals', $result->httpResponse()); |
1736 | 1736 | } |
1737 | 1737 | // Normal return value |
@@ -1740,28 +1740,28 @@ discard block |
||
1740 | 1740 | case 'struct': |
1741 | 1741 | if ($val->count() != 2) { |
1742 | 1742 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1743 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1743 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1744 | 1744 | 'phpvals', $result->httpResponse()); |
1745 | 1745 | } |
1746 | 1746 | /** @var Value $code */ |
1747 | 1747 | $code = $val['faultCode']; |
1748 | 1748 | if ($code->kindOf() != 'scalar' || $code->scalarTyp() != 'int') { |
1749 | 1749 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1750 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1750 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1751 | 1751 | 'xmlrpcvals', $result->httpResponse()); |
1752 | 1752 | } |
1753 | 1753 | /** @var Value $str */ |
1754 | 1754 | $str = $val['faultString']; |
1755 | 1755 | if ($str->kindOf() != 'scalar' || $str->scalarTyp() != 'string') { |
1756 | 1756 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1757 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1757 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1758 | 1758 | 'xmlrpcvals', $result->httpResponse()); |
1759 | 1759 | } |
1760 | 1760 | $response[] = new static::$responseClass(0, $code->scalarVal(), $str->scalarVal(), 'xmlrpcvals', $result->httpResponse()); |
1761 | 1761 | break; |
1762 | 1762 | default: |
1763 | 1763 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1764 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct", |
|
1764 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct", |
|
1765 | 1765 | 'xmlrpcvals', $result->httpResponse()); |
1766 | 1766 | } |
1767 | 1767 | } |
@@ -1796,7 +1796,7 @@ discard block |
||
1796 | 1796 | $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, |
1797 | 1797 | $method = 'http') |
1798 | 1798 | { |
1799 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1799 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1800 | 1800 | |
1801 | 1801 | return $this->sendPayloadSocket($req, $server, $port, $timeout, $username, $password, $authType, null, null, |
1802 | 1802 | null, null, $proxyHost, $proxyPort, $proxyUsername, $proxyPassword, $proxyAuthType, $method); |
@@ -1834,7 +1834,7 @@ discard block |
||
1834 | 1834 | $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '', |
1835 | 1835 | $sslVersion = 0) |
1836 | 1836 | { |
1837 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1837 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1838 | 1838 | |
1839 | 1839 | return $this->sendPayloadCURL($req, $server, $port, $timeout, $username, |
1840 | 1840 | $password, $authType, $cert, $certPass, $caCert, $caCertDir, $proxyHost, $proxyPort, |
@@ -2047,7 +2047,7 @@ discard block |
||
2047 | 2047 | public function &__get($name) |
2048 | 2048 | { |
2049 | 2049 | if (in_array($name, static::$options)) { |
2050 | - $this->logDeprecation('Getting property Client::' . $name . ' is deprecated'); |
|
2050 | + $this->logDeprecation('Getting property Client::'.$name.' is deprecated'); |
|
2051 | 2051 | return $this->$name; |
2052 | 2052 | } |
2053 | 2053 | |
@@ -2058,12 +2058,12 @@ discard block |
||
2058 | 2058 | case 'server': |
2059 | 2059 | case 'port': |
2060 | 2060 | case 'path': |
2061 | - $this->logDeprecation('Getting property Client::' . $name . ' is deprecated'); |
|
2061 | + $this->logDeprecation('Getting property Client::'.$name.' is deprecated'); |
|
2062 | 2062 | return $this->$name; |
2063 | 2063 | default: |
2064 | 2064 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2065 | 2065 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2066 | - trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2066 | + trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2067 | 2067 | $result = null; |
2068 | 2068 | return $result; |
2069 | 2069 | } |
@@ -2072,7 +2072,7 @@ discard block |
||
2072 | 2072 | public function __set($name, $value) |
2073 | 2073 | { |
2074 | 2074 | if (in_array($name, static::$options)) { |
2075 | - $this->logDeprecation('Setting property Client::' . $name . ' is deprecated'); |
|
2075 | + $this->logDeprecation('Setting property Client::'.$name.' is deprecated'); |
|
2076 | 2076 | $this->$name = $value; |
2077 | 2077 | return; |
2078 | 2078 | } |
@@ -2084,20 +2084,20 @@ discard block |
||
2084 | 2084 | case 'server': |
2085 | 2085 | case 'port': |
2086 | 2086 | case 'path': |
2087 | - $this->logDeprecation('Setting property Client::' . $name . ' is deprecated'); |
|
2087 | + $this->logDeprecation('Setting property Client::'.$name.' is deprecated'); |
|
2088 | 2088 | $this->$name = $value; |
2089 | 2089 | return; |
2090 | 2090 | default: |
2091 | 2091 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2092 | 2092 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2093 | - trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2093 | + trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2094 | 2094 | } |
2095 | 2095 | } |
2096 | 2096 | |
2097 | 2097 | public function __isset($name) |
2098 | 2098 | { |
2099 | 2099 | if (in_array($name, static::$options)) { |
2100 | - $this->logDeprecation('Checking property Client::' . $name . ' is deprecated'); |
|
2100 | + $this->logDeprecation('Checking property Client::'.$name.' is deprecated'); |
|
2101 | 2101 | return isset($this->$name); |
2102 | 2102 | } |
2103 | 2103 | |
@@ -2108,7 +2108,7 @@ discard block |
||
2108 | 2108 | case 'server': |
2109 | 2109 | case 'port': |
2110 | 2110 | case 'path': |
2111 | - $this->logDeprecation('Checking property Client::' . $name . ' is deprecated'); |
|
2111 | + $this->logDeprecation('Checking property Client::'.$name.' is deprecated'); |
|
2112 | 2112 | return isset($this->$name); |
2113 | 2113 | default: |
2114 | 2114 | return false; |
@@ -2118,7 +2118,7 @@ discard block |
||
2118 | 2118 | public function __unset($name) |
2119 | 2119 | { |
2120 | 2120 | if (in_array($name, static::$options)) { |
2121 | - $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated'); |
|
2121 | + $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated'); |
|
2122 | 2122 | unset($this->$name); |
2123 | 2123 | return; |
2124 | 2124 | } |
@@ -2130,13 +2130,13 @@ discard block |
||
2130 | 2130 | case 'server': |
2131 | 2131 | case 'port': |
2132 | 2132 | case 'path': |
2133 | - $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated'); |
|
2133 | + $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated'); |
|
2134 | 2134 | unset($this->$name); |
2135 | 2135 | return; |
2136 | 2136 | default: |
2137 | 2137 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2138 | 2138 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2139 | - trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2139 | + trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2140 | 2140 | } |
2141 | 2141 | } |
2142 | 2142 | } |