Passed
Push — master ( 3f1754...6a5d35 )
by Gaetano
07:05
created
src/Client.php 1 patch
Spacing   +105 added lines, -105 removed lines patch added patch discarded remove patch
@@ -335,10 +335,10 @@  discard block
 block discarded – undo
335 335
             $server = $parts['host'];
336 336
             $path = isset($parts['path']) ? $parts['path'] : '';
337 337
             if (isset($parts['query'])) {
338
-                $path .= '?' . $parts['query'];
338
+                $path .= '?'.$parts['query'];
339 339
             }
340 340
             if (isset($parts['fragment'])) {
341
-                $path .= '#' . $parts['fragment'];
341
+                $path .= '#'.$parts['fragment'];
342 342
             }
343 343
             if (isset($parts['port'])) {
344 344
                 $port = $parts['port'];
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
             }
355 355
         }
356 356
         if ($path == '' || $path[0] != '/') {
357
-            $this->path = '/' . $path;
357
+            $this->path = '/'.$path;
358 358
         } else {
359 359
             $this->path = $path;
360 360
         }
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
         //$this->accepted_charset_encodings = $ch->knownCharsets();
387 387
 
388 388
         // initialize user_agent string
389
-        $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion;
389
+        $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion;
390 390
     }
391 391
 
392 392
     /**
@@ -558,7 +558,7 @@  discard block
 block discarded – undo
558 558
      */
559 559
     public function setSSLVerifyPeer($i)
560 560
     {
561
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
561
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
562 562
 
563 563
         $this->verifypeer = $i;
564 564
         return $this;
@@ -575,7 +575,7 @@  discard block
 block discarded – undo
575 575
      */
576 576
     public function setSSLVerifyHost($i)
577 577
     {
578
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
578
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
579 579
 
580 580
         $this->verifyhost = $i;
581 581
         return $this;
@@ -590,7 +590,7 @@  discard block
 block discarded – undo
590 590
      */
591 591
     public function setSSLVersion($i)
592 592
     {
593
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
593
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
594 594
 
595 595
         $this->sslversion = $i;
596 596
         return $this;
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
      */
656 656
     public function setRequestCompression($compMethod)
657 657
     {
658
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
658
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
659 659
 
660 660
         $this->request_compression = $compMethod;
661 661
         return $this;
@@ -705,7 +705,7 @@  discard block
 block discarded – undo
705 705
      */
706 706
     public function setCurlOptions($options)
707 707
     {
708
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
708
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
709 709
 
710 710
         $this->extracurlopts = $options;
711 711
         return $this;
@@ -718,7 +718,7 @@  discard block
 block discarded – undo
718 718
      */
719 719
     public function setUseCurl($useCurlMode)
720 720
     {
721
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
721
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
722 722
 
723 723
         $this->use_curl = $useCurlMode;
724 724
         return $this;
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
      */
737 737
     public function setUserAgent($agentString)
738 738
     {
739
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
739
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
740 740
 
741 741
         $this->user_agent = $agentString;
742 742
         return $this;
@@ -767,12 +767,12 @@  discard block
 block discarded – undo
767 767
             }
768 768
         }
769 769
 
770
-        $url = $this->method . '://' . $this->server;
770
+        $url = $this->method.'://'.$this->server;
771 771
         if ($this->port == 0 || ($this->port == 80 && in_array($this->method, array('http', 'http10', 'http11', 'h2c'))) ||
772 772
             ($this->port == 443 && in_array($this->method, array('https', 'h2')))) {
773
-            return $url . $this->path;
773
+            return $url.$this->path;
774 774
         } else {
775
-            return $url . ':' . $this->port . $this->path;
775
+            return $url.':'.$this->port.$this->path;
776 776
         }
777 777
     }
778 778
 
@@ -812,7 +812,7 @@  discard block
 block discarded – undo
812 812
     public function send($req, $timeout = 0, $method = '')
813 813
     {
814 814
         if ($method !== '' || $timeout !== 0) {
815
-            $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated');
815
+            $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method ".__METHOD__.' is deprecated');
816 816
         }
817 817
 
818 818
         // if user does not specify http protocol, use native method of this client
@@ -931,7 +931,7 @@  discard block
 block discarded – undo
931 931
                     $payload = $a;
932 932
                     $encodingHdr = "Content-Encoding: gzip\r\n";
933 933
                 } else {
934
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request');
934
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request');
935 935
                 }
936 936
             } else if (function_exists('gzcompress')) {
937 937
                 $a = @gzcompress($payload);
@@ -939,14 +939,14 @@  discard block
 block discarded – undo
939 939
                     $payload = $a;
940 940
                     $encodingHdr = "Content-Encoding: deflate\r\n";
941 941
                 } else {
942
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request');
942
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request');
943 943
                 }
944 944
             } else {
945
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install');
945
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install');
946 946
             }
947 947
         } else {
948 948
             if ($opts['request_compression'] != '') {
949
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported');
949
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported');
950 950
             }
951 951
         }
952 952
 
@@ -954,16 +954,16 @@  discard block
 block discarded – undo
954 954
         $credentials = '';
955 955
         if ($opts['username'] != '') {
956 956
             if ($opts['authtype'] != 1) {
957
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0');
957
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0');
958 958
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
959
-                    PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth is supported with HTTP 1.0');
959
+                    PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth is supported with HTTP 1.0');
960 960
             }
961
-            $credentials = 'Authorization: Basic ' . base64_encode($opts['username'] . ':' . $opts['password']) . "\r\n";
961
+            $credentials = 'Authorization: Basic '.base64_encode($opts['username'].':'.$opts['password'])."\r\n";
962 962
         }
963 963
 
964 964
         $acceptedEncoding = '';
965 965
         if (is_array($opts['accepted_compression']) && count($opts['accepted_compression'])) {
966
-            $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $opts['accepted_compression']) . "\r\n";
966
+            $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $opts['accepted_compression'])."\r\n";
967 967
         }
968 968
 
969 969
         if ($port == 0) {
@@ -979,15 +979,15 @@  discard block
 block discarded – undo
979 979
             $connectPort = $opts['proxyport'];
980 980
             $transport = 'tcp';
981 981
             /// @todo check: should we not use https in some cases?
982
-            $uri = 'http://' . $server . ':' . $port . $path;
982
+            $uri = 'http://'.$server.':'.$port.$path;
983 983
             if ($opts['proxy_user'] != '') {
984 984
                 if ($opts['proxy_authtype'] != 1) {
985
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0');
985
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0');
986 986
                     return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
987
-                        PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth to proxy is supported with HTTP 1.0');
987
+                        PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth to proxy is supported with HTTP 1.0');
988 988
                 }
989
-                $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($opts['proxy_user'] . ':' .
990
-                    $opts['proxy_pass']) . "\r\n";
989
+                $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($opts['proxy_user'].':'.
990
+                    $opts['proxy_pass'])."\r\n";
991 991
             }
992 992
         } else {
993 993
             $connectServer = $server;
@@ -1003,38 +1003,38 @@  discard block
 block discarded – undo
1003 1003
             $version = '';
1004 1004
             foreach ($opts['cookies'] as $name => $cookie) {
1005 1005
                 /// @todo should we sanitize the cookie value on behalf of the user? See setCookie comments
1006
-                $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";";
1006
+                $cookieHeader .= ' '.$name.'='.$cookie['value'].";";
1007 1007
             }
1008
-            $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n";
1008
+            $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n";
1009 1009
         }
1010 1010
 
1011 1011
         $extraHeaders = '';
1012 1012
         if (is_array($this->extra_headers) && $this->extra_headers) {
1013
-            $extraHeaders = implode("\r\n", $this->extra_headers) . "\r\n";
1013
+            $extraHeaders = implode("\r\n", $this->extra_headers)."\r\n";
1014 1014
         }
1015 1015
 
1016 1016
         // omit port if default
1017 1017
         if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) {
1018 1018
             $port = '';
1019 1019
         } else {
1020
-            $port = ':' . $port;
1021
-        }
1022
-
1023
-        $op = 'POST ' . $uri . " HTTP/1.0\r\n" .
1024
-            'User-Agent: ' . $opts['user_agent'] . "\r\n" .
1025
-            'Host: ' . $server . $port . "\r\n" .
1026
-            $credentials .
1027
-            $proxyCredentials .
1028
-            $acceptedEncoding .
1029
-            $encodingHdr .
1030
-            'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']) . "\r\n" .
1031
-            $cookieHeader .
1032
-            'Content-Type: ' . $req->getContentType() . "\r\n" .
1033
-            $extraHeaders .
1034
-            'Content-Length: ' . strlen($payload) . "\r\n\r\n" .
1020
+            $port = ':'.$port;
1021
+        }
1022
+
1023
+        $op = 'POST '.$uri." HTTP/1.0\r\n".
1024
+            'User-Agent: '.$opts['user_agent']."\r\n".
1025
+            'Host: '.$server.$port."\r\n".
1026
+            $credentials.
1027
+            $proxyCredentials.
1028
+            $acceptedEncoding.
1029
+            $encodingHdr.
1030
+            'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])."\r\n".
1031
+            $cookieHeader.
1032
+            'Content-Type: '.$req->getContentType()."\r\n".
1033
+            $extraHeaders.
1034
+            'Content-Length: '.strlen($payload)."\r\n\r\n".
1035 1035
             $payload;
1036 1036
 
1037
-        if ($opts['debug'] > 1) {
1037
+        if ($opts['debug']>1) {
1038 1038
             $this->getLogger()->debug("---SENDING---\n$op\n---END---");
1039 1039
         }
1040 1040
 
@@ -1060,7 +1060,7 @@  discard block
 block discarded – undo
1060 1060
 
1061 1061
             if ($opts['sslversion'] != 0) {
1062 1062
                 /// @see https://www.php.net/manual/en/function.curl-setopt.php, https://www.php.net/manual/en/migration56.openssl.php
1063
-                switch($opts['sslversion']) {
1063
+                switch ($opts['sslversion']) {
1064 1064
                     /// @todo what does this map to? 1.0-1.3?
1065 1065
                     //case 1: // TLSv1
1066 1066
                     //    break;
@@ -1084,12 +1084,12 @@  discard block
 block discarded – undo
1084 1084
                             $contextOptions['ssl']['crypto_method'] = STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT;
1085 1085
                         } else {
1086 1086
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
1087
-                                PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': TLS-1.3 only is supported with PHP 7.4 or later');
1087
+                                PhpXmlRpc::$xmlrpcerr['unsupported_option'].': TLS-1.3 only is supported with PHP 7.4 or later');
1088 1088
                         }
1089 1089
                         break;
1090 1090
                     default:
1091 1091
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
1092
-                            PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': Unsupported required TLS version');
1092
+                            PhpXmlRpc::$xmlrpcerr['unsupported_option'].': Unsupported required TLS version');
1093 1093
                 }
1094 1094
             }
1095 1095
         }
@@ -1102,7 +1102,7 @@  discard block
 block discarded – undo
1102 1102
 
1103 1103
         $context = stream_context_create($contextOptions);
1104 1104
 
1105
-        if ($opts['timeout'] <= 0) {
1105
+        if ($opts['timeout']<=0) {
1106 1106
             $connectTimeout = ini_get('default_socket_timeout');
1107 1107
         } else {
1108 1108
             $connectTimeout = $opts['timeout'];
@@ -1114,7 +1114,7 @@  discard block
 block discarded – undo
1114 1114
         $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout,
1115 1115
             STREAM_CLIENT_CONNECT, $context);
1116 1116
         if ($fp) {
1117
-            if ($opts['timeout'] > 0) {
1117
+            if ($opts['timeout']>0) {
1118 1118
                 stream_set_timeout($fp, $opts['timeout'], 0);
1119 1119
             }
1120 1120
         } else {
@@ -1123,8 +1123,8 @@  discard block
 block discarded – undo
1123 1123
                 $this->errstr = $err['message'];
1124 1124
             }
1125 1125
 
1126
-            $this->errstr = 'Connect error: ' . $this->errstr;
1127
-            return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')');
1126
+            $this->errstr = 'Connect error: '.$this->errstr;
1127
+            return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')');
1128 1128
         }
1129 1129
 
1130 1130
         if (!fputs($fp, $op, strlen($op))) {
@@ -1204,19 +1204,19 @@  discard block
 block discarded – undo
1204 1204
             $opts['keepalive'], $opts['key'], $opts['keypass'], $opts['sslversion']);
1205 1205
 
1206 1206
         if (!$curl) {
1207
-            return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] .
1207
+            return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].
1208 1208
                 ': error during curl initialization. Check php error log for details');
1209 1209
         }
1210 1210
 
1211 1211
         $result = curl_exec($curl);
1212 1212
 
1213
-        if ($opts['debug'] > 1) {
1213
+        if ($opts['debug']>1) {
1214 1214
             $message = "---CURL INFO---\n";
1215 1215
             foreach (curl_getinfo($curl) as $name => $val) {
1216 1216
                 if (is_array($val)) {
1217 1217
                     $val = implode("\n", $val);
1218 1218
                 }
1219
-                $message .= $name . ': ' . $val . "\n";
1219
+                $message .= $name.': '.$val."\n";
1220 1220
             }
1221 1221
             $message .= '---END---';
1222 1222
             $this->getLogger()->debug($message);
@@ -1226,8 +1226,8 @@  discard block
 block discarded – undo
1226 1226
             /// @todo we should use a better check here - what if we get back '' or '0'?
1227 1227
 
1228 1228
             $this->errstr = 'no response';
1229
-            $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] .
1230
-                ': ' . curl_error($curl));
1229
+            $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].
1230
+                ': '.curl_error($curl));
1231 1231
             curl_close($curl);
1232 1232
             if ($opts['keepalive']) {
1233 1233
                 $this->xmlrpc_curl_handle = null;
@@ -1285,7 +1285,7 @@  discard block
 block discarded – undo
1285 1285
                     $payload = $a;
1286 1286
                     $encodingHdr = 'Content-Encoding: gzip';
1287 1287
                 } else {
1288
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request');
1288
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request');
1289 1289
                 }
1290 1290
             } else if (function_exists('gzcompress')) {
1291 1291
                 $a = @gzcompress($payload);
@@ -1293,14 +1293,14 @@  discard block
 block discarded – undo
1293 1293
                     $payload = $a;
1294 1294
                     $encodingHdr = 'Content-Encoding: deflate';
1295 1295
                 } else {
1296
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request');
1296
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request');
1297 1297
                 }
1298 1298
             } else {
1299
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install');
1299
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install');
1300 1300
             }
1301 1301
         } else {
1302 1302
             if ($opts['request_compression'] != '') {
1303
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported');
1303
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported');
1304 1304
             }
1305 1305
         }
1306 1306
 
@@ -1314,12 +1314,12 @@  discard block
 block discarded – undo
1314 1314
                     // http, https
1315 1315
                     $protocol = $method;
1316 1316
                     if (strpos($protocol, ':') !== false) {
1317
-                        $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1317
+                        $this->getLogger()->error('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1318 1318
                         return false;
1319 1319
                     }
1320 1320
                 }
1321 1321
             }
1322
-            $curl = curl_init($protocol . '://' . $server . ':' . $port . $path);
1322
+            $curl = curl_init($protocol.'://'.$server.':'.$port.$path);
1323 1323
             if (!$curl) {
1324 1324
                 return false;
1325 1325
             }
@@ -1333,7 +1333,7 @@  discard block
 block discarded – undo
1333 1333
         // results into variable
1334 1334
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
1335 1335
 
1336
-        if ($opts['debug'] > 1) {
1336
+        if ($opts['debug']>1) {
1337 1337
             curl_setopt($curl, CURLOPT_VERBOSE, true);
1338 1338
             /// @todo redirect curlopt_stderr to some stream which can be piped to the logger
1339 1339
         }
@@ -1358,7 +1358,7 @@  discard block
 block discarded – undo
1358 1358
             }
1359 1359
         }
1360 1360
         // extra headers
1361
-        $headers = array('Content-Type: ' . $req->getContentType(), 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']));
1361
+        $headers = array('Content-Type: '.$req->getContentType(), 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings']));
1362 1362
         // if no keepalive is wanted, let the server know it in advance
1363 1363
         if (!$opts['keepalive']) {
1364 1364
             $headers[] = 'Connection: close';
@@ -1394,7 +1394,7 @@  discard block
 block discarded – undo
1394 1394
                 if (defined('CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE')) {
1395 1395
                     curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE);
1396 1396
                 } else {
1397
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install');
1397
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install');
1398 1398
                     curl_close($curl);
1399 1399
                     return false;
1400 1400
                 }
@@ -1405,11 +1405,11 @@  discard block
 block discarded – undo
1405 1405
         }
1406 1406
 
1407 1407
         if ($opts['username'] && $opts['password']) {
1408
-            curl_setopt($curl, CURLOPT_USERPWD, $opts['username'] . ':' . $opts['password']);
1408
+            curl_setopt($curl, CURLOPT_USERPWD, $opts['username'].':'.$opts['password']);
1409 1409
             if (defined('CURLOPT_HTTPAUTH')) {
1410 1410
                 curl_setopt($curl, CURLOPT_HTTPAUTH, $opts['authtype']);
1411 1411
             } elseif ($opts['authtype'] != 1) {
1412
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install');
1412
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install');
1413 1413
                 curl_close($curl);
1414 1414
                 return false;
1415 1415
             }
@@ -1454,13 +1454,13 @@  discard block
 block discarded – undo
1454 1454
             if ($opts['proxyport'] == 0) {
1455 1455
                 $opts['proxyport'] = 8080; // NB: even for HTTPS, local connection is on port 8080
1456 1456
             }
1457
-            curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'] . ':' . $opts['proxyport']);
1457
+            curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'].':'.$opts['proxyport']);
1458 1458
             if ($opts['proxy_user']) {
1459
-                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'] . ':' . $opts['proxy_pass']);
1459
+                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'].':'.$opts['proxy_pass']);
1460 1460
                 if (defined('CURLOPT_PROXYAUTH')) {
1461 1461
                     curl_setopt($curl, CURLOPT_PROXYAUTH, $opts['proxy_authtype']);
1462 1462
                 } elseif ($opts['proxy_authtype'] != 1) {
1463
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1463
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1464 1464
                     curl_close($curl);
1465 1465
                     return false;
1466 1466
                 }
@@ -1472,7 +1472,7 @@  discard block
 block discarded – undo
1472 1472
         if (count($opts['cookies'])) {
1473 1473
             $cookieHeader = '';
1474 1474
             foreach ($opts['cookies'] as $name => $cookie) {
1475
-                $cookieHeader .= $name . '=' . $cookie['value'] . '; ';
1475
+                $cookieHeader .= $name.'='.$cookie['value'].'; ';
1476 1476
             }
1477 1477
             curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2));
1478 1478
         }
@@ -1481,7 +1481,7 @@  discard block
 block discarded – undo
1481 1481
             curl_setopt($curl, $opt, $val);
1482 1482
         }
1483 1483
 
1484
-        if ($opts['debug'] > 1) {
1484
+        if ($opts['debug']>1) {
1485 1485
             $this->getLogger()->debug("---SENDING---\n$payload\n---END---");
1486 1486
         }
1487 1487
 
@@ -1582,7 +1582,7 @@  discard block
 block discarded – undo
1582 1582
             $call['methodName'] = new Value($req->method(), 'string');
1583 1583
             $numParams = $req->getNumParams();
1584 1584
             $params = array();
1585
-            for ($i = 0; $i < $numParams; $i++) {
1585
+            for ($i = 0; $i<$numParams; $i++) {
1586 1586
                 $params[$i] = $req->getParam($i);
1587 1587
             }
1588 1588
             $call['params'] = new Value($params, 'array');
@@ -1604,7 +1604,7 @@  discard block
 block discarded – undo
1604 1604
         $response = array();
1605 1605
 
1606 1606
         if ($this->return_type == 'xml') {
1607
-            for ($i = 0; $i < count($reqs); $i++) {
1607
+            for ($i = 0; $i<count($reqs); $i++) {
1608 1608
                 $response[] = new static::$responseClass($rets, 0, '', 'xml', $result->httpResponse());
1609 1609
             }
1610 1610
 
@@ -1612,21 +1612,21 @@  discard block
 block discarded – undo
1612 1612
             if (!is_array($rets)) {
1613 1613
                 // bad return type from system.multicall
1614 1614
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1615
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse());
1615
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse());
1616 1616
             }
1617 1617
             $numRets = count($rets);
1618 1618
             if ($numRets != count($reqs)) {
1619 1619
                 // wrong number of return values.
1620 1620
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1621
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals',
1621
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals',
1622 1622
                     $result->httpResponse());
1623 1623
             }
1624 1624
 
1625
-            for ($i = 0; $i < $numRets; $i++) {
1625
+            for ($i = 0; $i<$numRets; $i++) {
1626 1626
                 $val = $rets[$i];
1627 1627
                 if (!is_array($val)) {
1628 1628
                     return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1629
-                        PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1629
+                        PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1630 1630
                         'phpvals', $result->httpResponse());
1631 1631
                 }
1632 1632
                 switch (count($val)) {
@@ -1634,7 +1634,7 @@  discard block
 block discarded – undo
1634 1634
                         if (!isset($val[0])) {
1635 1635
                             // Bad value
1636 1636
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1637
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value",
1637
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value",
1638 1638
                                 'phpvals', $result->httpResponse());
1639 1639
                         }
1640 1640
                         // Normal return value
@@ -1646,20 +1646,20 @@  discard block
 block discarded – undo
1646 1646
                         if (!is_int($code)) {
1647 1647
                             /// @todo should we check that it is != 0?
1648 1648
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1649
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1649
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1650 1650
                                 'phpvals', $result->httpResponse());
1651 1651
                         }
1652 1652
                         $str = @$val['faultString'];
1653 1653
                         if (!is_string($str)) {
1654 1654
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1655
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString",
1655
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString",
1656 1656
                                 'phpvals', $result->httpResponse());
1657 1657
                         }
1658 1658
                         $response[$i] = new static::$responseClass(0, $code, $str, 'phpvals', $result->httpResponse());
1659 1659
                         break;
1660 1660
                     default:
1661 1661
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1662
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1662
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1663 1663
                             'phpvals', $result->httpResponse());
1664 1664
                 }
1665 1665
             }
@@ -1668,14 +1668,14 @@  discard block
 block discarded – undo
1668 1668
             // return type == 'xmlrpcvals'
1669 1669
             if ($rets->kindOf() != 'array') {
1670 1670
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1671
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals',
1671
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals',
1672 1672
                     $result->httpResponse());
1673 1673
             }
1674 1674
             $numRets = $rets->count();
1675 1675
             if ($numRets != count($reqs)) {
1676 1676
                 // wrong number of return values.
1677 1677
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1678
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals',
1678
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals',
1679 1679
                     $result->httpResponse());
1680 1680
             }
1681 1681
 
@@ -1684,7 +1684,7 @@  discard block
 block discarded – undo
1684 1684
                     case 'array':
1685 1685
                         if ($val->count() != 1) {
1686 1686
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1687
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1687
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1688 1688
                                 'phpvals', $result->httpResponse());
1689 1689
                         }
1690 1690
                         // Normal return value
@@ -1693,28 +1693,28 @@  discard block
 block discarded – undo
1693 1693
                     case 'struct':
1694 1694
                         if ($val->count() != 2) {
1695 1695
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1696
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1696
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1697 1697
                                 'phpvals', $result->httpResponse());
1698 1698
                         }
1699 1699
                         /** @var Value $code */
1700 1700
                         $code = $val['faultCode'];
1701 1701
                         if ($code->kindOf() != 'scalar' || $code->scalarTyp() != 'int') {
1702 1702
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1703
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1703
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1704 1704
                                 'xmlrpcvals', $result->httpResponse());
1705 1705
                         }
1706 1706
                         /** @var Value $str */
1707 1707
                         $str = $val['faultString'];
1708 1708
                         if ($str->kindOf() != 'scalar' || $str->scalarTyp() != 'string') {
1709 1709
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1710
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1710
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1711 1711
                                 'xmlrpcvals', $result->httpResponse());
1712 1712
                         }
1713 1713
                         $response[] = new static::$responseClass(0, $code->scalarVal(), $str->scalarVal(), 'xmlrpcvals', $result->httpResponse());
1714 1714
                         break;
1715 1715
                     default:
1716 1716
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1717
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1717
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1718 1718
                             'xmlrpcvals', $result->httpResponse());
1719 1719
                 }
1720 1720
             }
@@ -1747,7 +1747,7 @@  discard block
 block discarded – undo
1747 1747
         $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
1748 1748
         $method = 'http')
1749 1749
     {
1750
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
1750
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
1751 1751
 
1752 1752
         return $this->sendPayloadSocket($req, $server, $port, $timeout, $username, $password, $authType, null, null,
1753 1753
             null, null, $proxyHost, $proxyPort, $proxyUsername, $proxyPassword, $proxyAuthType, $method);
@@ -1783,7 +1783,7 @@  discard block
 block discarded – undo
1783 1783
         $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '',
1784 1784
         $sslVersion = 0)
1785 1785
     {
1786
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
1786
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
1787 1787
 
1788 1788
         return $this->sendPayloadCURL($req, $server, $port, $timeout, $username,
1789 1789
             $password, $authType, $cert, $certPass, $caCert, $caCertDir, $proxyHost, $proxyPort,
@@ -1996,7 +1996,7 @@  discard block
 block discarded – undo
1996 1996
     public function &__get($name)
1997 1997
     {
1998 1998
         if (in_array($name, static::$options)) {
1999
-            $this->logDeprecation('Getting property Client::' . $name . ' is deprecated');
1999
+            $this->logDeprecation('Getting property Client::'.$name.' is deprecated');
2000 2000
             return $this->$name;
2001 2001
         }
2002 2002
 
@@ -2007,12 +2007,12 @@  discard block
 block discarded – undo
2007 2007
             case 'server':
2008 2008
             case 'port':
2009 2009
             case 'path':
2010
-                $this->logDeprecation('Getting property Client::' . $name . ' is deprecated');
2010
+                $this->logDeprecation('Getting property Client::'.$name.' is deprecated');
2011 2011
                 return $this->$name;
2012 2012
             default:
2013 2013
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
2014 2014
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
2015
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
2015
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
2016 2016
                 $result = null;
2017 2017
                 return $result;
2018 2018
         }
@@ -2021,7 +2021,7 @@  discard block
 block discarded – undo
2021 2021
     public function __set($name, $value)
2022 2022
     {
2023 2023
         if (in_array($name, static::$options)) {
2024
-            $this->logDeprecation('Setting property Client::' . $name . ' is deprecated');
2024
+            $this->logDeprecation('Setting property Client::'.$name.' is deprecated');
2025 2025
             $this->$name = $value;
2026 2026
             return;
2027 2027
         }
@@ -2033,20 +2033,20 @@  discard block
 block discarded – undo
2033 2033
             case 'server':
2034 2034
             case 'port':
2035 2035
             case 'path':
2036
-                $this->logDeprecation('Setting property Client::' . $name . ' is deprecated');
2036
+                $this->logDeprecation('Setting property Client::'.$name.' is deprecated');
2037 2037
                 $this->$name = $value;
2038 2038
                 return;
2039 2039
             default:
2040 2040
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
2041 2041
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
2042
-                trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
2042
+                trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
2043 2043
         }
2044 2044
     }
2045 2045
 
2046 2046
     public function __isset($name)
2047 2047
     {
2048 2048
         if (in_array($name, static::$options)) {
2049
-            $this->logDeprecation('Checking property Client::' . $name . ' is deprecated');
2049
+            $this->logDeprecation('Checking property Client::'.$name.' is deprecated');
2050 2050
             return isset($this->$name);
2051 2051
         }
2052 2052
 
@@ -2057,7 +2057,7 @@  discard block
 block discarded – undo
2057 2057
             case 'server':
2058 2058
             case 'port':
2059 2059
             case 'path':
2060
-                $this->logDeprecation('Checking property Client::' . $name . ' is deprecated');
2060
+                $this->logDeprecation('Checking property Client::'.$name.' is deprecated');
2061 2061
                 return isset($this->$name);
2062 2062
             default:
2063 2063
                 return false;
@@ -2067,7 +2067,7 @@  discard block
 block discarded – undo
2067 2067
     public function __unset($name)
2068 2068
     {
2069 2069
         if (in_array($name, static::$options)) {
2070
-            $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated');
2070
+            $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated');
2071 2071
             unset($this->$name);
2072 2072
             return;
2073 2073
         }
@@ -2079,13 +2079,13 @@  discard block
 block discarded – undo
2079 2079
             case 'server':
2080 2080
             case 'port':
2081 2081
             case 'path':
2082
-                $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated');
2082
+                $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated');
2083 2083
                 unset($this->$name);
2084 2084
                 return;
2085 2085
             default:
2086 2086
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
2087 2087
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
2088
-                trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
2088
+                trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
2089 2089
         }
2090 2090
     }
2091 2091
 }
Please login to merge, or discard this patch.