Passed
Push — master ( 18715e...cc36f0 )
by Gaetano
18:17 queued 08:23
created
src/Client.php 1 patch
Spacing   +106 added lines, -106 removed lines patch added patch discarded remove patch
@@ -335,10 +335,10 @@  discard block
 block discarded – undo
335 335
             $server = $parts['host'];
336 336
             $path = isset($parts['path']) ? $parts['path'] : '';
337 337
             if (isset($parts['query'])) {
338
-                $path .= '?' . $parts['query'];
338
+                $path .= '?'.$parts['query'];
339 339
             }
340 340
             if (isset($parts['fragment'])) {
341
-                $path .= '#' . $parts['fragment'];
341
+                $path .= '#'.$parts['fragment'];
342 342
             }
343 343
             if (isset($parts['port'])) {
344 344
                 $port = $parts['port'];
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
             }
355 355
         }
356 356
         if ($path == '' || $path[0] != '/') {
357
-            $this->path = '/' . $path;
357
+            $this->path = '/'.$path;
358 358
         } else {
359 359
             $this->path = $path;
360 360
         }
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
         //$this->accepted_charset_encodings = $ch->knownCharsets();
387 387
 
388 388
         // initialize user_agent string
389
-        $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion;
389
+        $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion;
390 390
     }
391 391
 
392 392
     /**
@@ -558,7 +558,7 @@  discard block
 block discarded – undo
558 558
      */
559 559
     public function setSSLVerifyPeer($i)
560 560
     {
561
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
561
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
562 562
 
563 563
         $this->verifypeer = $i;
564 564
         return $this;
@@ -575,7 +575,7 @@  discard block
 block discarded – undo
575 575
      */
576 576
     public function setSSLVerifyHost($i)
577 577
     {
578
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
578
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
579 579
 
580 580
         $this->verifyhost = $i;
581 581
         return $this;
@@ -590,7 +590,7 @@  discard block
 block discarded – undo
590 590
      */
591 591
     public function setSSLVersion($i)
592 592
     {
593
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
593
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
594 594
 
595 595
         $this->sslversion = $i;
596 596
         return $this;
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
      */
656 656
     public function setRequestCompression($compMethod)
657 657
     {
658
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
658
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
659 659
 
660 660
         $this->request_compression = $compMethod;
661 661
         return $this;
@@ -705,7 +705,7 @@  discard block
 block discarded – undo
705 705
      */
706 706
     public function setCurlOptions($options)
707 707
     {
708
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
708
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
709 709
 
710 710
         $this->extracurlopts = $options;
711 711
         return $this;
@@ -718,7 +718,7 @@  discard block
 block discarded – undo
718 718
      */
719 719
     public function setUseCurl($useCurlMode)
720 720
     {
721
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
721
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
722 722
 
723 723
         $this->use_curl = $useCurlMode;
724 724
         return $this;
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
      */
737 737
     public function setUserAgent($agentString)
738 738
     {
739
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
739
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
740 740
 
741 741
         $this->user_agent = $agentString;
742 742
         return $this;
@@ -767,12 +767,12 @@  discard block
 block discarded – undo
767 767
             }
768 768
         }
769 769
 
770
-        $url = $this->method . '://' . $this->server;
770
+        $url = $this->method.'://'.$this->server;
771 771
         if ($this->port == 0 || ($this->port == 80 && in_array($this->method, array('http', 'http10', 'http11', 'h2c'))) ||
772 772
             ($this->port == 443 && in_array($this->method, array('https', 'h2')))) {
773
-            return $url . $this->path;
773
+            return $url.$this->path;
774 774
         } else {
775
-            return $url . ':' . $this->port . $this->path;
775
+            return $url.':'.$this->port.$this->path;
776 776
         }
777 777
     }
778 778
 
@@ -812,7 +812,7 @@  discard block
 block discarded – undo
812 812
     public function send($req, $timeout = 0, $method = '')
813 813
     {
814 814
         if ($method !== '' || $timeout !== 0) {
815
-            $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated');
815
+            $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method ".__METHOD__.' is deprecated');
816 816
         }
817 817
 
818 818
         // if user does not specify http protocol, use native method of this client
@@ -931,7 +931,7 @@  discard block
 block discarded – undo
931 931
                     $payload = $a;
932 932
                     $encodingHdr = "Content-Encoding: gzip\r\n";
933 933
                 } else {
934
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request');
934
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request');
935 935
                 }
936 936
             } else if (function_exists('gzcompress')) {
937 937
                 $a = @gzcompress($payload);
@@ -939,14 +939,14 @@  discard block
 block discarded – undo
939 939
                     $payload = $a;
940 940
                     $encodingHdr = "Content-Encoding: deflate\r\n";
941 941
                 } else {
942
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request');
942
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request');
943 943
                 }
944 944
             } else {
945
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install');
945
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install');
946 946
             }
947 947
         } else {
948 948
             if ($opts['request_compression'] != '') {
949
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported');
949
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported');
950 950
             }
951 951
         }
952 952
 
@@ -954,16 +954,16 @@  discard block
 block discarded – undo
954 954
         $credentials = '';
955 955
         if ($opts['username'] != '') {
956 956
             if ($opts['authtype'] != 1) {
957
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0');
957
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0');
958 958
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
959
-                    PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth is supported with HTTP 1.0');
959
+                    PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth is supported with HTTP 1.0');
960 960
             }
961
-            $credentials = 'Authorization: Basic ' . base64_encode($opts['username'] . ':' . $opts['password']) . "\r\n";
961
+            $credentials = 'Authorization: Basic '.base64_encode($opts['username'].':'.$opts['password'])."\r\n";
962 962
         }
963 963
 
964 964
         $acceptedEncoding = '';
965 965
         if (is_array($opts['accepted_compression']) && count($opts['accepted_compression'])) {
966
-            $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $opts['accepted_compression']) . "\r\n";
966
+            $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $opts['accepted_compression'])."\r\n";
967 967
         }
968 968
 
969 969
         if ($port == 0) {
@@ -979,15 +979,15 @@  discard block
 block discarded – undo
979 979
             $connectPort = $opts['proxyport'];
980 980
             $transport = 'tcp';
981 981
             /// @todo check: should we not use https in some cases?
982
-            $uri = 'http://' . $server . ':' . $port . $path;
982
+            $uri = 'http://'.$server.':'.$port.$path;
983 983
             if ($opts['proxy_user'] != '') {
984 984
                 if ($opts['proxy_authtype'] != 1) {
985
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0');
985
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0');
986 986
                     return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
987
-                        PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth to proxy is supported with HTTP 1.0');
987
+                        PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth to proxy is supported with HTTP 1.0');
988 988
                 }
989
-                $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($opts['proxy_user'] . ':' .
990
-                    $opts['proxy_pass']) . "\r\n";
989
+                $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($opts['proxy_user'].':'.
990
+                    $opts['proxy_pass'])."\r\n";
991 991
             }
992 992
         } else {
993 993
             $connectServer = $server;
@@ -1003,38 +1003,38 @@  discard block
 block discarded – undo
1003 1003
             $version = '';
1004 1004
             foreach ($opts['cookies'] as $name => $cookie) {
1005 1005
                 /// @todo should we sanitize the cookie value on behalf of the user? See setCookie comments
1006
-                $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";";
1006
+                $cookieHeader .= ' '.$name.'='.$cookie['value'].";";
1007 1007
             }
1008
-            $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n";
1008
+            $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n";
1009 1009
         }
1010 1010
 
1011 1011
         $extraHeaders = '';
1012 1012
         if (!empty($this->extra_headers) && is_array($this->extra_headers)) {
1013
-            $extraHeaders = implode("\r\n", $this->extra_headers) . "\r\n";
1013
+            $extraHeaders = implode("\r\n", $this->extra_headers)."\r\n";
1014 1014
         }
1015 1015
 
1016 1016
         // omit port if default
1017 1017
         if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) {
1018 1018
             $port = '';
1019 1019
         } else {
1020
-            $port = ':' . $port;
1021
-        }
1022
-
1023
-        $op = 'POST ' . $uri . " HTTP/1.0\r\n" .
1024
-            'User-Agent: ' . $opts['user_agent'] . "\r\n" .
1025
-            'Host: ' . $server . $port . "\r\n" .
1026
-            $credentials .
1027
-            $proxyCredentials .
1028
-            $acceptedEncoding .
1029
-            $encodingHdr .
1030
-            'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']) . "\r\n" .
1031
-            $cookieHeader .
1032
-            $extraHeaders .
1033
-            'Content-Type: ' . $req->getContentType() . "\r\nContent-Length: " .
1034
-            strlen($payload) . "\r\n\r\n" .
1020
+            $port = ':'.$port;
1021
+        }
1022
+
1023
+        $op = 'POST '.$uri." HTTP/1.0\r\n".
1024
+            'User-Agent: '.$opts['user_agent']."\r\n".
1025
+            'Host: '.$server.$port."\r\n".
1026
+            $credentials.
1027
+            $proxyCredentials.
1028
+            $acceptedEncoding.
1029
+            $encodingHdr.
1030
+            'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])."\r\n".
1031
+            $cookieHeader.
1032
+            $extraHeaders.
1033
+            'Content-Type: '.$req->getContentType()."\r\nContent-Length: ".
1034
+            strlen($payload)."\r\n\r\n".
1035 1035
             $payload;
1036 1036
 
1037
-        if ($opts['debug'] > 1) {
1037
+        if ($opts['debug']>1) {
1038 1038
             $this->getLogger()->debug("---SENDING---\n$op\n---END---");
1039 1039
         }
1040 1040
 
@@ -1060,7 +1060,7 @@  discard block
 block discarded – undo
1060 1060
 
1061 1061
             if ($opts['sslversion'] != 0) {
1062 1062
                 /// @see https://www.php.net/manual/en/function.curl-setopt.php, https://www.php.net/manual/en/migration56.openssl.php
1063
-                switch($opts['sslversion']) {
1063
+                switch ($opts['sslversion']) {
1064 1064
                     /// @todo what does this map to? 1.0-1.3?
1065 1065
                     //case 1: // TLSv1
1066 1066
                     //    break;
@@ -1084,12 +1084,12 @@  discard block
 block discarded – undo
1084 1084
                             $contextOptions['ssl']['crypto_method'] = STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT;
1085 1085
                         } else {
1086 1086
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
1087
-                                PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': TLS-1.3 only is supported with PHP 7.4 or later');
1087
+                                PhpXmlRpc::$xmlrpcerr['unsupported_option'].': TLS-1.3 only is supported with PHP 7.4 or later');
1088 1088
                         }
1089 1089
                         break;
1090 1090
                     default:
1091 1091
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
1092
-                            PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': Unsupported required TLS version');
1092
+                            PhpXmlRpc::$xmlrpcerr['unsupported_option'].': Unsupported required TLS version');
1093 1093
                 }
1094 1094
             }
1095 1095
         }
@@ -1102,7 +1102,7 @@  discard block
 block discarded – undo
1102 1102
 
1103 1103
         $context = stream_context_create($contextOptions);
1104 1104
 
1105
-        if ($opts['timeout'] <= 0) {
1105
+        if ($opts['timeout']<=0) {
1106 1106
             $connectTimeout = ini_get('default_socket_timeout');
1107 1107
         } else {
1108 1108
             $connectTimeout = $opts['timeout'];
@@ -1114,7 +1114,7 @@  discard block
 block discarded – undo
1114 1114
         $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout,
1115 1115
             STREAM_CLIENT_CONNECT, $context);
1116 1116
         if ($fp) {
1117
-            if ($opts['timeout'] > 0) {
1117
+            if ($opts['timeout']>0) {
1118 1118
                 stream_set_timeout($fp, $opts['timeout'], 0);
1119 1119
             }
1120 1120
         } else {
@@ -1123,8 +1123,8 @@  discard block
 block discarded – undo
1123 1123
                 $this->errstr = $err['message'];
1124 1124
             }
1125 1125
 
1126
-            $this->errstr = 'Connect error: ' . $this->errstr;
1127
-            $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')');
1126
+            $this->errstr = 'Connect error: '.$this->errstr;
1127
+            $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')');
1128 1128
 
1129 1129
             return $r;
1130 1130
         }
@@ -1191,19 +1191,19 @@  discard block
 block discarded – undo
1191 1191
             $opts['keepalive'], $opts['key'], $opts['keypass'], $opts['sslversion']);
1192 1192
 
1193 1193
         if (!$curl) {
1194
-            return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] .
1194
+            return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].
1195 1195
                 ': error during curl initialization. Check php error log for details');
1196 1196
         }
1197 1197
 
1198 1198
         $result = curl_exec($curl);
1199 1199
 
1200
-        if ($opts['debug'] > 1) {
1200
+        if ($opts['debug']>1) {
1201 1201
             $message = "---CURL INFO---\n";
1202 1202
             foreach (curl_getinfo($curl) as $name => $val) {
1203 1203
                 if (is_array($val)) {
1204 1204
                     $val = implode("\n", $val);
1205 1205
                 }
1206
-                $message .= $name . ': ' . $val . "\n";
1206
+                $message .= $name.': '.$val."\n";
1207 1207
             }
1208 1208
             $message .= '---END---';
1209 1209
             $this->getLogger()->debug($message);
@@ -1213,8 +1213,8 @@  discard block
 block discarded – undo
1213 1213
             /// @todo we should use a better check here - what if we get back '' or '0'?
1214 1214
 
1215 1215
             $this->errstr = 'no response';
1216
-            $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] .
1217
-                ': ' . curl_error($curl));
1216
+            $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].
1217
+                ': '.curl_error($curl));
1218 1218
             curl_close($curl);
1219 1219
             if ($opts['keepalive']) {
1220 1220
                 $this->xmlrpc_curl_handle = null;
@@ -1272,7 +1272,7 @@  discard block
 block discarded – undo
1272 1272
                     $payload = $a;
1273 1273
                     $encodingHdr = 'Content-Encoding: gzip';
1274 1274
                 } else {
1275
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request');
1275
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request');
1276 1276
                 }
1277 1277
             } else if (function_exists('gzcompress')) {
1278 1278
                 $a = @gzcompress($payload);
@@ -1280,14 +1280,14 @@  discard block
 block discarded – undo
1280 1280
                     $payload = $a;
1281 1281
                     $encodingHdr = 'Content-Encoding: deflate';
1282 1282
                 } else {
1283
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request');
1283
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request');
1284 1284
                 }
1285 1285
             } else {
1286
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install');
1286
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install');
1287 1287
             }
1288 1288
         } else {
1289 1289
             if ($opts['request_compression'] != '') {
1290
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported');
1290
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported');
1291 1291
             }
1292 1292
         }
1293 1293
 
@@ -1301,12 +1301,12 @@  discard block
 block discarded – undo
1301 1301
                     // http, https
1302 1302
                     $protocol = $method;
1303 1303
                     if (strpos($protocol, ':') !== false) {
1304
-                        $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1304
+                        $this->getLogger()->error('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1305 1305
                         return false;
1306 1306
                     }
1307 1307
                 }
1308 1308
             }
1309
-            $curl = curl_init($protocol . '://' . $server . ':' . $port . $path);
1309
+            $curl = curl_init($protocol.'://'.$server.':'.$port.$path);
1310 1310
             if (!$curl) {
1311 1311
                 return false;
1312 1312
             }
@@ -1320,7 +1320,7 @@  discard block
 block discarded – undo
1320 1320
         // results into variable
1321 1321
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
1322 1322
 
1323
-        if ($opts['debug'] > 1) {
1323
+        if ($opts['debug']>1) {
1324 1324
             curl_setopt($curl, CURLOPT_VERBOSE, true);
1325 1325
             /// @todo redirect curlopt_stderr to some stream which can be piped to the logger
1326 1326
         }
@@ -1345,7 +1345,7 @@  discard block
 block discarded – undo
1345 1345
             }
1346 1346
         }
1347 1347
         // extra headers
1348
-        $headers = array('Content-Type: ' . $req->getContentType(), 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']));
1348
+        $headers = array('Content-Type: '.$req->getContentType(), 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings']));
1349 1349
         // if no keepalive is wanted, let the server know it in advance
1350 1350
         if (!$opts['keepalive']) {
1351 1351
             $headers[] = 'Connection: close';
@@ -1366,7 +1366,7 @@  discard block
 block discarded – undo
1366 1366
         curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
1367 1367
         // timeout is borked
1368 1368
         if ($opts['timeout']) {
1369
-            curl_setopt($curl, CURLOPT_TIMEOUT, $opts['timeout'] == 1 ? 1 : $opts['timeout'] - 1);
1369
+            curl_setopt($curl, CURLOPT_TIMEOUT, $opts['timeout'] == 1 ? 1 : $opts['timeout']-1);
1370 1370
         }
1371 1371
 
1372 1372
         switch ($method) {
@@ -1380,7 +1380,7 @@  discard block
 block discarded – undo
1380 1380
                 if (defined('CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE')) {
1381 1381
                     curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE);
1382 1382
                 } else {
1383
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install');
1383
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install');
1384 1384
                     curl_close($curl);
1385 1385
                     return false;
1386 1386
                 }
@@ -1391,11 +1391,11 @@  discard block
 block discarded – undo
1391 1391
         }
1392 1392
 
1393 1393
         if ($opts['username'] && $opts['password']) {
1394
-            curl_setopt($curl, CURLOPT_USERPWD, $opts['username'] . ':' . $opts['password']);
1394
+            curl_setopt($curl, CURLOPT_USERPWD, $opts['username'].':'.$opts['password']);
1395 1395
             if (defined('CURLOPT_HTTPAUTH')) {
1396 1396
                 curl_setopt($curl, CURLOPT_HTTPAUTH, $opts['authtype']);
1397 1397
             } elseif ($opts['authtype'] != 1) {
1398
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install');
1398
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install');
1399 1399
                 curl_close($curl);
1400 1400
                 return false;
1401 1401
             }
@@ -1440,13 +1440,13 @@  discard block
 block discarded – undo
1440 1440
             if ($opts['proxyport'] == 0) {
1441 1441
                 $opts['proxyport'] = 8080; // NB: even for HTTPS, local connection is on port 8080
1442 1442
             }
1443
-            curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'] . ':' . $opts['proxyport']);
1443
+            curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'].':'.$opts['proxyport']);
1444 1444
             if ($opts['proxy_user']) {
1445
-                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'] . ':' . $opts['proxy_pass']);
1445
+                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'].':'.$opts['proxy_pass']);
1446 1446
                 if (defined('CURLOPT_PROXYAUTH')) {
1447 1447
                     curl_setopt($curl, CURLOPT_PROXYAUTH, $opts['proxy_authtype']);
1448 1448
                 } elseif ($opts['proxy_authtype'] != 1) {
1449
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1449
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1450 1450
                     curl_close($curl);
1451 1451
                     return false;
1452 1452
                 }
@@ -1458,7 +1458,7 @@  discard block
 block discarded – undo
1458 1458
         if (count($opts['cookies'])) {
1459 1459
             $cookieHeader = '';
1460 1460
             foreach ($opts['cookies'] as $name => $cookie) {
1461
-                $cookieHeader .= $name . '=' . $cookie['value'] . '; ';
1461
+                $cookieHeader .= $name.'='.$cookie['value'].'; ';
1462 1462
             }
1463 1463
             curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2));
1464 1464
         }
@@ -1467,7 +1467,7 @@  discard block
 block discarded – undo
1467 1467
             curl_setopt($curl, $opt, $val);
1468 1468
         }
1469 1469
 
1470
-        if ($opts['debug'] > 1) {
1470
+        if ($opts['debug']>1) {
1471 1471
             $this->getLogger()->debug("---SENDING---\n$payload\n---END---");
1472 1472
         }
1473 1473
 
@@ -1568,7 +1568,7 @@  discard block
 block discarded – undo
1568 1568
             $call['methodName'] = new Value($req->method(), 'string');
1569 1569
             $numParams = $req->getNumParams();
1570 1570
             $params = array();
1571
-            for ($i = 0; $i < $numParams; $i++) {
1571
+            for ($i = 0; $i<$numParams; $i++) {
1572 1572
                 $params[$i] = $req->getParam($i);
1573 1573
             }
1574 1574
             $call['params'] = new Value($params, 'array');
@@ -1590,7 +1590,7 @@  discard block
 block discarded – undo
1590 1590
         $response = array();
1591 1591
 
1592 1592
         if ($this->return_type == 'xml') {
1593
-            for ($i = 0; $i < count($reqs); $i++) {
1593
+            for ($i = 0; $i<count($reqs); $i++) {
1594 1594
                 $response[] = new static::$responseClass($rets, 0, '', 'xml', $result->httpResponse());
1595 1595
             }
1596 1596
 
@@ -1598,21 +1598,21 @@  discard block
 block discarded – undo
1598 1598
             if (!is_array($rets)) {
1599 1599
                 // bad return type from system.multicall
1600 1600
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1601
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse());
1601
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse());
1602 1602
             }
1603 1603
             $numRets = count($rets);
1604 1604
             if ($numRets != count($reqs)) {
1605 1605
                 // wrong number of return values.
1606 1606
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1607
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals',
1607
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals',
1608 1608
                     $result->httpResponse());
1609 1609
             }
1610 1610
 
1611
-            for ($i = 0; $i < $numRets; $i++) {
1611
+            for ($i = 0; $i<$numRets; $i++) {
1612 1612
                 $val = $rets[$i];
1613 1613
                 if (!is_array($val)) {
1614 1614
                     return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1615
-                        PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1615
+                        PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1616 1616
                         'phpvals', $result->httpResponse());
1617 1617
                 }
1618 1618
                 switch (count($val)) {
@@ -1620,7 +1620,7 @@  discard block
 block discarded – undo
1620 1620
                         if (!isset($val[0])) {
1621 1621
                             // Bad value
1622 1622
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1623
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value",
1623
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value",
1624 1624
                                 'phpvals', $result->httpResponse());
1625 1625
                         }
1626 1626
                         // Normal return value
@@ -1632,20 +1632,20 @@  discard block
 block discarded – undo
1632 1632
                         if (!is_int($code)) {
1633 1633
                             /// @todo should we check that it is != 0?
1634 1634
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1635
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1635
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1636 1636
                                 'phpvals', $result->httpResponse());
1637 1637
                         }
1638 1638
                         $str = @$val['faultString'];
1639 1639
                         if (!is_string($str)) {
1640 1640
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1641
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString",
1641
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString",
1642 1642
                                 'phpvals', $result->httpResponse());
1643 1643
                         }
1644 1644
                         $response[$i] = new static::$responseClass(0, $code, $str, 'phpvals', $result->httpResponse());
1645 1645
                         break;
1646 1646
                     default:
1647 1647
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1648
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1648
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1649 1649
                             'phpvals', $result->httpResponse());
1650 1650
                 }
1651 1651
             }
@@ -1654,14 +1654,14 @@  discard block
 block discarded – undo
1654 1654
             // return type == 'xmlrpcvals'
1655 1655
             if ($rets->kindOf() != 'array') {
1656 1656
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1657
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals',
1657
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals',
1658 1658
                     $result->httpResponse());
1659 1659
             }
1660 1660
             $numRets = $rets->count();
1661 1661
             if ($numRets != count($reqs)) {
1662 1662
                 // wrong number of return values.
1663 1663
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1664
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals',
1664
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals',
1665 1665
                     $result->httpResponse());
1666 1666
             }
1667 1667
 
@@ -1670,7 +1670,7 @@  discard block
 block discarded – undo
1670 1670
                     case 'array':
1671 1671
                         if ($val->count() != 1) {
1672 1672
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1673
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1673
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1674 1674
                                 'phpvals', $result->httpResponse());
1675 1675
                         }
1676 1676
                         // Normal return value
@@ -1679,28 +1679,28 @@  discard block
 block discarded – undo
1679 1679
                     case 'struct':
1680 1680
                         if ($val->count() != 2) {
1681 1681
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1682
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1682
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1683 1683
                                 'phpvals', $result->httpResponse());
1684 1684
                         }
1685 1685
                         /** @var Value $code */
1686 1686
                         $code = $val['faultCode'];
1687 1687
                         if ($code->kindOf() != 'scalar' || $code->scalarTyp() != 'int') {
1688 1688
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1689
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1689
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1690 1690
                                 'xmlrpcvals', $result->httpResponse());
1691 1691
                         }
1692 1692
                         /** @var Value $str */
1693 1693
                         $str = $val['faultString'];
1694 1694
                         if ($str->kindOf() != 'scalar' || $str->scalarTyp() != 'string') {
1695 1695
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1696
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1696
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1697 1697
                                 'xmlrpcvals', $result->httpResponse());
1698 1698
                         }
1699 1699
                         $response[] = new static::$responseClass(0, $code->scalarVal(), $str->scalarVal(), 'xmlrpcvals', $result->httpResponse());
1700 1700
                         break;
1701 1701
                     default:
1702 1702
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1703
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1703
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1704 1704
                             'xmlrpcvals', $result->httpResponse());
1705 1705
                 }
1706 1706
             }
@@ -1733,7 +1733,7 @@  discard block
 block discarded – undo
1733 1733
         $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
1734 1734
         $method = 'http')
1735 1735
     {
1736
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
1736
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
1737 1737
 
1738 1738
         return $this->sendPayloadSocket($req, $server, $port, $timeout, $username, $password, $authType, null, null,
1739 1739
             null, null, $proxyHost, $proxyPort, $proxyUsername, $proxyPassword, $proxyAuthType, $method);
@@ -1769,7 +1769,7 @@  discard block
 block discarded – undo
1769 1769
         $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '',
1770 1770
         $sslVersion = 0)
1771 1771
     {
1772
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
1772
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
1773 1773
 
1774 1774
         return $this->sendPayloadCURL($req, $server, $port, $timeout, $username,
1775 1775
             $password, $authType, $cert, $certPass, $caCert, $caCertDir, $proxyHost, $proxyPort,
@@ -1982,7 +1982,7 @@  discard block
 block discarded – undo
1982 1982
     public function &__get($name)
1983 1983
     {
1984 1984
         if (in_array($name, static::$options)) {
1985
-            $this->logDeprecation('Getting property Client::' . $name . ' is deprecated');
1985
+            $this->logDeprecation('Getting property Client::'.$name.' is deprecated');
1986 1986
             return $this->$name;
1987 1987
         }
1988 1988
 
@@ -1993,12 +1993,12 @@  discard block
 block discarded – undo
1993 1993
             case 'server':
1994 1994
             case 'port':
1995 1995
             case 'path':
1996
-                $this->logDeprecation('Getting property Client::' . $name . ' is deprecated');
1996
+                $this->logDeprecation('Getting property Client::'.$name.' is deprecated');
1997 1997
                 return $this->$name;
1998 1998
             default:
1999 1999
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
2000 2000
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
2001
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
2001
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
2002 2002
                 $result = null;
2003 2003
                 return $result;
2004 2004
         }
@@ -2007,7 +2007,7 @@  discard block
 block discarded – undo
2007 2007
     public function __set($name, $value)
2008 2008
     {
2009 2009
         if (in_array($name, static::$options)) {
2010
-            $this->logDeprecation('Setting property Client::' . $name . ' is deprecated');
2010
+            $this->logDeprecation('Setting property Client::'.$name.' is deprecated');
2011 2011
             $this->$name = $value;
2012 2012
             return;
2013 2013
         }
@@ -2019,20 +2019,20 @@  discard block
 block discarded – undo
2019 2019
             case 'server':
2020 2020
             case 'port':
2021 2021
             case 'path':
2022
-                $this->logDeprecation('Setting property Client::' . $name . ' is deprecated');
2022
+                $this->logDeprecation('Setting property Client::'.$name.' is deprecated');
2023 2023
                 $this->$name = $value;
2024 2024
                 return;
2025 2025
             default:
2026 2026
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
2027 2027
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
2028
-                trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
2028
+                trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
2029 2029
         }
2030 2030
     }
2031 2031
 
2032 2032
     public function __isset($name)
2033 2033
     {
2034 2034
         if (in_array($name, static::$options)) {
2035
-            $this->logDeprecation('Checking property Client::' . $name . ' is deprecated');
2035
+            $this->logDeprecation('Checking property Client::'.$name.' is deprecated');
2036 2036
             return isset($this->$name);
2037 2037
         }
2038 2038
 
@@ -2043,7 +2043,7 @@  discard block
 block discarded – undo
2043 2043
             case 'server':
2044 2044
             case 'port':
2045 2045
             case 'path':
2046
-                $this->logDeprecation('Checking property Client::' . $name . ' is deprecated');
2046
+                $this->logDeprecation('Checking property Client::'.$name.' is deprecated');
2047 2047
                 return isset($this->$name);
2048 2048
             default:
2049 2049
                 return false;
@@ -2053,7 +2053,7 @@  discard block
 block discarded – undo
2053 2053
     public function __unset($name)
2054 2054
     {
2055 2055
         if (in_array($name, static::$options)) {
2056
-            $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated');
2056
+            $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated');
2057 2057
             unset($this->$name);
2058 2058
             return;
2059 2059
         }
@@ -2065,13 +2065,13 @@  discard block
 block discarded – undo
2065 2065
             case 'server':
2066 2066
             case 'port':
2067 2067
             case 'path':
2068
-                $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated');
2068
+                $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated');
2069 2069
                 unset($this->$name);
2070 2070
                 return;
2071 2071
             default:
2072 2072
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
2073 2073
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
2074
-                trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
2074
+                trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
2075 2075
         }
2076 2076
     }
2077 2077
 }
Please login to merge, or discard this patch.