Passed
Push — master ( 1cc656...3c7609 )
by Gaetano
09:33
created
src/Server.php 1 patch
Spacing   +67 added lines, -67 removed lines patch added patch discarded remove patch
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
     public function getOptions()
252 252
     {
253 253
         $values = array();
254
-        foreach(static::$options as $opt) {
254
+        foreach (static::$options as $opt) {
255 255
             $values[$opt] = $this->getOption($opt);
256 256
         }
257 257
         return $values;
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
      */
265 265
     public function setOptions($options)
266 266
     {
267
-        foreach($options as $name => $value) {
267
+        foreach ($options as $name => $value) {
268 268
             $this->setOption($name, $value);
269 269
         }
270 270
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
      */
303 303
     public static function xmlrpc_debugmsg($msg)
304 304
     {
305
-        static::$_xmlrpc_debuginfo .= $msg . "\n";
305
+        static::$_xmlrpc_debuginfo .= $msg."\n";
306 306
     }
307 307
 
308 308
     /**
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
      */
315 315
     public static function error_occurred($msg)
316 316
     {
317
-        static::$_xmlrpcs_occurred_errors .= $msg . "\n";
317
+        static::$_xmlrpcs_occurred_errors .= $msg."\n";
318 318
     }
319 319
 
320 320
     /**
@@ -335,10 +335,10 @@  discard block
 block discarded – undo
335 335
         // user debug info should be encoded by the end user using the INTERNAL_ENCODING
336 336
         $out = '';
337 337
         if ($this->debug_info != '') {
338
-            $out .= "<!-- SERVER DEBUG INFO (BASE64 ENCODED):\n" . base64_encode($this->debug_info) . "\n-->\n";
338
+            $out .= "<!-- SERVER DEBUG INFO (BASE64 ENCODED):\n".base64_encode($this->debug_info)."\n-->\n";
339 339
         }
340 340
         if (static::$_xmlrpc_debuginfo != '') {
341
-            $out .= "<!-- DEBUG INFO:\n" . $this->getCharsetEncoder()->encodeEntities(str_replace('--', '_-', static::$_xmlrpc_debuginfo), PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "\n-->\n";
341
+            $out .= "<!-- DEBUG INFO:\n".$this->getCharsetEncoder()->encodeEntities(str_replace('--', '_-', static::$_xmlrpc_debuginfo), PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."\n-->\n";
342 342
             // NB: a better solution MIGHT be to use CDATA, but we need to insert it
343 343
             // into return payload AFTER the beginning tag
344 344
             //$out .= "<![CDATA[ DEBUG INFO:\n\n" . str_replace(']]>', ']_]_>', static::$_xmlrpc_debuginfo) . "\n]]>\n";
@@ -367,8 +367,8 @@  discard block
 block discarded – undo
367 367
         $this->debug_info = '';
368 368
 
369 369
         // Save what we received, before parsing it
370
-        if ($this->debug > 1) {
371
-            $this->debugMsg("+++GOT+++\n" . $data . "\n+++END+++");
370
+        if ($this->debug>1) {
371
+            $this->debugMsg("+++GOT+++\n".$data."\n+++END+++");
372 372
         }
373 373
 
374 374
         $resp = $this->parseRequestHeaders($data, $reqCharset, $respCharset, $respEncoding);
@@ -385,13 +385,13 @@  discard block
 block discarded – undo
385 385
             $resp->raw_data = $rawData;
386 386
         }
387 387
 
388
-        if ($this->debug > 2 && static::$_xmlrpcs_occurred_errors != '') {
389
-            $this->debugMsg("+++PROCESSING ERRORS AND WARNINGS+++\n" .
390
-                static::$_xmlrpcs_occurred_errors . "+++END+++");
388
+        if ($this->debug>2 && static::$_xmlrpcs_occurred_errors != '') {
389
+            $this->debugMsg("+++PROCESSING ERRORS AND WARNINGS+++\n".
390
+                static::$_xmlrpcs_occurred_errors."+++END+++");
391 391
         }
392 392
 
393 393
         $header = $resp->xml_header($respCharset);
394
-        if ($this->debug > 0) {
394
+        if ($this->debug>0) {
395 395
             $header .= $this->serializeDebug($respCharset);
396 396
         }
397 397
 
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
         if (empty($payload)) {
403 403
             $payload = $resp->serialize($respCharset);
404 404
         }
405
-        $payload = $header . $payload;
405
+        $payload = $header.$payload;
406 406
 
407 407
         if ($returnPayload) {
408 408
             return $payload;
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
         // if we get a warning/error that has output some text before here, then we cannot
412 412
         // add a new header. We cannot say we are sending xml, either...
413 413
         if (!headers_sent()) {
414
-            header('Content-Type: ' . $resp->getContentType());
414
+            header('Content-Type: '.$resp->getContentType());
415 415
             // we do not know if client actually told us an accepted charset, but if it did we have to tell it what we did
416 416
             header("Vary: Accept-Charset");
417 417
 
@@ -434,10 +434,10 @@  discard block
 block discarded – undo
434 434
             // Note that Apache/mod_php will add (and even alter!) the Content-Length header on its own, but only for
435 435
             // responses up to 8000 bytes
436 436
             if ($phpNoSelfCompress) {
437
-                header('Content-Length: ' . (int)strlen($payload));
437
+                header('Content-Length: '.(int) strlen($payload));
438 438
             }
439 439
         } else {
440
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': http headers already sent before response is fully generated. Check for php warning or error messages');
440
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': http headers already sent before response is fully generated. Check for php warning or error messages');
441 441
         }
442 442
 
443 443
         print $payload;
@@ -526,9 +526,9 @@  discard block
 block discarded – undo
526 526
             $numParams = count($in);
527 527
         }
528 528
         foreach ($sigs as $curSig) {
529
-            if (count($curSig) == $numParams + 1) {
529
+            if (count($curSig) == $numParams+1) {
530 530
                 $itsOK = 1;
531
-                for ($n = 0; $n < $numParams; $n++) {
531
+                for ($n = 0; $n<$numParams; $n++) {
532 532
                     if (is_object($in)) {
533 533
                         $p = $in->getParam($n);
534 534
                         if ($p->kindOf() == 'scalar') {
@@ -541,10 +541,10 @@  discard block
 block discarded – undo
541 541
                     }
542 542
 
543 543
                     // param index is $n+1, as first member of sig is return type
544
-                    if ($pt != $curSig[$n + 1] && $curSig[$n + 1] != Value::$xmlrpcValue) {
544
+                    if ($pt != $curSig[$n+1] && $curSig[$n+1] != Value::$xmlrpcValue) {
545 545
                         $itsOK = 0;
546
-                        $pno = $n + 1;
547
-                        $wanted = $curSig[$n + 1];
546
+                        $pno = $n+1;
547
+                        $wanted = $curSig[$n+1];
548 548
                         $got = $pt;
549 549
                         break;
550 550
                     }
@@ -571,10 +571,10 @@  discard block
 block discarded – undo
571 571
         // check if $_SERVER is populated: it might have been disabled via ini file
572 572
         // (this is true even when in CLI mode)
573 573
         if (count($_SERVER) == 0) {
574
-            $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': cannot parse request headers as $_SERVER is not populated');
574
+            $this->getLogger()->error('XML-RPC: '.__METHOD__.': cannot parse request headers as $_SERVER is not populated');
575 575
         }
576 576
 
577
-        if ($this->debug > 1) {
577
+        if ($this->debug>1) {
578 578
             if (function_exists('getallheaders')) {
579 579
                 $this->debugMsg(''); // empty line
580 580
                 foreach (getallheaders() as $name => $val) {
@@ -599,13 +599,13 @@  discard block
 block discarded – undo
599 599
                 if (function_exists('gzinflate') && in_array($contentEncoding, $this->accepted_compression)) {
600 600
                     if ($contentEncoding == 'deflate' && $degzdata = @gzuncompress($data)) {
601 601
                         $data = $degzdata;
602
-                        if ($this->debug > 1) {
603
-                            $this->debugMsg("\n+++INFLATED REQUEST+++[" . strlen($data) . " chars]+++\n" . $data . "\n+++END+++");
602
+                        if ($this->debug>1) {
603
+                            $this->debugMsg("\n+++INFLATED REQUEST+++[".strlen($data)." chars]+++\n".$data."\n+++END+++");
604 604
                         }
605 605
                     } elseif ($contentEncoding == 'gzip' && $degzdata = @gzinflate(substr($data, 10))) {
606 606
                         $data = $degzdata;
607
-                        if ($this->debug > 1) {
608
-                            $this->debugMsg("+++INFLATED REQUEST+++[" . strlen($data) . " chars]+++\n" . $data . "\n+++END+++");
607
+                        if ($this->debug>1) {
608
+                            $this->debugMsg("+++INFLATED REQUEST+++[".strlen($data)." chars]+++\n".$data."\n+++END+++");
609 609
                         }
610 610
                     } else {
611 611
                         $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['server_decompress_fail'],
@@ -692,7 +692,7 @@  discard block
 block discarded – undo
692 692
                     if ($reqEncoding == 'ISO-8859-1') {
693 693
                         $data = utf8_encode($data);
694 694
                     } else {
695
-                        $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': unsupported charset encoding of received request: ' . $reqEncoding);
695
+                        $this->getLogger()->error('XML-RPC: '.__METHOD__.': unsupported charset encoding of received request: '.$reqEncoding);
696 696
                     }
697 697
                 }
698 698
             }
@@ -723,7 +723,7 @@  discard block
 block discarded – undo
723 723
             preg_match('/^XML error ([0-9]+)/', $_xh['isf_reason'], $matches);
724 724
             return new static::$responseClass(
725 725
                 0,
726
-                PhpXmlRpc::$xmlrpcerrxml + (int)$matches[1],
726
+                PhpXmlRpc::$xmlrpcerrxml+(int) $matches[1],
727 727
                 $_xh['isf_reason']);
728 728
         } elseif ($_xh['isf']) {
729 729
             /// @todo separate better the various cases, as we have done in Request::parseResponse: invalid xml-rpc vs.
@@ -731,7 +731,7 @@  discard block
 block discarded – undo
731 731
             return new static::$responseClass(
732 732
                 0,
733 733
                 PhpXmlRpc::$xmlrpcerr['invalid_request'],
734
-                PhpXmlRpc::$xmlrpcstr['invalid_request'] . ' ' . $_xh['isf_reason']);
734
+                PhpXmlRpc::$xmlrpcstr['invalid_request'].' '.$_xh['isf_reason']);
735 735
         } else {
736 736
             // small layering violation in favor of speed and memory usage: we should allow the 'execute' method handle
737 737
             // this, but in the most common scenario (xml-rpc values type server with some methods registered as phpvals)
@@ -741,8 +741,8 @@  discard block
 block discarded – undo
741 741
                     ($this->dmap[$_xh['method']]['parameters_type'] != 'xmlrpcvals')
742 742
                 )
743 743
             ) {
744
-                if ($this->debug > 1) {
745
-                    $this->debugMsg("\n+++PARSED+++\n" . var_export($_xh['params'], true) . "\n+++END+++");
744
+                if ($this->debug>1) {
745
+                    $this->debugMsg("\n+++PARSED+++\n".var_export($_xh['params'], true)."\n+++END+++");
746 746
                 }
747 747
 
748 748
                 return $this->execute($_xh['method'], $_xh['params'], $_xh['pt']);
@@ -750,12 +750,12 @@  discard block
 block discarded – undo
750 750
                 // build a Request object with data parsed from xml and add parameters in
751 751
                 $req = new Request($_xh['method']);
752 752
                 /// @todo for more speed, we could just pass in the array to the constructor (and loose the type validation)...
753
-                for ($i = 0; $i < count($_xh['params']); $i++) {
753
+                for ($i = 0; $i<count($_xh['params']); $i++) {
754 754
                     $req->addParam($_xh['params'][$i]);
755 755
                 }
756 756
 
757
-                if ($this->debug > 1) {
758
-                    $this->debugMsg("\n+++PARSED+++\n" . var_export($req, true) . "\n+++END+++");
757
+                if ($this->debug>1) {
758
+                    $this->debugMsg("\n+++PARSED+++\n".var_export($req, true)."\n+++END+++");
759 759
                 }
760 760
 
761 761
                 return $this->execute($req);
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
805 805
                 return new static::$responseClass(
806 806
                     0,
807 807
                     PhpXmlRpc::$xmlrpcerr['incorrect_params'],
808
-                    PhpXmlRpc::$xmlrpcstr['incorrect_params'] . ": {$errStr}"
808
+                    PhpXmlRpc::$xmlrpcstr['incorrect_params'].": {$errStr}"
809 809
                 );
810 810
             }
811 811
         }
@@ -820,7 +820,7 @@  discard block
 block discarded – undo
820 820
         // build string representation of function 'name'
821 821
         if (is_array($func)) {
822 822
             if (is_object($func[0])) {
823
-                $funcName = get_class($func[0]) . '->' . $func[1];
823
+                $funcName = get_class($func[0]).'->'.$func[1];
824 824
             } else {
825 825
                 $funcName = implode('::', $func);
826 826
             }
@@ -832,23 +832,23 @@  discard block
 block discarded – undo
832 832
 
833 833
         // verify that function to be invoked is in fact callable
834 834
         if (!is_callable($func)) {
835
-            $this->getLogger()->error("XML-RPC: " . __METHOD__ . ": function '$funcName' registered as method handler is not callable");
835
+            $this->getLogger()->error("XML-RPC: ".__METHOD__.": function '$funcName' registered as method handler is not callable");
836 836
             return new static::$responseClass(
837 837
                 0,
838 838
                 PhpXmlRpc::$xmlrpcerr['server_error'],
839
-                PhpXmlRpc::$xmlrpcstr['server_error'] . ": no function matches method"
839
+                PhpXmlRpc::$xmlrpcstr['server_error'].": no function matches method"
840 840
             );
841 841
         }
842 842
 
843 843
         if (isset($dmap[$methodName]['exception_handling'])) {
844
-            $exception_handling = (int)$dmap[$methodName]['exception_handling'];
844
+            $exception_handling = (int) $dmap[$methodName]['exception_handling'];
845 845
         } else {
846 846
             $exception_handling = $this->exception_handling;
847 847
         }
848 848
 
849 849
         // If debug level is 3, we should catch all errors generated during processing of user function, and log them
850 850
         // as part of response
851
-        if ($this->debug > 2) {
851
+        if ($this->debug>2) {
852 852
             self::$_xmlrpcs_prev_ehandler = set_error_handler(array('\PhpXmlRpc\Server', '_xmlrpcs_errorHandler'));
853 853
         }
854 854
 
@@ -862,14 +862,14 @@  discard block
 block discarded – undo
862 862
                     $r = call_user_func($func, $req);
863 863
                 }
864 864
                 if (!is_a($r, 'PhpXmlRpc\Response')) {
865
-                    $this->getLogger()->error("XML-RPC: " . __METHOD__ . ": function '$funcName' registered as method handler does not return an xmlrpc response object but a " . gettype($r));
865
+                    $this->getLogger()->error("XML-RPC: ".__METHOD__.": function '$funcName' registered as method handler does not return an xmlrpc response object but a ".gettype($r));
866 866
                     if (is_a($r, 'PhpXmlRpc\Value')) {
867 867
                         $r = new static::$responseClass($r);
868 868
                     } else {
869 869
                         $r = new static::$responseClass(
870 870
                             0,
871 871
                             PhpXmlRpc::$xmlrpcerr['server_error'],
872
-                            PhpXmlRpc::$xmlrpcstr['server_error'] . ": function does not return xmlrpc response object"
872
+                            PhpXmlRpc::$xmlrpcstr['server_error'].": function does not return xmlrpc response object"
873 873
                         );
874 874
                     }
875 875
                 }
@@ -884,7 +884,7 @@  discard block
 block discarded – undo
884 884
                         $r = call_user_func_array($func, array($methodName, $params, $this->user_data));
885 885
                         // mimic EPI behaviour: if we get an array that looks like an error, make it an error response
886 886
                         if (is_array($r) && array_key_exists('faultCode', $r) && array_key_exists('faultString', $r)) {
887
-                            $r = new static::$responseClass(0, (integer)$r['faultCode'], (string)$r['faultString']);
887
+                            $r = new static::$responseClass(0, (integer) $r['faultCode'], (string) $r['faultString']);
888 888
                         } else {
889 889
                             // functions using EPI api should NOT return resp objects, so make sure we encode the
890 890
                             // return type correctly
@@ -909,7 +909,7 @@  discard block
 block discarded – undo
909 909
             // proper error-response
910 910
             switch ($exception_handling) {
911 911
                 case 2:
912
-                    if ($this->debug > 2) {
912
+                    if ($this->debug>2) {
913 913
                         if (self::$_xmlrpcs_prev_ehandler) {
914 914
                             set_error_handler(self::$_xmlrpcs_prev_ehandler);
915 915
                         } else {
@@ -932,7 +932,7 @@  discard block
 block discarded – undo
932 932
             // proper error-response
933 933
             switch ($exception_handling) {
934 934
                 case 2:
935
-                    if ($this->debug > 2) {
935
+                    if ($this->debug>2) {
936 936
                         if (self::$_xmlrpcs_prev_ehandler) {
937 937
                             set_error_handler(self::$_xmlrpcs_prev_ehandler);
938 938
                         } else {
@@ -952,7 +952,7 @@  discard block
 block discarded – undo
952 952
             }
953 953
         }
954 954
 
955
-        if ($this->debug > 2) {
955
+        if ($this->debug>2) {
956 956
             // note: restore the error handler we found before calling the user func, even if it has been changed
957 957
             // inside the func itself
958 958
             if (self::$_xmlrpcs_prev_ehandler) {
@@ -1018,7 +1018,7 @@  discard block
 block discarded – undo
1018 1018
      */
1019 1019
     protected function debugMsg($string)
1020 1020
     {
1021
-        $this->debug_info .= $string . "\n";
1021
+        $this->debug_info .= $string."\n";
1022 1022
     }
1023 1023
 
1024 1024
     /**
@@ -1309,7 +1309,7 @@  discard block
 block discarded – undo
1309 1309
                 $i++; // for error message, we count params from 1
1310 1310
                 return static::_xmlrpcs_multicall_error(new static::$responseClass(0,
1311 1311
                     PhpXmlRpc::$xmlrpcerr['incorrect_params'],
1312
-                    PhpXmlRpc::$xmlrpcstr['incorrect_params'] . ": probable xml error in param " . $i));
1312
+                    PhpXmlRpc::$xmlrpcstr['incorrect_params'].": probable xml error in param ".$i));
1313 1313
             }
1314 1314
         }
1315 1315
 
@@ -1390,7 +1390,7 @@  discard block
 block discarded – undo
1390 1390
             }
1391 1391
         } else {
1392 1392
             $numCalls = count($req);
1393
-            for ($i = 0; $i < $numCalls; $i++) {
1393
+            for ($i = 0; $i<$numCalls; $i++) {
1394 1394
                 $result[$i] = static::_xmlrpcs_multicall_do_call_phpvals($server, $req[$i]);
1395 1395
             }
1396 1396
         }
@@ -1455,12 +1455,12 @@  discard block
 block discarded – undo
1455 1455
      */
1456 1456
     protected function xml_header($charsetEncoding = '')
1457 1457
     {
1458
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
1458
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
1459 1459
 
1460 1460
         if ($charsetEncoding != '') {
1461
-            return "<?xml version=\"1.0\" encoding=\"$charsetEncoding\"?" . ">\n";
1461
+            return "<?xml version=\"1.0\" encoding=\"$charsetEncoding\"?".">\n";
1462 1462
         } else {
1463
-            return "<?xml version=\"1.0\"?" . ">\n";
1463
+            return "<?xml version=\"1.0\"?".">\n";
1464 1464
         }
1465 1465
     }
1466 1466
 
@@ -1476,7 +1476,7 @@  discard block
 block discarded – undo
1476 1476
             case self::OPT_FUNCTIONS_PARAMETERS_TYPE:
1477 1477
             case self::OPT_PHPVALS_ENCODING_OPTIONS:
1478 1478
             case self::OPT_RESPONSE_CHARSET_ENCODING:
1479
-                $this->logDeprecation('Getting property Request::' . $name . ' is deprecated');
1479
+                $this->logDeprecation('Getting property Request::'.$name.' is deprecated');
1480 1480
                 return $this->$name;
1481 1481
             case 'accepted_charset_encodings':
1482 1482
                 // manually implement the 'protected property' behaviour
@@ -1488,16 +1488,16 @@  discard block
 block discarded – undo
1488 1488
                     }
1489 1489
                 }
1490 1490
                 if ($canAccess) {
1491
-                    $this->logDeprecation('Getting property Request::' . $name . ' is deprecated');
1491
+                    $this->logDeprecation('Getting property Request::'.$name.' is deprecated');
1492 1492
                     return $this->accepted_compression;
1493 1493
                 } else {
1494
-                    trigger_error("Cannot access protected property Server::accepted_charset_encodings in " . __FILE__, E_USER_ERROR);
1494
+                    trigger_error("Cannot access protected property Server::accepted_charset_encodings in ".__FILE__, E_USER_ERROR);
1495 1495
                 }
1496 1496
                 break;
1497 1497
             default:
1498 1498
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
1499 1499
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
1500
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
1500
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
1501 1501
                 $result = null;
1502 1502
                 return $result;
1503 1503
         }
@@ -1514,7 +1514,7 @@  discard block
 block discarded – undo
1514 1514
             case self::OPT_FUNCTIONS_PARAMETERS_TYPE:
1515 1515
             case self::OPT_PHPVALS_ENCODING_OPTIONS:
1516 1516
             case self::OPT_RESPONSE_CHARSET_ENCODING:
1517
-                $this->logDeprecation('Setting property Request::' . $name . ' is deprecated');
1517
+                $this->logDeprecation('Setting property Request::'.$name.' is deprecated');
1518 1518
                 $this->$name = $value;
1519 1519
                 break;
1520 1520
             case 'accepted_charset_encodings':
@@ -1527,16 +1527,16 @@  discard block
 block discarded – undo
1527 1527
                     }
1528 1528
                 }
1529 1529
                 if ($canAccess) {
1530
-                    $this->logDeprecation('Setting property Request::' . $name . ' is deprecated');
1530
+                    $this->logDeprecation('Setting property Request::'.$name.' is deprecated');
1531 1531
                     $this->accepted_compression = $value;
1532 1532
                 } else {
1533
-                    trigger_error("Cannot access protected property Server::accepted_charset_encodings in " . __FILE__, E_USER_ERROR);
1533
+                    trigger_error("Cannot access protected property Server::accepted_charset_encodings in ".__FILE__, E_USER_ERROR);
1534 1534
                 }
1535 1535
                 break;
1536 1536
             default:
1537 1537
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
1538 1538
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
1539
-                trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
1539
+                trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
1540 1540
         }
1541 1541
     }
1542 1542
 
@@ -1551,7 +1551,7 @@  discard block
 block discarded – undo
1551 1551
             case self::OPT_FUNCTIONS_PARAMETERS_TYPE:
1552 1552
             case self::OPT_PHPVALS_ENCODING_OPTIONS:
1553 1553
             case self::OPT_RESPONSE_CHARSET_ENCODING:
1554
-                $this->logDeprecation('Checking property Request::' . $name . ' is deprecated');
1554
+                $this->logDeprecation('Checking property Request::'.$name.' is deprecated');
1555 1555
                 return isset($this->$name);
1556 1556
             case 'accepted_charset_encodings':
1557 1557
                 // manually implement the 'protected property' behaviour
@@ -1563,7 +1563,7 @@  discard block
 block discarded – undo
1563 1563
                     }
1564 1564
                 }
1565 1565
                 if ($canAccess) {
1566
-                    $this->logDeprecation('Checking property Request::' . $name . ' is deprecated');
1566
+                    $this->logDeprecation('Checking property Request::'.$name.' is deprecated');
1567 1567
                     return isset($this->accepted_compression);
1568 1568
                 }
1569 1569
                 // break through voluntarily
@@ -1583,7 +1583,7 @@  discard block
 block discarded – undo
1583 1583
             case self::OPT_FUNCTIONS_PARAMETERS_TYPE:
1584 1584
             case self::OPT_PHPVALS_ENCODING_OPTIONS:
1585 1585
             case self::OPT_RESPONSE_CHARSET_ENCODING:
1586
-                $this->logDeprecation('Unsetting property Request::' . $name . ' is deprecated');
1586
+                $this->logDeprecation('Unsetting property Request::'.$name.' is deprecated');
1587 1587
                 unset($this->$name);
1588 1588
                 break;
1589 1589
             case 'accepted_charset_encodings':
@@ -1596,16 +1596,16 @@  discard block
 block discarded – undo
1596 1596
                     }
1597 1597
                 }
1598 1598
                 if ($canAccess) {
1599
-                    $this->logDeprecation('Unsetting property Request::' . $name . ' is deprecated');
1599
+                    $this->logDeprecation('Unsetting property Request::'.$name.' is deprecated');
1600 1600
                     unset($this->accepted_compression);
1601 1601
                 } else {
1602
-                    trigger_error("Cannot access protected property Server::accepted_charset_encodings in " . __FILE__, E_USER_ERROR);
1602
+                    trigger_error("Cannot access protected property Server::accepted_charset_encodings in ".__FILE__, E_USER_ERROR);
1603 1603
                 }
1604 1604
                 break;
1605 1605
             default:
1606 1606
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
1607 1607
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
1608
-                trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
1608
+                trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
1609 1609
         }
1610 1610
     }
1611 1611
 }
Please login to merge, or discard this patch.
src/Client.php 1 patch
Spacing   +104 added lines, -104 removed lines patch added patch discarded remove patch
@@ -326,10 +326,10 @@  discard block
 block discarded – undo
326 326
             $server = $parts['host'];
327 327
             $path = isset($parts['path']) ? $parts['path'] : '';
328 328
             if (isset($parts['query'])) {
329
-                $path .= '?' . $parts['query'];
329
+                $path .= '?'.$parts['query'];
330 330
             }
331 331
             if (isset($parts['fragment'])) {
332
-                $path .= '#' . $parts['fragment'];
332
+                $path .= '#'.$parts['fragment'];
333 333
             }
334 334
             if (isset($parts['port'])) {
335 335
                 $port = $parts['port'];
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
             }
346 346
         }
347 347
         if ($path == '' || $path[0] != '/') {
348
-            $this->path = '/' . $path;
348
+            $this->path = '/'.$path;
349 349
         } else {
350 350
             $this->path = $path;
351 351
         }
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
         //$this->accepted_charset_encodings = $ch->knownCharsets();
378 378
 
379 379
         // initialize user_agent string
380
-        $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion;
380
+        $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion;
381 381
     }
382 382
 
383 383
     /**
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
      */
550 550
     public function setSSLVerifyPeer($i)
551 551
     {
552
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
552
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
553 553
 
554 554
         $this->verifypeer = $i;
555 555
         return $this;
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
      */
567 567
     public function setSSLVerifyHost($i)
568 568
     {
569
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
569
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
570 570
 
571 571
         $this->verifyhost = $i;
572 572
         return $this;
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
      */
582 582
     public function setSSLVersion($i)
583 583
     {
584
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
584
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
585 585
 
586 586
         $this->sslversion = $i;
587 587
         return $this;
@@ -646,7 +646,7 @@  discard block
 block discarded – undo
646 646
      */
647 647
     public function setRequestCompression($compMethod)
648 648
     {
649
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
649
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
650 650
 
651 651
         $this->request_compression = $compMethod;
652 652
         return $this;
@@ -696,7 +696,7 @@  discard block
 block discarded – undo
696 696
      */
697 697
     public function setCurlOptions($options)
698 698
     {
699
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
699
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
700 700
 
701 701
         $this->extracurlopts = $options;
702 702
         return $this;
@@ -709,7 +709,7 @@  discard block
 block discarded – undo
709 709
      */
710 710
     public function setUseCurl($useCurlMode)
711 711
     {
712
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
712
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
713 713
 
714 714
         $this->use_curl = $useCurlMode;
715 715
         return $this;
@@ -727,7 +727,7 @@  discard block
 block discarded – undo
727 727
      */
728 728
     public function setUserAgent($agentString)
729 729
     {
730
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
730
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
731 731
 
732 732
         $this->user_agent = $agentString;
733 733
         return $this;
@@ -758,12 +758,12 @@  discard block
 block discarded – undo
758 758
             }
759 759
         }
760 760
 
761
-        $url = $this->method . '://' . $this->server;
761
+        $url = $this->method.'://'.$this->server;
762 762
         if ($this->port == 0 || ($this->port == 80 && in_array($this->method, array('http', 'http10', 'http11', 'h2c'))) ||
763 763
             ($this->port == 443 && in_array($this->method, array('https', 'h2')))) {
764
-            return $url . $this->path;
764
+            return $url.$this->path;
765 765
         } else {
766
-            return $url . ':' . $this->port . $this->path;
766
+            return $url.':'.$this->port.$this->path;
767 767
         }
768 768
     }
769 769
 
@@ -803,7 +803,7 @@  discard block
 block discarded – undo
803 803
     public function send($req, $timeout = 0, $method = '')
804 804
     {
805 805
         if ($method !== '' || $timeout !== 0) {
806
-            $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated');
806
+            $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method ".__METHOD__.' is deprecated');
807 807
         }
808 808
 
809 809
         // if user does not specify http protocol, use native method of this client
@@ -921,7 +921,7 @@  discard block
 block discarded – undo
921 921
                     $payload = $a;
922 922
                     $encodingHdr = "Content-Encoding: gzip\r\n";
923 923
                 } else {
924
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request');
924
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request');
925 925
                 }
926 926
             } else if (function_exists('gzcompress')) {
927 927
                 $a = @gzcompress($payload);
@@ -929,14 +929,14 @@  discard block
 block discarded – undo
929 929
                     $payload = $a;
930 930
                     $encodingHdr = "Content-Encoding: deflate\r\n";
931 931
                 } else {
932
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request');
932
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request');
933 933
                 }
934 934
             } else {
935
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install');
935
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install');
936 936
             }
937 937
         } else {
938 938
             if ($opts['request_compression'] != '') {
939
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported');
939
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported');
940 940
             }
941 941
         }
942 942
 
@@ -944,16 +944,16 @@  discard block
 block discarded – undo
944 944
         $credentials = '';
945 945
         if ($opts['username'] != '') {
946 946
             if ($opts['authtype'] != 1) {
947
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0');
947
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0');
948 948
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
949
-                    PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth is supported with HTTP 1.0');
949
+                    PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth is supported with HTTP 1.0');
950 950
             }
951
-            $credentials = 'Authorization: Basic ' . base64_encode($opts['username'] . ':' . $opts['password']) . "\r\n";
951
+            $credentials = 'Authorization: Basic '.base64_encode($opts['username'].':'.$opts['password'])."\r\n";
952 952
         }
953 953
 
954 954
         $acceptedEncoding = '';
955 955
         if (is_array($opts['accepted_compression']) && count($opts['accepted_compression'])) {
956
-            $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $opts['accepted_compression']) . "\r\n";
956
+            $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $opts['accepted_compression'])."\r\n";
957 957
         }
958 958
 
959 959
         if ($port == 0) {
@@ -969,15 +969,15 @@  discard block
 block discarded – undo
969 969
             $connectPort = $opts['proxyport'];
970 970
             $transport = 'tcp';
971 971
             /// @todo check: should we not use https in some cases?
972
-            $uri = 'http://' . $server . ':' . $port . $path;
972
+            $uri = 'http://'.$server.':'.$port.$path;
973 973
             if ($opts['proxy_user'] != '') {
974 974
                 if ($opts['proxy_authtype'] != 1) {
975
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0');
975
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0');
976 976
                     return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
977
-                        PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth to proxy is supported with HTTP 1.0');
977
+                        PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth to proxy is supported with HTTP 1.0');
978 978
                 }
979
-                $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($opts['proxy_user'] . ':' .
980
-                    $opts['proxy_pass']) . "\r\n";
979
+                $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($opts['proxy_user'].':'.
980
+                    $opts['proxy_pass'])."\r\n";
981 981
             }
982 982
         } else {
983 983
             $connectServer = $server;
@@ -993,32 +993,32 @@  discard block
 block discarded – undo
993 993
             $version = '';
994 994
             foreach ($opts['cookies'] as $name => $cookie) {
995 995
                 /// @todo should we sanitize the cookie value on behalf of the user? See setCookie comments
996
-                $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";";
996
+                $cookieHeader .= ' '.$name.'='.$cookie['value'].";";
997 997
             }
998
-            $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n";
998
+            $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n";
999 999
         }
1000 1000
 
1001 1001
         // omit port if default
1002 1002
         if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) {
1003 1003
             $port = '';
1004 1004
         } else {
1005
-            $port = ':' . $port;
1006
-        }
1007
-
1008
-        $op = 'POST ' . $uri . " HTTP/1.0\r\n" .
1009
-            'User-Agent: ' . $opts['user_agent'] . "\r\n" .
1010
-            'Host: ' . $server . $port . "\r\n" .
1011
-            $credentials .
1012
-            $proxyCredentials .
1013
-            $acceptedEncoding .
1014
-            $encodingHdr .
1015
-            'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']) . "\r\n" .
1016
-            $cookieHeader .
1017
-            'Content-Type: ' . $req->getContentType() . "\r\nContent-Length: " .
1018
-            strlen($payload) . "\r\n\r\n" .
1005
+            $port = ':'.$port;
1006
+        }
1007
+
1008
+        $op = 'POST '.$uri." HTTP/1.0\r\n".
1009
+            'User-Agent: '.$opts['user_agent']."\r\n".
1010
+            'Host: '.$server.$port."\r\n".
1011
+            $credentials.
1012
+            $proxyCredentials.
1013
+            $acceptedEncoding.
1014
+            $encodingHdr.
1015
+            'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])."\r\n".
1016
+            $cookieHeader.
1017
+            'Content-Type: '.$req->getContentType()."\r\nContent-Length: ".
1018
+            strlen($payload)."\r\n\r\n".
1019 1019
             $payload;
1020 1020
 
1021
-        if ($opts['debug'] > 1) {
1021
+        if ($opts['debug']>1) {
1022 1022
             $this->getLogger()->debug("---SENDING---\n$op\n---END---");
1023 1023
         }
1024 1024
 
@@ -1044,7 +1044,7 @@  discard block
 block discarded – undo
1044 1044
 
1045 1045
             if ($opts['sslversion'] != 0) {
1046 1046
                 /// @see https://www.php.net/manual/en/function.curl-setopt.php, https://www.php.net/manual/en/migration56.openssl.php
1047
-                switch($opts['sslversion']) {
1047
+                switch ($opts['sslversion']) {
1048 1048
                     /// @todo what does this map to? 1.0-1.3?
1049 1049
                     //case 1: // TLSv1
1050 1050
                     //    break;
@@ -1068,12 +1068,12 @@  discard block
 block discarded – undo
1068 1068
                             $contextOptions['ssl']['crypto_method'] = STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT;
1069 1069
                         } else {
1070 1070
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
1071
-                                PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': TLS-1.3 only is supported with PHP 7.4 or later');
1071
+                                PhpXmlRpc::$xmlrpcerr['unsupported_option'].': TLS-1.3 only is supported with PHP 7.4 or later');
1072 1072
                         }
1073 1073
                         break;
1074 1074
                     default:
1075 1075
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'],
1076
-                            PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': Unsupported required TLS version');
1076
+                            PhpXmlRpc::$xmlrpcerr['unsupported_option'].': Unsupported required TLS version');
1077 1077
                 }
1078 1078
             }
1079 1079
         }
@@ -1086,7 +1086,7 @@  discard block
 block discarded – undo
1086 1086
 
1087 1087
         $context = stream_context_create($contextOptions);
1088 1088
 
1089
-        if ($opts['timeout'] <= 0) {
1089
+        if ($opts['timeout']<=0) {
1090 1090
             $connectTimeout = ini_get('default_socket_timeout');
1091 1091
         } else {
1092 1092
             $connectTimeout = $opts['timeout'];
@@ -1098,7 +1098,7 @@  discard block
 block discarded – undo
1098 1098
         $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout,
1099 1099
             STREAM_CLIENT_CONNECT, $context);
1100 1100
         if ($fp) {
1101
-            if ($opts['timeout'] > 0) {
1101
+            if ($opts['timeout']>0) {
1102 1102
                 stream_set_timeout($fp, $opts['timeout'], 0);
1103 1103
             }
1104 1104
         } else {
@@ -1107,8 +1107,8 @@  discard block
 block discarded – undo
1107 1107
                 $this->errstr = $err['message'];
1108 1108
             }
1109 1109
 
1110
-            $this->errstr = 'Connect error: ' . $this->errstr;
1111
-            $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')');
1110
+            $this->errstr = 'Connect error: '.$this->errstr;
1111
+            $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')');
1112 1112
 
1113 1113
             return $r;
1114 1114
         }
@@ -1175,19 +1175,19 @@  discard block
 block discarded – undo
1175 1175
             $opts['keepalive'], $opts['key'], $opts['keypass'], $opts['sslversion']);
1176 1176
 
1177 1177
         if (!$curl) {
1178
-            return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] .
1178
+            return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].
1179 1179
                 ': error during curl initialization. Check php error log for details');
1180 1180
         }
1181 1181
 
1182 1182
         $result = curl_exec($curl);
1183 1183
 
1184
-        if ($opts['debug'] > 1) {
1184
+        if ($opts['debug']>1) {
1185 1185
             $message = "---CURL INFO---\n";
1186 1186
             foreach (curl_getinfo($curl) as $name => $val) {
1187 1187
                 if (is_array($val)) {
1188 1188
                     $val = implode("\n", $val);
1189 1189
                 }
1190
-                $message .= $name . ': ' . $val . "\n";
1190
+                $message .= $name.': '.$val."\n";
1191 1191
             }
1192 1192
             $message .= '---END---';
1193 1193
             $this->getLogger()->debug($message);
@@ -1197,8 +1197,8 @@  discard block
 block discarded – undo
1197 1197
             /// @todo we should use a better check here - what if we get back '' or '0'?
1198 1198
 
1199 1199
             $this->errstr = 'no response';
1200
-            $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] .
1201
-                ': ' . curl_error($curl));
1200
+            $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].
1201
+                ': '.curl_error($curl));
1202 1202
             curl_close($curl);
1203 1203
             if ($opts['keepalive']) {
1204 1204
                 $this->xmlrpc_curl_handle = null;
@@ -1256,7 +1256,7 @@  discard block
 block discarded – undo
1256 1256
                     $payload = $a;
1257 1257
                     $encodingHdr = 'Content-Encoding: gzip';
1258 1258
                 } else {
1259
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request');
1259
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request');
1260 1260
                 }
1261 1261
             } else if (function_exists('gzcompress')) {
1262 1262
                 $a = @gzcompress($payload);
@@ -1264,14 +1264,14 @@  discard block
 block discarded – undo
1264 1264
                     $payload = $a;
1265 1265
                     $encodingHdr = 'Content-Encoding: deflate';
1266 1266
                 } else {
1267
-                    $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request');
1267
+                    $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request');
1268 1268
                 }
1269 1269
             } else {
1270
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install');
1270
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install');
1271 1271
             }
1272 1272
         } else {
1273 1273
             if ($opts['request_compression'] != '') {
1274
-                $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported');
1274
+                $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported');
1275 1275
             }
1276 1276
         }
1277 1277
 
@@ -1285,12 +1285,12 @@  discard block
 block discarded – undo
1285 1285
                     // http, https
1286 1286
                     $protocol = $method;
1287 1287
                     if (strpos($protocol, ':') !== false) {
1288
-                        $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1288
+                        $this->getLogger()->error('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'");
1289 1289
                         return false;
1290 1290
                     }
1291 1291
                 }
1292 1292
             }
1293
-            $curl = curl_init($protocol . '://' . $server . ':' . $port . $path);
1293
+            $curl = curl_init($protocol.'://'.$server.':'.$port.$path);
1294 1294
             if (!$curl) {
1295 1295
                 return false;
1296 1296
             }
@@ -1304,7 +1304,7 @@  discard block
 block discarded – undo
1304 1304
         // results into variable
1305 1305
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
1306 1306
 
1307
-        if ($opts['debug'] > 1) {
1307
+        if ($opts['debug']>1) {
1308 1308
             curl_setopt($curl, CURLOPT_VERBOSE, true);
1309 1309
             /// @todo redirect curlopt_stderr to some stream which can be piped to the logger
1310 1310
         }
@@ -1329,7 +1329,7 @@  discard block
 block discarded – undo
1329 1329
             }
1330 1330
         }
1331 1331
         // extra headers
1332
-        $headers = array('Content-Type: ' . $req->getContentType(), 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']));
1332
+        $headers = array('Content-Type: '.$req->getContentType(), 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings']));
1333 1333
         // if no keepalive is wanted, let the server know it in advance
1334 1334
         if (!$opts['keepalive']) {
1335 1335
             $headers[] = 'Connection: close';
@@ -1346,7 +1346,7 @@  discard block
 block discarded – undo
1346 1346
         curl_setopt($curl, CURLOPT_HTTPHEADER, $headers);
1347 1347
         // timeout is borked
1348 1348
         if ($opts['timeout']) {
1349
-            curl_setopt($curl, CURLOPT_TIMEOUT, $opts['timeout'] == 1 ? 1 : $opts['timeout'] - 1);
1349
+            curl_setopt($curl, CURLOPT_TIMEOUT, $opts['timeout'] == 1 ? 1 : $opts['timeout']-1);
1350 1350
         }
1351 1351
 
1352 1352
         switch ($method) {
@@ -1360,7 +1360,7 @@  discard block
 block discarded – undo
1360 1360
                 if (defined('CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE')) {
1361 1361
                     curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE);
1362 1362
                 } else {
1363
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install');
1363
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install');
1364 1364
                     curl_close($curl);
1365 1365
                     return false;
1366 1366
                 }
@@ -1371,11 +1371,11 @@  discard block
 block discarded – undo
1371 1371
         }
1372 1372
 
1373 1373
         if ($opts['username'] && $opts['password']) {
1374
-            curl_setopt($curl, CURLOPT_USERPWD, $opts['username'] . ':' . $opts['password']);
1374
+            curl_setopt($curl, CURLOPT_USERPWD, $opts['username'].':'.$opts['password']);
1375 1375
             if (defined('CURLOPT_HTTPAUTH')) {
1376 1376
                 curl_setopt($curl, CURLOPT_HTTPAUTH, $opts['authtype']);
1377 1377
             } elseif ($opts['authtype'] != 1) {
1378
-                $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install');
1378
+                $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install');
1379 1379
                 curl_close($curl);
1380 1380
                 return false;
1381 1381
             }
@@ -1420,13 +1420,13 @@  discard block
 block discarded – undo
1420 1420
             if ($opts['proxyport'] == 0) {
1421 1421
                 $opts['proxyport'] = 8080; // NB: even for HTTPS, local connection is on port 8080
1422 1422
             }
1423
-            curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'] . ':' . $opts['proxyport']);
1423
+            curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'].':'.$opts['proxyport']);
1424 1424
             if ($opts['proxy_user']) {
1425
-                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'] . ':' . $opts['proxy_pass']);
1425
+                curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'].':'.$opts['proxy_pass']);
1426 1426
                 if (defined('CURLOPT_PROXYAUTH')) {
1427 1427
                     curl_setopt($curl, CURLOPT_PROXYAUTH, $opts['proxy_authtype']);
1428 1428
                 } elseif ($opts['proxy_authtype'] != 1) {
1429
-                    $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1429
+                    $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install');
1430 1430
                     curl_close($curl);
1431 1431
                     return false;
1432 1432
                 }
@@ -1438,7 +1438,7 @@  discard block
 block discarded – undo
1438 1438
         if (count($opts['cookies'])) {
1439 1439
             $cookieHeader = '';
1440 1440
             foreach ($opts['cookies'] as $name => $cookie) {
1441
-                $cookieHeader .= $name . '=' . $cookie['value'] . '; ';
1441
+                $cookieHeader .= $name.'='.$cookie['value'].'; ';
1442 1442
             }
1443 1443
             curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2));
1444 1444
         }
@@ -1447,7 +1447,7 @@  discard block
 block discarded – undo
1447 1447
             curl_setopt($curl, $opt, $val);
1448 1448
         }
1449 1449
 
1450
-        if ($opts['debug'] > 1) {
1450
+        if ($opts['debug']>1) {
1451 1451
             $this->getLogger()->debug("---SENDING---\n$payload\n---END---");
1452 1452
         }
1453 1453
 
@@ -1548,7 +1548,7 @@  discard block
 block discarded – undo
1548 1548
             $call['methodName'] = new Value($req->method(), 'string');
1549 1549
             $numParams = $req->getNumParams();
1550 1550
             $params = array();
1551
-            for ($i = 0; $i < $numParams; $i++) {
1551
+            for ($i = 0; $i<$numParams; $i++) {
1552 1552
                 $params[$i] = $req->getParam($i);
1553 1553
             }
1554 1554
             $call['params'] = new Value($params, 'array');
@@ -1570,7 +1570,7 @@  discard block
 block discarded – undo
1570 1570
         $response = array();
1571 1571
 
1572 1572
         if ($this->return_type == 'xml') {
1573
-            for ($i = 0; $i < count($reqs); $i++) {
1573
+            for ($i = 0; $i<count($reqs); $i++) {
1574 1574
                 $response[] = new static::$responseClass($rets, 0, '', 'xml', $result->httpResponse());
1575 1575
             }
1576 1576
 
@@ -1578,21 +1578,21 @@  discard block
 block discarded – undo
1578 1578
             if (!is_array($rets)) {
1579 1579
                 // bad return type from system.multicall
1580 1580
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1581
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse());
1581
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse());
1582 1582
             }
1583 1583
             $numRets = count($rets);
1584 1584
             if ($numRets != count($reqs)) {
1585 1585
                 // wrong number of return values.
1586 1586
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1587
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals',
1587
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals',
1588 1588
                     $result->httpResponse());
1589 1589
             }
1590 1590
 
1591
-            for ($i = 0; $i < $numRets; $i++) {
1591
+            for ($i = 0; $i<$numRets; $i++) {
1592 1592
                 $val = $rets[$i];
1593 1593
                 if (!is_array($val)) {
1594 1594
                     return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1595
-                        PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1595
+                        PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1596 1596
                         'phpvals', $result->httpResponse());
1597 1597
                 }
1598 1598
                 switch (count($val)) {
@@ -1600,7 +1600,7 @@  discard block
 block discarded – undo
1600 1600
                         if (!isset($val[0])) {
1601 1601
                             // Bad value
1602 1602
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1603
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value",
1603
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value",
1604 1604
                                 'phpvals', $result->httpResponse());
1605 1605
                         }
1606 1606
                         // Normal return value
@@ -1612,20 +1612,20 @@  discard block
 block discarded – undo
1612 1612
                         if (!is_int($code)) {
1613 1613
                             /// @todo should we check that it is != 0?
1614 1614
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1615
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1615
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1616 1616
                                 'phpvals', $result->httpResponse());
1617 1617
                         }
1618 1618
                         $str = @$val['faultString'];
1619 1619
                         if (!is_string($str)) {
1620 1620
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1621
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString",
1621
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString",
1622 1622
                                 'phpvals', $result->httpResponse());
1623 1623
                         }
1624 1624
                         $response[$i] = new static::$responseClass(0, $code, $str, 'phpvals', $result->httpResponse());
1625 1625
                         break;
1626 1626
                     default:
1627 1627
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1628
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1628
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1629 1629
                             'phpvals', $result->httpResponse());
1630 1630
                 }
1631 1631
             }
@@ -1634,14 +1634,14 @@  discard block
 block discarded – undo
1634 1634
             // return type == 'xmlrpcvals'
1635 1635
             if ($rets->kindOf() != 'array') {
1636 1636
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1637
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals',
1637
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals',
1638 1638
                     $result->httpResponse());
1639 1639
             }
1640 1640
             $numRets = $rets->count();
1641 1641
             if ($numRets != count($reqs)) {
1642 1642
                 // wrong number of return values.
1643 1643
                 return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1644
-                    PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals',
1644
+                    PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals',
1645 1645
                     $result->httpResponse());
1646 1646
             }
1647 1647
 
@@ -1650,7 +1650,7 @@  discard block
 block discarded – undo
1650 1650
                     case 'array':
1651 1651
                         if ($val->count() != 1) {
1652 1652
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1653
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1653
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1654 1654
                                 'phpvals', $result->httpResponse());
1655 1655
                         }
1656 1656
                         // Normal return value
@@ -1659,28 +1659,28 @@  discard block
 block discarded – undo
1659 1659
                     case 'struct':
1660 1660
                         if ($val->count() != 2) {
1661 1661
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1662
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items",
1662
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items",
1663 1663
                                 'phpvals', $result->httpResponse());
1664 1664
                         }
1665 1665
                         /** @var Value $code */
1666 1666
                         $code = $val['faultCode'];
1667 1667
                         if ($code->kindOf() != 'scalar' || $code->scalarTyp() != 'int') {
1668 1668
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1669
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1669
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1670 1670
                                 'xmlrpcvals', $result->httpResponse());
1671 1671
                         }
1672 1672
                         /** @var Value $str */
1673 1673
                         $str = $val['faultString'];
1674 1674
                         if ($str->kindOf() != 'scalar' || $str->scalarTyp() != 'string') {
1675 1675
                             return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1676
-                                PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode",
1676
+                                PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode",
1677 1677
                                 'xmlrpcvals', $result->httpResponse());
1678 1678
                         }
1679 1679
                         $response[] = new static::$responseClass(0, $code->scalarVal(), $str->scalarVal(), 'xmlrpcvals', $result->httpResponse());
1680 1680
                         break;
1681 1681
                     default:
1682 1682
                         return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'],
1683
-                            PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct",
1683
+                            PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct",
1684 1684
                             'xmlrpcvals', $result->httpResponse());
1685 1685
                 }
1686 1686
             }
@@ -1713,7 +1713,7 @@  discard block
 block discarded – undo
1713 1713
         $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1,
1714 1714
         $method = 'http')
1715 1715
     {
1716
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
1716
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
1717 1717
 
1718 1718
         return $this->sendPayloadSocket($req, $server, $port, $timeout, $username, $password, $authType, null, null,
1719 1719
             null, null, $proxyHost, $proxyPort, $proxyUsername, $proxyPassword, $proxyAuthType, $method);
@@ -1749,7 +1749,7 @@  discard block
 block discarded – undo
1749 1749
         $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '',
1750 1750
         $sslVersion = 0)
1751 1751
     {
1752
-        $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated');
1752
+        $this->logDeprecation('Method '.__METHOD__.' is deprecated');
1753 1753
 
1754 1754
         return $this->sendPayloadCURL($req, $server, $port, $timeout, $username,
1755 1755
             $password, $authType, $cert, $certPass, $caCert, $caCertDir, $proxyHost, $proxyPort,
@@ -1962,7 +1962,7 @@  discard block
 block discarded – undo
1962 1962
     public function &__get($name)
1963 1963
     {
1964 1964
         if (in_array($name, static::$options)) {
1965
-            $this->logDeprecation('Getting property Client::' . $name . ' is deprecated');
1965
+            $this->logDeprecation('Getting property Client::'.$name.' is deprecated');
1966 1966
             return $this->$name;
1967 1967
         }
1968 1968
 
@@ -1973,12 +1973,12 @@  discard block
 block discarded – undo
1973 1973
             case 'server':
1974 1974
             case 'port':
1975 1975
             case 'path':
1976
-                $this->logDeprecation('Getting property Client::' . $name . ' is deprecated');
1976
+                $this->logDeprecation('Getting property Client::'.$name.' is deprecated');
1977 1977
                 return $this->$name;
1978 1978
             default:
1979 1979
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
1980 1980
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
1981
-                trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
1981
+                trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
1982 1982
                 $result = null;
1983 1983
                 return $result;
1984 1984
         }
@@ -1987,7 +1987,7 @@  discard block
 block discarded – undo
1987 1987
     public function __set($name, $value)
1988 1988
     {
1989 1989
         if (in_array($name, static::$options)) {
1990
-            $this->logDeprecation('Setting property Client::' . $name . ' is deprecated');
1990
+            $this->logDeprecation('Setting property Client::'.$name.' is deprecated');
1991 1991
             $this->$name = $value;
1992 1992
             return;
1993 1993
         }
@@ -1999,20 +1999,20 @@  discard block
 block discarded – undo
1999 1999
             case 'server':
2000 2000
             case 'port':
2001 2001
             case 'path':
2002
-                $this->logDeprecation('Setting property Client::' . $name . ' is deprecated');
2002
+                $this->logDeprecation('Setting property Client::'.$name.' is deprecated');
2003 2003
                 $this->$name = $value;
2004 2004
                 return;
2005 2005
             default:
2006 2006
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
2007 2007
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
2008
-                trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
2008
+                trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
2009 2009
         }
2010 2010
     }
2011 2011
 
2012 2012
     public function __isset($name)
2013 2013
     {
2014 2014
         if (in_array($name, static::$options)) {
2015
-            $this->logDeprecation('Checking property Client::' . $name . ' is deprecated');
2015
+            $this->logDeprecation('Checking property Client::'.$name.' is deprecated');
2016 2016
             return isset($this->$name);
2017 2017
         }
2018 2018
 
@@ -2023,7 +2023,7 @@  discard block
 block discarded – undo
2023 2023
             case 'server':
2024 2024
             case 'port':
2025 2025
             case 'path':
2026
-                $this->logDeprecation('Checking property Client::' . $name . ' is deprecated');
2026
+                $this->logDeprecation('Checking property Client::'.$name.' is deprecated');
2027 2027
                 return isset($this->$name);
2028 2028
             default:
2029 2029
                 return false;
@@ -2033,7 +2033,7 @@  discard block
 block discarded – undo
2033 2033
     public function __unset($name)
2034 2034
     {
2035 2035
         if (in_array($name, static::$options)) {
2036
-            $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated');
2036
+            $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated');
2037 2037
             unset($this->$name);
2038 2038
             return;
2039 2039
         }
@@ -2045,13 +2045,13 @@  discard block
 block discarded – undo
2045 2045
             case 'server':
2046 2046
             case 'port':
2047 2047
             case 'path':
2048
-                $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated');
2048
+                $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated');
2049 2049
                 unset($this->$name);
2050 2050
                 return;
2051 2051
             default:
2052 2052
                 /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout...
2053 2053
                 $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
2054
-                trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING);
2054
+                trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING);
2055 2055
         }
2056 2056
     }
2057 2057
 }
Please login to merge, or discard this patch.