@@ -251,7 +251,7 @@ discard block |
||
251 | 251 | public function getOptions() |
252 | 252 | { |
253 | 253 | $values = array(); |
254 | - foreach(static::$options as $opt) { |
|
254 | + foreach (static::$options as $opt) { |
|
255 | 255 | $values[$opt] = $this->getOption($opt); |
256 | 256 | } |
257 | 257 | return $values; |
@@ -264,7 +264,7 @@ discard block |
||
264 | 264 | */ |
265 | 265 | public function setOptions($options) |
266 | 266 | { |
267 | - foreach($options as $name => $value) { |
|
267 | + foreach ($options as $name => $value) { |
|
268 | 268 | $this->setOption($name, $value); |
269 | 269 | } |
270 | 270 | |
@@ -302,7 +302,7 @@ discard block |
||
302 | 302 | */ |
303 | 303 | public static function xmlrpc_debugmsg($msg) |
304 | 304 | { |
305 | - static::$_xmlrpc_debuginfo .= $msg . "\n"; |
|
305 | + static::$_xmlrpc_debuginfo .= $msg."\n"; |
|
306 | 306 | } |
307 | 307 | |
308 | 308 | /** |
@@ -314,7 +314,7 @@ discard block |
||
314 | 314 | */ |
315 | 315 | public static function error_occurred($msg) |
316 | 316 | { |
317 | - static::$_xmlrpcs_occurred_errors .= $msg . "\n"; |
|
317 | + static::$_xmlrpcs_occurred_errors .= $msg."\n"; |
|
318 | 318 | } |
319 | 319 | |
320 | 320 | /** |
@@ -335,10 +335,10 @@ discard block |
||
335 | 335 | // user debug info should be encoded by the end user using the INTERNAL_ENCODING |
336 | 336 | $out = ''; |
337 | 337 | if ($this->debug_info != '') { |
338 | - $out .= "<!-- SERVER DEBUG INFO (BASE64 ENCODED):\n" . base64_encode($this->debug_info) . "\n-->\n"; |
|
338 | + $out .= "<!-- SERVER DEBUG INFO (BASE64 ENCODED):\n".base64_encode($this->debug_info)."\n-->\n"; |
|
339 | 339 | } |
340 | 340 | if (static::$_xmlrpc_debuginfo != '') { |
341 | - $out .= "<!-- DEBUG INFO:\n" . $this->getCharsetEncoder()->encodeEntities(str_replace('--', '_-', static::$_xmlrpc_debuginfo), PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding) . "\n-->\n"; |
|
341 | + $out .= "<!-- DEBUG INFO:\n".$this->getCharsetEncoder()->encodeEntities(str_replace('--', '_-', static::$_xmlrpc_debuginfo), PhpXmlRpc::$xmlrpc_internalencoding, $charsetEncoding)."\n-->\n"; |
|
342 | 342 | // NB: a better solution MIGHT be to use CDATA, but we need to insert it |
343 | 343 | // into return payload AFTER the beginning tag |
344 | 344 | //$out .= "<![CDATA[ DEBUG INFO:\n\n" . str_replace(']]>', ']_]_>', static::$_xmlrpc_debuginfo) . "\n]]>\n"; |
@@ -367,8 +367,8 @@ discard block |
||
367 | 367 | $this->debug_info = ''; |
368 | 368 | |
369 | 369 | // Save what we received, before parsing it |
370 | - if ($this->debug > 1) { |
|
371 | - $this->debugMsg("+++GOT+++\n" . $data . "\n+++END+++"); |
|
370 | + if ($this->debug>1) { |
|
371 | + $this->debugMsg("+++GOT+++\n".$data."\n+++END+++"); |
|
372 | 372 | } |
373 | 373 | |
374 | 374 | $resp = $this->parseRequestHeaders($data, $reqCharset, $respCharset, $respEncoding); |
@@ -385,13 +385,13 @@ discard block |
||
385 | 385 | $resp->raw_data = $rawData; |
386 | 386 | } |
387 | 387 | |
388 | - if ($this->debug > 2 && static::$_xmlrpcs_occurred_errors != '') { |
|
389 | - $this->debugMsg("+++PROCESSING ERRORS AND WARNINGS+++\n" . |
|
390 | - static::$_xmlrpcs_occurred_errors . "+++END+++"); |
|
388 | + if ($this->debug>2 && static::$_xmlrpcs_occurred_errors != '') { |
|
389 | + $this->debugMsg("+++PROCESSING ERRORS AND WARNINGS+++\n". |
|
390 | + static::$_xmlrpcs_occurred_errors."+++END+++"); |
|
391 | 391 | } |
392 | 392 | |
393 | 393 | $header = $resp->xml_header($respCharset); |
394 | - if ($this->debug > 0) { |
|
394 | + if ($this->debug>0) { |
|
395 | 395 | $header .= $this->serializeDebug($respCharset); |
396 | 396 | } |
397 | 397 | |
@@ -402,7 +402,7 @@ discard block |
||
402 | 402 | if (empty($payload)) { |
403 | 403 | $payload = $resp->serialize($respCharset); |
404 | 404 | } |
405 | - $payload = $header . $payload; |
|
405 | + $payload = $header.$payload; |
|
406 | 406 | |
407 | 407 | if ($returnPayload) { |
408 | 408 | return $payload; |
@@ -411,7 +411,7 @@ discard block |
||
411 | 411 | // if we get a warning/error that has output some text before here, then we cannot |
412 | 412 | // add a new header. We cannot say we are sending xml, either... |
413 | 413 | if (!headers_sent()) { |
414 | - header('Content-Type: ' . $resp->getContentType()); |
|
414 | + header('Content-Type: '.$resp->getContentType()); |
|
415 | 415 | // we do not know if client actually told us an accepted charset, but if it did we have to tell it what we did |
416 | 416 | header("Vary: Accept-Charset"); |
417 | 417 | |
@@ -434,12 +434,12 @@ discard block |
||
434 | 434 | // Note that Apache/mod_php will add (and even alter!) the Content-Length header on its own, but only for |
435 | 435 | // responses up to 8000 bytes |
436 | 436 | if ($phpNoSelfCompress) { |
437 | - header('Content-Length: ' . (int)strlen($payload)); |
|
437 | + header('Content-Length: '.(int) strlen($payload)); |
|
438 | 438 | } |
439 | 439 | } else { |
440 | 440 | /// @todo allow the user to easily subclass this in a way which allows the resp. headers to be already sent |
441 | 441 | /// by now without flagging it as an error. Possibly check for presence of Content-Type header |
442 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': http headers already sent before response is fully generated. Check for php warning or error messages'); |
|
442 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': http headers already sent before response is fully generated. Check for php warning or error messages'); |
|
443 | 443 | } |
444 | 444 | |
445 | 445 | print $payload; |
@@ -528,9 +528,9 @@ discard block |
||
528 | 528 | $numParams = count($in); |
529 | 529 | } |
530 | 530 | foreach ($sigs as $curSig) { |
531 | - if (count($curSig) == $numParams + 1) { |
|
531 | + if (count($curSig) == $numParams+1) { |
|
532 | 532 | $itsOK = 1; |
533 | - for ($n = 0; $n < $numParams; $n++) { |
|
533 | + for ($n = 0; $n<$numParams; $n++) { |
|
534 | 534 | if (is_object($in)) { |
535 | 535 | $p = $in->getParam($n); |
536 | 536 | if ($p->kindOf() == 'scalar') { |
@@ -543,10 +543,10 @@ discard block |
||
543 | 543 | } |
544 | 544 | |
545 | 545 | // param index is $n+1, as first member of sig is return type |
546 | - if ($pt != $curSig[$n + 1] && $curSig[$n + 1] != Value::$xmlrpcValue) { |
|
546 | + if ($pt != $curSig[$n+1] && $curSig[$n+1] != Value::$xmlrpcValue) { |
|
547 | 547 | $itsOK = 0; |
548 | - $pno = $n + 1; |
|
549 | - $wanted = $curSig[$n + 1]; |
|
548 | + $pno = $n+1; |
|
549 | + $wanted = $curSig[$n+1]; |
|
550 | 550 | $got = $pt; |
551 | 551 | break; |
552 | 552 | } |
@@ -573,10 +573,10 @@ discard block |
||
573 | 573 | // check if $_SERVER is populated: it might have been disabled via ini file |
574 | 574 | // (this is true even when in CLI mode) |
575 | 575 | if (count($_SERVER) == 0) { |
576 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': cannot parse request headers as $_SERVER is not populated'); |
|
576 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': cannot parse request headers as $_SERVER is not populated'); |
|
577 | 577 | } |
578 | 578 | |
579 | - if ($this->debug > 1) { |
|
579 | + if ($this->debug>1) { |
|
580 | 580 | if (function_exists('getallheaders')) { |
581 | 581 | $this->debugMsg(''); // empty line |
582 | 582 | foreach (getallheaders() as $name => $val) { |
@@ -601,13 +601,13 @@ discard block |
||
601 | 601 | if (function_exists('gzinflate') && in_array($contentEncoding, $this->accepted_compression)) { |
602 | 602 | if ($contentEncoding == 'deflate' && $degzdata = @gzuncompress($data)) { |
603 | 603 | $data = $degzdata; |
604 | - if ($this->debug > 1) { |
|
605 | - $this->debugMsg("\n+++INFLATED REQUEST+++[" . strlen($data) . " chars]+++\n" . $data . "\n+++END+++"); |
|
604 | + if ($this->debug>1) { |
|
605 | + $this->debugMsg("\n+++INFLATED REQUEST+++[".strlen($data)." chars]+++\n".$data."\n+++END+++"); |
|
606 | 606 | } |
607 | 607 | } elseif ($contentEncoding == 'gzip' && $degzdata = @gzinflate(substr($data, 10))) { |
608 | 608 | $data = $degzdata; |
609 | - if ($this->debug > 1) { |
|
610 | - $this->debugMsg("+++INFLATED REQUEST+++[" . strlen($data) . " chars]+++\n" . $data . "\n+++END+++"); |
|
609 | + if ($this->debug>1) { |
|
610 | + $this->debugMsg("+++INFLATED REQUEST+++[".strlen($data)." chars]+++\n".$data."\n+++END+++"); |
|
611 | 611 | } |
612 | 612 | } else { |
613 | 613 | $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['server_decompress_fail'], |
@@ -695,7 +695,7 @@ discard block |
||
695 | 695 | if ($reqEncoding == 'ISO-8859-1') { |
696 | 696 | $data = utf8_encode($data); |
697 | 697 | } else { |
698 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': unsupported charset encoding of received request: ' . $reqEncoding); |
|
698 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': unsupported charset encoding of received request: '.$reqEncoding); |
|
699 | 699 | } |
700 | 700 | } |
701 | 701 | } |
@@ -729,7 +729,7 @@ discard block |
||
729 | 729 | preg_match('/^XML error ([0-9]+)/', $_xh['isf_reason'], $matches); |
730 | 730 | return new static::$responseClass( |
731 | 731 | 0, |
732 | - PhpXmlRpc::$xmlrpcerrxml + (int)$matches[1], |
|
732 | + PhpXmlRpc::$xmlrpcerrxml+(int) $matches[1], |
|
733 | 733 | $_xh['isf_reason']); |
734 | 734 | } elseif ($_xh['isf']) { |
735 | 735 | /// @todo separate better the various cases, as we have done in Request::parseResponse: invalid xml-rpc vs. |
@@ -737,7 +737,7 @@ discard block |
||
737 | 737 | return new static::$responseClass( |
738 | 738 | 0, |
739 | 739 | PhpXmlRpc::$xmlrpcerr['invalid_request'], |
740 | - PhpXmlRpc::$xmlrpcstr['invalid_request'] . ' ' . $_xh['isf_reason']); |
|
740 | + PhpXmlRpc::$xmlrpcstr['invalid_request'].' '.$_xh['isf_reason']); |
|
741 | 741 | } else { |
742 | 742 | // small layering violation in favor of speed and memory usage: we should allow the 'execute' method handle |
743 | 743 | // this, but in the most common scenario (xml-rpc values type server with some methods registered as phpvals) |
@@ -747,8 +747,8 @@ discard block |
||
747 | 747 | ($this->dmap[$_xh['method']]['parameters_type'] != 'xmlrpcvals') |
748 | 748 | ) |
749 | 749 | ) { |
750 | - if ($this->debug > 1) { |
|
751 | - $this->debugMsg("\n+++PARSED+++\n" . var_export($_xh['params'], true) . "\n+++END+++"); |
|
750 | + if ($this->debug>1) { |
|
751 | + $this->debugMsg("\n+++PARSED+++\n".var_export($_xh['params'], true)."\n+++END+++"); |
|
752 | 752 | } |
753 | 753 | |
754 | 754 | return $this->execute($_xh['method'], $_xh['params'], $_xh['pt']); |
@@ -756,12 +756,12 @@ discard block |
||
756 | 756 | // build a Request object with data parsed from xml and add parameters in |
757 | 757 | $req = new Request($_xh['method']); |
758 | 758 | /// @todo for more speed, we could just pass in the array to the constructor (and loose the type validation)... |
759 | - for ($i = 0; $i < count($_xh['params']); $i++) { |
|
759 | + for ($i = 0; $i<count($_xh['params']); $i++) { |
|
760 | 760 | $req->addParam($_xh['params'][$i]); |
761 | 761 | } |
762 | 762 | |
763 | - if ($this->debug > 1) { |
|
764 | - $this->debugMsg("\n+++PARSED+++\n" . var_export($req, true) . "\n+++END+++"); |
|
763 | + if ($this->debug>1) { |
|
764 | + $this->debugMsg("\n+++PARSED+++\n".var_export($req, true)."\n+++END+++"); |
|
765 | 765 | } |
766 | 766 | |
767 | 767 | return $this->execute($req); |
@@ -811,7 +811,7 @@ discard block |
||
811 | 811 | return new static::$responseClass( |
812 | 812 | 0, |
813 | 813 | PhpXmlRpc::$xmlrpcerr['incorrect_params'], |
814 | - PhpXmlRpc::$xmlrpcstr['incorrect_params'] . ": {$errStr}" |
|
814 | + PhpXmlRpc::$xmlrpcstr['incorrect_params'].": {$errStr}" |
|
815 | 815 | ); |
816 | 816 | } |
817 | 817 | } |
@@ -826,7 +826,7 @@ discard block |
||
826 | 826 | // build string representation of function 'name' |
827 | 827 | if (is_array($func)) { |
828 | 828 | if (is_object($func[0])) { |
829 | - $funcName = get_class($func[0]) . '->' . $func[1]; |
|
829 | + $funcName = get_class($func[0]).'->'.$func[1]; |
|
830 | 830 | } else { |
831 | 831 | $funcName = implode('::', $func); |
832 | 832 | } |
@@ -838,16 +838,16 @@ discard block |
||
838 | 838 | |
839 | 839 | // verify that function to be invoked is in fact callable |
840 | 840 | if (!is_callable($func)) { |
841 | - $this->getLogger()->error("XML-RPC: " . __METHOD__ . ": function '$funcName' registered as method handler is not callable"); |
|
841 | + $this->getLogger()->error("XML-RPC: ".__METHOD__.": function '$funcName' registered as method handler is not callable"); |
|
842 | 842 | return new static::$responseClass( |
843 | 843 | 0, |
844 | 844 | PhpXmlRpc::$xmlrpcerr['server_error'], |
845 | - PhpXmlRpc::$xmlrpcstr['server_error'] . ": no function matches method" |
|
845 | + PhpXmlRpc::$xmlrpcstr['server_error'].": no function matches method" |
|
846 | 846 | ); |
847 | 847 | } |
848 | 848 | |
849 | 849 | if (isset($dmap[$methodName]['exception_handling'])) { |
850 | - $exception_handling = (int)$dmap[$methodName]['exception_handling']; |
|
850 | + $exception_handling = (int) $dmap[$methodName]['exception_handling']; |
|
851 | 851 | } else { |
852 | 852 | $exception_handling = $this->exception_handling; |
853 | 853 | } |
@@ -868,14 +868,14 @@ discard block |
||
868 | 868 | $r = call_user_func($func, $req); |
869 | 869 | } |
870 | 870 | if (!is_a($r, 'PhpXmlRpc\Response')) { |
871 | - $this->getLogger()->error("XML-RPC: " . __METHOD__ . ": function '$funcName' registered as method handler does not return an xmlrpc response object but a " . gettype($r)); |
|
871 | + $this->getLogger()->error("XML-RPC: ".__METHOD__.": function '$funcName' registered as method handler does not return an xmlrpc response object but a ".gettype($r)); |
|
872 | 872 | if (is_a($r, 'PhpXmlRpc\Value')) { |
873 | 873 | $r = new static::$responseClass($r); |
874 | 874 | } else { |
875 | 875 | $r = new static::$responseClass( |
876 | 876 | 0, |
877 | 877 | PhpXmlRpc::$xmlrpcerr['server_error'], |
878 | - PhpXmlRpc::$xmlrpcstr['server_error'] . ": function does not return xmlrpc response object" |
|
878 | + PhpXmlRpc::$xmlrpcstr['server_error'].": function does not return xmlrpc response object" |
|
879 | 879 | ); |
880 | 880 | } |
881 | 881 | } |
@@ -890,7 +890,7 @@ discard block |
||
890 | 890 | $r = call_user_func_array($func, array($methodName, $params, $this->user_data)); |
891 | 891 | // mimic EPI behaviour: if we get an array that looks like an error, make it an error response |
892 | 892 | if (is_array($r) && array_key_exists('faultCode', $r) && array_key_exists('faultString', $r)) { |
893 | - $r = new static::$responseClass(0, (integer)$r['faultCode'], (string)$r['faultString']); |
|
893 | + $r = new static::$responseClass(0, (integer) $r['faultCode'], (string) $r['faultString']); |
|
894 | 894 | } else { |
895 | 895 | // functions using EPI api should NOT return resp objects, so make sure we encode the |
896 | 896 | // return type correctly |
@@ -1021,7 +1021,7 @@ discard block |
||
1021 | 1021 | */ |
1022 | 1022 | protected function debugMsg($string) |
1023 | 1023 | { |
1024 | - $this->debug_info .= $string . "\n"; |
|
1024 | + $this->debug_info .= $string."\n"; |
|
1025 | 1025 | } |
1026 | 1026 | |
1027 | 1027 | /** |
@@ -1312,7 +1312,7 @@ discard block |
||
1312 | 1312 | $i++; // for error message, we count params from 1 |
1313 | 1313 | return static::_xmlrpcs_multicall_error(new static::$responseClass(0, |
1314 | 1314 | PhpXmlRpc::$xmlrpcerr['incorrect_params'], |
1315 | - PhpXmlRpc::$xmlrpcstr['incorrect_params'] . ": probable xml error in param " . $i)); |
|
1315 | + PhpXmlRpc::$xmlrpcstr['incorrect_params'].": probable xml error in param ".$i)); |
|
1316 | 1316 | } |
1317 | 1317 | } |
1318 | 1318 | |
@@ -1393,7 +1393,7 @@ discard block |
||
1393 | 1393 | } |
1394 | 1394 | } else { |
1395 | 1395 | $numCalls = count($req); |
1396 | - for ($i = 0; $i < $numCalls; $i++) { |
|
1396 | + for ($i = 0; $i<$numCalls; $i++) { |
|
1397 | 1397 | $result[$i] = static::_xmlrpcs_multicall_do_call_phpvals($server, $req[$i]); |
1398 | 1398 | } |
1399 | 1399 | } |
@@ -1421,7 +1421,7 @@ discard block |
||
1421 | 1421 | // From PHP 8.4 the E_STRICT constant has been deprecated and will emit deprecation notices. |
1422 | 1422 | // PHP core and core extensions since PHP 8.0 and later do not emit E_STRICT notices at all. |
1423 | 1423 | // On PHP 7 series before PHP 7.4, some functions conditionally emit E_STRICT notices. |
1424 | - if (PHP_VERSION_ID >= 70400) { |
|
1424 | + if (PHP_VERSION_ID>=70400) { |
|
1425 | 1425 | static::error_occurred($errString); |
1426 | 1426 | } elseif ($errCode != E_STRICT) { |
1427 | 1427 | static::error_occurred($errString); |
@@ -1462,12 +1462,12 @@ discard block |
||
1462 | 1462 | */ |
1463 | 1463 | protected function xml_header($charsetEncoding = '') |
1464 | 1464 | { |
1465 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1465 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1466 | 1466 | |
1467 | 1467 | if ($charsetEncoding != '') { |
1468 | - return "<?xml version=\"1.0\" encoding=\"$charsetEncoding\"?" . ">\n"; |
|
1468 | + return "<?xml version=\"1.0\" encoding=\"$charsetEncoding\"?".">\n"; |
|
1469 | 1469 | } else { |
1470 | - return "<?xml version=\"1.0\"?" . ">\n"; |
|
1470 | + return "<?xml version=\"1.0\"?".">\n"; |
|
1471 | 1471 | } |
1472 | 1472 | } |
1473 | 1473 | |
@@ -1483,7 +1483,7 @@ discard block |
||
1483 | 1483 | case self::OPT_FUNCTIONS_PARAMETERS_TYPE: |
1484 | 1484 | case self::OPT_PHPVALS_ENCODING_OPTIONS: |
1485 | 1485 | case self::OPT_RESPONSE_CHARSET_ENCODING: |
1486 | - $this->logDeprecation('Getting property Request::' . $name . ' is deprecated'); |
|
1486 | + $this->logDeprecation('Getting property Request::'.$name.' is deprecated'); |
|
1487 | 1487 | return $this->$name; |
1488 | 1488 | case 'accepted_charset_encodings': |
1489 | 1489 | // manually implement the 'protected property' behaviour |
@@ -1495,16 +1495,16 @@ discard block |
||
1495 | 1495 | } |
1496 | 1496 | } |
1497 | 1497 | if ($canAccess) { |
1498 | - $this->logDeprecation('Getting property Request::' . $name . ' is deprecated'); |
|
1498 | + $this->logDeprecation('Getting property Request::'.$name.' is deprecated'); |
|
1499 | 1499 | return $this->accepted_compression; |
1500 | 1500 | } else { |
1501 | - trigger_error("Cannot access protected property Server::accepted_charset_encodings in " . __FILE__, E_USER_ERROR); |
|
1501 | + trigger_error("Cannot access protected property Server::accepted_charset_encodings in ".__FILE__, E_USER_ERROR); |
|
1502 | 1502 | } |
1503 | 1503 | break; |
1504 | 1504 | default: |
1505 | 1505 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
1506 | 1506 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
1507 | - trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
1507 | + trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
1508 | 1508 | $result = null; |
1509 | 1509 | return $result; |
1510 | 1510 | } |
@@ -1521,7 +1521,7 @@ discard block |
||
1521 | 1521 | case self::OPT_FUNCTIONS_PARAMETERS_TYPE: |
1522 | 1522 | case self::OPT_PHPVALS_ENCODING_OPTIONS: |
1523 | 1523 | case self::OPT_RESPONSE_CHARSET_ENCODING: |
1524 | - $this->logDeprecation('Setting property Request::' . $name . ' is deprecated'); |
|
1524 | + $this->logDeprecation('Setting property Request::'.$name.' is deprecated'); |
|
1525 | 1525 | $this->$name = $value; |
1526 | 1526 | break; |
1527 | 1527 | case 'accepted_charset_encodings': |
@@ -1534,16 +1534,16 @@ discard block |
||
1534 | 1534 | } |
1535 | 1535 | } |
1536 | 1536 | if ($canAccess) { |
1537 | - $this->logDeprecation('Setting property Request::' . $name . ' is deprecated'); |
|
1537 | + $this->logDeprecation('Setting property Request::'.$name.' is deprecated'); |
|
1538 | 1538 | $this->accepted_compression = $value; |
1539 | 1539 | } else { |
1540 | - trigger_error("Cannot access protected property Server::accepted_charset_encodings in " . __FILE__, E_USER_ERROR); |
|
1540 | + trigger_error("Cannot access protected property Server::accepted_charset_encodings in ".__FILE__, E_USER_ERROR); |
|
1541 | 1541 | } |
1542 | 1542 | break; |
1543 | 1543 | default: |
1544 | 1544 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
1545 | 1545 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
1546 | - trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
1546 | + trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
1547 | 1547 | } |
1548 | 1548 | } |
1549 | 1549 | |
@@ -1558,7 +1558,7 @@ discard block |
||
1558 | 1558 | case self::OPT_FUNCTIONS_PARAMETERS_TYPE: |
1559 | 1559 | case self::OPT_PHPVALS_ENCODING_OPTIONS: |
1560 | 1560 | case self::OPT_RESPONSE_CHARSET_ENCODING: |
1561 | - $this->logDeprecation('Checking property Request::' . $name . ' is deprecated'); |
|
1561 | + $this->logDeprecation('Checking property Request::'.$name.' is deprecated'); |
|
1562 | 1562 | return isset($this->$name); |
1563 | 1563 | case 'accepted_charset_encodings': |
1564 | 1564 | // manually implement the 'protected property' behaviour |
@@ -1570,7 +1570,7 @@ discard block |
||
1570 | 1570 | } |
1571 | 1571 | } |
1572 | 1572 | if ($canAccess) { |
1573 | - $this->logDeprecation('Checking property Request::' . $name . ' is deprecated'); |
|
1573 | + $this->logDeprecation('Checking property Request::'.$name.' is deprecated'); |
|
1574 | 1574 | return isset($this->accepted_compression); |
1575 | 1575 | } |
1576 | 1576 | // break through voluntarily |
@@ -1590,7 +1590,7 @@ discard block |
||
1590 | 1590 | case self::OPT_FUNCTIONS_PARAMETERS_TYPE: |
1591 | 1591 | case self::OPT_PHPVALS_ENCODING_OPTIONS: |
1592 | 1592 | case self::OPT_RESPONSE_CHARSET_ENCODING: |
1593 | - $this->logDeprecation('Unsetting property Request::' . $name . ' is deprecated'); |
|
1593 | + $this->logDeprecation('Unsetting property Request::'.$name.' is deprecated'); |
|
1594 | 1594 | unset($this->$name); |
1595 | 1595 | break; |
1596 | 1596 | case 'accepted_charset_encodings': |
@@ -1603,16 +1603,16 @@ discard block |
||
1603 | 1603 | } |
1604 | 1604 | } |
1605 | 1605 | if ($canAccess) { |
1606 | - $this->logDeprecation('Unsetting property Request::' . $name . ' is deprecated'); |
|
1606 | + $this->logDeprecation('Unsetting property Request::'.$name.' is deprecated'); |
|
1607 | 1607 | unset($this->accepted_compression); |
1608 | 1608 | } else { |
1609 | - trigger_error("Cannot access protected property Server::accepted_charset_encodings in " . __FILE__, E_USER_ERROR); |
|
1609 | + trigger_error("Cannot access protected property Server::accepted_charset_encodings in ".__FILE__, E_USER_ERROR); |
|
1610 | 1610 | } |
1611 | 1611 | break; |
1612 | 1612 | default: |
1613 | 1613 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
1614 | 1614 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
1615 | - trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
1615 | + trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
1616 | 1616 | } |
1617 | 1617 | } |
1618 | 1618 | } |
@@ -335,10 +335,10 @@ discard block |
||
335 | 335 | $server = $parts['host']; |
336 | 336 | $path = isset($parts['path']) ? $parts['path'] : ''; |
337 | 337 | if (isset($parts['query'])) { |
338 | - $path .= '?' . $parts['query']; |
|
338 | + $path .= '?'.$parts['query']; |
|
339 | 339 | } |
340 | 340 | if (isset($parts['fragment'])) { |
341 | - $path .= '#' . $parts['fragment']; |
|
341 | + $path .= '#'.$parts['fragment']; |
|
342 | 342 | } |
343 | 343 | if (isset($parts['port'])) { |
344 | 344 | $port = $parts['port']; |
@@ -354,7 +354,7 @@ discard block |
||
354 | 354 | } |
355 | 355 | } |
356 | 356 | if ($path == '' || $path[0] != '/') { |
357 | - $this->path = '/' . $path; |
|
357 | + $this->path = '/'.$path; |
|
358 | 358 | } else { |
359 | 359 | $this->path = $path; |
360 | 360 | } |
@@ -386,7 +386,7 @@ discard block |
||
386 | 386 | //$this->accepted_charset_encodings = $ch->knownCharsets(); |
387 | 387 | |
388 | 388 | // initialize user_agent string |
389 | - $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion; |
|
389 | + $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion; |
|
390 | 390 | } |
391 | 391 | |
392 | 392 | /** |
@@ -558,7 +558,7 @@ discard block |
||
558 | 558 | */ |
559 | 559 | public function setSSLVerifyPeer($i) |
560 | 560 | { |
561 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
561 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
562 | 562 | |
563 | 563 | $this->verifypeer = $i; |
564 | 564 | return $this; |
@@ -575,7 +575,7 @@ discard block |
||
575 | 575 | */ |
576 | 576 | public function setSSLVerifyHost($i) |
577 | 577 | { |
578 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
578 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
579 | 579 | |
580 | 580 | $this->verifyhost = $i; |
581 | 581 | return $this; |
@@ -590,7 +590,7 @@ discard block |
||
590 | 590 | */ |
591 | 591 | public function setSSLVersion($i) |
592 | 592 | { |
593 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
593 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
594 | 594 | |
595 | 595 | $this->sslversion = $i; |
596 | 596 | return $this; |
@@ -655,7 +655,7 @@ discard block |
||
655 | 655 | */ |
656 | 656 | public function setRequestCompression($compMethod) |
657 | 657 | { |
658 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
658 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
659 | 659 | |
660 | 660 | $this->request_compression = $compMethod; |
661 | 661 | return $this; |
@@ -705,7 +705,7 @@ discard block |
||
705 | 705 | */ |
706 | 706 | public function setCurlOptions($options) |
707 | 707 | { |
708 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
708 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
709 | 709 | |
710 | 710 | $this->extracurlopts = $options; |
711 | 711 | return $this; |
@@ -718,7 +718,7 @@ discard block |
||
718 | 718 | */ |
719 | 719 | public function setUseCurl($useCurlMode) |
720 | 720 | { |
721 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
721 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
722 | 722 | |
723 | 723 | $this->use_curl = $useCurlMode; |
724 | 724 | return $this; |
@@ -736,7 +736,7 @@ discard block |
||
736 | 736 | */ |
737 | 737 | public function setUserAgent($agentString) |
738 | 738 | { |
739 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
739 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
740 | 740 | |
741 | 741 | $this->user_agent = $agentString; |
742 | 742 | return $this; |
@@ -767,12 +767,12 @@ discard block |
||
767 | 767 | } |
768 | 768 | } |
769 | 769 | |
770 | - $url = $this->method . '://' . $this->server; |
|
770 | + $url = $this->method.'://'.$this->server; |
|
771 | 771 | if ($this->port == 0 || ($this->port == 80 && in_array($this->method, array('http', 'http10', 'http11', 'h2c'))) || |
772 | 772 | ($this->port == 443 && in_array($this->method, array('https', 'h2')))) { |
773 | - return $url . $this->path; |
|
773 | + return $url.$this->path; |
|
774 | 774 | } else { |
775 | - return $url . ':' . $this->port . $this->path; |
|
775 | + return $url.':'.$this->port.$this->path; |
|
776 | 776 | } |
777 | 777 | } |
778 | 778 | |
@@ -812,7 +812,7 @@ discard block |
||
812 | 812 | public function send($req, $timeout = 0, $method = '') |
813 | 813 | { |
814 | 814 | if ($method !== '' || $timeout !== 0) { |
815 | - $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated'); |
|
815 | + $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method ".__METHOD__.' is deprecated'); |
|
816 | 816 | } |
817 | 817 | |
818 | 818 | // if user does not specify http protocol, use native method of this client |
@@ -931,7 +931,7 @@ discard block |
||
931 | 931 | $payload = $a; |
932 | 932 | $encodingHdr = "Content-Encoding: gzip\r\n"; |
933 | 933 | } else { |
934 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request'); |
|
934 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request'); |
|
935 | 935 | } |
936 | 936 | } else if (function_exists('gzcompress')) { |
937 | 937 | $a = @gzcompress($payload); |
@@ -939,14 +939,14 @@ discard block |
||
939 | 939 | $payload = $a; |
940 | 940 | $encodingHdr = "Content-Encoding: deflate\r\n"; |
941 | 941 | } else { |
942 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request'); |
|
942 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request'); |
|
943 | 943 | } |
944 | 944 | } else { |
945 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install'); |
|
945 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install'); |
|
946 | 946 | } |
947 | 947 | } else { |
948 | 948 | if ($opts['request_compression'] != '') { |
949 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported'); |
|
949 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported'); |
|
950 | 950 | } |
951 | 951 | } |
952 | 952 | |
@@ -954,16 +954,16 @@ discard block |
||
954 | 954 | $credentials = ''; |
955 | 955 | if ($opts['username'] != '') { |
956 | 956 | if ($opts['authtype'] != 1) { |
957 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0'); |
|
957 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0'); |
|
958 | 958 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
959 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth is supported with HTTP 1.0'); |
|
959 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth is supported with HTTP 1.0'); |
|
960 | 960 | } |
961 | - $credentials = 'Authorization: Basic ' . base64_encode($opts['username'] . ':' . $opts['password']) . "\r\n"; |
|
961 | + $credentials = 'Authorization: Basic '.base64_encode($opts['username'].':'.$opts['password'])."\r\n"; |
|
962 | 962 | } |
963 | 963 | |
964 | 964 | $acceptedEncoding = ''; |
965 | 965 | if (is_array($opts['accepted_compression']) && count($opts['accepted_compression'])) { |
966 | - $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $opts['accepted_compression']) . "\r\n"; |
|
966 | + $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $opts['accepted_compression'])."\r\n"; |
|
967 | 967 | } |
968 | 968 | |
969 | 969 | if ($port == 0) { |
@@ -979,15 +979,15 @@ discard block |
||
979 | 979 | $connectPort = $opts['proxyport']; |
980 | 980 | $transport = 'tcp'; |
981 | 981 | /// @todo check: should we not use https in some cases? |
982 | - $uri = 'http://' . $server . ':' . $port . $path; |
|
982 | + $uri = 'http://'.$server.':'.$port.$path; |
|
983 | 983 | if ($opts['proxy_user'] != '') { |
984 | 984 | if ($opts['proxy_authtype'] != 1) { |
985 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0'); |
|
985 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0'); |
|
986 | 986 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
987 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth to proxy is supported with HTTP 1.0'); |
|
987 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth to proxy is supported with HTTP 1.0'); |
|
988 | 988 | } |
989 | - $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($opts['proxy_user'] . ':' . |
|
990 | - $opts['proxy_pass']) . "\r\n"; |
|
989 | + $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($opts['proxy_user'].':'. |
|
990 | + $opts['proxy_pass'])."\r\n"; |
|
991 | 991 | } |
992 | 992 | } else { |
993 | 993 | $connectServer = $server; |
@@ -1003,38 +1003,38 @@ discard block |
||
1003 | 1003 | $version = ''; |
1004 | 1004 | foreach ($opts['cookies'] as $name => $cookie) { |
1005 | 1005 | /// @todo should we sanitize the cookie value on behalf of the user? See setCookie comments |
1006 | - $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";"; |
|
1006 | + $cookieHeader .= ' '.$name.'='.$cookie['value'].";"; |
|
1007 | 1007 | } |
1008 | - $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n"; |
|
1008 | + $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n"; |
|
1009 | 1009 | } |
1010 | 1010 | |
1011 | 1011 | $extraHeaders = ''; |
1012 | 1012 | if (is_array($this->extra_headers) && $this->extra_headers) { |
1013 | - $extraHeaders = implode("\r\n", $this->extra_headers) . "\r\n"; |
|
1013 | + $extraHeaders = implode("\r\n", $this->extra_headers)."\r\n"; |
|
1014 | 1014 | } |
1015 | 1015 | |
1016 | 1016 | // omit port if default |
1017 | 1017 | if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) { |
1018 | 1018 | $port = ''; |
1019 | 1019 | } else { |
1020 | - $port = ':' . $port; |
|
1021 | - } |
|
1022 | - |
|
1023 | - $op = 'POST ' . $uri . " HTTP/1.0\r\n" . |
|
1024 | - 'User-Agent: ' . $opts['user_agent'] . "\r\n" . |
|
1025 | - 'Host: ' . $server . $port . "\r\n" . |
|
1026 | - $credentials . |
|
1027 | - $proxyCredentials . |
|
1028 | - $acceptedEncoding . |
|
1029 | - $encodingHdr . |
|
1030 | - 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']) . "\r\n" . |
|
1031 | - $cookieHeader . |
|
1032 | - 'Content-Type: ' . $req->getContentType() . "\r\n" . |
|
1033 | - $extraHeaders . |
|
1034 | - 'Content-Length: ' . strlen($payload) . "\r\n\r\n" . |
|
1020 | + $port = ':'.$port; |
|
1021 | + } |
|
1022 | + |
|
1023 | + $op = 'POST '.$uri." HTTP/1.0\r\n". |
|
1024 | + 'User-Agent: '.$opts['user_agent']."\r\n". |
|
1025 | + 'Host: '.$server.$port."\r\n". |
|
1026 | + $credentials. |
|
1027 | + $proxyCredentials. |
|
1028 | + $acceptedEncoding. |
|
1029 | + $encodingHdr. |
|
1030 | + 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])."\r\n". |
|
1031 | + $cookieHeader. |
|
1032 | + 'Content-Type: '.$req->getContentType()."\r\n". |
|
1033 | + $extraHeaders. |
|
1034 | + 'Content-Length: '.strlen($payload)."\r\n\r\n". |
|
1035 | 1035 | $payload; |
1036 | 1036 | |
1037 | - if ($opts['debug'] > 1) { |
|
1037 | + if ($opts['debug']>1) { |
|
1038 | 1038 | $this->getLogger()->debug("---SENDING---\n$op\n---END---"); |
1039 | 1039 | } |
1040 | 1040 | |
@@ -1060,7 +1060,7 @@ discard block |
||
1060 | 1060 | |
1061 | 1061 | if ($opts['sslversion'] != 0) { |
1062 | 1062 | /// @see https://www.php.net/manual/en/function.curl-setopt.php, https://www.php.net/manual/en/migration56.openssl.php |
1063 | - switch($opts['sslversion']) { |
|
1063 | + switch ($opts['sslversion']) { |
|
1064 | 1064 | /// @todo what does this map to? 1.0-1.3? |
1065 | 1065 | //case 1: // TLSv1 |
1066 | 1066 | // break; |
@@ -1084,12 +1084,12 @@ discard block |
||
1084 | 1084 | $contextOptions['ssl']['crypto_method'] = STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT; |
1085 | 1085 | } else { |
1086 | 1086 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1087 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': TLS-1.3 only is supported with PHP 7.4 or later'); |
|
1087 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': TLS-1.3 only is supported with PHP 7.4 or later'); |
|
1088 | 1088 | } |
1089 | 1089 | break; |
1090 | 1090 | default: |
1091 | 1091 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1092 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': Unsupported required TLS version'); |
|
1092 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': Unsupported required TLS version'); |
|
1093 | 1093 | } |
1094 | 1094 | } |
1095 | 1095 | } |
@@ -1102,7 +1102,7 @@ discard block |
||
1102 | 1102 | |
1103 | 1103 | $context = stream_context_create($contextOptions); |
1104 | 1104 | |
1105 | - if ($opts['timeout'] <= 0) { |
|
1105 | + if ($opts['timeout']<=0) { |
|
1106 | 1106 | $connectTimeout = ini_get('default_socket_timeout'); |
1107 | 1107 | } else { |
1108 | 1108 | $connectTimeout = $opts['timeout']; |
@@ -1114,7 +1114,7 @@ discard block |
||
1114 | 1114 | $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout, |
1115 | 1115 | STREAM_CLIENT_CONNECT, $context); |
1116 | 1116 | if ($fp) { |
1117 | - if ($opts['timeout'] > 0) { |
|
1117 | + if ($opts['timeout']>0) { |
|
1118 | 1118 | stream_set_timeout($fp, $opts['timeout'], 0); |
1119 | 1119 | } |
1120 | 1120 | } else { |
@@ -1123,8 +1123,8 @@ discard block |
||
1123 | 1123 | $this->errstr = $err['message']; |
1124 | 1124 | } |
1125 | 1125 | |
1126 | - $this->errstr = 'Connect error: ' . $this->errstr; |
|
1127 | - return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')'); |
|
1126 | + $this->errstr = 'Connect error: '.$this->errstr; |
|
1127 | + return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')'); |
|
1128 | 1128 | } |
1129 | 1129 | |
1130 | 1130 | if (!fputs($fp, $op, strlen($op))) { |
@@ -1204,19 +1204,19 @@ discard block |
||
1204 | 1204 | $opts['keepalive'], $opts['key'], $opts['keypass'], $opts['sslversion']); |
1205 | 1205 | |
1206 | 1206 | if (!$curl) { |
1207 | - return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . |
|
1207 | + return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail']. |
|
1208 | 1208 | ': error during curl initialization. Check php error log for details'); |
1209 | 1209 | } |
1210 | 1210 | |
1211 | 1211 | $result = curl_exec($curl); |
1212 | 1212 | |
1213 | - if ($opts['debug'] > 1) { |
|
1213 | + if ($opts['debug']>1) { |
|
1214 | 1214 | $message = "---CURL INFO---\n"; |
1215 | 1215 | foreach (curl_getinfo($curl) as $name => $val) { |
1216 | 1216 | if (is_array($val)) { |
1217 | 1217 | $val = implode("\n", $val); |
1218 | 1218 | } |
1219 | - $message .= $name . ': ' . $val . "\n"; |
|
1219 | + $message .= $name.': '.$val."\n"; |
|
1220 | 1220 | } |
1221 | 1221 | $message .= '---END---'; |
1222 | 1222 | $this->getLogger()->debug($message); |
@@ -1226,8 +1226,8 @@ discard block |
||
1226 | 1226 | /// @todo we should use a better check here - what if we get back '' or '0'? |
1227 | 1227 | |
1228 | 1228 | $this->errstr = 'no response'; |
1229 | - $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . |
|
1230 | - ': ' . curl_error($curl)); |
|
1229 | + $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail']. |
|
1230 | + ': '.curl_error($curl)); |
|
1231 | 1231 | curl_close($curl); |
1232 | 1232 | if ($opts['keepalive']) { |
1233 | 1233 | $this->xmlrpc_curl_handle = null; |
@@ -1285,7 +1285,7 @@ discard block |
||
1285 | 1285 | $payload = $a; |
1286 | 1286 | $encodingHdr = 'Content-Encoding: gzip'; |
1287 | 1287 | } else { |
1288 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request'); |
|
1288 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request'); |
|
1289 | 1289 | } |
1290 | 1290 | } else if (function_exists('gzcompress')) { |
1291 | 1291 | $a = @gzcompress($payload); |
@@ -1293,14 +1293,14 @@ discard block |
||
1293 | 1293 | $payload = $a; |
1294 | 1294 | $encodingHdr = 'Content-Encoding: deflate'; |
1295 | 1295 | } else { |
1296 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request'); |
|
1296 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request'); |
|
1297 | 1297 | } |
1298 | 1298 | } else { |
1299 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install'); |
|
1299 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install'); |
|
1300 | 1300 | } |
1301 | 1301 | } else { |
1302 | 1302 | if ($opts['request_compression'] != '') { |
1303 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported'); |
|
1303 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported'); |
|
1304 | 1304 | } |
1305 | 1305 | } |
1306 | 1306 | |
@@ -1314,12 +1314,12 @@ discard block |
||
1314 | 1314 | // http, https |
1315 | 1315 | $protocol = $method; |
1316 | 1316 | if (strpos($protocol, ':') !== false) { |
1317 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'"); |
|
1317 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'"); |
|
1318 | 1318 | return false; |
1319 | 1319 | } |
1320 | 1320 | } |
1321 | 1321 | } |
1322 | - $curl = curl_init($protocol . '://' . $server . ':' . $port . $path); |
|
1322 | + $curl = curl_init($protocol.'://'.$server.':'.$port.$path); |
|
1323 | 1323 | if (!$curl) { |
1324 | 1324 | return false; |
1325 | 1325 | } |
@@ -1333,7 +1333,7 @@ discard block |
||
1333 | 1333 | // results into variable |
1334 | 1334 | curl_setopt($curl, CURLOPT_RETURNTRANSFER, true); |
1335 | 1335 | |
1336 | - if ($opts['debug'] > 1) { |
|
1336 | + if ($opts['debug']>1) { |
|
1337 | 1337 | curl_setopt($curl, CURLOPT_VERBOSE, true); |
1338 | 1338 | /// @todo redirect curlopt_stderr to some stream which can be piped to the logger |
1339 | 1339 | } |
@@ -1358,7 +1358,7 @@ discard block |
||
1358 | 1358 | } |
1359 | 1359 | } |
1360 | 1360 | // extra headers |
1361 | - $headers = array('Content-Type: ' . $req->getContentType(), 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings'])); |
|
1361 | + $headers = array('Content-Type: '.$req->getContentType(), 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])); |
|
1362 | 1362 | // if no keepalive is wanted, let the server know it in advance |
1363 | 1363 | if (!$opts['keepalive']) { |
1364 | 1364 | $headers[] = 'Connection: close'; |
@@ -1394,7 +1394,7 @@ discard block |
||
1394 | 1394 | if (defined('CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE')) { |
1395 | 1395 | curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE); |
1396 | 1396 | } else { |
1397 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install'); |
|
1397 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install'); |
|
1398 | 1398 | curl_close($curl); |
1399 | 1399 | return false; |
1400 | 1400 | } |
@@ -1405,11 +1405,11 @@ discard block |
||
1405 | 1405 | } |
1406 | 1406 | |
1407 | 1407 | if ($opts['username'] && $opts['password']) { |
1408 | - curl_setopt($curl, CURLOPT_USERPWD, $opts['username'] . ':' . $opts['password']); |
|
1408 | + curl_setopt($curl, CURLOPT_USERPWD, $opts['username'].':'.$opts['password']); |
|
1409 | 1409 | if (defined('CURLOPT_HTTPAUTH')) { |
1410 | 1410 | curl_setopt($curl, CURLOPT_HTTPAUTH, $opts['authtype']); |
1411 | 1411 | } elseif ($opts['authtype'] != 1) { |
1412 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install'); |
|
1412 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install'); |
|
1413 | 1413 | curl_close($curl); |
1414 | 1414 | return false; |
1415 | 1415 | } |
@@ -1454,13 +1454,13 @@ discard block |
||
1454 | 1454 | if ($opts['proxyport'] == 0) { |
1455 | 1455 | $opts['proxyport'] = 8080; // NB: even for HTTPS, local connection is on port 8080 |
1456 | 1456 | } |
1457 | - curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'] . ':' . $opts['proxyport']); |
|
1457 | + curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'].':'.$opts['proxyport']); |
|
1458 | 1458 | if ($opts['proxy_user']) { |
1459 | - curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'] . ':' . $opts['proxy_pass']); |
|
1459 | + curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'].':'.$opts['proxy_pass']); |
|
1460 | 1460 | if (defined('CURLOPT_PROXYAUTH')) { |
1461 | 1461 | curl_setopt($curl, CURLOPT_PROXYAUTH, $opts['proxy_authtype']); |
1462 | 1462 | } elseif ($opts['proxy_authtype'] != 1) { |
1463 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install'); |
|
1463 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install'); |
|
1464 | 1464 | curl_close($curl); |
1465 | 1465 | return false; |
1466 | 1466 | } |
@@ -1472,7 +1472,7 @@ discard block |
||
1472 | 1472 | if (count($opts['cookies'])) { |
1473 | 1473 | $cookieHeader = ''; |
1474 | 1474 | foreach ($opts['cookies'] as $name => $cookie) { |
1475 | - $cookieHeader .= $name . '=' . $cookie['value'] . '; '; |
|
1475 | + $cookieHeader .= $name.'='.$cookie['value'].'; '; |
|
1476 | 1476 | } |
1477 | 1477 | curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2)); |
1478 | 1478 | } |
@@ -1481,7 +1481,7 @@ discard block |
||
1481 | 1481 | curl_setopt($curl, $opt, $val); |
1482 | 1482 | } |
1483 | 1483 | |
1484 | - if ($opts['debug'] > 1) { |
|
1484 | + if ($opts['debug']>1) { |
|
1485 | 1485 | $this->getLogger()->debug("---SENDING---\n$payload\n---END---"); |
1486 | 1486 | } |
1487 | 1487 | |
@@ -1582,7 +1582,7 @@ discard block |
||
1582 | 1582 | $call['methodName'] = new Value($req->method(), 'string'); |
1583 | 1583 | $numParams = $req->getNumParams(); |
1584 | 1584 | $params = array(); |
1585 | - for ($i = 0; $i < $numParams; $i++) { |
|
1585 | + for ($i = 0; $i<$numParams; $i++) { |
|
1586 | 1586 | $params[$i] = $req->getParam($i); |
1587 | 1587 | } |
1588 | 1588 | $call['params'] = new Value($params, 'array'); |
@@ -1604,7 +1604,7 @@ discard block |
||
1604 | 1604 | $response = array(); |
1605 | 1605 | |
1606 | 1606 | if ($this->return_type == 'xml') { |
1607 | - for ($i = 0; $i < count($reqs); $i++) { |
|
1607 | + for ($i = 0; $i<count($reqs); $i++) { |
|
1608 | 1608 | $response[] = new static::$responseClass($rets, 0, '', 'xml', $result->httpResponse()); |
1609 | 1609 | } |
1610 | 1610 | |
@@ -1612,21 +1612,21 @@ discard block |
||
1612 | 1612 | if (!is_array($rets)) { |
1613 | 1613 | // bad return type from system.multicall |
1614 | 1614 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1615 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse()); |
|
1615 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse()); |
|
1616 | 1616 | } |
1617 | 1617 | $numRets = count($rets); |
1618 | 1618 | if ($numRets != count($reqs)) { |
1619 | 1619 | // wrong number of return values. |
1620 | 1620 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1621 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals', |
|
1621 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals', |
|
1622 | 1622 | $result->httpResponse()); |
1623 | 1623 | } |
1624 | 1624 | |
1625 | - for ($i = 0; $i < $numRets; $i++) { |
|
1625 | + for ($i = 0; $i<$numRets; $i++) { |
|
1626 | 1626 | $val = $rets[$i]; |
1627 | 1627 | if (!is_array($val)) { |
1628 | 1628 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1629 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct", |
|
1629 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct", |
|
1630 | 1630 | 'phpvals', $result->httpResponse()); |
1631 | 1631 | } |
1632 | 1632 | switch (count($val)) { |
@@ -1634,7 +1634,7 @@ discard block |
||
1634 | 1634 | if (!isset($val[0])) { |
1635 | 1635 | // Bad value |
1636 | 1636 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1637 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value", |
|
1637 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value", |
|
1638 | 1638 | 'phpvals', $result->httpResponse()); |
1639 | 1639 | } |
1640 | 1640 | // Normal return value |
@@ -1646,20 +1646,20 @@ discard block |
||
1646 | 1646 | if (!is_int($code)) { |
1647 | 1647 | /// @todo should we check that it is != 0? |
1648 | 1648 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1649 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1649 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1650 | 1650 | 'phpvals', $result->httpResponse()); |
1651 | 1651 | } |
1652 | 1652 | $str = @$val['faultString']; |
1653 | 1653 | if (!is_string($str)) { |
1654 | 1654 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1655 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString", |
|
1655 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString", |
|
1656 | 1656 | 'phpvals', $result->httpResponse()); |
1657 | 1657 | } |
1658 | 1658 | $response[$i] = new static::$responseClass(0, $code, $str, 'phpvals', $result->httpResponse()); |
1659 | 1659 | break; |
1660 | 1660 | default: |
1661 | 1661 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1662 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1662 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1663 | 1663 | 'phpvals', $result->httpResponse()); |
1664 | 1664 | } |
1665 | 1665 | } |
@@ -1668,14 +1668,14 @@ discard block |
||
1668 | 1668 | // return type == 'xmlrpcvals' |
1669 | 1669 | if ($rets->kindOf() != 'array') { |
1670 | 1670 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1671 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals', |
|
1671 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals', |
|
1672 | 1672 | $result->httpResponse()); |
1673 | 1673 | } |
1674 | 1674 | $numRets = $rets->count(); |
1675 | 1675 | if ($numRets != count($reqs)) { |
1676 | 1676 | // wrong number of return values. |
1677 | 1677 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1678 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals', |
|
1678 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals', |
|
1679 | 1679 | $result->httpResponse()); |
1680 | 1680 | } |
1681 | 1681 | |
@@ -1684,7 +1684,7 @@ discard block |
||
1684 | 1684 | case 'array': |
1685 | 1685 | if ($val->count() != 1) { |
1686 | 1686 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1687 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1687 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1688 | 1688 | 'phpvals', $result->httpResponse()); |
1689 | 1689 | } |
1690 | 1690 | // Normal return value |
@@ -1693,28 +1693,28 @@ discard block |
||
1693 | 1693 | case 'struct': |
1694 | 1694 | if ($val->count() != 2) { |
1695 | 1695 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1696 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1696 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1697 | 1697 | 'phpvals', $result->httpResponse()); |
1698 | 1698 | } |
1699 | 1699 | /** @var Value $code */ |
1700 | 1700 | $code = $val['faultCode']; |
1701 | 1701 | if ($code->kindOf() != 'scalar' || $code->scalarTyp() != 'int') { |
1702 | 1702 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1703 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1703 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1704 | 1704 | 'xmlrpcvals', $result->httpResponse()); |
1705 | 1705 | } |
1706 | 1706 | /** @var Value $str */ |
1707 | 1707 | $str = $val['faultString']; |
1708 | 1708 | if ($str->kindOf() != 'scalar' || $str->scalarTyp() != 'string') { |
1709 | 1709 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1710 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1710 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1711 | 1711 | 'xmlrpcvals', $result->httpResponse()); |
1712 | 1712 | } |
1713 | 1713 | $response[] = new static::$responseClass(0, $code->scalarVal(), $str->scalarVal(), 'xmlrpcvals', $result->httpResponse()); |
1714 | 1714 | break; |
1715 | 1715 | default: |
1716 | 1716 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1717 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct", |
|
1717 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct", |
|
1718 | 1718 | 'xmlrpcvals', $result->httpResponse()); |
1719 | 1719 | } |
1720 | 1720 | } |
@@ -1747,7 +1747,7 @@ discard block |
||
1747 | 1747 | $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, |
1748 | 1748 | $method = 'http') |
1749 | 1749 | { |
1750 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1750 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1751 | 1751 | |
1752 | 1752 | return $this->sendPayloadSocket($req, $server, $port, $timeout, $username, $password, $authType, null, null, |
1753 | 1753 | null, null, $proxyHost, $proxyPort, $proxyUsername, $proxyPassword, $proxyAuthType, $method); |
@@ -1783,7 +1783,7 @@ discard block |
||
1783 | 1783 | $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '', |
1784 | 1784 | $sslVersion = 0) |
1785 | 1785 | { |
1786 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1786 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1787 | 1787 | |
1788 | 1788 | return $this->sendPayloadCURL($req, $server, $port, $timeout, $username, |
1789 | 1789 | $password, $authType, $cert, $certPass, $caCert, $caCertDir, $proxyHost, $proxyPort, |
@@ -1996,7 +1996,7 @@ discard block |
||
1996 | 1996 | public function &__get($name) |
1997 | 1997 | { |
1998 | 1998 | if (in_array($name, static::$options)) { |
1999 | - $this->logDeprecation('Getting property Client::' . $name . ' is deprecated'); |
|
1999 | + $this->logDeprecation('Getting property Client::'.$name.' is deprecated'); |
|
2000 | 2000 | return $this->$name; |
2001 | 2001 | } |
2002 | 2002 | |
@@ -2007,12 +2007,12 @@ discard block |
||
2007 | 2007 | case 'server': |
2008 | 2008 | case 'port': |
2009 | 2009 | case 'path': |
2010 | - $this->logDeprecation('Getting property Client::' . $name . ' is deprecated'); |
|
2010 | + $this->logDeprecation('Getting property Client::'.$name.' is deprecated'); |
|
2011 | 2011 | return $this->$name; |
2012 | 2012 | default: |
2013 | 2013 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2014 | 2014 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2015 | - trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2015 | + trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2016 | 2016 | $result = null; |
2017 | 2017 | return $result; |
2018 | 2018 | } |
@@ -2021,7 +2021,7 @@ discard block |
||
2021 | 2021 | public function __set($name, $value) |
2022 | 2022 | { |
2023 | 2023 | if (in_array($name, static::$options)) { |
2024 | - $this->logDeprecation('Setting property Client::' . $name . ' is deprecated'); |
|
2024 | + $this->logDeprecation('Setting property Client::'.$name.' is deprecated'); |
|
2025 | 2025 | $this->$name = $value; |
2026 | 2026 | return; |
2027 | 2027 | } |
@@ -2033,20 +2033,20 @@ discard block |
||
2033 | 2033 | case 'server': |
2034 | 2034 | case 'port': |
2035 | 2035 | case 'path': |
2036 | - $this->logDeprecation('Setting property Client::' . $name . ' is deprecated'); |
|
2036 | + $this->logDeprecation('Setting property Client::'.$name.' is deprecated'); |
|
2037 | 2037 | $this->$name = $value; |
2038 | 2038 | return; |
2039 | 2039 | default: |
2040 | 2040 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2041 | 2041 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2042 | - trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2042 | + trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2043 | 2043 | } |
2044 | 2044 | } |
2045 | 2045 | |
2046 | 2046 | public function __isset($name) |
2047 | 2047 | { |
2048 | 2048 | if (in_array($name, static::$options)) { |
2049 | - $this->logDeprecation('Checking property Client::' . $name . ' is deprecated'); |
|
2049 | + $this->logDeprecation('Checking property Client::'.$name.' is deprecated'); |
|
2050 | 2050 | return isset($this->$name); |
2051 | 2051 | } |
2052 | 2052 | |
@@ -2057,7 +2057,7 @@ discard block |
||
2057 | 2057 | case 'server': |
2058 | 2058 | case 'port': |
2059 | 2059 | case 'path': |
2060 | - $this->logDeprecation('Checking property Client::' . $name . ' is deprecated'); |
|
2060 | + $this->logDeprecation('Checking property Client::'.$name.' is deprecated'); |
|
2061 | 2061 | return isset($this->$name); |
2062 | 2062 | default: |
2063 | 2063 | return false; |
@@ -2067,7 +2067,7 @@ discard block |
||
2067 | 2067 | public function __unset($name) |
2068 | 2068 | { |
2069 | 2069 | if (in_array($name, static::$options)) { |
2070 | - $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated'); |
|
2070 | + $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated'); |
|
2071 | 2071 | unset($this->$name); |
2072 | 2072 | return; |
2073 | 2073 | } |
@@ -2079,13 +2079,13 @@ discard block |
||
2079 | 2079 | case 'server': |
2080 | 2080 | case 'port': |
2081 | 2081 | case 'path': |
2082 | - $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated'); |
|
2082 | + $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated'); |
|
2083 | 2083 | unset($this->$name); |
2084 | 2084 | return; |
2085 | 2085 | default: |
2086 | 2086 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2087 | 2087 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2088 | - trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2088 | + trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2089 | 2089 | } |
2090 | 2090 | } |
2091 | 2091 | } |
@@ -24,7 +24,7 @@ |
||
24 | 24 | } |
25 | 25 | } |
26 | 26 | |
27 | -require_once __DIR__ . "/_prepend.php"; |
|
27 | +require_once __DIR__."/_prepend.php"; |
|
28 | 28 | |
29 | 29 | use PhpXmlRpc\PhpXmlRpc; |
30 | 30 | use PhpXmlRpc\Server; |
@@ -10,8 +10,8 @@ |
||
10 | 10 | // That is generally a good idea security-wise, but you might want to allow it in case of specific needs. |
11 | 11 | // Look at the code in demo/server.php for an example of how to enable that. |
12 | 12 | |
13 | -require_once __DIR__ . "/../../lib/xmlrpc.inc"; |
|
14 | -require_once __DIR__ . "/../../lib/xmlrpcs.inc"; |
|
13 | +require_once __DIR__."/../../lib/xmlrpc.inc"; |
|
14 | +require_once __DIR__."/../../lib/xmlrpcs.inc"; |
|
15 | 15 | |
16 | 16 | $signatures1 = include(__DIR__.'/methodProviders/functions.php'); |
17 | 17 | $signatures2 = include(__DIR__.'/methodProviders/interop.php'); |
@@ -43,7 +43,7 @@ discard block |
||
43 | 43 | $headers['Authorization'] = $_SERVER['REDIRECT_HTTP_AUTHORIZATION']; |
44 | 44 | } elseif (isset($_SERVER['PHP_AUTH_USER'])) { |
45 | 45 | $basic_pass = isset($_SERVER['PHP_AUTH_PW']) ? $_SERVER['PHP_AUTH_PW'] : ''; |
46 | - $headers['Authorization'] = 'Basic ' . base64_encode($_SERVER['PHP_AUTH_USER'] . ':' . $basic_pass); |
|
46 | + $headers['Authorization'] = 'Basic '.base64_encode($_SERVER['PHP_AUTH_USER'].':'.$basic_pass); |
|
47 | 47 | } elseif (isset($_SERVER['PHP_AUTH_DIGEST'])) { |
48 | 48 | $headers['Authorization'] = $_SERVER['PHP_AUTH_DIGEST']; |
49 | 49 | } |
@@ -97,7 +97,7 @@ discard block |
||
97 | 97 | $sleep_sig = array(array(Value::$xmlrpcInt, Value::$xmlrpcInt)); |
98 | 98 | $sleep_doc = 'Sleeps for the requested number of seconds (between 1 and 60), before sending back the response'; |
99 | 99 | function sleepSeconds($secs) { |
100 | - if ($secs > 0 && $secs < 61) { |
|
100 | + if ($secs>0 && $secs<61) { |
|
101 | 101 | sleep($secs); |
102 | 102 | } |
103 | 103 | return $secs; |
@@ -123,7 +123,7 @@ discard block |
||
123 | 123 | |
124 | 124 | // Greek word 'kosme'. NB: NOT a valid ISO8859 string! |
125 | 125 | // NB: we can only register this when setting internal encoding to UTF-8, or it will break system.listMethods |
126 | - "tests.utf8methodname." . 'κόσμε' => array( |
|
126 | + "tests.utf8methodname.".'κόσμε' => array( |
|
127 | 127 | "function" => "exampleMethods::stringEcho", |
128 | 128 | "signature" => exampleMethods::$stringecho_sig, |
129 | 129 | "docstring" => exampleMethods::$stringecho_doc, |
@@ -88,11 +88,12 @@ |
||
88 | 88 | $a = $req->getParam(0); |
89 | 89 | $b = $req->getParam(1); |
90 | 90 | |
91 | - if ($a->scalarTyp() == Value::$xmlrpcNull) |
|
92 | - return new Response(new Value(plain_findstate($b->scalarVal()))); |
|
93 | - else |
|
94 | - return new Response(new Value(plain_findstate($a->scalarVal()))); |
|
95 | -} |
|
91 | + if ($a->scalarTyp() == Value::$xmlrpcNull) { |
|
92 | + return new Response(new Value(plain_findstate($b->scalarVal()))); |
|
93 | + } else { |
|
94 | + return new Response(new Value(plain_findstate($a->scalarVal()))); |
|
95 | + } |
|
96 | + } |
|
96 | 97 | |
97 | 98 | $sleep_sig = array(array(Value::$xmlrpcInt, Value::$xmlrpcInt)); |
98 | 99 | $sleep_doc = 'Sleeps for the requested number of seconds (between 1 and 60), before sending back the response'; |
@@ -1,8 +1,8 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -include_once __DIR__ . '/../lib/xmlrpc_wrappers.inc'; |
|
3 | +include_once __DIR__.'/../lib/xmlrpc_wrappers.inc'; |
|
4 | 4 | |
5 | -include_once __DIR__ . '/ServerAwareTestCase.php'; |
|
5 | +include_once __DIR__.'/ServerAwareTestCase.php'; |
|
6 | 6 | |
7 | 7 | /** |
8 | 8 | * Tests which involve interaction with the server - carried out via the client. |
@@ -30,7 +30,7 @@ discard block |
||
30 | 30 | // (but only if not called from subclass objects / multitests) |
31 | 31 | if (function_exists('debug_backtrace') && strtolower(get_called_class()) == 'servertest') { |
32 | 32 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS); |
33 | - for ($i = 0; $i < count($trace); $i++) { |
|
33 | + for ($i = 0; $i<count($trace); $i++) { |
|
34 | 34 | if (strpos($trace[$i]['function'], 'test') === 0) { |
35 | 35 | self::$failed_tests[$trace[$i]['function']] = true; |
36 | 36 | break; |
@@ -79,9 +79,9 @@ discard block |
||
79 | 79 | } |
80 | 80 | $this->validateResponse($r); |
81 | 81 | if (is_array($errorCode)) { |
82 | - $this->assertContains($r->faultCode(), $errorCode, 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString()); |
|
82 | + $this->assertContains($r->faultCode(), $errorCode, 'Error '.$r->faultCode().' connecting to server: '.$r->faultString()); |
|
83 | 83 | } else { |
84 | - $this->assertEquals($errorCode, $r->faultCode(), 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString()); |
|
84 | + $this->assertEquals($errorCode, $r->faultCode(), 'Error '.$r->faultCode().' connecting to server: '.$r->faultString()); |
|
85 | 85 | } |
86 | 86 | if (!$r->faultCode()) { |
87 | 87 | if ($returnResponse) { |
@@ -108,20 +108,20 @@ discard block |
||
108 | 108 | $query = parse_url($this->client->path, PHP_URL_QUERY); |
109 | 109 | parse_str($query, $vars); |
110 | 110 | $query = http_build_query(array_merge($vars, $data)); |
111 | - $this->client->path = parse_url($this->client->path, PHP_URL_PATH) . '?' . $query; |
|
111 | + $this->client->path = parse_url($this->client->path, PHP_URL_PATH).'?'.$query; |
|
112 | 112 | } |
113 | 113 | |
114 | 114 | public function testString() |
115 | 115 | { |
116 | - $sendString = "here are 3 \"entities\": < > & " . |
|
117 | - "and here's a dollar sign: \$pretendvarname and a backslash too: " . chr(92) . |
|
118 | - " - isn't that great? \\\"hackery\\\" at it's best " . |
|
119 | - " also don't want to miss out on \$item[0]. " . |
|
120 | - "The real weird stuff follows: CRLF here" . chr(13) . chr(10) . |
|
121 | - "a simple CR here" . chr(13) . |
|
122 | - "a simple LF here" . chr(10) . |
|
123 | - "and then LFCR" . chr(10) . chr(13) . |
|
124 | - "last but not least weird names: G" . chr(252) . "nter, El" . chr(232) . "ne, and an xml comment closing tag: -->"; |
|
116 | + $sendString = "here are 3 \"entities\": < > & ". |
|
117 | + "and here's a dollar sign: \$pretendvarname and a backslash too: ".chr(92). |
|
118 | + " - isn't that great? \\\"hackery\\\" at it's best ". |
|
119 | + " also don't want to miss out on \$item[0]. ". |
|
120 | + "The real weird stuff follows: CRLF here".chr(13).chr(10). |
|
121 | + "a simple CR here".chr(13). |
|
122 | + "a simple LF here".chr(10). |
|
123 | + "and then LFCR".chr(10).chr(13). |
|
124 | + "last but not least weird names: G".chr(252)."nter, El".chr(232)."ne, and an xml comment closing tag: -->"; |
|
125 | 125 | $m = new xmlrpcmsg('examples.stringecho', array( |
126 | 126 | new xmlrpcval($sendString, 'string'), |
127 | 127 | )); |
@@ -142,7 +142,7 @@ discard block |
||
142 | 142 | public function testLatin1String() |
143 | 143 | { |
144 | 144 | $sendString = |
145 | - "last but not least weird names: G" . chr(252) . "nter, El" . chr(232) . "ne"; |
|
145 | + "last but not least weird names: G".chr(252)."nter, El".chr(232)."ne"; |
|
146 | 146 | $x = '<?xml version="1.0" encoding="ISO-8859-1"?><methodCall><methodName>examples.stringecho</methodName><params><param><value>'. |
147 | 147 | $sendString. |
148 | 148 | '</value></param></params></methodCall>'; |
@@ -251,7 +251,7 @@ discard block |
||
251 | 251 | public function testUtf8Method() |
252 | 252 | { |
253 | 253 | PhpXmlRpc\PhpXmlRpc::$xmlrpc_internalencoding = 'UTF-8'; |
254 | - $m = new xmlrpcmsg("tests.utf8methodname." . 'κόσμε', array( |
|
254 | + $m = new xmlrpcmsg("tests.utf8methodname.".'κόσμε', array( |
|
255 | 255 | new xmlrpcval('hello') |
256 | 256 | )); |
257 | 257 | $v = $this->send($m); |
@@ -272,7 +272,7 @@ discard block |
||
272 | 272 | )); |
273 | 273 | $v = $this->send($m); |
274 | 274 | if ($v) { |
275 | - $this->assertEquals($a + $b, $v->scalarval()); |
|
275 | + $this->assertEquals($a+$b, $v->scalarval()); |
|
276 | 276 | } |
277 | 277 | } |
278 | 278 | |
@@ -284,7 +284,7 @@ discard block |
||
284 | 284 | )); |
285 | 285 | $v = $this->send($m); |
286 | 286 | if ($v) { |
287 | - $this->assertEquals(12 - 23, $v->scalarval()); |
|
287 | + $this->assertEquals(12-23, $v->scalarval()); |
|
288 | 288 | } |
289 | 289 | } |
290 | 290 | |
@@ -323,7 +323,7 @@ discard block |
||
323 | 323 | if ($v) { |
324 | 324 | $sz = $v->arraysize(); |
325 | 325 | $got = ''; |
326 | - for ($i = 0; $i < $sz; $i++) { |
|
326 | + for ($i = 0; $i<$sz; $i++) { |
|
327 | 327 | $b = $v->arraymem($i); |
328 | 328 | if ($b->scalarval()) { |
329 | 329 | $got .= '1'; |
@@ -370,7 +370,7 @@ discard block |
||
370 | 370 | $got = ''; |
371 | 371 | $expected = '37210'; |
372 | 372 | $expect_array = array('ctLeftAngleBrackets', 'ctRightAngleBrackets', 'ctAmpersands', 'ctApostrophes', 'ctQuotes'); |
373 | - foreach($expect_array as $val) { |
|
373 | + foreach ($expect_array as $val) { |
|
374 | 374 | $b = $v->structmem($val); |
375 | 375 | $got .= $b->scalarVal(); |
376 | 376 | } |
@@ -873,7 +873,7 @@ discard block |
||
873 | 873 | { |
874 | 874 | // make a 'deep client copy' as the original one might have many properties set |
875 | 875 | // also for speed only wrap one method of the whole server |
876 | - $class = wrap_xmlrpc_server($this->client, array('simple_client_copy' => 0, 'method_filter' => '/examples\.getStateName/' )); |
|
876 | + $class = wrap_xmlrpc_server($this->client, array('simple_client_copy' => 0, 'method_filter' => '/examples\.getStateName/')); |
|
877 | 877 | if ($class == '') { |
878 | 878 | $this->fail('Registration of remote server failed'); |
879 | 879 | } else { |
@@ -912,9 +912,9 @@ discard block |
||
912 | 912 | $cookies = array( |
913 | 913 | //'c1' => array(), |
914 | 914 | 'c2' => array('value' => 'c2'), |
915 | - 'c3' => array('value' => 'c3', 'expires' => time() + 60 * 60 * 24 * 30), |
|
916 | - 'c4' => array('value' => 'c4', 'expires' => time() + 60 * 60 * 24 * 30, 'path' => '/'), |
|
917 | - 'c5' => array('value' => 'c5', 'expires' => time() + 60 * 60 * 24 * 30, 'path' => '/', 'domain' => 'localhost'), |
|
915 | + 'c3' => array('value' => 'c3', 'expires' => time()+60 * 60 * 24 * 30), |
|
916 | + 'c4' => array('value' => 'c4', 'expires' => time()+60 * 60 * 24 * 30, 'path' => '/'), |
|
917 | + 'c5' => array('value' => 'c5', 'expires' => time()+60 * 60 * 24 * 30, 'path' => '/', 'domain' => 'localhost'), |
|
918 | 918 | ); |
919 | 919 | $cookiesval = php_xmlrpc_encode($cookies); |
920 | 920 | $m = new xmlrpcmsg('tests.setcookies', array($cookiesval)); |
@@ -962,10 +962,10 @@ discard block |
||
962 | 962 | $m = new xmlrpcmsg('tests.getcookies', array()); |
963 | 963 | foreach ($cookies as $cookie => $val) { |
964 | 964 | $this->client->setCookie($cookie, $val); |
965 | - $cookies[$cookie] = (string)$cookies[$cookie]; |
|
965 | + $cookies[$cookie] = (string) $cookies[$cookie]; |
|
966 | 966 | } |
967 | 967 | $r = $this->client->send($m, $this->timeout, $this->method); |
968 | - $this->assertEquals(0, $r->faultCode(), 'Error ' . $r->faultCode() . ' connecting to server: ' . $r->faultString()); |
|
968 | + $this->assertEquals(0, $r->faultCode(), 'Error '.$r->faultCode().' connecting to server: '.$r->faultString()); |
|
969 | 969 | if (!$r->faultCode()) { |
970 | 970 | $v = $r->value(); |
971 | 971 | $v = php_xmlrpc_decode($v); |
@@ -1,6 +1,6 @@ discard block |
||
1 | 1 | <?php |
2 | 2 | |
3 | -include_once __DIR__ . '/08ServerTest.php'; |
|
3 | +include_once __DIR__.'/08ServerTest.php'; |
|
4 | 4 | |
5 | 5 | /** |
6 | 6 | * Tests which stress http features of the library. |
@@ -28,7 +28,7 @@ discard block |
||
28 | 28 | { |
29 | 29 | $methods = array(); |
30 | 30 | // as long as we are descendants, get_class_methods will list private/protected methods |
31 | - foreach(get_class_methods('ServerTest') as $method) |
|
31 | + foreach (get_class_methods('ServerTest') as $method) |
|
32 | 32 | { |
33 | 33 | if (strpos($method, 'test') === 0 && !in_array($method, $this->unsafeMethods)) |
34 | 34 | { |
@@ -296,7 +296,7 @@ discard block |
||
296 | 296 | if (version_compare(PHP_VERSION, '8.0', '>=') && $this->args['SSLVERSION'] == 0) |
297 | 297 | { |
298 | 298 | $version = explode('.', PHP_VERSION); |
299 | - $this->client->setSSLVersion(min(4 + $version[1], 7)); |
|
299 | + $this->client->setSSLVersion(min(4+$version[1], 7)); |
|
300 | 300 | } |
301 | 301 | |
302 | 302 | $this->$method(); |
@@ -326,7 +326,7 @@ discard block |
||
326 | 326 | preg_match('/ubunutu([0-9]+)/', $output[0], $matches); |
327 | 327 | $ubuntuVersion = @$matches[1]; |
328 | 328 | } |
329 | - if ($ubuntuVersion >= 20) { |
|
329 | + if ($ubuntuVersion>=20) { |
|
330 | 330 | $this->markTestSkipped('HTTPS via Socket known to fail on php less than 7.2 on Ubuntu 20 and higher'); |
331 | 331 | return; |
332 | 332 | } |
@@ -346,11 +346,11 @@ discard block |
||
346 | 346 | { |
347 | 347 | $version = explode('.', PHP_VERSION); |
348 | 348 | $this->client->setOption(\PhpXmlRpc\Client::OPT_EXTRA_SOCKET_OPTS, |
349 | - array('ssl' => array('security_level' => 2 + $version[1]))); |
|
349 | + array('ssl' => array('security_level' => 2+$version[1]))); |
|
350 | 350 | /// @todo we should probably look deeper into the Apache config / ssl version in use to find out why this |
351 | 351 | /// does not work well with TLS < 1.2 |
352 | 352 | if ($this->args['SSLVERSION'] == 0) { |
353 | - $this->client->setSSLVersion(min(5 + $version[1], 7)); |
|
353 | + $this->client->setSSLVersion(min(5+$version[1], 7)); |
|
354 | 354 | } |
355 | 355 | } |
356 | 356 | $this->$method(); |
@@ -390,7 +390,7 @@ discard block |
||
390 | 390 | if (version_compare(PHP_VERSION, '8.0', '>=') && $this->args['SSLVERSION'] == 0) |
391 | 391 | { |
392 | 392 | $version = explode('.', PHP_VERSION); |
393 | - $this->client->setSSLVersion(min(4 + $version[1], 7)); |
|
393 | + $this->client->setSSLVersion(min(4+$version[1], 7)); |
|
394 | 394 | } |
395 | 395 | |
396 | 396 | $this->$method(); |
@@ -546,7 +546,7 @@ discard block |
||
546 | 546 | // this checks for a non-failed call |
547 | 547 | $time = microtime(true); |
548 | 548 | $this->send($m); |
549 | - $time = microtime(true) - $time; |
|
549 | + $time = microtime(true)-$time; |
|
550 | 550 | $this->assertGreaterThan(1.0, $time); |
551 | 551 | $this->assertLessThan(2.0, $time); |
552 | 552 | |
@@ -554,7 +554,7 @@ discard block |
||
554 | 554 | $m = new xmlrpcmsg('tests.sleep', array(new xmlrpcval(5, 'int'))); |
555 | 555 | $time = microtime(true); |
556 | 556 | $r = $this->send($m, array(0, PhpXmlRpc\PhpXmlRpc::$xmlrpcerr['http_error'], PhpXmlRpc\PhpXmlRpc::$xmlrpcerr['curl_fail'])); |
557 | - $time = microtime(true) - $time; |
|
557 | + $time = microtime(true)-$time; |
|
558 | 558 | $this->assertGreaterThan(2.0, $time); |
559 | 559 | $this->assertLessThan(4.0, $time); |
560 | 560 |
@@ -7,7 +7,7 @@ discard block |
||
7 | 7 | // In case this file is made available on an open-access server, avoid it being useable by anyone who can not also |
8 | 8 | // write a specific file to disk. |
9 | 9 | // NB: keep filename, cookie name in sync with the code within the TestCase classes sending http requests to this file |
10 | -$idFile = sys_get_temp_dir() . '/phpunit_rand_id.txt'; |
|
10 | +$idFile = sys_get_temp_dir().'/phpunit_rand_id.txt'; |
|
11 | 11 | $randId = isset($_COOKIE['PHPUNIT_RANDOM_TEST_ID']) ? $_COOKIE['PHPUNIT_RANDOM_TEST_ID'] : ''; |
12 | 12 | $fileId = file_exists($idFile) ? file_get_contents($idFile) : ''; |
13 | 13 | if ($randId == '' || $fileId == '' || $fileId !== $randId) { |
@@ -31,7 +31,7 @@ discard block |
||
31 | 31 | chmod($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY'], 0777); |
32 | 32 | } |
33 | 33 | |
34 | - include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php"; |
|
34 | + include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php"; |
|
35 | 35 | } |
36 | 36 | |
37 | 37 | $targetFile = null; |
@@ -54,7 +54,7 @@ discard block |
||
54 | 54 | } |
55 | 55 | |
56 | 56 | if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) { |
57 | - include_once __DIR__ . "/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php"; |
|
57 | + include_once __DIR__."/../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php"; |
|
58 | 58 | } |
59 | 59 | |
60 | 60 | /** |
@@ -87,7 +87,7 @@ discard block |
||
87 | 87 | } elseif ($_GET['FORCE_AUTH'] == 'Digest') { |
88 | 88 | if (empty($_SERVER['PHP_AUTH_DIGEST'])) { |
89 | 89 | header('HTTP/1.1 401 Unauthorized'); |
90 | - header('WWW-Authenticate: Digest realm="Phpxmlrpc Digest Realm",qop="auth",nonce="' . uniqid() . '",opaque="' . md5('Phpxmlrpc Digest Realm') . '"'); |
|
90 | + header('WWW-Authenticate: Digest realm="Phpxmlrpc Digest Realm",qop="auth",nonce="'.uniqid().'",opaque="'.md5('Phpxmlrpc Digest Realm').'"'); |
|
91 | 91 | die('Text visible if user hits Cancel button'); |
92 | 92 | } |
93 | 93 | } |
@@ -95,11 +95,11 @@ discard block |
||
95 | 95 | if (isset($_GET['FORCE_REDIRECT'])) { |
96 | 96 | header('HTTP/1.0 302 Found'); |
97 | 97 | unset($_GET['FORCE_REDIRECT']); |
98 | - header('Location: ' . $_SERVER['REQUEST_URI'] . (count($_GET) ? '?' . http_build_query($_GET) : '')); |
|
98 | + header('Location: '.$_SERVER['REQUEST_URI'].(count($_GET) ? '?'.http_build_query($_GET) : '')); |
|
99 | 99 | die(); |
100 | 100 | } |
101 | - if (isset($_GET['SLOW_LORIS']) && $_GET['SLOW_LORIS'] > 0) { |
|
102 | - slowLoris((int)$_GET['SLOW_LORIS'], $s); |
|
101 | + if (isset($_GET['SLOW_LORIS']) && $_GET['SLOW_LORIS']>0) { |
|
102 | + slowLoris((int) $_GET['SLOW_LORIS'], $s); |
|
103 | 103 | die(); |
104 | 104 | } |
105 | 105 | } |
@@ -113,13 +113,13 @@ discard block |
||
113 | 113 | { |
114 | 114 | /// @todo as is, this method can not be used by eg. jsonrpc servers. We could look at the value $s::$responseClass |
115 | 115 | /// to improve that |
116 | - $strings = array('<?xml version="1.0"?>','<methodResponse>','<params>','<param>','<value>','<string></string>','</value>','</param>','</params>','</methodResponse>'); |
|
116 | + $strings = array('<?xml version="1.0"?>', '<methodResponse>', '<params>', '<param>', '<value>', '<string></string>', '</value>', '</param>', '</params>', '</methodResponse>'); |
|
117 | 117 | |
118 | 118 | header('Content-type: xml; charset=utf-8'); |
119 | - foreach($strings as $i => $string) { |
|
119 | + foreach ($strings as $i => $string) { |
|
120 | 120 | echo $string; |
121 | 121 | flush(); |
122 | - if ($i < count($strings) && $secs > 0 && $secs <= 60) { |
|
122 | + if ($i<count($strings) && $secs>0 && $secs<=60) { |
|
123 | 123 | sleep($secs); |
124 | 124 | } |
125 | 125 | } |