@@ -334,10 +334,10 @@ discard block |
||
334 | 334 | $server = $parts['host']; |
335 | 335 | $path = isset($parts['path']) ? $parts['path'] : ''; |
336 | 336 | if (isset($parts['query'])) { |
337 | - $path .= '?' . $parts['query']; |
|
337 | + $path .= '?'.$parts['query']; |
|
338 | 338 | } |
339 | 339 | if (isset($parts['fragment'])) { |
340 | - $path .= '#' . $parts['fragment']; |
|
340 | + $path .= '#'.$parts['fragment']; |
|
341 | 341 | } |
342 | 342 | if (isset($parts['port'])) { |
343 | 343 | $port = $parts['port']; |
@@ -353,7 +353,7 @@ discard block |
||
353 | 353 | } |
354 | 354 | } |
355 | 355 | if ($path == '' || $path[0] != '/') { |
356 | - $this->path = '/' . $path; |
|
356 | + $this->path = '/'.$path; |
|
357 | 357 | } else { |
358 | 358 | $this->path = $path; |
359 | 359 | } |
@@ -385,7 +385,7 @@ discard block |
||
385 | 385 | //$this->accepted_charset_encodings = $ch->knownCharsets(); |
386 | 386 | |
387 | 387 | // initialize user_agent string |
388 | - $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion; |
|
388 | + $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion; |
|
389 | 389 | |
390 | 390 | $this->extra_headers = $extra_headers; |
391 | 391 | } |
@@ -559,7 +559,7 @@ discard block |
||
559 | 559 | */ |
560 | 560 | public function setSSLVerifyPeer($i) |
561 | 561 | { |
562 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
562 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
563 | 563 | |
564 | 564 | $this->verifypeer = $i; |
565 | 565 | return $this; |
@@ -576,7 +576,7 @@ discard block |
||
576 | 576 | */ |
577 | 577 | public function setSSLVerifyHost($i) |
578 | 578 | { |
579 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
579 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
580 | 580 | |
581 | 581 | $this->verifyhost = $i; |
582 | 582 | return $this; |
@@ -591,7 +591,7 @@ discard block |
||
591 | 591 | */ |
592 | 592 | public function setSSLVersion($i) |
593 | 593 | { |
594 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
594 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
595 | 595 | |
596 | 596 | $this->sslversion = $i; |
597 | 597 | return $this; |
@@ -656,7 +656,7 @@ discard block |
||
656 | 656 | */ |
657 | 657 | public function setRequestCompression($compMethod) |
658 | 658 | { |
659 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
659 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
660 | 660 | |
661 | 661 | $this->request_compression = $compMethod; |
662 | 662 | return $this; |
@@ -706,7 +706,7 @@ discard block |
||
706 | 706 | */ |
707 | 707 | public function setCurlOptions($options) |
708 | 708 | { |
709 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
709 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
710 | 710 | |
711 | 711 | $this->extracurlopts = $options; |
712 | 712 | return $this; |
@@ -719,7 +719,7 @@ discard block |
||
719 | 719 | */ |
720 | 720 | public function setUseCurl($useCurlMode) |
721 | 721 | { |
722 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
722 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
723 | 723 | |
724 | 724 | $this->use_curl = $useCurlMode; |
725 | 725 | return $this; |
@@ -737,7 +737,7 @@ discard block |
||
737 | 737 | */ |
738 | 738 | public function setUserAgent($agentString) |
739 | 739 | { |
740 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
740 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
741 | 741 | |
742 | 742 | $this->user_agent = $agentString; |
743 | 743 | return $this; |
@@ -768,12 +768,12 @@ discard block |
||
768 | 768 | } |
769 | 769 | } |
770 | 770 | |
771 | - $url = $this->method . '://' . $this->server; |
|
771 | + $url = $this->method.'://'.$this->server; |
|
772 | 772 | if ($this->port == 0 || ($this->port == 80 && in_array($this->method, array('http', 'http10', 'http11', 'h2c'))) || |
773 | 773 | ($this->port == 443 && in_array($this->method, array('https', 'h2')))) { |
774 | - return $url . $this->path; |
|
774 | + return $url.$this->path; |
|
775 | 775 | } else { |
776 | - return $url . ':' . $this->port . $this->path; |
|
776 | + return $url.':'.$this->port.$this->path; |
|
777 | 777 | } |
778 | 778 | } |
779 | 779 | |
@@ -837,7 +837,7 @@ discard block |
||
837 | 837 | public function send($req, $timeout = 0, $method = '') |
838 | 838 | { |
839 | 839 | if ($method !== '' || $timeout !== 0) { |
840 | - $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated'); |
|
840 | + $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method ".__METHOD__.' is deprecated'); |
|
841 | 841 | } |
842 | 842 | |
843 | 843 | // if user does not specify http protocol, use native method of this client |
@@ -956,7 +956,7 @@ discard block |
||
956 | 956 | $payload = $a; |
957 | 957 | $encodingHdr = "Content-Encoding: gzip\r\n"; |
958 | 958 | } else { |
959 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request'); |
|
959 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request'); |
|
960 | 960 | } |
961 | 961 | } else if (function_exists('gzcompress')) { |
962 | 962 | $a = @gzcompress($payload); |
@@ -964,14 +964,14 @@ discard block |
||
964 | 964 | $payload = $a; |
965 | 965 | $encodingHdr = "Content-Encoding: deflate\r\n"; |
966 | 966 | } else { |
967 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request'); |
|
967 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request'); |
|
968 | 968 | } |
969 | 969 | } else { |
970 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install'); |
|
970 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install'); |
|
971 | 971 | } |
972 | 972 | } else { |
973 | 973 | if ($opts['request_compression'] != '') { |
974 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported'); |
|
974 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported'); |
|
975 | 975 | } |
976 | 976 | } |
977 | 977 | |
@@ -979,16 +979,16 @@ discard block |
||
979 | 979 | $credentials = ''; |
980 | 980 | if ($opts['username'] != '') { |
981 | 981 | if ($opts['authtype'] != 1) { |
982 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0'); |
|
982 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0'); |
|
983 | 983 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
984 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth is supported with HTTP 1.0'); |
|
984 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth is supported with HTTP 1.0'); |
|
985 | 985 | } |
986 | - $credentials = 'Authorization: Basic ' . base64_encode($opts['username'] . ':' . $opts['password']) . "\r\n"; |
|
986 | + $credentials = 'Authorization: Basic '.base64_encode($opts['username'].':'.$opts['password'])."\r\n"; |
|
987 | 987 | } |
988 | 988 | |
989 | 989 | $acceptedEncoding = ''; |
990 | 990 | if (is_array($opts['accepted_compression']) && count($opts['accepted_compression'])) { |
991 | - $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $opts['accepted_compression']) . "\r\n"; |
|
991 | + $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $opts['accepted_compression'])."\r\n"; |
|
992 | 992 | } |
993 | 993 | |
994 | 994 | if ($port == 0) { |
@@ -1004,15 +1004,15 @@ discard block |
||
1004 | 1004 | $connectPort = $opts['proxyport']; |
1005 | 1005 | $transport = 'tcp'; |
1006 | 1006 | /// @todo check: should we not use https in some cases? |
1007 | - $uri = 'http://' . $server . ':' . $port . $path; |
|
1007 | + $uri = 'http://'.$server.':'.$port.$path; |
|
1008 | 1008 | if ($opts['proxy_user'] != '') { |
1009 | 1009 | if ($opts['proxy_authtype'] != 1) { |
1010 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0'); |
|
1010 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0'); |
|
1011 | 1011 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1012 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth to proxy is supported with HTTP 1.0'); |
|
1012 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth to proxy is supported with HTTP 1.0'); |
|
1013 | 1013 | } |
1014 | - $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($opts['proxy_user'] . ':' . |
|
1015 | - $opts['proxy_pass']) . "\r\n"; |
|
1014 | + $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($opts['proxy_user'].':'. |
|
1015 | + $opts['proxy_pass'])."\r\n"; |
|
1016 | 1016 | } |
1017 | 1017 | } else { |
1018 | 1018 | $connectServer = $server; |
@@ -1028,32 +1028,32 @@ discard block |
||
1028 | 1028 | $version = ''; |
1029 | 1029 | foreach ($opts['cookies'] as $name => $cookie) { |
1030 | 1030 | /// @todo should we sanitize the cookie value on behalf of the user? See setCookie comments |
1031 | - $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";"; |
|
1031 | + $cookieHeader .= ' '.$name.'='.$cookie['value'].";"; |
|
1032 | 1032 | } |
1033 | - $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n"; |
|
1033 | + $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n"; |
|
1034 | 1034 | } |
1035 | 1035 | |
1036 | 1036 | // omit port if default |
1037 | 1037 | if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) { |
1038 | 1038 | $port = ''; |
1039 | 1039 | } else { |
1040 | - $port = ':' . $port; |
|
1041 | - } |
|
1042 | - |
|
1043 | - $op = 'POST ' . $uri . " HTTP/1.0\r\n" . |
|
1044 | - 'User-Agent: ' . $opts['user_agent'] . "\r\n" . |
|
1045 | - 'Host: ' . $server . $port . "\r\n" . |
|
1046 | - $credentials . |
|
1047 | - $proxyCredentials . |
|
1048 | - $acceptedEncoding . |
|
1049 | - $encodingHdr . |
|
1050 | - 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']) . "\r\n" . |
|
1051 | - $cookieHeader . |
|
1052 | - 'Content-Type: ' . $req->getContentType() . "\r\nContent-Length: " . |
|
1053 | - strlen($payload) . "\r\n\r\n" . |
|
1040 | + $port = ':'.$port; |
|
1041 | + } |
|
1042 | + |
|
1043 | + $op = 'POST '.$uri." HTTP/1.0\r\n". |
|
1044 | + 'User-Agent: '.$opts['user_agent']."\r\n". |
|
1045 | + 'Host: '.$server.$port."\r\n". |
|
1046 | + $credentials. |
|
1047 | + $proxyCredentials. |
|
1048 | + $acceptedEncoding. |
|
1049 | + $encodingHdr. |
|
1050 | + 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])."\r\n". |
|
1051 | + $cookieHeader. |
|
1052 | + 'Content-Type: '.$req->getContentType()."\r\nContent-Length: ". |
|
1053 | + strlen($payload)."\r\n\r\n". |
|
1054 | 1054 | $payload; |
1055 | 1055 | |
1056 | - if ($opts['debug'] > 1) { |
|
1056 | + if ($opts['debug']>1) { |
|
1057 | 1057 | $this->getLogger()->debug("---SENDING---\n$op\n---END---"); |
1058 | 1058 | } |
1059 | 1059 | |
@@ -1079,7 +1079,7 @@ discard block |
||
1079 | 1079 | |
1080 | 1080 | if ($opts['sslversion'] != 0) { |
1081 | 1081 | /// @see https://www.php.net/manual/en/function.curl-setopt.php, https://www.php.net/manual/en/migration56.openssl.php |
1082 | - switch($opts['sslversion']) { |
|
1082 | + switch ($opts['sslversion']) { |
|
1083 | 1083 | /// @todo what does this map to? 1.0-1.3? |
1084 | 1084 | //case 1: // TLSv1 |
1085 | 1085 | // break; |
@@ -1103,12 +1103,12 @@ discard block |
||
1103 | 1103 | $contextOptions['ssl']['crypto_method'] = STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT; |
1104 | 1104 | } else { |
1105 | 1105 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1106 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': TLS-1.3 only is supported with PHP 7.4 or later'); |
|
1106 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': TLS-1.3 only is supported with PHP 7.4 or later'); |
|
1107 | 1107 | } |
1108 | 1108 | break; |
1109 | 1109 | default: |
1110 | 1110 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1111 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': Unsupported required TLS version'); |
|
1111 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': Unsupported required TLS version'); |
|
1112 | 1112 | } |
1113 | 1113 | } |
1114 | 1114 | } |
@@ -1121,7 +1121,7 @@ discard block |
||
1121 | 1121 | |
1122 | 1122 | $context = stream_context_create($contextOptions); |
1123 | 1123 | |
1124 | - if ($opts['timeout'] <= 0) { |
|
1124 | + if ($opts['timeout']<=0) { |
|
1125 | 1125 | $connectTimeout = ini_get('default_socket_timeout'); |
1126 | 1126 | } else { |
1127 | 1127 | $connectTimeout = $opts['timeout']; |
@@ -1133,7 +1133,7 @@ discard block |
||
1133 | 1133 | $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout, |
1134 | 1134 | STREAM_CLIENT_CONNECT, $context); |
1135 | 1135 | if ($fp) { |
1136 | - if ($opts['timeout'] > 0) { |
|
1136 | + if ($opts['timeout']>0) { |
|
1137 | 1137 | stream_set_timeout($fp, $opts['timeout'], 0); |
1138 | 1138 | } |
1139 | 1139 | } else { |
@@ -1142,8 +1142,8 @@ discard block |
||
1142 | 1142 | $this->errstr = $err['message']; |
1143 | 1143 | } |
1144 | 1144 | |
1145 | - $this->errstr = 'Connect error: ' . $this->errstr; |
|
1146 | - $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')'); |
|
1145 | + $this->errstr = 'Connect error: '.$this->errstr; |
|
1146 | + $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')'); |
|
1147 | 1147 | |
1148 | 1148 | return $r; |
1149 | 1149 | } |
@@ -1210,19 +1210,19 @@ discard block |
||
1210 | 1210 | $opts['keepalive'], $opts['key'], $opts['keypass'], $opts['sslversion']); |
1211 | 1211 | |
1212 | 1212 | if (!$curl) { |
1213 | - return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . |
|
1213 | + return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail']. |
|
1214 | 1214 | ': error during curl initialization. Check php error log for details'); |
1215 | 1215 | } |
1216 | 1216 | |
1217 | 1217 | $result = curl_exec($curl); |
1218 | 1218 | |
1219 | - if ($opts['debug'] > 1) { |
|
1219 | + if ($opts['debug']>1) { |
|
1220 | 1220 | $message = "---CURL INFO---\n"; |
1221 | 1221 | foreach (curl_getinfo($curl) as $name => $val) { |
1222 | 1222 | if (is_array($val)) { |
1223 | 1223 | $val = implode("\n", $val); |
1224 | 1224 | } |
1225 | - $message .= $name . ': ' . $val . "\n"; |
|
1225 | + $message .= $name.': '.$val."\n"; |
|
1226 | 1226 | } |
1227 | 1227 | $message .= '---END---'; |
1228 | 1228 | $this->getLogger()->debug($message); |
@@ -1232,8 +1232,8 @@ discard block |
||
1232 | 1232 | /// @todo we should use a better check here - what if we get back '' or '0'? |
1233 | 1233 | |
1234 | 1234 | $this->errstr = 'no response'; |
1235 | - $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . |
|
1236 | - ': ' . curl_error($curl)); |
|
1235 | + $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail']. |
|
1236 | + ': '.curl_error($curl)); |
|
1237 | 1237 | curl_close($curl); |
1238 | 1238 | if ($opts['keepalive']) { |
1239 | 1239 | $this->xmlrpc_curl_handle = null; |
@@ -1291,7 +1291,7 @@ discard block |
||
1291 | 1291 | $payload = $a; |
1292 | 1292 | $encodingHdr = 'Content-Encoding: gzip'; |
1293 | 1293 | } else { |
1294 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request'); |
|
1294 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request'); |
|
1295 | 1295 | } |
1296 | 1296 | } else if (function_exists('gzcompress')) { |
1297 | 1297 | $a = @gzcompress($payload); |
@@ -1299,14 +1299,14 @@ discard block |
||
1299 | 1299 | $payload = $a; |
1300 | 1300 | $encodingHdr = 'Content-Encoding: deflate'; |
1301 | 1301 | } else { |
1302 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request'); |
|
1302 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request'); |
|
1303 | 1303 | } |
1304 | 1304 | } else { |
1305 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install'); |
|
1305 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install'); |
|
1306 | 1306 | } |
1307 | 1307 | } else { |
1308 | 1308 | if ($opts['request_compression'] != '') { |
1309 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported'); |
|
1309 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported'); |
|
1310 | 1310 | } |
1311 | 1311 | } |
1312 | 1312 | |
@@ -1320,12 +1320,12 @@ discard block |
||
1320 | 1320 | // http, https |
1321 | 1321 | $protocol = $method; |
1322 | 1322 | if (strpos($protocol, ':') !== false) { |
1323 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'"); |
|
1323 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'"); |
|
1324 | 1324 | return false; |
1325 | 1325 | } |
1326 | 1326 | } |
1327 | 1327 | } |
1328 | - $curl = curl_init($protocol . '://' . $server . ':' . $port . $path); |
|
1328 | + $curl = curl_init($protocol.'://'.$server.':'.$port.$path); |
|
1329 | 1329 | if (!$curl) { |
1330 | 1330 | return false; |
1331 | 1331 | } |
@@ -1339,7 +1339,7 @@ discard block |
||
1339 | 1339 | // results into variable |
1340 | 1340 | curl_setopt($curl, CURLOPT_RETURNTRANSFER, true); |
1341 | 1341 | |
1342 | - if ($opts['debug'] > 1) { |
|
1342 | + if ($opts['debug']>1) { |
|
1343 | 1343 | curl_setopt($curl, CURLOPT_VERBOSE, true); |
1344 | 1344 | /// @todo redirect curlopt_stderr to some stream which can be piped to the logger |
1345 | 1345 | } |
@@ -1364,7 +1364,7 @@ discard block |
||
1364 | 1364 | } |
1365 | 1365 | } |
1366 | 1366 | // extra headers |
1367 | - $headers = array('Content-Type: ' . $req->getContentType(), 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings'])); |
|
1367 | + $headers = array('Content-Type: '.$req->getContentType(), 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])); |
|
1368 | 1368 | // if no keepalive is wanted, let the server know it in advance |
1369 | 1369 | if (!$opts['keepalive']) { |
1370 | 1370 | $headers[] = 'Connection: close'; |
@@ -1385,7 +1385,7 @@ discard block |
||
1385 | 1385 | curl_setopt($curl, CURLOPT_HTTPHEADER, $headers); |
1386 | 1386 | // timeout is borked |
1387 | 1387 | if ($opts['timeout']) { |
1388 | - curl_setopt($curl, CURLOPT_TIMEOUT, $opts['timeout'] == 1 ? 1 : $opts['timeout'] - 1); |
|
1388 | + curl_setopt($curl, CURLOPT_TIMEOUT, $opts['timeout'] == 1 ? 1 : $opts['timeout']-1); |
|
1389 | 1389 | } |
1390 | 1390 | |
1391 | 1391 | switch ($method) { |
@@ -1399,7 +1399,7 @@ discard block |
||
1399 | 1399 | if (defined('CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE')) { |
1400 | 1400 | curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE); |
1401 | 1401 | } else { |
1402 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install'); |
|
1402 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install'); |
|
1403 | 1403 | curl_close($curl); |
1404 | 1404 | return false; |
1405 | 1405 | } |
@@ -1410,11 +1410,11 @@ discard block |
||
1410 | 1410 | } |
1411 | 1411 | |
1412 | 1412 | if ($opts['username'] && $opts['password']) { |
1413 | - curl_setopt($curl, CURLOPT_USERPWD, $opts['username'] . ':' . $opts['password']); |
|
1413 | + curl_setopt($curl, CURLOPT_USERPWD, $opts['username'].':'.$opts['password']); |
|
1414 | 1414 | if (defined('CURLOPT_HTTPAUTH')) { |
1415 | 1415 | curl_setopt($curl, CURLOPT_HTTPAUTH, $opts['authtype']); |
1416 | 1416 | } elseif ($opts['authtype'] != 1) { |
1417 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install'); |
|
1417 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install'); |
|
1418 | 1418 | curl_close($curl); |
1419 | 1419 | return false; |
1420 | 1420 | } |
@@ -1459,13 +1459,13 @@ discard block |
||
1459 | 1459 | if ($opts['proxyport'] == 0) { |
1460 | 1460 | $opts['proxyport'] = 8080; // NB: even for HTTPS, local connection is on port 8080 |
1461 | 1461 | } |
1462 | - curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'] . ':' . $opts['proxyport']); |
|
1462 | + curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'].':'.$opts['proxyport']); |
|
1463 | 1463 | if ($opts['proxy_user']) { |
1464 | - curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'] . ':' . $opts['proxy_pass']); |
|
1464 | + curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'].':'.$opts['proxy_pass']); |
|
1465 | 1465 | if (defined('CURLOPT_PROXYAUTH')) { |
1466 | 1466 | curl_setopt($curl, CURLOPT_PROXYAUTH, $opts['proxy_authtype']); |
1467 | 1467 | } elseif ($opts['proxy_authtype'] != 1) { |
1468 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install'); |
|
1468 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install'); |
|
1469 | 1469 | curl_close($curl); |
1470 | 1470 | return false; |
1471 | 1471 | } |
@@ -1477,7 +1477,7 @@ discard block |
||
1477 | 1477 | if (count($opts['cookies'])) { |
1478 | 1478 | $cookieHeader = ''; |
1479 | 1479 | foreach ($opts['cookies'] as $name => $cookie) { |
1480 | - $cookieHeader .= $name . '=' . $cookie['value'] . '; '; |
|
1480 | + $cookieHeader .= $name.'='.$cookie['value'].'; '; |
|
1481 | 1481 | } |
1482 | 1482 | curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2)); |
1483 | 1483 | } |
@@ -1486,7 +1486,7 @@ discard block |
||
1486 | 1486 | curl_setopt($curl, $opt, $val); |
1487 | 1487 | } |
1488 | 1488 | |
1489 | - if ($opts['debug'] > 1) { |
|
1489 | + if ($opts['debug']>1) { |
|
1490 | 1490 | $this->getLogger()->debug("---SENDING---\n$payload\n---END---"); |
1491 | 1491 | } |
1492 | 1492 | |
@@ -1587,7 +1587,7 @@ discard block |
||
1587 | 1587 | $call['methodName'] = new Value($req->method(), 'string'); |
1588 | 1588 | $numParams = $req->getNumParams(); |
1589 | 1589 | $params = array(); |
1590 | - for ($i = 0; $i < $numParams; $i++) { |
|
1590 | + for ($i = 0; $i<$numParams; $i++) { |
|
1591 | 1591 | $params[$i] = $req->getParam($i); |
1592 | 1592 | } |
1593 | 1593 | $call['params'] = new Value($params, 'array'); |
@@ -1609,7 +1609,7 @@ discard block |
||
1609 | 1609 | $response = array(); |
1610 | 1610 | |
1611 | 1611 | if ($this->return_type == 'xml') { |
1612 | - for ($i = 0; $i < count($reqs); $i++) { |
|
1612 | + for ($i = 0; $i<count($reqs); $i++) { |
|
1613 | 1613 | $response[] = new static::$responseClass($rets, 0, '', 'xml', $result->httpResponse()); |
1614 | 1614 | } |
1615 | 1615 | |
@@ -1617,21 +1617,21 @@ discard block |
||
1617 | 1617 | if (!is_array($rets)) { |
1618 | 1618 | // bad return type from system.multicall |
1619 | 1619 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1620 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse()); |
|
1620 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse()); |
|
1621 | 1621 | } |
1622 | 1622 | $numRets = count($rets); |
1623 | 1623 | if ($numRets != count($reqs)) { |
1624 | 1624 | // wrong number of return values. |
1625 | 1625 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1626 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals', |
|
1626 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals', |
|
1627 | 1627 | $result->httpResponse()); |
1628 | 1628 | } |
1629 | 1629 | |
1630 | - for ($i = 0; $i < $numRets; $i++) { |
|
1630 | + for ($i = 0; $i<$numRets; $i++) { |
|
1631 | 1631 | $val = $rets[$i]; |
1632 | 1632 | if (!is_array($val)) { |
1633 | 1633 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1634 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct", |
|
1634 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct", |
|
1635 | 1635 | 'phpvals', $result->httpResponse()); |
1636 | 1636 | } |
1637 | 1637 | switch (count($val)) { |
@@ -1639,7 +1639,7 @@ discard block |
||
1639 | 1639 | if (!isset($val[0])) { |
1640 | 1640 | // Bad value |
1641 | 1641 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1642 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value", |
|
1642 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value", |
|
1643 | 1643 | 'phpvals', $result->httpResponse()); |
1644 | 1644 | } |
1645 | 1645 | // Normal return value |
@@ -1651,20 +1651,20 @@ discard block |
||
1651 | 1651 | if (!is_int($code)) { |
1652 | 1652 | /// @todo should we check that it is != 0? |
1653 | 1653 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1654 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1654 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1655 | 1655 | 'phpvals', $result->httpResponse()); |
1656 | 1656 | } |
1657 | 1657 | $str = @$val['faultString']; |
1658 | 1658 | if (!is_string($str)) { |
1659 | 1659 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1660 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString", |
|
1660 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString", |
|
1661 | 1661 | 'phpvals', $result->httpResponse()); |
1662 | 1662 | } |
1663 | 1663 | $response[$i] = new static::$responseClass(0, $code, $str, 'phpvals', $result->httpResponse()); |
1664 | 1664 | break; |
1665 | 1665 | default: |
1666 | 1666 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1667 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1667 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1668 | 1668 | 'phpvals', $result->httpResponse()); |
1669 | 1669 | } |
1670 | 1670 | } |
@@ -1673,14 +1673,14 @@ discard block |
||
1673 | 1673 | // return type == 'xmlrpcvals' |
1674 | 1674 | if ($rets->kindOf() != 'array') { |
1675 | 1675 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1676 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals', |
|
1676 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals', |
|
1677 | 1677 | $result->httpResponse()); |
1678 | 1678 | } |
1679 | 1679 | $numRets = $rets->count(); |
1680 | 1680 | if ($numRets != count($reqs)) { |
1681 | 1681 | // wrong number of return values. |
1682 | 1682 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1683 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals', |
|
1683 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals', |
|
1684 | 1684 | $result->httpResponse()); |
1685 | 1685 | } |
1686 | 1686 | |
@@ -1689,7 +1689,7 @@ discard block |
||
1689 | 1689 | case 'array': |
1690 | 1690 | if ($val->count() != 1) { |
1691 | 1691 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1692 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1692 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1693 | 1693 | 'phpvals', $result->httpResponse()); |
1694 | 1694 | } |
1695 | 1695 | // Normal return value |
@@ -1698,28 +1698,28 @@ discard block |
||
1698 | 1698 | case 'struct': |
1699 | 1699 | if ($val->count() != 2) { |
1700 | 1700 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1701 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1701 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1702 | 1702 | 'phpvals', $result->httpResponse()); |
1703 | 1703 | } |
1704 | 1704 | /** @var Value $code */ |
1705 | 1705 | $code = $val['faultCode']; |
1706 | 1706 | if ($code->kindOf() != 'scalar' || $code->scalarTyp() != 'int') { |
1707 | 1707 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1708 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1708 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1709 | 1709 | 'xmlrpcvals', $result->httpResponse()); |
1710 | 1710 | } |
1711 | 1711 | /** @var Value $str */ |
1712 | 1712 | $str = $val['faultString']; |
1713 | 1713 | if ($str->kindOf() != 'scalar' || $str->scalarTyp() != 'string') { |
1714 | 1714 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1715 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1715 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1716 | 1716 | 'xmlrpcvals', $result->httpResponse()); |
1717 | 1717 | } |
1718 | 1718 | $response[] = new static::$responseClass(0, $code->scalarVal(), $str->scalarVal(), 'xmlrpcvals', $result->httpResponse()); |
1719 | 1719 | break; |
1720 | 1720 | default: |
1721 | 1721 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1722 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct", |
|
1722 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct", |
|
1723 | 1723 | 'xmlrpcvals', $result->httpResponse()); |
1724 | 1724 | } |
1725 | 1725 | } |
@@ -1752,7 +1752,7 @@ discard block |
||
1752 | 1752 | $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, |
1753 | 1753 | $method = 'http') |
1754 | 1754 | { |
1755 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1755 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1756 | 1756 | |
1757 | 1757 | return $this->sendPayloadSocket($req, $server, $port, $timeout, $username, $password, $authType, null, null, |
1758 | 1758 | null, null, $proxyHost, $proxyPort, $proxyUsername, $proxyPassword, $proxyAuthType, $method); |
@@ -1788,7 +1788,7 @@ discard block |
||
1788 | 1788 | $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '', |
1789 | 1789 | $sslVersion = 0) |
1790 | 1790 | { |
1791 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1791 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1792 | 1792 | |
1793 | 1793 | return $this->sendPayloadCURL($req, $server, $port, $timeout, $username, |
1794 | 1794 | $password, $authType, $cert, $certPass, $caCert, $caCertDir, $proxyHost, $proxyPort, |
@@ -2001,7 +2001,7 @@ discard block |
||
2001 | 2001 | public function &__get($name) |
2002 | 2002 | { |
2003 | 2003 | if (in_array($name, static::$options)) { |
2004 | - $this->logDeprecation('Getting property Client::' . $name . ' is deprecated'); |
|
2004 | + $this->logDeprecation('Getting property Client::'.$name.' is deprecated'); |
|
2005 | 2005 | return $this->$name; |
2006 | 2006 | } |
2007 | 2007 | |
@@ -2012,12 +2012,12 @@ discard block |
||
2012 | 2012 | case 'server': |
2013 | 2013 | case 'port': |
2014 | 2014 | case 'path': |
2015 | - $this->logDeprecation('Getting property Client::' . $name . ' is deprecated'); |
|
2015 | + $this->logDeprecation('Getting property Client::'.$name.' is deprecated'); |
|
2016 | 2016 | return $this->$name; |
2017 | 2017 | default: |
2018 | 2018 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2019 | 2019 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2020 | - trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2020 | + trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2021 | 2021 | $result = null; |
2022 | 2022 | return $result; |
2023 | 2023 | } |
@@ -2026,7 +2026,7 @@ discard block |
||
2026 | 2026 | public function __set($name, $value) |
2027 | 2027 | { |
2028 | 2028 | if (in_array($name, static::$options)) { |
2029 | - $this->logDeprecation('Setting property Client::' . $name . ' is deprecated'); |
|
2029 | + $this->logDeprecation('Setting property Client::'.$name.' is deprecated'); |
|
2030 | 2030 | $this->$name = $value; |
2031 | 2031 | return; |
2032 | 2032 | } |
@@ -2038,20 +2038,20 @@ discard block |
||
2038 | 2038 | case 'server': |
2039 | 2039 | case 'port': |
2040 | 2040 | case 'path': |
2041 | - $this->logDeprecation('Setting property Client::' . $name . ' is deprecated'); |
|
2041 | + $this->logDeprecation('Setting property Client::'.$name.' is deprecated'); |
|
2042 | 2042 | $this->$name = $value; |
2043 | 2043 | return; |
2044 | 2044 | default: |
2045 | 2045 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2046 | 2046 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2047 | - trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2047 | + trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2048 | 2048 | } |
2049 | 2049 | } |
2050 | 2050 | |
2051 | 2051 | public function __isset($name) |
2052 | 2052 | { |
2053 | 2053 | if (in_array($name, static::$options)) { |
2054 | - $this->logDeprecation('Checking property Client::' . $name . ' is deprecated'); |
|
2054 | + $this->logDeprecation('Checking property Client::'.$name.' is deprecated'); |
|
2055 | 2055 | return isset($this->$name); |
2056 | 2056 | } |
2057 | 2057 | |
@@ -2062,7 +2062,7 @@ discard block |
||
2062 | 2062 | case 'server': |
2063 | 2063 | case 'port': |
2064 | 2064 | case 'path': |
2065 | - $this->logDeprecation('Checking property Client::' . $name . ' is deprecated'); |
|
2065 | + $this->logDeprecation('Checking property Client::'.$name.' is deprecated'); |
|
2066 | 2066 | return isset($this->$name); |
2067 | 2067 | default: |
2068 | 2068 | return false; |
@@ -2072,7 +2072,7 @@ discard block |
||
2072 | 2072 | public function __unset($name) |
2073 | 2073 | { |
2074 | 2074 | if (in_array($name, static::$options)) { |
2075 | - $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated'); |
|
2075 | + $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated'); |
|
2076 | 2076 | unset($this->$name); |
2077 | 2077 | return; |
2078 | 2078 | } |
@@ -2084,13 +2084,13 @@ discard block |
||
2084 | 2084 | case 'server': |
2085 | 2085 | case 'port': |
2086 | 2086 | case 'path': |
2087 | - $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated'); |
|
2087 | + $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated'); |
|
2088 | 2088 | unset($this->$name); |
2089 | 2089 | return; |
2090 | 2090 | default: |
2091 | 2091 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2092 | 2092 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2093 | - trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2093 | + trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2094 | 2094 | } |
2095 | 2095 | } |
2096 | 2096 | } |