@@ -326,10 +326,10 @@ discard block |
||
326 | 326 | $server = $parts['host']; |
327 | 327 | $path = isset($parts['path']) ? $parts['path'] : ''; |
328 | 328 | if (isset($parts['query'])) { |
329 | - $path .= '?' . $parts['query']; |
|
329 | + $path .= '?'.$parts['query']; |
|
330 | 330 | } |
331 | 331 | if (isset($parts['fragment'])) { |
332 | - $path .= '#' . $parts['fragment']; |
|
332 | + $path .= '#'.$parts['fragment']; |
|
333 | 333 | } |
334 | 334 | if (isset($parts['port'])) { |
335 | 335 | $port = $parts['port']; |
@@ -345,7 +345,7 @@ discard block |
||
345 | 345 | } |
346 | 346 | } |
347 | 347 | if ($path == '' || $path[0] != '/') { |
348 | - $this->path = '/' . $path; |
|
348 | + $this->path = '/'.$path; |
|
349 | 349 | } else { |
350 | 350 | $this->path = $path; |
351 | 351 | } |
@@ -377,7 +377,7 @@ discard block |
||
377 | 377 | //$this->accepted_charset_encodings = $ch->knownCharsets(); |
378 | 378 | |
379 | 379 | // initialize user_agent string |
380 | - $this->user_agent = PhpXmlRpc::$xmlrpcName . ' ' . PhpXmlRpc::$xmlrpcVersion; |
|
380 | + $this->user_agent = PhpXmlRpc::$xmlrpcName.' '.PhpXmlRpc::$xmlrpcVersion; |
|
381 | 381 | } |
382 | 382 | |
383 | 383 | /** |
@@ -549,7 +549,7 @@ discard block |
||
549 | 549 | */ |
550 | 550 | public function setSSLVerifyPeer($i) |
551 | 551 | { |
552 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
552 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
553 | 553 | |
554 | 554 | $this->verifypeer = $i; |
555 | 555 | return $this; |
@@ -566,7 +566,7 @@ discard block |
||
566 | 566 | */ |
567 | 567 | public function setSSLVerifyHost($i) |
568 | 568 | { |
569 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
569 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
570 | 570 | |
571 | 571 | $this->verifyhost = $i; |
572 | 572 | return $this; |
@@ -581,7 +581,7 @@ discard block |
||
581 | 581 | */ |
582 | 582 | public function setSSLVersion($i) |
583 | 583 | { |
584 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
584 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
585 | 585 | |
586 | 586 | $this->sslversion = $i; |
587 | 587 | return $this; |
@@ -646,7 +646,7 @@ discard block |
||
646 | 646 | */ |
647 | 647 | public function setRequestCompression($compMethod) |
648 | 648 | { |
649 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
649 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
650 | 650 | |
651 | 651 | $this->request_compression = $compMethod; |
652 | 652 | return $this; |
@@ -696,7 +696,7 @@ discard block |
||
696 | 696 | */ |
697 | 697 | public function setCurlOptions($options) |
698 | 698 | { |
699 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
699 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
700 | 700 | |
701 | 701 | $this->extracurlopts = $options; |
702 | 702 | return $this; |
@@ -709,7 +709,7 @@ discard block |
||
709 | 709 | */ |
710 | 710 | public function setUseCurl($useCurlMode) |
711 | 711 | { |
712 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
712 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
713 | 713 | |
714 | 714 | $this->use_curl = $useCurlMode; |
715 | 715 | return $this; |
@@ -727,7 +727,7 @@ discard block |
||
727 | 727 | */ |
728 | 728 | public function setUserAgent($agentString) |
729 | 729 | { |
730 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
730 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
731 | 731 | |
732 | 732 | $this->user_agent = $agentString; |
733 | 733 | return $this; |
@@ -758,12 +758,12 @@ discard block |
||
758 | 758 | } |
759 | 759 | } |
760 | 760 | |
761 | - $url = $this->method . '://' . $this->server; |
|
761 | + $url = $this->method.'://'.$this->server; |
|
762 | 762 | if ($this->port == 0 || ($this->port == 80 && in_array($this->method, array('http', 'http10', 'http11', 'h2c'))) || |
763 | 763 | ($this->port == 443 && in_array($this->method, array('https', 'h2')))) { |
764 | - return $url . $this->path; |
|
764 | + return $url.$this->path; |
|
765 | 765 | } else { |
766 | - return $url . ':' . $this->port . $this->path; |
|
766 | + return $url.':'.$this->port.$this->path; |
|
767 | 767 | } |
768 | 768 | } |
769 | 769 | |
@@ -803,7 +803,7 @@ discard block |
||
803 | 803 | public function send($req, $timeout = 0, $method = '') |
804 | 804 | { |
805 | 805 | if ($method !== '' || $timeout !== 0) { |
806 | - $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated'); |
|
806 | + $this->logDeprecation("Using non-default values for arguments 'method' and 'timeout' when calling method ".__METHOD__.' is deprecated'); |
|
807 | 807 | } |
808 | 808 | |
809 | 809 | // if user does not specify http protocol, use native method of this client |
@@ -921,7 +921,7 @@ discard block |
||
921 | 921 | $payload = $a; |
922 | 922 | $encodingHdr = "Content-Encoding: gzip\r\n"; |
923 | 923 | } else { |
924 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request'); |
|
924 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request'); |
|
925 | 925 | } |
926 | 926 | } else if (function_exists('gzcompress')) { |
927 | 927 | $a = @gzcompress($payload); |
@@ -929,14 +929,14 @@ discard block |
||
929 | 929 | $payload = $a; |
930 | 930 | $encodingHdr = "Content-Encoding: deflate\r\n"; |
931 | 931 | } else { |
932 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request'); |
|
932 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request'); |
|
933 | 933 | } |
934 | 934 | } else { |
935 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install'); |
|
935 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install'); |
|
936 | 936 | } |
937 | 937 | } else { |
938 | 938 | if ($opts['request_compression'] != '') { |
939 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported'); |
|
939 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported'); |
|
940 | 940 | } |
941 | 941 | } |
942 | 942 | |
@@ -944,16 +944,16 @@ discard block |
||
944 | 944 | $credentials = ''; |
945 | 945 | if ($opts['username'] != '') { |
946 | 946 | if ($opts['authtype'] != 1) { |
947 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported with HTTP 1.0'); |
|
947 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported with HTTP 1.0'); |
|
948 | 948 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
949 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth is supported with HTTP 1.0'); |
|
949 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth is supported with HTTP 1.0'); |
|
950 | 950 | } |
951 | - $credentials = 'Authorization: Basic ' . base64_encode($opts['username'] . ':' . $opts['password']) . "\r\n"; |
|
951 | + $credentials = 'Authorization: Basic '.base64_encode($opts['username'].':'.$opts['password'])."\r\n"; |
|
952 | 952 | } |
953 | 953 | |
954 | 954 | $acceptedEncoding = ''; |
955 | 955 | if (is_array($opts['accepted_compression']) && count($opts['accepted_compression'])) { |
956 | - $acceptedEncoding = 'Accept-Encoding: ' . implode(', ', $opts['accepted_compression']) . "\r\n"; |
|
956 | + $acceptedEncoding = 'Accept-Encoding: '.implode(', ', $opts['accepted_compression'])."\r\n"; |
|
957 | 957 | } |
958 | 958 | |
959 | 959 | if ($port == 0) { |
@@ -969,15 +969,15 @@ discard block |
||
969 | 969 | $connectPort = $opts['proxyport']; |
970 | 970 | $transport = 'tcp'; |
971 | 971 | /// @todo check: should we not use https in some cases? |
972 | - $uri = 'http://' . $server . ':' . $port . $path; |
|
972 | + $uri = 'http://'.$server.':'.$port.$path; |
|
973 | 973 | if ($opts['proxy_user'] != '') { |
974 | 974 | if ($opts['proxy_authtype'] != 1) { |
975 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported with HTTP 1.0'); |
|
975 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported with HTTP 1.0'); |
|
976 | 976 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
977 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': only Basic auth to proxy is supported with HTTP 1.0'); |
|
977 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': only Basic auth to proxy is supported with HTTP 1.0'); |
|
978 | 978 | } |
979 | - $proxyCredentials = 'Proxy-Authorization: Basic ' . base64_encode($opts['proxy_user'] . ':' . |
|
980 | - $opts['proxy_pass']) . "\r\n"; |
|
979 | + $proxyCredentials = 'Proxy-Authorization: Basic '.base64_encode($opts['proxy_user'].':'. |
|
980 | + $opts['proxy_pass'])."\r\n"; |
|
981 | 981 | } |
982 | 982 | } else { |
983 | 983 | $connectServer = $server; |
@@ -993,32 +993,32 @@ discard block |
||
993 | 993 | $version = ''; |
994 | 994 | foreach ($opts['cookies'] as $name => $cookie) { |
995 | 995 | /// @todo should we sanitize the cookie value on behalf of the user? See setCookie comments |
996 | - $cookieHeader .= ' ' . $name . '=' . $cookie['value'] . ";"; |
|
996 | + $cookieHeader .= ' '.$name.'='.$cookie['value'].";"; |
|
997 | 997 | } |
998 | - $cookieHeader = 'Cookie:' . $version . substr($cookieHeader, 0, -1) . "\r\n"; |
|
998 | + $cookieHeader = 'Cookie:'.$version.substr($cookieHeader, 0, -1)."\r\n"; |
|
999 | 999 | } |
1000 | 1000 | |
1001 | 1001 | // omit port if default |
1002 | 1002 | if (($port == 80 && in_array($method, array('http', 'http10'))) || ($port == 443 && $method == 'https')) { |
1003 | 1003 | $port = ''; |
1004 | 1004 | } else { |
1005 | - $port = ':' . $port; |
|
1006 | - } |
|
1007 | - |
|
1008 | - $op = 'POST ' . $uri . " HTTP/1.0\r\n" . |
|
1009 | - 'User-Agent: ' . $opts['user_agent'] . "\r\n" . |
|
1010 | - 'Host: ' . $server . $port . "\r\n" . |
|
1011 | - $credentials . |
|
1012 | - $proxyCredentials . |
|
1013 | - $acceptedEncoding . |
|
1014 | - $encodingHdr . |
|
1015 | - 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings']) . "\r\n" . |
|
1016 | - $cookieHeader . |
|
1017 | - 'Content-Type: ' . $req->getContentType() . "\r\nContent-Length: " . |
|
1018 | - strlen($payload) . "\r\n\r\n" . |
|
1005 | + $port = ':'.$port; |
|
1006 | + } |
|
1007 | + |
|
1008 | + $op = 'POST '.$uri." HTTP/1.0\r\n". |
|
1009 | + 'User-Agent: '.$opts['user_agent']."\r\n". |
|
1010 | + 'Host: '.$server.$port."\r\n". |
|
1011 | + $credentials. |
|
1012 | + $proxyCredentials. |
|
1013 | + $acceptedEncoding. |
|
1014 | + $encodingHdr. |
|
1015 | + 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])."\r\n". |
|
1016 | + $cookieHeader. |
|
1017 | + 'Content-Type: '.$req->getContentType()."\r\nContent-Length: ". |
|
1018 | + strlen($payload)."\r\n\r\n". |
|
1019 | 1019 | $payload; |
1020 | 1020 | |
1021 | - if ($opts['debug'] > 1) { |
|
1021 | + if ($opts['debug']>1) { |
|
1022 | 1022 | $this->getLogger()->debug("---SENDING---\n$op\n---END---"); |
1023 | 1023 | } |
1024 | 1024 | |
@@ -1044,7 +1044,7 @@ discard block |
||
1044 | 1044 | |
1045 | 1045 | if ($opts['sslversion'] != 0) { |
1046 | 1046 | /// @see https://www.php.net/manual/en/function.curl-setopt.php, https://www.php.net/manual/en/migration56.openssl.php |
1047 | - switch($opts['sslversion']) { |
|
1047 | + switch ($opts['sslversion']) { |
|
1048 | 1048 | /// @todo what does this map to? 1.0-1.3? |
1049 | 1049 | //case 1: // TLSv1 |
1050 | 1050 | // break; |
@@ -1068,12 +1068,12 @@ discard block |
||
1068 | 1068 | $contextOptions['ssl']['crypto_method'] = STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT; |
1069 | 1069 | } else { |
1070 | 1070 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1071 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': TLS-1.3 only is supported with PHP 7.4 or later'); |
|
1071 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': TLS-1.3 only is supported with PHP 7.4 or later'); |
|
1072 | 1072 | } |
1073 | 1073 | break; |
1074 | 1074 | default: |
1075 | 1075 | return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['unsupported_option'], |
1076 | - PhpXmlRpc::$xmlrpcerr['unsupported_option'] . ': Unsupported required TLS version'); |
|
1076 | + PhpXmlRpc::$xmlrpcerr['unsupported_option'].': Unsupported required TLS version'); |
|
1077 | 1077 | } |
1078 | 1078 | } |
1079 | 1079 | } |
@@ -1086,7 +1086,7 @@ discard block |
||
1086 | 1086 | |
1087 | 1087 | $context = stream_context_create($contextOptions); |
1088 | 1088 | |
1089 | - if ($opts['timeout'] <= 0) { |
|
1089 | + if ($opts['timeout']<=0) { |
|
1090 | 1090 | $connectTimeout = ini_get('default_socket_timeout'); |
1091 | 1091 | } else { |
1092 | 1092 | $connectTimeout = $opts['timeout']; |
@@ -1098,7 +1098,7 @@ discard block |
||
1098 | 1098 | $fp = @stream_socket_client("$transport://$connectServer:$connectPort", $this->errno, $this->errstr, $connectTimeout, |
1099 | 1099 | STREAM_CLIENT_CONNECT, $context); |
1100 | 1100 | if ($fp) { |
1101 | - if ($opts['timeout'] > 0) { |
|
1101 | + if ($opts['timeout']>0) { |
|
1102 | 1102 | stream_set_timeout($fp, $opts['timeout'], 0); |
1103 | 1103 | } |
1104 | 1104 | } else { |
@@ -1107,8 +1107,8 @@ discard block |
||
1107 | 1107 | $this->errstr = $err['message']; |
1108 | 1108 | } |
1109 | 1109 | |
1110 | - $this->errstr = 'Connect error: ' . $this->errstr; |
|
1111 | - $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr . ' (' . $this->errno . ')'); |
|
1110 | + $this->errstr = 'Connect error: '.$this->errstr; |
|
1111 | + $r = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['http_error'], $this->errstr.' ('.$this->errno.')'); |
|
1112 | 1112 | |
1113 | 1113 | return $r; |
1114 | 1114 | } |
@@ -1175,19 +1175,19 @@ discard block |
||
1175 | 1175 | $opts['keepalive'], $opts['key'], $opts['keypass'], $opts['sslversion']); |
1176 | 1176 | |
1177 | 1177 | if (!$curl) { |
1178 | - return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . |
|
1178 | + return new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail']. |
|
1179 | 1179 | ': error during curl initialization. Check php error log for details'); |
1180 | 1180 | } |
1181 | 1181 | |
1182 | 1182 | $result = curl_exec($curl); |
1183 | 1183 | |
1184 | - if ($opts['debug'] > 1) { |
|
1184 | + if ($opts['debug']>1) { |
|
1185 | 1185 | $message = "---CURL INFO---\n"; |
1186 | 1186 | foreach (curl_getinfo($curl) as $name => $val) { |
1187 | 1187 | if (is_array($val)) { |
1188 | 1188 | $val = implode("\n", $val); |
1189 | 1189 | } |
1190 | - $message .= $name . ': ' . $val . "\n"; |
|
1190 | + $message .= $name.': '.$val."\n"; |
|
1191 | 1191 | } |
1192 | 1192 | $message .= '---END---'; |
1193 | 1193 | $this->getLogger()->debug($message); |
@@ -1197,8 +1197,8 @@ discard block |
||
1197 | 1197 | /// @todo we should use a better check here - what if we get back '' or '0'? |
1198 | 1198 | |
1199 | 1199 | $this->errstr = 'no response'; |
1200 | - $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . |
|
1201 | - ': ' . curl_error($curl)); |
|
1200 | + $resp = new static::$responseClass(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail']. |
|
1201 | + ': '.curl_error($curl)); |
|
1202 | 1202 | curl_close($curl); |
1203 | 1203 | if ($opts['keepalive']) { |
1204 | 1204 | $this->xmlrpc_curl_handle = null; |
@@ -1256,7 +1256,7 @@ discard block |
||
1256 | 1256 | $payload = $a; |
1257 | 1257 | $encodingHdr = 'Content-Encoding: gzip'; |
1258 | 1258 | } else { |
1259 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzencode failure in compressing request'); |
|
1259 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzencode failure in compressing request'); |
|
1260 | 1260 | } |
1261 | 1261 | } else if (function_exists('gzcompress')) { |
1262 | 1262 | $a = @gzcompress($payload); |
@@ -1264,14 +1264,14 @@ discard block |
||
1264 | 1264 | $payload = $a; |
1265 | 1265 | $encodingHdr = 'Content-Encoding: deflate'; |
1266 | 1266 | } else { |
1267 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': gzcompress failure in compressing request'); |
|
1267 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': gzcompress failure in compressing request'); |
|
1268 | 1268 | } |
1269 | 1269 | } else { |
1270 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported by this PHP install'); |
|
1270 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported by this PHP install'); |
|
1271 | 1271 | } |
1272 | 1272 | } else { |
1273 | 1273 | if ($opts['request_compression'] != '') { |
1274 | - $this->getLogger()->warning('XML-RPC: ' . __METHOD__ . ': desired request compression method is unsupported'); |
|
1274 | + $this->getLogger()->warning('XML-RPC: '.__METHOD__.': desired request compression method is unsupported'); |
|
1275 | 1275 | } |
1276 | 1276 | } |
1277 | 1277 | |
@@ -1285,12 +1285,12 @@ discard block |
||
1285 | 1285 | // http, https |
1286 | 1286 | $protocol = $method; |
1287 | 1287 | if (strpos($protocol, ':') !== false) { |
1288 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'"); |
|
1288 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.": warning - attempted hacking attempt?. The curl protocol requested for the call is: '$protocol'"); |
|
1289 | 1289 | return false; |
1290 | 1290 | } |
1291 | 1291 | } |
1292 | 1292 | } |
1293 | - $curl = curl_init($protocol . '://' . $server . ':' . $port . $path); |
|
1293 | + $curl = curl_init($protocol.'://'.$server.':'.$port.$path); |
|
1294 | 1294 | if (!$curl) { |
1295 | 1295 | return false; |
1296 | 1296 | } |
@@ -1304,7 +1304,7 @@ discard block |
||
1304 | 1304 | // results into variable |
1305 | 1305 | curl_setopt($curl, CURLOPT_RETURNTRANSFER, true); |
1306 | 1306 | |
1307 | - if ($opts['debug'] > 1) { |
|
1307 | + if ($opts['debug']>1) { |
|
1308 | 1308 | curl_setopt($curl, CURLOPT_VERBOSE, true); |
1309 | 1309 | /// @todo redirect curlopt_stderr to some stream which can be piped to the logger |
1310 | 1310 | } |
@@ -1329,7 +1329,7 @@ discard block |
||
1329 | 1329 | } |
1330 | 1330 | } |
1331 | 1331 | // extra headers |
1332 | - $headers = array('Content-Type: ' . $req->getContentType(), 'Accept-Charset: ' . implode(',', $opts['accepted_charset_encodings'])); |
|
1332 | + $headers = array('Content-Type: '.$req->getContentType(), 'Accept-Charset: '.implode(',', $opts['accepted_charset_encodings'])); |
|
1333 | 1333 | // if no keepalive is wanted, let the server know it in advance |
1334 | 1334 | if (!$opts['keepalive']) { |
1335 | 1335 | $headers[] = 'Connection: close'; |
@@ -1346,7 +1346,7 @@ discard block |
||
1346 | 1346 | curl_setopt($curl, CURLOPT_HTTPHEADER, $headers); |
1347 | 1347 | // timeout is borked |
1348 | 1348 | if ($opts['timeout']) { |
1349 | - curl_setopt($curl, CURLOPT_TIMEOUT, $opts['timeout'] == 1 ? 1 : $opts['timeout'] - 1); |
|
1349 | + curl_setopt($curl, CURLOPT_TIMEOUT, $opts['timeout'] == 1 ? 1 : $opts['timeout']-1); |
|
1350 | 1350 | } |
1351 | 1351 | |
1352 | 1352 | switch ($method) { |
@@ -1360,7 +1360,7 @@ discard block |
||
1360 | 1360 | if (defined('CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE')) { |
1361 | 1361 | curl_setopt($curl, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE); |
1362 | 1362 | } else { |
1363 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. HTTP2 is not supported by the current PHP/curl install'); |
|
1363 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. HTTP2 is not supported by the current PHP/curl install'); |
|
1364 | 1364 | curl_close($curl); |
1365 | 1365 | return false; |
1366 | 1366 | } |
@@ -1371,11 +1371,11 @@ discard block |
||
1371 | 1371 | } |
1372 | 1372 | |
1373 | 1373 | if ($opts['username'] && $opts['password']) { |
1374 | - curl_setopt($curl, CURLOPT_USERPWD, $opts['username'] . ':' . $opts['password']); |
|
1374 | + curl_setopt($curl, CURLOPT_USERPWD, $opts['username'].':'.$opts['password']); |
|
1375 | 1375 | if (defined('CURLOPT_HTTPAUTH')) { |
1376 | 1376 | curl_setopt($curl, CURLOPT_HTTPAUTH, $opts['authtype']); |
1377 | 1377 | } elseif ($opts['authtype'] != 1) { |
1378 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth is supported by the current PHP/curl install'); |
|
1378 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth is supported by the current PHP/curl install'); |
|
1379 | 1379 | curl_close($curl); |
1380 | 1380 | return false; |
1381 | 1381 | } |
@@ -1420,13 +1420,13 @@ discard block |
||
1420 | 1420 | if ($opts['proxyport'] == 0) { |
1421 | 1421 | $opts['proxyport'] = 8080; // NB: even for HTTPS, local connection is on port 8080 |
1422 | 1422 | } |
1423 | - curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'] . ':' . $opts['proxyport']); |
|
1423 | + curl_setopt($curl, CURLOPT_PROXY, $opts['proxy'].':'.$opts['proxyport']); |
|
1424 | 1424 | if ($opts['proxy_user']) { |
1425 | - curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'] . ':' . $opts['proxy_pass']); |
|
1425 | + curl_setopt($curl, CURLOPT_PROXYUSERPWD, $opts['proxy_user'].':'.$opts['proxy_pass']); |
|
1426 | 1426 | if (defined('CURLOPT_PROXYAUTH')) { |
1427 | 1427 | curl_setopt($curl, CURLOPT_PROXYAUTH, $opts['proxy_authtype']); |
1428 | 1428 | } elseif ($opts['proxy_authtype'] != 1) { |
1429 | - $this->getLogger()->error('XML-RPC: ' . __METHOD__ . ': warning. Only Basic auth to proxy is supported by the current PHP/curl install'); |
|
1429 | + $this->getLogger()->error('XML-RPC: '.__METHOD__.': warning. Only Basic auth to proxy is supported by the current PHP/curl install'); |
|
1430 | 1430 | curl_close($curl); |
1431 | 1431 | return false; |
1432 | 1432 | } |
@@ -1438,7 +1438,7 @@ discard block |
||
1438 | 1438 | if (count($opts['cookies'])) { |
1439 | 1439 | $cookieHeader = ''; |
1440 | 1440 | foreach ($opts['cookies'] as $name => $cookie) { |
1441 | - $cookieHeader .= $name . '=' . $cookie['value'] . '; '; |
|
1441 | + $cookieHeader .= $name.'='.$cookie['value'].'; '; |
|
1442 | 1442 | } |
1443 | 1443 | var_dump(substr($cookieHeader, 0, -2)); |
1444 | 1444 | curl_setopt($curl, CURLOPT_COOKIE, substr($cookieHeader, 0, -2)); |
@@ -1448,7 +1448,7 @@ discard block |
||
1448 | 1448 | curl_setopt($curl, $opt, $val); |
1449 | 1449 | } |
1450 | 1450 | |
1451 | - if ($opts['debug'] > 1) { |
|
1451 | + if ($opts['debug']>1) { |
|
1452 | 1452 | $this->getLogger()->debug("---SENDING---\n$payload\n---END---"); |
1453 | 1453 | } |
1454 | 1454 | |
@@ -1549,7 +1549,7 @@ discard block |
||
1549 | 1549 | $call['methodName'] = new Value($req->method(), 'string'); |
1550 | 1550 | $numParams = $req->getNumParams(); |
1551 | 1551 | $params = array(); |
1552 | - for ($i = 0; $i < $numParams; $i++) { |
|
1552 | + for ($i = 0; $i<$numParams; $i++) { |
|
1553 | 1553 | $params[$i] = $req->getParam($i); |
1554 | 1554 | } |
1555 | 1555 | $call['params'] = new Value($params, 'array'); |
@@ -1571,7 +1571,7 @@ discard block |
||
1571 | 1571 | $response = array(); |
1572 | 1572 | |
1573 | 1573 | if ($this->return_type == 'xml') { |
1574 | - for ($i = 0; $i < count($reqs); $i++) { |
|
1574 | + for ($i = 0; $i<count($reqs); $i++) { |
|
1575 | 1575 | $response[] = new Response($rets, 0, '', 'xml', $result->httpResponse()); |
1576 | 1576 | } |
1577 | 1577 | |
@@ -1579,21 +1579,21 @@ discard block |
||
1579 | 1579 | if (!is_array($rets)) { |
1580 | 1580 | // bad return type from system.multicall |
1581 | 1581 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1582 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': not an array', 'phpvals', $result->httpResponse()); |
|
1582 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': not an array', 'phpvals', $result->httpResponse()); |
|
1583 | 1583 | } |
1584 | 1584 | $numRets = count($rets); |
1585 | 1585 | if ($numRets != count($reqs)) { |
1586 | 1586 | // wrong number of return values. |
1587 | 1587 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1588 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'phpvals', |
|
1588 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'phpvals', |
|
1589 | 1589 | $result->httpResponse()); |
1590 | 1590 | } |
1591 | 1591 | |
1592 | - for ($i = 0; $i < $numRets; $i++) { |
|
1592 | + for ($i = 0; $i<$numRets; $i++) { |
|
1593 | 1593 | $val = $rets[$i]; |
1594 | 1594 | if (!is_array($val)) { |
1595 | 1595 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1596 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct", |
|
1596 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct", |
|
1597 | 1597 | 'phpvals', $result->httpResponse()); |
1598 | 1598 | } |
1599 | 1599 | switch (count($val)) { |
@@ -1601,7 +1601,7 @@ discard block |
||
1601 | 1601 | if (!isset($val[0])) { |
1602 | 1602 | // Bad value |
1603 | 1603 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1604 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has no value", |
|
1604 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has no value", |
|
1605 | 1605 | 'phpvals', $result->httpResponse()); |
1606 | 1606 | } |
1607 | 1607 | // Normal return value |
@@ -1613,20 +1613,20 @@ discard block |
||
1613 | 1613 | if (!is_int($code)) { |
1614 | 1614 | /// @todo should we check that it is != 0? |
1615 | 1615 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1616 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1616 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1617 | 1617 | 'phpvals', $result->httpResponse()); |
1618 | 1618 | } |
1619 | 1619 | $str = @$val['faultString']; |
1620 | 1620 | if (!is_string($str)) { |
1621 | 1621 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1622 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no FaultString", |
|
1622 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no FaultString", |
|
1623 | 1623 | 'phpvals', $result->httpResponse()); |
1624 | 1624 | } |
1625 | 1625 | $response[$i] = new Response(0, $code, $str, 'phpvals', $result->httpResponse()); |
1626 | 1626 | break; |
1627 | 1627 | default: |
1628 | 1628 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1629 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1629 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1630 | 1630 | 'phpvals', $result->httpResponse()); |
1631 | 1631 | } |
1632 | 1632 | } |
@@ -1635,14 +1635,14 @@ discard block |
||
1635 | 1635 | // return type == 'xmlrpcvals' |
1636 | 1636 | if ($rets->kindOf() != 'array') { |
1637 | 1637 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1638 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array", 'xmlrpcvals', |
|
1638 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array", 'xmlrpcvals', |
|
1639 | 1639 | $result->httpResponse()); |
1640 | 1640 | } |
1641 | 1641 | $numRets = $rets->count(); |
1642 | 1642 | if ($numRets != count($reqs)) { |
1643 | 1643 | // wrong number of return values. |
1644 | 1644 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1645 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ': incorrect number of responses', 'xmlrpcvals', |
|
1645 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].': incorrect number of responses', 'xmlrpcvals', |
|
1646 | 1646 | $result->httpResponse()); |
1647 | 1647 | } |
1648 | 1648 | |
@@ -1651,7 +1651,7 @@ discard block |
||
1651 | 1651 | case 'array': |
1652 | 1652 | if ($val->count() != 1) { |
1653 | 1653 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1654 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1654 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1655 | 1655 | 'phpvals', $result->httpResponse()); |
1656 | 1656 | } |
1657 | 1657 | // Normal return value |
@@ -1660,28 +1660,28 @@ discard block |
||
1660 | 1660 | case 'struct': |
1661 | 1661 | if ($val->count() != 2) { |
1662 | 1662 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1663 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has too many items", |
|
1663 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has too many items", |
|
1664 | 1664 | 'phpvals', $result->httpResponse()); |
1665 | 1665 | } |
1666 | 1666 | /** @var Value $code */ |
1667 | 1667 | $code = $val['faultCode']; |
1668 | 1668 | if ($code->kindOf() != 'scalar' || $code->scalarTyp() != 'int') { |
1669 | 1669 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1670 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1670 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1671 | 1671 | 'xmlrpcvals', $result->httpResponse()); |
1672 | 1672 | } |
1673 | 1673 | /** @var Value $str */ |
1674 | 1674 | $str = $val['faultString']; |
1675 | 1675 | if ($str->kindOf() != 'scalar' || $str->scalarTyp() != 'string') { |
1676 | 1676 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1677 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i has invalid or no faultCode", |
|
1677 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i has invalid or no faultCode", |
|
1678 | 1678 | 'xmlrpcvals', $result->httpResponse()); |
1679 | 1679 | } |
1680 | 1680 | $response[] = new Response(0, $code->scalarVal(), $str->scalarVal(), 'xmlrpcvals', $result->httpResponse()); |
1681 | 1681 | break; |
1682 | 1682 | default: |
1683 | 1683 | return new Response(0, PhpXmlRpc::$xmlrpcerr['multicall_error'], |
1684 | - PhpXmlRpc::$xmlrpcstr['multicall_error'] . ": response element $i is not an array or struct", |
|
1684 | + PhpXmlRpc::$xmlrpcstr['multicall_error'].": response element $i is not an array or struct", |
|
1685 | 1685 | 'xmlrpcvals', $result->httpResponse()); |
1686 | 1686 | } |
1687 | 1687 | } |
@@ -1714,7 +1714,7 @@ discard block |
||
1714 | 1714 | $authType = 1, $proxyHost = '', $proxyPort = 0, $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, |
1715 | 1715 | $method = 'http') |
1716 | 1716 | { |
1717 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1717 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1718 | 1718 | |
1719 | 1719 | return $this->sendPayloadSocket($req, $server, $port, $timeout, $username, $password, $authType, null, null, |
1720 | 1720 | null, null, $proxyHost, $proxyPort, $proxyUsername, $proxyPassword, $proxyAuthType, $method); |
@@ -1750,7 +1750,7 @@ discard block |
||
1750 | 1750 | $proxyUsername = '', $proxyPassword = '', $proxyAuthType = 1, $keepAlive = false, $key = '', $keyPass = '', |
1751 | 1751 | $sslVersion = 0) |
1752 | 1752 | { |
1753 | - $this->logDeprecation('Method ' . __METHOD__ . ' is deprecated'); |
|
1753 | + $this->logDeprecation('Method '.__METHOD__.' is deprecated'); |
|
1754 | 1754 | |
1755 | 1755 | return $this->sendPayloadCURL($req, $server, $port, $timeout, $username, |
1756 | 1756 | $password, $authType, $cert, $certPass, $caCert, $caCertDir, $proxyHost, $proxyPort, |
@@ -1963,7 +1963,7 @@ discard block |
||
1963 | 1963 | public function &__get($name) |
1964 | 1964 | { |
1965 | 1965 | if (in_array($name, static::$options)) { |
1966 | - $this->logDeprecation('Getting property Client::' . $name . ' is deprecated'); |
|
1966 | + $this->logDeprecation('Getting property Client::'.$name.' is deprecated'); |
|
1967 | 1967 | return $this->$name; |
1968 | 1968 | } |
1969 | 1969 | |
@@ -1974,12 +1974,12 @@ discard block |
||
1974 | 1974 | case 'server': |
1975 | 1975 | case 'port': |
1976 | 1976 | case 'path': |
1977 | - $this->logDeprecation('Getting property Client::' . $name . ' is deprecated'); |
|
1977 | + $this->logDeprecation('Getting property Client::'.$name.' is deprecated'); |
|
1978 | 1978 | return $this->$name; |
1979 | 1979 | default: |
1980 | 1980 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
1981 | 1981 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
1982 | - trigger_error('Undefined property via __get(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
1982 | + trigger_error('Undefined property via __get(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
1983 | 1983 | $result = null; |
1984 | 1984 | return $result; |
1985 | 1985 | } |
@@ -1988,7 +1988,7 @@ discard block |
||
1988 | 1988 | public function __set($name, $value) |
1989 | 1989 | { |
1990 | 1990 | if (in_array($name, static::$options)) { |
1991 | - $this->logDeprecation('Setting property Client::' . $name . ' is deprecated'); |
|
1991 | + $this->logDeprecation('Setting property Client::'.$name.' is deprecated'); |
|
1992 | 1992 | $this->$name = $value; |
1993 | 1993 | return; |
1994 | 1994 | } |
@@ -2000,20 +2000,20 @@ discard block |
||
2000 | 2000 | case 'server': |
2001 | 2001 | case 'port': |
2002 | 2002 | case 'path': |
2003 | - $this->logDeprecation('Setting property Client::' . $name . ' is deprecated'); |
|
2003 | + $this->logDeprecation('Setting property Client::'.$name.' is deprecated'); |
|
2004 | 2004 | $this->$name = $value; |
2005 | 2005 | return; |
2006 | 2006 | default: |
2007 | 2007 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2008 | 2008 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2009 | - trigger_error('Undefined property via __set(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2009 | + trigger_error('Undefined property via __set(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2010 | 2010 | } |
2011 | 2011 | } |
2012 | 2012 | |
2013 | 2013 | public function __isset($name) |
2014 | 2014 | { |
2015 | 2015 | if (in_array($name, static::$options)) { |
2016 | - $this->logDeprecation('Checking property Client::' . $name . ' is deprecated'); |
|
2016 | + $this->logDeprecation('Checking property Client::'.$name.' is deprecated'); |
|
2017 | 2017 | return isset($this->$name); |
2018 | 2018 | } |
2019 | 2019 | |
@@ -2024,7 +2024,7 @@ discard block |
||
2024 | 2024 | case 'server': |
2025 | 2025 | case 'port': |
2026 | 2026 | case 'path': |
2027 | - $this->logDeprecation('Checking property Client::' . $name . ' is deprecated'); |
|
2027 | + $this->logDeprecation('Checking property Client::'.$name.' is deprecated'); |
|
2028 | 2028 | return isset($this->$name); |
2029 | 2029 | default: |
2030 | 2030 | return false; |
@@ -2034,7 +2034,7 @@ discard block |
||
2034 | 2034 | public function __unset($name) |
2035 | 2035 | { |
2036 | 2036 | if (in_array($name, static::$options)) { |
2037 | - $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated'); |
|
2037 | + $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated'); |
|
2038 | 2038 | unset($this->$name); |
2039 | 2039 | return; |
2040 | 2040 | } |
@@ -2046,13 +2046,13 @@ discard block |
||
2046 | 2046 | case 'server': |
2047 | 2047 | case 'port': |
2048 | 2048 | case 'path': |
2049 | - $this->logDeprecation('Unsetting property Client::' . $name . ' is deprecated'); |
|
2049 | + $this->logDeprecation('Unsetting property Client::'.$name.' is deprecated'); |
|
2050 | 2050 | unset($this->$name); |
2051 | 2051 | return; |
2052 | 2052 | default: |
2053 | 2053 | /// @todo throw instead? There are very few other places where the lib trigger errors which can potentially reach stdout... |
2054 | 2054 | $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1); |
2055 | - trigger_error('Undefined property via __unset(): ' . $name . ' in ' . $trace[0]['file'] . ' on line ' . $trace[0]['line'], E_USER_WARNING); |
|
2055 | + trigger_error('Undefined property via __unset(): '.$name.' in '.$trace[0]['file'].' on line '.$trace[0]['line'], E_USER_WARNING); |
|
2056 | 2056 | } |
2057 | 2057 | } |
2058 | 2058 | } |