gewebe / SyliusVATPlugin

src/Vat/Rates/EuRates.php

<?php

declare(strict_types=1);

namespace Gewebe\SyliusVATPlugin\Vat\Rates;

use Ibericode\Vat\Countries;
use Ibericode\Vat\Rates;

/**
 * European VAT rates and countries
 */
final class EuRates implements RatesInterface
{
    private Countries $countries;

    public function __construct(private Rates $rates)
    {
        $this->countries = new Countries();
    }

    public function getCountries(): array
    {
        $euCountries = [];

        /**
         * @var string $countryCode
         * @var string $countryName
         */
        foreach ($this->countries as $countryCode => $countryName) {
            if (!$this->countries->isCountryCodeInEU($countryCode)) {

It seems like $countryCode can also be of type null; however, parameter $code of Ibericode\Vat\Countries::isCountryCodeInEU() does only seem to accept string, maybe add an additional type check?

                continue;
            }

            $euCountries[$countryCode] = $countryName;
        }

        return $euCountries;
    }

    public function getCountryRate(string $countryCode, string $level = self::RATE_STANDARD): float
    {
        return $this->rates->getRateForCountry($countryCode, $level);
    }
}