Gewebe\SyliusVATPlugin\Vat\Rates\EuRates::getCountries()

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getCountries(): array
    {
        $euCountries = [];

        /**
         * @var string $countryCode
         * @var string $countryName
         */
        foreach ($this->countries as $countryCode => $countryName) {
            if (!$this->countries->isCountryCodeInEU($countryCode)) {

It seems like $countryCode can also be of type null; however, parameter $code of Ibericode\Vat\Countries::isCountryCodeInEU() does only seem to accept string, maybe add an additional type check?

                continue;
            }

            $euCountries[$countryCode] = $countryName;
        }

        return $euCountries;
    }