CountryLoader::loadCountry() - Code Metrics - geobase/php-countries - Measure and Improve Code Quality continuously with Scrutinizer

CountryLoader::loadCountry() A
last analyzed 2017-03-06 21:53 UTC

↳ Parent: CountryLoader

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	9

Duplication

Lines	15
Ratio	100 %

Code Coverage

Tests	6
CRAP Score	3.1406

Importance

Changes

Metric	Value
dl	15
loc	15
ccs	6
cts	8
cp	0.75
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	3
nop	1
crap	3.1406

<?php

namespace GeoBase\Countries\Country;

use GeoBase\CountriesData\CountriesData;

class CountryLoader
{
    const ALL_COUNTRIES_FILE = 'countries.json';
    const COUNTRY_FILE = 'countries/%s.json';
    const COUNTRY_POLYGON_FILE = 'countries/%s/polygon.json';

    /**
     * @var Storage
     */
    private $path;

    public function __construct()
    {
        $this->path = CountriesData::getCountriesPath();

    }

    /**
     * @return array
     */
    public function loadAllCountries()
    {
        return json_decode(
            file_get_contents($this->path.DIRECTORY_SEPARATOR.self::ALL_COUNTRIES_FILE),
            true
        );
    }

    /**
     * @param string $country
     *
     * @return array
     */
    public function loadCountry($country)

    {
        if (!$country) {
            return;
        }
        $file = $this->path.DIRECTORY_SEPARATOR.sprintf(self::COUNTRY_FILE, $country);
        if (!file_exists($file)) {
            return;
        }

        return json_decode(
            file_get_contents($file),
            true
        );
    }

    /**
     * @param string $country
     *
     * @return array
     */
    public function loadCountryPolygon($country)

    {
        if (!$country) {
            return;
        }
        $file = $this->path.DIRECTORY_SEPARATOR.sprintf(self::COUNTRY_POLYGON_FILE, $country);
        if (!file_exists($file)) {
            return;
        }

        return json_decode(
            file_get_contents($file),
            true
        );
    }
}


1			<?php
2
3			namespace GeoBase\Countries\Country;
4
5			use GeoBase\CountriesData\CountriesData;
6
7			class CountryLoader
8			{
9			const ALL_COUNTRIES_FILE = 'countries.json';
10			const COUNTRY_FILE = 'countries/%s.json';
11			const COUNTRY_POLYGON_FILE = 'countries/%s/polygon.json';
12
13			/**
14			* @var Storage
15			*/
16			private $path;
17
18	3		public function __construct()
19			{
20	3		$this->path = CountriesData::getCountriesPath();
			0 ignored issues – show Documentation Bug introduced 2017-03-06 21:12 UTC by Report Bug Copy Issue Report It seems like `\GeoBase\CountriesData\C...ata::getCountriesPath()` of type `string` is incompatible with the declared type `object<GeoBase\Countries\Country\Storage>` of property `$path`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
21	3		}
22
23			/**
24			* @return array
25			*/
26	3		public function loadAllCountries()
27			{
28	3		return json_decode(
29	3		file_get_contents($this->path.DIRECTORY_SEPARATOR.self::ALL_COUNTRIES_FILE),
30	3		true
31			);
32			}
33
34			/**
35			* @param string $country
36			*
37			* @return array
38			*/
39	1	View Code Duplication	public function loadCountry($country)
			0 ignored issues – show Duplication introduced 2017-03-06 21:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40			{
41	1		if (!$country) {
42			return;
43			}
44	1		$file = $this->path.DIRECTORY_SEPARATOR.sprintf(self::COUNTRY_FILE, $country);
45	1		if (!file_exists($file)) {
46			return;
47			}
48
49	1		return json_decode(
50			file_get_contents($file),
51	1		true
52			);
53			}
54
55			/**
56			* @param string $country
57			*
58			* @return array
59			*/
60		View Code Duplication	public function loadCountryPolygon($country)
			0 ignored issues – show Duplication introduced 2017-03-06 21:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61			{
62			if (!$country) {
63			return;
64			}
65			$file = $this->path.DIRECTORY_SEPARATOR.sprintf(self::COUNTRY_POLYGON_FILE, $country);
66			if (!file_exists($file)) {
67			return;
68			}
69
70			return json_decode(
71			file_get_contents($file),
72			true
73			);
74			}
75			}
76

geobase / php-countries

CountryLoader::loadCountry() A last analyzed 2017-03-06 21:53 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CountryLoader::loadCountry() A
last analyzed 2017-03-06 21:53 UTC