GeoBase\Countries\Country\CountryLoader

Complexity

Total Complexity

8

Size/Duplication

Total Lines	69
Duplicated Lines	43.48 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

56.52%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	loadAllCountries()	0	7	1
A	loadCountry()	15	15	3
A	loadCountryPolygon()	15	15	3

<?php

namespace GeoBase\Countries\Country;

use GeoBase\CountriesData\CountriesData;

class CountryLoader
{
    const ALL_COUNTRIES_FILE = 'countries.json';
    const COUNTRY_FILE = 'countries/%s.json';
    const COUNTRY_POLYGON_FILE = 'countries/%s/polygon.json';

    /**
     * @var Storage
     */
    private $path;

    public function __construct()
    {
        $this->path = CountriesData::getCountriesPath();

It seems like \GeoBase\CountriesData\CountriesData::getCountriesPath() of type string is incompatible with the declared type object<GeoBase\Countries\Country\Storage> of property $path.

    }

    /**
     * @return array
     */
    public function loadAllCountries()
    {
        return json_decode(
            file_get_contents($this->path.DIRECTORY_SEPARATOR.self::ALL_COUNTRIES_FILE),
            true
        );
    }

    /**
     * @param string $country
     *
     * @return array
     */
    public function loadCountry($country)

This method seems to be duplicated in your project.

    {
        if (!$country) {
            return;
        }
        $file = $this->path.DIRECTORY_SEPARATOR.sprintf(self::COUNTRY_FILE, $country);
        if (!file_exists($file)) {
            return;
        }

        return json_decode(
            file_get_contents($file),
            true
        );
    }

    /**
     * @param string $country
     *
     * @return array
     */
    public function loadCountryPolygon($country)

This method seems to be duplicated in your project.

    {
        if (!$country) {
            return;
        }
        $file = $this->path.DIRECTORY_SEPARATOR.sprintf(self::COUNTRY_POLYGON_FILE, $country);
        if (!file_exists($file)) {
            return;
        }

        return json_decode(
            file_get_contents($file),
            true
        );
    }
}