genkgo / camt

src/Camt053/Decoder/Message.php

<?php

declare(strict_types=1);

namespace Genkgo\Camt\Camt053\Decoder;

use Genkgo\Camt\Camt053\DTO as Camt053DTO;
use Genkgo\Camt\Decoder\Message as BaseMessageDecoder;
use Genkgo\Camt\DTO;
use Genkgo\Camt\Iban;
use SimpleXMLElement;

class Message extends BaseMessageDecoder
{
    public function addRecords(DTO\Message $message, SimpleXMLElement $document): void
    {
        $statements = [];

        $xmlStatements = $this->getRootElement($document)->Stmt;
        foreach ($xmlStatements as $xmlStatement) {
            $statement = new Camt053DTO\Statement(
                (string) $xmlStatement->Id,
                $this->dateDecoder->decode((string) $xmlStatement->CreDtTm),
                $this->getAccount($xmlStatement)

It seems like $xmlStatement can also be of type null; however, parameter $xmlRecord of Genkgo\Camt\Camt053\Decoder\Message::getAccount() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            );

            if (isset($xmlStatement->StmtPgntn)) {
                $statement->setPagination(new DTO\Pagination(
                    (string) $xmlStatement->StmtPgntn->PgNb,
                    ('true' === (string) $xmlStatement->StmtPgntn->LastPgInd) ? true : false
                ));
            }

            if (isset($xmlStatement->AddtlStmtInf)) {
                $statement->setAdditionalInformation((string) $xmlStatement->AddtlStmtInf);
            }

            $this->addCommonRecordInformation($statement, $xmlStatement);

It seems like $xmlStatement can also be of type null; however, parameter $xmlRecord of Genkgo\Camt\Decoder\Message::addCommonRecordInformation() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            $this->recordDecoder->addBalances($statement, $xmlStatement);

It seems like $xmlStatement can also be of type null; however, parameter $xmlRecord of Genkgo\Camt\Decoder\Record::addBalances() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            $this->recordDecoder->addEntries($statement, $xmlStatement);

It seems like $xmlStatement can also be of type null; however, parameter $xmlRecord of Genkgo\Camt\Decoder\Record::addEntries() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            $statements[] = $statement;
        }

        $message->setRecords($statements);
    }

    /**
     * @inheritDoc
     */
    public function getRootElement(SimpleXMLElement $document): SimpleXMLElement
    {
        return $document->BkToCstmrStmt;
    }

    protected function getAccount(SimpleXMLElement $xmlRecord): DTO\Account
    {
        if (isset($xmlRecord->Acct->Id->IBAN)) {
            return new DTO\IbanAccount(new Iban((string) $xmlRecord->Acct->Id->IBAN));
        }

        $xmlOtherIdentification = $xmlRecord->Acct->Id->Othr;
        $otherAccount = new DTO\OtherAccount((string) $xmlOtherIdentification->Id);

        if (isset($xmlOtherIdentification->SchmeNm)) {
            if (isset($xmlOtherIdentification->SchmeNm->Cd)) {
                $otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Cd);
            }

            if (isset($xmlOtherIdentification->SchmeNm->Prtry)) {
                $otherAccount->setSchemeName((string) $xmlOtherIdentification->SchmeNm->Prtry);
            }
        }

        if (isset($xmlOtherIdentification->Issr)) {
            $otherAccount->setIssuer((string) $xmlOtherIdentification->Issr);
        }

        return $otherAccount;
    }
}