Genkgo\Camt\Camt053\Decoder\Message::addRecords()

Complexity

Conditions	5
Paths	5

Size

Total Lines	31
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	5

Importance

Changes

0

<?php
    public function addRecords(DTO\Message $message, SimpleXMLElement $document): void
    {
        $statements = [];

        $xmlStatements = $this->getRootElement($document)->Stmt;
        foreach ($xmlStatements as $xmlStatement) {
            $statement = new Camt053DTO\Statement(
                (string) $xmlStatement->Id,
                $this->dateDecoder->decode((string) $xmlStatement->CreDtTm),
                $this->getAccount($xmlStatement)

It seems like $xmlStatement can also be of type null; however, parameter $xmlRecord of Genkgo\Camt\Camt053\Decoder\Message::getAccount() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            );

            if (isset($xmlStatement->StmtPgntn)) {
                $statement->setPagination(new DTO\Pagination(
                    (string) $xmlStatement->StmtPgntn->PgNb,
                    ('true' === (string) $xmlStatement->StmtPgntn->LastPgInd) ? true : false
                ));
            }

            if (isset($xmlStatement->AddtlStmtInf)) {
                $statement->setAdditionalInformation((string) $xmlStatement->AddtlStmtInf);
            }

            $this->addCommonRecordInformation($statement, $xmlStatement);

It seems like $xmlStatement can also be of type null; however, parameter $xmlRecord of Genkgo\Camt\Decoder\Message::addCommonRecordInformation() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            $this->recordDecoder->addBalances($statement, $xmlStatement);

It seems like $xmlStatement can also be of type null; however, parameter $xmlRecord of Genkgo\Camt\Decoder\Record::addBalances() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            $this->recordDecoder->addEntries($statement, $xmlStatement);

It seems like $xmlStatement can also be of type null; however, parameter $xmlRecord of Genkgo\Camt\Decoder\Record::addEntries() does only seem to accept SimpleXMLElement, maybe add an additional type check?

            $statements[] = $statement;
        }

        $message->setRecords($statements);
    }