PredisAdapter::get() - Code Metrics - genkgo/cache - Measure and Improve Code Quality continuously with Scrutinizer

PredisAdapter::get() A
last analyzed 2017-08-23 14:56 UTC

↳ Parent: PredisAdapter

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php
namespace Genkgo\Cache\Adapter;

use Genkgo\Cache\CacheAdapterInterface;
use Genkgo\Cache\SerializerInterface;
use Predis\ClientInterface;

/**
 * Class PredisAdapter
 * @package Genkgo\Cache\Adapter
 */
class PredisAdapter implements CacheAdapterInterface
{
    /**
     * @var ClientInterface
     */
    private $client;
    /**
     * @var SerializerInterface
     */
    private $serializer;
    /**
     * @var int|null
     */
    private $ttl;

    /**
     * @param ClientInterface $client
     * @param SerializerInterface $serializer
     * @param null $ttl
     */
    public function __construct(
        ClientInterface $client,
        SerializerInterface $serializer,
        $ttl = null
    ) {
        $this->client = $client;
        $this->serializer = $serializer;
        $this->ttl = $ttl;
    }


    /**
     * Gets a cache entry
     * returning null if not in cache
     *
     * @param $key
     * @return null|mixed
     */
    public function get($key)
    {
        return $this->serializer->deserialize($this->client->get($key));
    }

    /**
     * Sets a cache entry
     *
     * @param $key
     * @param $value
     * @return void
     */
    public function set($key, $value)
    {
        if ($this->ttl === null) {
            $this->client->set($key, $this->serializer->serialize($value));
        } else {
            $this->client->set($key, $this->serializer->serialize($value), 'ex', $this->ttl);
        }
    }

    /**
     * Deletes a cache entry
     *
     * @param $key
     * @return void
     */
    public function delete($key)
    {
        if (strpos($key, '*') !== false) {
            $this->deleteGlob($key);
        } else {
            $this->client->del([$key]);
        }
    }

    private function deleteGlob ($pattern) {
        $keys = $this->client->keys($pattern);
        $options = $this->client->getOptions();
        if (isset($options->prefix)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $length = strlen($options->prefix->getPrefix());
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

            $keys = array_map(function ($key) use ($length) {
                return substr($key, $length);
            }, $keys);
        }

        if (count($keys) === 0) {
            return;
        }

        $this->client->del($keys);
    }
}


1		<?php
2		namespace Genkgo\Cache\Adapter;
3
4		use Genkgo\Cache\CacheAdapterInterface;
5		use Genkgo\Cache\SerializerInterface;
6		use Predis\ClientInterface;
7
8		/**
9		* Class PredisAdapter
10		* @package Genkgo\Cache\Adapter
11		*/
12		class PredisAdapter implements CacheAdapterInterface
13		{
14		/**
15		* @var ClientInterface
16		*/
17		private $client;
18		/**
19		* @var SerializerInterface
20		*/
21		private $serializer;
22		/**
23		* @var int\|null
24		*/
25		private $ttl;
26
27		/**
28		* @param ClientInterface $client
29		* @param SerializerInterface $serializer
30		* @param null $ttl
31		*/
32	6	public function __construct(
33		ClientInterface $client,
34		SerializerInterface $serializer,
35		$ttl = null
36		) {
37	6	$this->client = $client;
38	6	$this->serializer = $serializer;
39	6	$this->ttl = $ttl;
40	6	}
41
42
43		/**
44		* Gets a cache entry
45		* returning null if not in cache
46		*
47		* @param $key
48		* @return null\|mixed
49		*/
50	2	public function get($key)
51		{
52	2	return $this->serializer->deserialize($this->client->get($key));
53		}
54
55		/**
56		* Sets a cache entry
57		*
58		* @param $key
59		* @param $value
60		* @return void
61		*/
62	5	public function set($key, $value)
63		{
64	5	if ($this->ttl === null) {
65	4	$this->client->set($key, $this->serializer->serialize($value));
66	4	} else {
67	1	$this->client->set($key, $this->serializer->serialize($value), 'ex', $this->ttl);
68		}
69	5	}
70
71		/**
72		* Deletes a cache entry
73		*
74		* @param $key
75		* @return void
76		*/
77	3	public function delete($key)
78		{
79	3	if (strpos($key, '*') !== false) {
80	2	$this->deleteGlob($key);
81	2	} else {
82	1	$this->client->del([$key]);
83		}
84	3	}
85
86	2	private function deleteGlob ($pattern) {
87	2	$keys = $this->client->keys($pattern);
88	2	$options = $this->client->getOptions();
89	2	if (isset($options->prefix)) {
		0 ignored issues – show Bug introduced 2015-12-14 13:04 UTC by Report Bug Copy Issue Report Accessing `prefix` on the interface `Predis\Configuration\OptionsInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
90	1	$length = strlen($options->prefix->getPrefix());
		0 ignored issues – show Bug introduced 2015-12-14 13:04 UTC by Report Bug Copy Issue Report Accessing `prefix` on the interface `Predis\Configuration\OptionsInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
91
92	1	$keys = array_map(function ($key) use ($length) {
93	1	return substr($key, $length);
94	1	}, $keys);
95	1	}
96
97	2	if (count($keys) === 0) {
98		return;
99		}
100
101	2	$this->client->del($keys);
102	2	}
103		}
104

genkgo / cache

PredisAdapter::get() A last analyzed 2017-08-23 14:56 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

PredisAdapter::get() A
last analyzed 2017-08-23 14:56 UTC