Genkgo\Cache\Adapter\PredisAdapter

Complexity

Total Complexity

9

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

96.88%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	get()	0	4	1
A	set()	0	8	2
A	delete()	0	8	2
A	deleteGlob()	0	17	3

<?php
namespace Genkgo\Cache\Adapter;

use Genkgo\Cache\CacheAdapterInterface;
use Genkgo\Cache\SerializerInterface;
use Predis\ClientInterface;

/**
 * Class PredisAdapter
 * @package Genkgo\Cache\Adapter
 */
class PredisAdapter implements CacheAdapterInterface
{
    /**
     * @var ClientInterface
     */
    private $client;
    /**
     * @var SerializerInterface
     */
    private $serializer;
    /**
     * @var int|null
     */
    private $ttl;

    /**
     * @param ClientInterface $client
     * @param SerializerInterface $serializer
     * @param null $ttl
     */
    public function __construct(
        ClientInterface $client,
        SerializerInterface $serializer,
        $ttl = null
    ) {
        $this->client = $client;
        $this->serializer = $serializer;
        $this->ttl = $ttl;
    }


    /**
     * Gets a cache entry
     * returning null if not in cache
     *
     * @param $key
     * @return null|mixed
     */
    public function get($key)
    {
        return $this->serializer->deserialize($this->client->get($key));
    }

    /**
     * Sets a cache entry
     *
     * @param $key
     * @param $value
     * @return void
     */
    public function set($key, $value)
    {
        if ($this->ttl === null) {
            $this->client->set($key, $this->serializer->serialize($value));
        } else {
            $this->client->set($key, $this->serializer->serialize($value), 'ex', $this->ttl);
        }
    }

    /**
     * Deletes a cache entry
     *
     * @param $key
     * @return void
     */
    public function delete($key)
    {
        if (strpos($key, '*') !== false) {
            $this->deleteGlob($key);
        } else {
            $this->client->del([$key]);
        }
    }

    private function deleteGlob ($pattern) {
        $keys = $this->client->keys($pattern);
        $options = $this->client->getOptions();
        if (isset($options->prefix)) {

Accessing prefix on the interface Predis\Configuration\OptionsInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $length = strlen($options->prefix->getPrefix());

Accessing prefix on the interface Predis\Configuration\OptionsInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $keys = array_map(function ($key) use ($length) {
                return substr($key, $length);
            }, $keys);
        }

        if (count($keys) === 0) {
            return;
        }

        $this->client->del($keys);
    }
}