Completed
Pull Request — dev (#22)
by
unknown
04:13
created
var/SymfonyRequirements.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      * Adds a mandatory requirement in form of a php.ini configuration.
224 224
      *
225 225
      * @param string        $cfgName           The configuration name used for ini_get()
226
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
226
+     * @param boolean|string $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
227 227
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
228 228
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
229 229
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
      * Adds an optional recommendation in form of a php.ini configuration.
242 242
      *
243 243
      * @param string        $cfgName           The configuration name used for ini_get()
244
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
244
+     * @param string|false $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
245 245
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
246 246
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
247 247
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
Please login to merge, or discard this patch.
web/config.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -382,7 +382,10 @@  discard block
 block discarded – undo
382 382
                         <?php if ($hasMinorProblems): ?>
383 383
                             <h2>Recommendations</h2>
384 384
                             <p>
385
-                                <?php if ($hasMajorProblems): ?>Additionally, to<?php else: ?>To<?php endif; ?> enhance your Symfony experience,
385
+                                <?php if ($hasMajorProblems): ?>Additionally, to<?php else {
386
+    : ?>To<?php endif;
387
+}
388
+?> enhance your Symfony experience,
386 389
                                 it’s recommended that you fix the following:
387 390
                             </p>
388 391
                             <ol>
@@ -398,9 +401,12 @@  discard block
 block discarded – undo
398 401
                             <p id="phpini">*
399 402
                                 <?php if ($symfonyRequirements->getPhpIniConfigPath()): ?>
400 403
                                     Changes to the <strong>php.ini</strong> file must be done in "<strong><?php echo $symfonyRequirements->getPhpIniConfigPath() ?></strong>".
401
-                                <?php else: ?>
404
+                                <?php else {
405
+    : ?>
402 406
                                     To change settings, create a "<strong>php.ini</strong>".
403
-                                <?php endif; ?>
407
+                                <?php endif;
408
+}
409
+?>
404 410
                             </p>
405 411
                         <?php endif; ?>
406 412
 
Please login to merge, or discard this patch.
src/AppBundle/Entity/Event.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@
 block discarded – undo
148 148
     }
149 149
 
150 150
     /**
151
-     * @param UserIntern $user
151
+     * @param User $users
152 152
      *
153 153
      * @return Event
154 154
      */
Please login to merge, or discard this patch.
src/AppBundle/Controller/Api/DefaultController.php 1 patch
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 class DefaultController extends Controller
13 13
 {
14 14
     /**
15
-
16 15
      * @param Request $request
17 16
      * @Route("/login", name="api_login")
18 17
      * @Method("POST")
Please login to merge, or discard this patch.
src/AppBundle/Form/User/RegistrationType.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 /**
16 16
  * Class UserType
17 17
  * @package AppBundle\Form
18
-
19 18
  */
20 19
 class RegistrationType extends AbstractType
21 20
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
     {
74 74
         $resolver->setDefaults(array(
75 75
             'data_class' => User::class,
76
-            'validation_groups' => array('registration','edit'),
76
+            'validation_groups' => array('registration', 'edit'),
77 77
         ));
78 78
     }
79 79
 }
Please login to merge, or discard this patch.
src/AppBundle/Form/User/EditType.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
 /**
16 16
  * Class UserType
17 17
  * @package AppBundle\Form
18
-
19 18
  */
20 19
 class EditType extends AbstractType
21 20
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
     {
74 74
         $resolver->setDefaults(array(
75 75
             'data_class' => User::class,
76
-            'validation_groups' => array('registration','edit'),
76
+            'validation_groups' => array('registration', 'edit'),
77 77
         ));
78 78
     }
79 79
 }
Please login to merge, or discard this patch.
src/AppBundle/Form/User/ActivationType.php 2 patches
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 /**
13 13
  * Class UserType
14 14
  * @package AppBundle\Form
15
-
16 15
  */
17 16
 class ActivationType extends AbstractType
18 17
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
     {
74 74
         $resolver->setDefaults(array(
75 75
             'data_class' => User::class,
76
-            'validation_groups' => array('registration','edit'),
76
+            'validation_groups' => array('registration', 'edit'),
77 77
         ));
78 78
     }
79 79
 }
Please login to merge, or discard this patch.
src/AppBundle/Repository/UserRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
                 ->orWhere(
41 41
                     $postsQuery->expr()->like('u.email', ':name')
42 42
                 )
43
-                ->setParameter('name', '%' . $filter->name . '%');
43
+                ->setParameter('name', '%'.$filter->name.'%');
44 44
         }
45 45
 
46 46
         return $postsQuery->getQuery();
Please login to merge, or discard this patch.
tests/AppBundle/Controller/UserControllerTest.php 2 patches
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,10 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace Tests\AppBundle\Controller;
4 4
 
5
-use AppBundle\Form\User\EditType;
6 5
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
7
-use Symfony\Component\DependencyInjection\ContainerInterface;
8
-use Doctrine\ORM\EntityManager;
9 6
 use AppBundle\Entity\User;
10 7
 
11 8
 class UserControllerTest extends WebTestCase
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
         $form = $crawler->filter('table td form')->form();
67 67
         $url_params = explode('/', $form->getUri());
68
-        $userid = $url_params[count($url_params)-1];
68
+        $userid = $url_params[count($url_params) - 1];
69 69
 
70 70
         $client->submit($form, ['activation[enabled]' => false]);
71 71
         $user = $em->getRepository('AppBundle:User')->findOneBy(array("id" => $userid));
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 
89 89
         $form = $crawler->filter('table td form')->form();
90 90
         $url_params = explode('/', $form->getUri());
91
-        $userid = $url_params[count($url_params)-1];
91
+        $userid = $url_params[count($url_params) - 1];
92 92
 
93 93
         $crawler = $client->request('GET', '/user/edit/'.$userid);
94 94
         $form = $crawler->selectButton('Save')->form();
Please login to merge, or discard this patch.