WorkermanHttpWrapper::__construct() - Code Metrics - garveen/laravoole - Measure and Improve Code Quality continuously with Scrutinizer

WorkermanHttpWrapper::__construct() A
last analyzed 2017-08-11 07:11 UTC

↳ Parent: WorkermanHttpWrapper

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	2
dl	0
loc	5
ccs	4
cts	4
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php
namespace Laravoole\Wrapper;

use Laravoole\Workerman\Worker;
use Laravoole\Illuminate\Request;
use Laravoole\Response;

class WorkermanHttpWrapper extends Workerman implements ServerInterface
{
    use HttpTrait;

    public function __construct($host, $port)
    {
        parent::__construct($host, $port);
        $this->server = new Worker("http://{$host}:{$port}");
    }

    public function start()
    {
        $this->on('Receive', [$this, 'onRequest']);
        return parent::start();
    }

    public function onWorkerStart($worker)
    {
        parent::onWorkerStart($worker);
        $this->accept_gzip = config('laravoole.base_config.gzip');
    }

    public function onRequest($connection, $data)
    {
        $request = new Request($data['get'], $data['post'], []/* attributes */, $data['cookie'], $data['files'], $data['server']);
        $request->setLaravooleInfo(['workermanConnection' => $connection]);
        $response = new Response($this, $request);
        // provide response callback
        $illuminateResponse = parent::handleRequest($request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        return $this->handleResponse($response, $illuminateResponse, $request->header('Accept-Encoding', ''));

    }

    public function endResponse($response, $content)
    {
    	$connection = $response->request->getLaravooleInfo()->workermanConnection;
        if (!is_string($content)) {
        	$response->content = file_get_contents($content());
        } else {
        	$response->content = $content;
        }
        $rawContent = $response->getRawContent();
    	$connection->maxSendBufferSize = strlen($rawContent);
        $connection->close($rawContent, true);
    }
}


1		<?php
2		namespace Laravoole\Wrapper;
3
4		use Laravoole\Workerman\Worker;
5		use Laravoole\Illuminate\Request;
6		use Laravoole\Response;
7
8		class WorkermanHttpWrapper extends Workerman implements ServerInterface
9		{
10		use HttpTrait;
11
12	4	public function __construct($host, $port)
13		{
14	4	parent::__construct($host, $port);
15	4	$this->server = new Worker("http://{$host}:{$port}");
16	4	}
17
18	4	public function start()
19		{
20	4	$this->on('Receive', [$this, 'onRequest']);
21	4	return parent::start();
22		}
23
24	4	public function onWorkerStart($worker)
25		{
26	4	parent::onWorkerStart($worker);
27	4	$this->accept_gzip = config('laravoole.base_config.gzip');
28	4	}
29
30	4	public function onRequest($connection, $data)
31		{
32	4	$request = new Request($data['get'], $data['post'], []/* attributes */, $data['cookie'], $data['files'], $data['server']);
33	4	$request->setLaravooleInfo(['workermanConnection' => $connection]);
34	4	$response = new Response($this, $request);
35		// provide response callback
36	4	$illuminateResponse = parent::handleRequest($request);
		0 ignored issues – show Comprehensibility Bug introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`handleRequest()` instead of `onRequest()`). Are you sure this is correct? If so, you might want to change this to `$this->handleRequest()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
37	4	return $this->handleResponse($response, $illuminateResponse, $request->header('Accept-Encoding', ''));
		0 ignored issues – show Bug introduced 2017-03-15 10:42 UTC by Report Bug Copy Issue Report It seems like `$request->header('Accept-Encoding', '')` targeting `Illuminate\Http\Concerns...actsWithInput::header()` can also be of type `array`; however, `Laravoole\Wrapper\HttpTrait::handleResponse()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
38		}
39
40	4	public function endResponse($response, $content)
41		{
42	4	$connection = $response->request->getLaravooleInfo()->workermanConnection;
43	4	if (!is_string($content)) {
44	4	$response->content = file_get_contents($content());
45	2	} else {
46	4	$response->content = $content;
47		}
48	4	$rawContent = $response->getRawContent();
49	4	$connection->maxSendBufferSize = strlen($rawContent);
50	4	$connection->close($rawContent, true);
51	4	}
52		}
53

garveen / laravoole

WorkermanHttpWrapper::__construct() A last analyzed 2017-08-11 07:11 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

WorkermanHttpWrapper::__construct() A
last analyzed 2017-08-11 07:11 UTC