Laravoole\Wrapper\WorkermanHttpWrapper

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	start()	0	5	1
A	onWorkerStart()	0	5	1
A	onRequest()	0	9	1
A	endResponse()	0	12	2

<?php
namespace Laravoole\Wrapper;

use Laravoole\Workerman\Worker;
use Laravoole\Illuminate\Request;
use Laravoole\Response;

class WorkermanHttpWrapper extends Workerman implements ServerInterface
{
    use HttpTrait;

    public function __construct($host, $port)
    {
        parent::__construct($host, $port);
        $this->server = new Worker("http://{$host}:{$port}");
    }

    public function start()
    {
        $this->on('Receive', [$this, 'onRequest']);
        return parent::start();
    }

    public function onWorkerStart($worker)
    {
        parent::onWorkerStart($worker);
        $this->accept_gzip = config('laravoole.base_config.gzip');
    }

    public function onRequest($connection, $data)
    {
        $request = new Request($data['get'], $data['post'], []/* attributes */, $data['cookie'], $data['files'], $data['server']);
        $request->setLaravooleInfo(['workermanConnection' => $connection]);
        $response = new Response($this, $request);
        // provide response callback
        $illuminateResponse = parent::handleRequest($request);

It seems like you call parent on a different method (handleRequest() instead of onRequest()). Are you sure this is correct? If so, you might want to change this to $this->handleRequest().

        return $this->handleResponse($response, $illuminateResponse, $request->header('Accept-Encoding', ''));

It seems like $request->header('Accept-Encoding', '') targeting Illuminate\Http\Concerns\InteractsWithInput::header() can also be of type array; however, Laravoole\Wrapper\HttpTrait::handleResponse() does only seem to accept string, maybe add an additional type check?

    }

    public function endResponse($response, $content)
    {
    	$connection = $response->request->getLaravooleInfo()->workermanConnection;
        if (!is_string($content)) {
        	$response->content = file_get_contents($content());
        } else {
        	$response->content = $content;
        }
        $rawContent = $response->getRawContent();
    	$connection->maxSendBufferSize = strlen($rawContent);
        $connection->close($rawContent, true);
    }
}