ganbarodigital / php-the-missing-bits

src/string-functions.php

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
         // in case a named parameter appears multiple times in the format string
         if ($paramKeys[$paramName] === -1) {
             // no - it needs a home
-            $messageData[$nextData] =& $args[$paramName];
+            $messageData[$nextData] = & $args[$paramName];
             $paramKeys[$paramName] = $nextData;
             $nextData++;
         }

Braces +4 added lines, -2 removed lines

@@ -52,7 +52,8 @@ 
 *         the unmodified $key if it is not a string
 *         the quoted $key if it is a string
 */
-function quote_index($key) {
+function quote_index($key)
+{
     if (!is_string($key)) {
         return $key;
     }
@@ -68,7 +69,8 @@ 
  *         the property name to add braces to (if required)
  * @return string
  */
-function quote_property($propertyName) {
+function quote_property($propertyName)
+{
     // robustness!
     if (!check_is_stringy($propertyName)) {
         throw new InvalidArgumentException('$propertyName is not a valid class or object property name');

src/TypeInspectors/GetStringTypes.php

Spacing +2 added lines, -2 removed lines

@@ -118,14 +118,14 @@
         }
 
         // if we get here, then $item will coerce to a PHP numeric type :)
-        return [ $retval => $retval ];
+        return [$retval => $retval];
     }
 
     private static function fromObject($item)
     {
         // does this object support being converted to a string?
         if (method_exists($item, '__toString')) {
-            return [ 'string' => 'string' ];
+            return ['string' => 'string'];
         }
 
         // no, it does not

src/TypeInspectors/GetStrictTypes.php

Spacing +4 added lines, -4 removed lines

@@ -49,9 +49,9 @@ 
 class GetStrictTypes
 {
     private static $dispatchMap = [
-        'array' => [ GetArrayTypes::class, 'from' ],
-        'object' => [ GetObjectTypes::class, 'from' ],
-        'string' => [ GetStringTypes::class, 'from' ],
+        'array' => [GetArrayTypes::class, 'from'],
+        'object' => [GetObjectTypes::class, 'from'],
+        'string' => [GetStringTypes::class, 'from'],
     ];
 
     /**
@@ -84,6 +84,6 @@ 
         }
 
         // if we get here, then we just return the PHP scalar type
-        return [ $type => $type ];
+        return [$type => $type];
     }
 }

src/TraceInspectors/FilterBacktrace.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 
         // PHP's stack trace is a little esoteric. To find all the details about
         // a caller, we have to combine information from two stack frames.
-        $prevFrame = $backtrace[max($index - 1,0)];
+        $prevFrame = $backtrace[max($index - 1, 0)];
 
         // find the first backtrace entry that passes our filters
         for ($i = $index; $i <= $maxIndex; $i++) {

src/TypeInspectors/GetDuckTypes.php

Spacing +2 added lines, -2 removed lines

@@ -91,7 +91,7 @@ 
         }
 
         // if we get here, then we just return the PHP scalar type
-        return [ $type => $type ];
+        return [$type => $type];
     }
 
     /**
@@ -130,7 +130,7 @@ 
         $retval = array_merge(
             GetObjectTypes::from($item),
             self::getObjectSpecialTypes($item),
-            [ 'object' => 'object' ]
+            ['object' => 'object']
         );
 
         return $retval;

Doc Comments +1 added lines, -1 removed lines

@@ -194,7 +194,7 @@
      *
      * @param  mixed $item
      *         the item to examine
-     * @return array
+     * @return string[]
      *         the basic type of the examined item
      */
     private static function fromString($item)

src/TypeInspectors/GetStringDuckTypes.php

Spacing +1 added lines, -1 removed lines

@@ -157,7 +157,7 @@
     {
         // does this object support being converted to a string?
         if (method_exists($item, '__toString')) {
-            return [ 'string' => 'string' ];
+            return ['string' => 'string'];
         }
 
         // no, it does not

src/list-functions.php

Indentation +11 added lines, -11 removed lines

@@ -45,17 +45,17 @@
 use GanbaroDigital\MissingBits\ListTraversals\TraverseList;
 use GanbaroDigital\MissingBits\ListTraversals\TraverseObject;
 
- /**
-  * traverse a list held in an array
-  *
-  * @param  array $list
-  *         the list to walk
-  * @param  string $listName
-  *         what is the name of $list in the calling code?
-  * @param  callable $callable
-  *         what are we calling
-  * @return void
-  */
+    /**
+     * traverse a list held in an array
+     *
+     * @param  array $list
+     *         the list to walk
+     * @param  string $listName
+     *         what is the name of $list in the calling code?
+     * @param  callable $callable
+     *         what are we calling
+     * @return void
+     */
 function traverse_array($list, $listName, callable $callable)
 {
     return TraverseArray::using($list, $listName, $callable);

src/type-functions.php

Doc Comments +3 added lines, -3 removed lines

@@ -543,7 +543,7 @@ 
 /**
  * is $item something that PHP will accept as a string?
  *
- * @param  mixed $item
+ * @param  string $item
  *         the variable to examine
  * @return bool
  *         TRUE if PHP will happily use $item as a string
@@ -652,7 +652,7 @@ 
 /**
  * what PHP type is $item?
  *
- * @param  mixed $item
+ * @param  string $item
  *         the data to examine
  * @param  int $flags
  *         options to change what we put in the return value
@@ -669,7 +669,7 @@ 
  *
  * @param  mixed $item
  *         the item to examine
- * @return array
+ * @return string[]
  *         the list of type(s) that this item can be
  */
 function get_strict_types($item)

src/TypeInspectors/GetPrintableType.php

Spacing +1 added lines, -1 removed lines

@@ -164,7 +164,7 @@
         }
 
         // $item contains an <object, method> pair
-        return "callable<" . get_class($item[0]). "::" . $item[1] . ">";
+        return "callable<" . get_class($item[0]) . "::" . $item[1] . ">";
     }
 
     /**