g1a / hubph

src/Internal/EventLogger.php

Doc Comments +3 added lines

@@ -55,6 +55,9 @@
 EOT;
     }
 
+    /**
+     * @param string $event_name
+     */
     protected function getEntry($event_name, $args, $params, $response)
     {
         $args_string = json_encode($args);

src/HubphAPI.php

Doc Comments +16 added lines

@@ -36,6 +36,9 @@ 
         $this->eventLogger = null;
     }
 
+    /**
+     * @param string $as
+     */
     public function setAs($as)
     {
         if ($as != $this->as) {
@@ -122,6 +125,9 @@ 
         return [$status, $existingPRs];
     }
 
+    /**
+     * @param string $number
+     */
     public function prStatuses($projectWithOrg, $number)
     {
         list($org, $project) = explode('/', $projectWithOrg, 2);
@@ -141,6 +147,10 @@ 
         uasort(
 
             $pullRequestStatus,
+
+            /**
+             * @param string $rhs
+             */
             function ($lhs, $rhs) {
                 return abs(strtotime($lhs['updated_at']) - strtotime($rhs['updated_at']));
             }
@@ -171,11 +181,17 @@ 
         return $remote;
     }
 
+    /**
+     * @param string $projectWithOrg
+     */
     protected function existingPRs($projectWithOrg, VersionIdentifiers $vids)
     {
         return $this->matchingPRs($projectWithOrg, $vids->getPreamble(), $vids->pattern());
     }
 
+    /**
+     * @param string $preamble
+     */
     public function matchingPRs($projectWithOrg, $preamble, $pattern = '')
     {
         $q = "repo:$projectWithOrg in:title is:pr state:open $preamble";

src/Cli/HubphCommands.php

Doc Comments +15 added lines, -6 removed lines

@@ -194,6 +194,9 @@ 
         return $this->getProjectWithOrfFromUrl($remote);
     }
 
+    /**
+     * @param string $remote
+     */
     protected function getProjectWithOrfFromUrl($remote)
     {
         $remote = preg_replace('#^git@[^:]*:#', '', $remote);
@@ -251,7 +254,7 @@ 
      *   _links: Links
      * @default-fields number,user,title
      * @default-string-field number
-     * @return Consolidation\OutputFormatters\StructuredData\RowsOfFields
+     * @return RowsOfFields
     */
     public function prFind($projectWithOrg = '', $options = ['as' => 'default', 'format' => 'yaml', 'q' => ''])
     {
@@ -311,7 +314,7 @@ 
      * @default-fields full_name,language,default_branch
      * @default-string-field full_name
      *
-     * @return Consolidation\OutputFormatters\StructuredData\RowsOfFields
+     * @return RowsOfFields
      */
     public function orgRepos($org, $options = ['as' => 'default', 'format' => 'table'])
     {
@@ -362,7 +365,7 @@ 
      *   license: License
      *   permissions: Permissions
      *
-     * @return Consolidation\OutputFormatters\StructuredData\PropertyList
+     * @return PropertyList
      */
     public function repoInfo($projectWithOrg = '', $options = ['as' => 'default', 'format' => 'table'])
     {
@@ -426,6 +429,9 @@ 
         $this->logger->notice("Set default branch to {new}.", ['new' => $newDefault]);
     }
 
+    /**
+     * @param WorkingCopy $workingCopy
+     */
     protected function configureDefaultWithWorkingCopy($workingCopy, $currentDefault, $newDefault, $currentHeadSha)
     {
         $statusResult = $workingCopy->status();
@@ -503,7 +509,7 @@ 
      *   head: Head
      *   base: Base
      *   _links: Links
-     * @return Consolidation\OutputFormatters\StructuredData\PropertyList
+     * @return PropertyList
      */
     public function prShow($projectWithOrg = '', $number = '', $options = ['as' => 'default', 'format' => 'table'])
     {
@@ -540,7 +546,7 @@ 
      *   updated_at: Updated
      * @default-fields id,creator,state,description
      * @default-string-field description
-     * @return Consolidation\OutputFormatters\StructuredData\RowsOfFields
+     * @return RowsOfFields
      */
     public function prStatuses($projectWithOrg = '', $number = '', $options = ['as' => 'default', 'format' => 'yaml'])
     {
@@ -598,7 +604,7 @@ 
      *   _links: Links
      * @default-fields number,user,title
      * @default-string-field number
-     * @return Consolidation\OutputFormatters\StructuredData\RowsOfFields
+     * @return RowsOfFields
      */
     public function prList($projectWithOrg = '', $options = ['state' => 'open', 'as' => 'default', 'format' => 'table'])
     {
@@ -649,6 +655,9 @@ 
         );
     }
 
+    /**
+     * @param string $field
+     */
     protected function keyById($data, $field)
     {
         return

Unused Use Statements -4 removed lines

@@ -2,9 +2,6 @@ 
 
 namespace Hubph\Cli;
 
-use Consolidation\AnnotatedCommand\CommandData;
-use Consolidation\Filter\FilterOutputData;
-use Consolidation\Filter\LogicalOpFactory;
 use Consolidation\OutputFormatters\Options\FormatterOptions;
 use Consolidation\OutputFormatters\StructuredData\RowsOfFields;
 use Consolidation\OutputFormatters\StructuredData\PropertyList;
@@ -15,7 +12,6 @@ 
 use Consolidation\AnnotatedCommand\CommandError;
 use Hubph\HubphAPI;
 use Hubph\VersionIdentifiers;
-use Hubph\PullRequests;
 use Hubph\Git\WorkingCopy;
 
 class HubphCommands extends \Robo\Tasks implements ConfigAwareInterface, LoggerAwareInterface

src/Git/Git.php

Unused Use Statements -3 removed lines

@@ -3,9 +3,6 @@
 
 namespace Hubph\Git;
 
-use Psr\Log\LoggerAwareInterface;
-use Psr\Log\LoggerAwareTrait;
-use Symfony\Component\Filesystem\Filesystem;
 use Hubph\Util\ExecWithRedactionTrait;
 
 trait Git

src/Git/Remote.php

Doc Comments +7 added lines

@@ -45,6 +45,9 @@ 
         return !empty($this->remote);
     }
 
+    /**
+     * @return string
+     */
     public function projectWithOrg()
     {
         return static::projectWithOrgFromUrl($this->remote);
@@ -123,6 +126,9 @@ 
         $this->git('push --delete {remote} {tag}', ['remote' => $this->remote, 'tag' => $tag]);
     }
 
+    /**
+     * @param string $tag
+     */
     protected function satisfies($tag, $version_constraints)
     {
         // If we are using a regex rather than semver, then pass anything.
@@ -184,6 +190,7 @@ 
     /**
      * Run a git function on the local working copy. Fail on error.
      *
+     * @param string $cmd
      * @return string stdout
      */
     public function git($cmd, $replacements = [], $redacted = [])

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Composer\Semver\Semver;
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
-use Symfony\Component\Filesystem\Filesystem;
 use Hubph\Util\ExecWithRedactionTrait;
 
 class Remote implements LoggerAwareInterface

src/Git/WorkingCopy.php

Doc Comments +8 added lines

@@ -35,6 +35,9 @@ 
         $this->confirmCachedRepoHasCorrectRemote();
     }
 
+    /**
+     * @param string $dir
+     */
     public static function fromDir($dir, $remoteName = 'origin', $api = null)
     {
         $remote = Remote::fromDir($dir, $remoteName);
@@ -218,6 +221,9 @@ 
         return Remote::fromDir($this->dir, $remote_name);
     }
 
+    /**
+     * @return string
+     */
     public function url($remote_name = '')
     {
         return $this->remote($remote_name)->url();
@@ -258,6 +264,8 @@ 
 
     /**
      * Fetch from the specified remote.
+     * @param string $remote
+     * @param string $branch
      */
     public function fetch($remote, $branch)
     {

src/Util/ExecWithRedactionTrait.php

Doc Comments +3 added lines

@@ -3,6 +3,9 @@
 
 trait ExecWithRedactionTrait
 {
+    /**
+     * @param string $cmd
+     */
     protected function execWithRedaction($cmd, $replacements = [], $redacted = [])
     {
         $redactedReplacements = $this->redactedReplacements($replacements, $redacted);