PullRequests::addSearchResults() - Code Metrics - Inspection of "Initial implementation of pr:check and related com..." - g1a/hubph - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b60952...ee4ec3 )

by Greg

created 2018-07-25 22:35 UTC

PullRequests::addSearchResults() A

↳ Parent: PullRequests

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Hubph;

class PullRequests
{
    protected $prs = [];

    /**
     * PullRequests constructor
     */
    public function __construct()
    {
    }

    public function addSearchResults($searchResults)
    {
        //print "Search results with $vid: ($q)\n";
        //var_export($searchResults);
        //print "\n";

        $total = $searchResults['total_count'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $incomplete = $searchResults['incomplete_results'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        foreach ($searchResults['items'] as $pr) {
            $this->add($pr);
        }
    }

    public function add($pr)
    {
        $this->prs[$pr['number']] = $pr;
    }

    public function titles()
    {
        $titles = array_map(
            function ($pr) {
                return $pr['title'];
            }, $this->prs
        );
        return $titles;
    }

    public function prNumbers()
    {
        return array_keys($this->prs);
    }

    public function isEmpty()
    {
        return empty($this->prs);
    }
}


1			<?php
2
3			namespace Hubph;
4
5			class PullRequests
6			{
7			protected $prs = [];
8
9			/**
10			* PullRequests constructor
11			*/
12			public function __construct()
13			{
14			}
15
16			public function addSearchResults($searchResults)
17			{
18			//print "Search results with $vid: ($q)\n";
19			//var_export($searchResults);
20			//print "\n";
21
22			$total = $searchResults['total_count'];
			0 ignored issues – show Unused Code introduced 2018-07-25 22:37 UTC by Report Bug Copy Issue Report `$total` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
23			$incomplete = $searchResults['incomplete_results'];
			0 ignored issues – show Unused Code introduced 2018-07-25 22:37 UTC by Report Bug Copy Issue Report `$incomplete` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
24
25			foreach ($searchResults['items'] as $pr) {
26			$this->add($pr);
27			}
28			}
29
30			public function add($pr)
31			{
32			$this->prs[$pr['number']] = $pr;
33			}
34
35			public function titles()
36			{
37			$titles = array_map(
38			function ($pr) {
39			return $pr['title'];
40			}, $this->prs
41			);
42			return $titles;
43			}
44
45			public function prNumbers()
46			{
47			return array_keys($this->prs);
48			}
49
50			public function isEmpty()
51			{
52			return empty($this->prs);
53			}
54			}
55

g1a / hubph

Push — master ( b60952...ee4ec3 )

PullRequests::addSearchResults() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like