Completed
Push — master ( b60952...ee4ec3 )
by Greg
02:01
created

PullRequests   A

Complexity

Total Complexity 7

Size/Duplication

Total Lines 50
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 0

Importance

Changes 0
Metric Value
wmc 7
lcom 1
cbo 0
dl 0
loc 50
rs 10
c 0
b 0
f 0

6 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 3 1
A addSearchResults() 0 13 2
A add() 0 4 1
A titles() 0 9 1
A prNumbers() 0 4 1
A isEmpty() 0 4 1
1
<?php
2
3
namespace Hubph;
4
5
class PullRequests
6
{
7
    protected $prs = [];
8
9
    /**
10
     * PullRequests constructor
11
     */
12
    public function __construct()
13
    {
14
    }
15
16
    public function addSearchResults($searchResults)
17
    {
18
        //print "Search results with $vid: ($q)\n";
19
        //var_export($searchResults);
20
        //print "\n";
21
22
        $total = $searchResults['total_count'];
0 ignored issues
show
Unused Code introduced by
$total is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
23
        $incomplete = $searchResults['incomplete_results'];
0 ignored issues
show
Unused Code introduced by
$incomplete is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
24
25
        foreach ($searchResults['items'] as $pr) {
26
            $this->add($pr);
27
        }
28
    }
29
30
    public function add($pr)
31
    {
32
        $this->prs[$pr['number']] = $pr;
33
    }
34
35
    public function titles()
36
    {
37
        $titles = array_map(
38
            function ($pr) {
39
                return $pr['title'];
40
            }, $this->prs
41
        );
42
        return $titles;
43
    }
44
45
    public function prNumbers()
46
    {
47
        return array_keys($this->prs);
48
    }
49
50
    public function isEmpty()
51
    {
52
        return empty($this->prs);
53
    }
54
}
55