Completed
Push — master ( c4f878...6d18b5 )
by frank
02:06
created
classes/autoptimizeVersionUpdatesHandler.php 1 patch
Spacing   +56 added lines, -56 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * Handles version updates and should only be instantiated in autoptimize.php if/when needed.
4 4
  */
5 5
 
6
-if ( ! defined( 'ABSPATH' ) ) {
6
+if (!defined('ABSPATH')) {
7 7
     exit;
8 8
 }
9 9
 
@@ -16,9 +16,9 @@  discard block
 block discarded – undo
16 16
      */
17 17
     protected $current_major_version = null;
18 18
 
19
-    public function __construct( $current_version )
19
+    public function __construct($current_version)
20 20
     {
21
-        $this->current_major_version = substr( $current_version, 0, 3 );
21
+        $this->current_major_version = substr($current_version, 0, 3);
22 22
     }
23 23
 
24 24
     /**
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
     {
30 30
         $major_update = false;
31 31
 
32
-        switch ( $this->current_major_version ) {
32
+        switch ($this->current_major_version) {
33 33
             case '1.6':
34 34
                 $this->upgrade_from_1_6();
35 35
                 $major_update = true;
@@ -47,14 +47,14 @@  discard block
 block discarded – undo
47 47
                 $major_update = true;
48 48
                 // No break, intentionally, so all upgrades are ran during a single request...
49 49
             case '2.4':
50
-                if ( get_option( 'autoptimize_version', 'none' ) == '2.4.2' ) {
50
+                if (get_option('autoptimize_version', 'none') == '2.4.2') {
51 51
                     $this->upgrade_from_2_4_2();
52 52
                 }
53 53
                 $major_update = false;
54 54
                 // No break, intentionally, so all upgrades are ran during a single request...
55 55
         }
56 56
 
57
-        if ( true === $major_update ) {
57
+        if (true === $major_update) {
58 58
             $this->on_major_version_update();
59 59
         }
60 60
     }
@@ -66,19 +66,19 @@  discard block
 block discarded – undo
66 66
      *
67 67
      * @param string $target Target version to check against (ie., the currently running one).
68 68
      */
69
-    public static function check_installed_and_update( $target )
69
+    public static function check_installed_and_update($target)
70 70
     {
71
-        $db_version = get_option( 'autoptimize_version', 'none' );
72
-        if ( $db_version !== $target ) {
73
-            if ( 'none' === $db_version ) {
74
-                add_action( 'admin_notices', 'autoptimizeMain::notice_installed' );
71
+        $db_version = get_option('autoptimize_version', 'none');
72
+        if ($db_version !== $target) {
73
+            if ('none' === $db_version) {
74
+                add_action('admin_notices', 'autoptimizeMain::notice_installed');
75 75
             } else {
76
-                $updater = new self( $db_version );
76
+                $updater = new self($db_version);
77 77
                 $updater->run_needed_major_upgrades();
78 78
             }
79 79
 
80 80
             // Versions differed, upgrades happened if needed, store the new version.
81
-            update_option( 'autoptimize_version', $target );
81
+            update_option('autoptimize_version', $target);
82 82
         }
83 83
     }
84 84
 
@@ -89,10 +89,10 @@  discard block
 block discarded – undo
89 89
     protected function on_major_version_update()
90 90
     {
91 91
         // The transients guard here prevents stale object caches from busting the cache on every request.
92
-        if ( false == get_transient( 'autoptimize_stale_option_buster' ) ) {
93
-            set_transient( 'autoptimize_stale_option_buster', 'Mamsie & Liessie zehhe: ZWIJH!', HOUR_IN_SECONDS );
92
+        if (false == get_transient('autoptimize_stale_option_buster')) {
93
+            set_transient('autoptimize_stale_option_buster', 'Mamsie & Liessie zehhe: ZWIJH!', HOUR_IN_SECONDS);
94 94
             autoptimizeCache::clearall();
95
-            add_action( 'admin_notices', 'autoptimizeMain::notice_updated' );
95
+            add_action('admin_notices', 'autoptimizeMain::notice_updated');
96 96
         }
97 97
     }
98 98
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     private function upgrade_from_1_6()
103 103
     {
104 104
         // If user was on version 1.6.x, force advanced options to be shown by default.
105
-        update_option( 'autoptimize_show_adv', '1' );
105
+        update_option('autoptimize_show_adv', '1');
106 106
 
107 107
         // And remove old options.
108 108
         $to_delete_options = array(
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
             'autoptimize_cdn_img_url',
115 115
             'autoptimize_css_yui',
116 116
         );
117
-        foreach ( $to_delete_options as $del_opt ) {
118
-            delete_option( $del_opt );
117
+        foreach ($to_delete_options as $del_opt) {
118
+            delete_option($del_opt);
119 119
         }
120 120
     }
121 121
 
@@ -126,29 +126,29 @@  discard block
 block discarded – undo
126 126
      */
127 127
     private function upgrade_from_1_7()
128 128
     {
129
-        if ( ! is_multisite() ) {
130
-            $css_exclude = get_option( 'autoptimize_css_exclude' );
131
-            if ( empty( $css_exclude ) ) {
129
+        if (!is_multisite()) {
130
+            $css_exclude = get_option('autoptimize_css_exclude');
131
+            if (empty($css_exclude)) {
132 132
                 $css_exclude = 'admin-bar.min.css, dashicons.min.css';
133
-            } elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) {
133
+            } elseif (false === strpos($css_exclude, 'dashicons.min.css')) {
134 134
                 $css_exclude .= ', dashicons.min.css';
135 135
             }
136
-            update_option( 'autoptimize_css_exclude', $css_exclude );
136
+            update_option('autoptimize_css_exclude', $css_exclude);
137 137
         } else {
138 138
             global $wpdb;
139
-            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
139
+            $blog_ids         = $wpdb->get_col("SELECT blog_id FROM $wpdb->blogs");
140 140
             $original_blog_id = get_current_blog_id();
141
-            foreach ( $blog_ids as $blog_id ) {
142
-                switch_to_blog( $blog_id );
143
-                $css_exclude = get_option( 'autoptimize_css_exclude' );
144
-                if ( empty( $css_exclude ) ) {
141
+            foreach ($blog_ids as $blog_id) {
142
+                switch_to_blog($blog_id);
143
+                $css_exclude = get_option('autoptimize_css_exclude');
144
+                if (empty($css_exclude)) {
145 145
                     $css_exclude = 'admin-bar.min.css, dashicons.min.css';
146
-                } elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) {
146
+                } elseif (false === strpos($css_exclude, 'dashicons.min.css')) {
147 147
                     $css_exclude .= ', dashicons.min.css';
148 148
                 }
149
-                update_option( 'autoptimize_css_exclude', $css_exclude );
149
+                update_option('autoptimize_css_exclude', $css_exclude);
150 150
             }
151
-            switch_to_blog( $original_blog_id );
151
+            switch_to_blog($original_blog_id);
152 152
         }
153 153
     }
154 154
 
@@ -160,19 +160,19 @@  discard block
 block discarded – undo
160 160
      */
161 161
     private function upgrade_from_1_9()
162 162
     {
163
-        if ( ! is_multisite() ) {
164
-            update_option( 'autoptimize_css_include_inline', 'on' );
165
-            update_option( 'autoptimize_js_include_inline', 'on' );
163
+        if (!is_multisite()) {
164
+            update_option('autoptimize_css_include_inline', 'on');
165
+            update_option('autoptimize_js_include_inline', 'on');
166 166
         } else {
167 167
             global $wpdb;
168
-            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
168
+            $blog_ids         = $wpdb->get_col("SELECT blog_id FROM $wpdb->blogs");
169 169
             $original_blog_id = get_current_blog_id();
170
-            foreach ( $blog_ids as $blog_id ) {
171
-                switch_to_blog( $blog_id );
172
-                update_option( 'autoptimize_css_include_inline', 'on' );
173
-                update_option( 'autoptimize_js_include_inline', 'on' );
170
+            foreach ($blog_ids as $blog_id) {
171
+                switch_to_blog($blog_id);
172
+                update_option('autoptimize_css_include_inline', 'on');
173
+                update_option('autoptimize_js_include_inline', 'on');
174 174
             }
175
-            switch_to_blog( $original_blog_id );
175
+            switch_to_blog($original_blog_id);
176 176
         }
177 177
     }
178 178
 
@@ -183,17 +183,17 @@  discard block
 block discarded – undo
183 183
      */
184 184
     private function upgrade_from_2_2()
185 185
     {
186
-        if ( ! is_multisite() ) {
186
+        if (!is_multisite()) {
187 187
             $this->do_2_2_settings_update();
188 188
         } else {
189 189
             global $wpdb;
190
-            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
190
+            $blog_ids         = $wpdb->get_col("SELECT blog_id FROM $wpdb->blogs");
191 191
             $original_blog_id = get_current_blog_id();
192
-            foreach ( $blog_ids as $blog_id ) {
193
-                switch_to_blog( $blog_id );
192
+            foreach ($blog_ids as $blog_id) {
193
+                switch_to_blog($blog_id);
194 194
                 $this->do_2_2_settings_update();
195 195
             }
196
-            switch_to_blog( $original_blog_id );
196
+            switch_to_blog($original_blog_id);
197 197
         }
198 198
     }
199 199
 
@@ -202,12 +202,12 @@  discard block
 block discarded – undo
202 202
      */
203 203
     private function do_2_2_settings_update()
204 204
     {
205
-        $nogooglefont    = get_option( 'autoptimize_css_nogooglefont', '' );
206
-        $ao_extrasetting = get_option( 'autoptimize_extra_settings', '' );
207
-        if ( ( $nogooglefont ) && ( empty( $ao_extrasetting ) ) ) {
208
-            update_option( 'autoptimize_extra_settings', autoptimizeConfig::get_ao_extra_default_options() );
205
+        $nogooglefont    = get_option('autoptimize_css_nogooglefont', '');
206
+        $ao_extrasetting = get_option('autoptimize_extra_settings', '');
207
+        if (($nogooglefont) && (empty($ao_extrasetting))) {
208
+            update_option('autoptimize_extra_settings', autoptimizeConfig::get_ao_extra_default_options());
209 209
         }
210
-        delete_option( 'autoptimize_css_nogooglefont' );
210
+        delete_option('autoptimize_css_nogooglefont');
211 211
     }
212 212
 
213 213
     /**
@@ -219,15 +219,15 @@  discard block
 block discarded – undo
219 219
         $jobs = _get_cron_array();
220 220
 
221 221
         // Remove all ao_cachechecker cron jobs (for now).
222
-        foreach ( $jobs as $when => $job ) {
223
-            $name = key( $job );
222
+        foreach ($jobs as $when => $job) {
223
+            $name = key($job);
224 224
 
225
-            if ( false !== strpos( $name, 'ao_cachechecker' ) ) {
226
-                unset( $jobs[ $when ] );
225
+            if (false !== strpos($name, 'ao_cachechecker')) {
226
+                unset($jobs[$when]);
227 227
             }
228 228
         }
229 229
 
230 230
         // Save the data.
231
-        _set_cron_array( $jobs );
231
+        _set_cron_array($jobs);
232 232
     }
233 233
 }
Please login to merge, or discard this patch.