Completed
Push — master ( 5aeeae...286286 )
by frank
02:03
created
classes/autoptimizeVersionUpdatesHandler.php 1 patch
Spacing   +62 added lines, -62 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * Handles version updates and should only be instantiated in autoptimize.php if/when needed.
4 4
  */
5 5
 
6
-if ( ! defined( 'ABSPATH' ) ) {
6
+if (!defined('ABSPATH')) {
7 7
     exit;
8 8
 }
9 9
 
@@ -16,9 +16,9 @@  discard block
 block discarded – undo
16 16
      */
17 17
     protected $current_major_version = null;
18 18
 
19
-    public function __construct( $current_version )
19
+    public function __construct($current_version)
20 20
     {
21
-        $this->current_major_version = substr( $current_version, 0, 3 );
21
+        $this->current_major_version = substr($current_version, 0, 3);
22 22
     }
23 23
 
24 24
     /**
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
     {
30 30
         $major_update = false;
31 31
 
32
-        switch ( $this->current_major_version ) {
32
+        switch ($this->current_major_version) {
33 33
             case '1.6':
34 34
                 $this->upgrade_from_1_6();
35 35
                 $major_update = true;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
                 $major_update = true;
48 48
                 // No break, intentionally, so all upgrades are ran during a single request...
49 49
             case '2.4':
50
-                if ( get_option( 'autoptimize_version', 'none' ) == '2.4.2' ) {
50
+                if (get_option('autoptimize_version', 'none') == '2.4.2') {
51 51
                     $this->upgrade_from_2_4_2();
52 52
                 }
53 53
                 $this->upgrade_from_2_4();
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
                 // No break, intentionally, so all upgrades are ran during a single request...
56 56
         }
57 57
 
58
-        if ( true === $major_update ) {
58
+        if (true === $major_update) {
59 59
             $this->on_major_version_update();
60 60
         }
61 61
     }
@@ -67,19 +67,19 @@  discard block
 block discarded – undo
67 67
      *
68 68
      * @param string $target Target version to check against (ie., the currently running one).
69 69
      */
70
-    public static function check_installed_and_update( $target )
70
+    public static function check_installed_and_update($target)
71 71
     {
72
-        $db_version = get_option( 'autoptimize_version', 'none' );
73
-        if ( $db_version !== $target ) {
74
-            if ( 'none' === $db_version ) {
75
-                add_action( 'admin_notices', 'autoptimizeMain::notice_installed' );
72
+        $db_version = get_option('autoptimize_version', 'none');
73
+        if ($db_version !== $target) {
74
+            if ('none' === $db_version) {
75
+                add_action('admin_notices', 'autoptimizeMain::notice_installed');
76 76
             } else {
77
-                $updater = new self( $db_version );
77
+                $updater = new self($db_version);
78 78
                 $updater->run_needed_major_upgrades();
79 79
             }
80 80
 
81 81
             // Versions differed, upgrades happened if needed, store the new version.
82
-            update_option( 'autoptimize_version', $target );
82
+            update_option('autoptimize_version', $target);
83 83
         }
84 84
     }
85 85
 
@@ -90,10 +90,10 @@  discard block
 block discarded – undo
90 90
     protected function on_major_version_update()
91 91
     {
92 92
         // The transients guard here prevents stale object caches from busting the cache on every request.
93
-        if ( false == get_transient( 'autoptimize_stale_option_buster' ) ) {
94
-            set_transient( 'autoptimize_stale_option_buster', 'Mamsie & Liessie zehhe: ZWIJH!', HOUR_IN_SECONDS );
93
+        if (false == get_transient('autoptimize_stale_option_buster')) {
94
+            set_transient('autoptimize_stale_option_buster', 'Mamsie & Liessie zehhe: ZWIJH!', HOUR_IN_SECONDS);
95 95
             autoptimizeCache::clearall();
96
-            add_action( 'admin_notices', 'autoptimizeMain::notice_updated' );
96
+            add_action('admin_notices', 'autoptimizeMain::notice_updated');
97 97
         }
98 98
     }
99 99
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     private function upgrade_from_1_6()
104 104
     {
105 105
         // If user was on version 1.6.x, force advanced options to be shown by default.
106
-        update_option( 'autoptimize_show_adv', '1' );
106
+        update_option('autoptimize_show_adv', '1');
107 107
 
108 108
         // And remove old options.
109 109
         $to_delete_options = array(
@@ -115,8 +115,8 @@  discard block
 block discarded – undo
115 115
             'autoptimize_cdn_img_url',
116 116
             'autoptimize_css_yui',
117 117
         );
118
-        foreach ( $to_delete_options as $del_opt ) {
119
-            delete_option( $del_opt );
118
+        foreach ($to_delete_options as $del_opt) {
119
+            delete_option($del_opt);
120 120
         }
121 121
     }
122 122
 
@@ -127,29 +127,29 @@  discard block
 block discarded – undo
127 127
      */
128 128
     private function upgrade_from_1_7()
129 129
     {
130
-        if ( ! is_multisite() ) {
131
-            $css_exclude = get_option( 'autoptimize_css_exclude' );
132
-            if ( empty( $css_exclude ) ) {
130
+        if (!is_multisite()) {
131
+            $css_exclude = get_option('autoptimize_css_exclude');
132
+            if (empty($css_exclude)) {
133 133
                 $css_exclude = 'admin-bar.min.css, dashicons.min.css';
134
-            } elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) {
134
+            } elseif (false === strpos($css_exclude, 'dashicons.min.css')) {
135 135
                 $css_exclude .= ', dashicons.min.css';
136 136
             }
137
-            update_option( 'autoptimize_css_exclude', $css_exclude );
137
+            update_option('autoptimize_css_exclude', $css_exclude);
138 138
         } else {
139 139
             global $wpdb;
140
-            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
140
+            $blog_ids         = $wpdb->get_col("SELECT blog_id FROM $wpdb->blogs");
141 141
             $original_blog_id = get_current_blog_id();
142
-            foreach ( $blog_ids as $blog_id ) {
143
-                switch_to_blog( $blog_id );
144
-                $css_exclude = get_option( 'autoptimize_css_exclude' );
145
-                if ( empty( $css_exclude ) ) {
142
+            foreach ($blog_ids as $blog_id) {
143
+                switch_to_blog($blog_id);
144
+                $css_exclude = get_option('autoptimize_css_exclude');
145
+                if (empty($css_exclude)) {
146 146
                     $css_exclude = 'admin-bar.min.css, dashicons.min.css';
147
-                } elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) {
147
+                } elseif (false === strpos($css_exclude, 'dashicons.min.css')) {
148 148
                     $css_exclude .= ', dashicons.min.css';
149 149
                 }
150
-                update_option( 'autoptimize_css_exclude', $css_exclude );
150
+                update_option('autoptimize_css_exclude', $css_exclude);
151 151
             }
152
-            switch_to_blog( $original_blog_id );
152
+            switch_to_blog($original_blog_id);
153 153
         }
154 154
     }
155 155
 
@@ -161,19 +161,19 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function upgrade_from_1_9()
163 163
     {
164
-        if ( ! is_multisite() ) {
165
-            update_option( 'autoptimize_css_include_inline', 'on' );
166
-            update_option( 'autoptimize_js_include_inline', 'on' );
164
+        if (!is_multisite()) {
165
+            update_option('autoptimize_css_include_inline', 'on');
166
+            update_option('autoptimize_js_include_inline', 'on');
167 167
         } else {
168 168
             global $wpdb;
169
-            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
169
+            $blog_ids         = $wpdb->get_col("SELECT blog_id FROM $wpdb->blogs");
170 170
             $original_blog_id = get_current_blog_id();
171
-            foreach ( $blog_ids as $blog_id ) {
172
-                switch_to_blog( $blog_id );
173
-                update_option( 'autoptimize_css_include_inline', 'on' );
174
-                update_option( 'autoptimize_js_include_inline', 'on' );
171
+            foreach ($blog_ids as $blog_id) {
172
+                switch_to_blog($blog_id);
173
+                update_option('autoptimize_css_include_inline', 'on');
174
+                update_option('autoptimize_js_include_inline', 'on');
175 175
             }
176
-            switch_to_blog( $original_blog_id );
176
+            switch_to_blog($original_blog_id);
177 177
         }
178 178
     }
179 179
 
@@ -184,17 +184,17 @@  discard block
 block discarded – undo
184 184
      */
185 185
     private function upgrade_from_2_2()
186 186
     {
187
-        if ( ! is_multisite() ) {
187
+        if (!is_multisite()) {
188 188
             $this->do_2_2_settings_update();
189 189
         } else {
190 190
             global $wpdb;
191
-            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
191
+            $blog_ids         = $wpdb->get_col("SELECT blog_id FROM $wpdb->blogs");
192 192
             $original_blog_id = get_current_blog_id();
193
-            foreach ( $blog_ids as $blog_id ) {
194
-                switch_to_blog( $blog_id );
193
+            foreach ($blog_ids as $blog_id) {
194
+                switch_to_blog($blog_id);
195 195
                 $this->do_2_2_settings_update();
196 196
             }
197
-            switch_to_blog( $original_blog_id );
197
+            switch_to_blog($original_blog_id);
198 198
         }
199 199
     }
200 200
 
@@ -203,12 +203,12 @@  discard block
 block discarded – undo
203 203
      */
204 204
     private function do_2_2_settings_update()
205 205
     {
206
-        $nogooglefont    = get_option( 'autoptimize_css_nogooglefont', '' );
207
-        $ao_extrasetting = get_option( 'autoptimize_extra_settings', '' );
208
-        if ( ( $nogooglefont ) && ( empty( $ao_extrasetting ) ) ) {
209
-            update_option( 'autoptimize_extra_settings', autoptimizeConfig::get_ao_extra_default_options() );
206
+        $nogooglefont    = get_option('autoptimize_css_nogooglefont', '');
207
+        $ao_extrasetting = get_option('autoptimize_extra_settings', '');
208
+        if (($nogooglefont) && (empty($ao_extrasetting))) {
209
+            update_option('autoptimize_extra_settings', autoptimizeConfig::get_ao_extra_default_options());
210 210
         }
211
-        delete_option( 'autoptimize_css_nogooglefont' );
211
+        delete_option('autoptimize_css_nogooglefont');
212 212
     }
213 213
 
214 214
     /**
@@ -220,33 +220,33 @@  discard block
 block discarded – undo
220 220
         $jobs = _get_cron_array();
221 221
 
222 222
         // Remove all ao_cachechecker cron jobs (for now).
223
-        foreach ( $jobs as $when => $job ) {
224
-            $name = key( $job );
223
+        foreach ($jobs as $when => $job) {
224
+            $name = key($job);
225 225
 
226
-            if ( false !== strpos( $name, 'ao_cachechecker' ) ) {
227
-                unset( $jobs[ $when ] );
226
+            if (false !== strpos($name, 'ao_cachechecker')) {
227
+                unset($jobs[$when]);
228 228
             }
229 229
         }
230 230
 
231 231
         // Save the data.
232
-        _set_cron_array( $jobs );
232
+        _set_cron_array($jobs);
233 233
     }
234 234
 
235 235
     /**
236 236
      * Migrate imgopt options from autoptimize_extra_settings to autoptimize_imgopt_settings
237 237
      */
238 238
     private function upgrade_from_2_4() {
239
-        $extra_settings  = get_option( 'autoptimize_extra_settings', '' );
240
-        $imgopt_settings = get_option( 'autoptimize_imgopt_settings', '' );
241
-        if ( empty( $imgopt_settings ) && ! empty( $extra_settings ) ) {
239
+        $extra_settings  = get_option('autoptimize_extra_settings', '');
240
+        $imgopt_settings = get_option('autoptimize_imgopt_settings', '');
241
+        if (empty($imgopt_settings) && !empty($extra_settings)) {
242 242
             $imgopt_settings = autoptimizeConfig::get_ao_imgopt_default_options();
243
-            if ( array_key_exists( 'autoptimize_extra_checkbox_field_5', $extra_settings ) ) {
243
+            if (array_key_exists('autoptimize_extra_checkbox_field_5', $extra_settings)) {
244 244
                 $imgopt_settings['autoptimize_imgopt_checkbox_field_1'] = $extra_settings['autoptimize_extra_checkbox_field_5'];
245 245
             }
246
-            if ( array_key_exists( 'autoptimize_extra_select_field_6', $extra_settings ) ) {
246
+            if (array_key_exists('autoptimize_extra_select_field_6', $extra_settings)) {
247 247
                 $imgopt_settings['autoptimize_imgopt_select_field_2'] = $extra_settings['autoptimize_extra_select_field_6'];
248 248
             }
249
-            update_option( 'autoptimize_imgopt_settings', $imgopt_settings );
249
+            update_option('autoptimize_imgopt_settings', $imgopt_settings);
250 250
         }
251 251
     }
252 252
 }
Please login to merge, or discard this patch.