fustundag / awscw-custom-metrics

src/AWSCustomMetric/Plugin/RedisCheck.php

Doc Comments +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getServer()
     {

Spacing +13 added lines, -13 removed lines

@@ -52,12 +52,12 @@ 
 
     private function getServerPortArgs()
     {
-        return '-h ' . $this->getServer() . ' -p ' . $this->getPort();
+        return '-h '.$this->getServer().' -p '.$this->getPort();
     }
 
     private function getRedisCliCmd()
     {
-        return '/usr/bin/redis-cli ' . $this->getServerPortArgs();
+        return '/usr/bin/redis-cli '.$this->getServerPortArgs();
     }
 
     /**
@@ -82,29 +82,29 @@ 
     private function findKeys()
     {
         try {
-            $this->diObj->getCommandRunner()->execute($this->getRedisCliCmd() . ' --raw dbsize');
+            $this->diObj->getCommandRunner()->execute($this->getRedisCliCmd().' --raw dbsize');
             $retVal = $this->diObj->getCommandRunner()->getReturnCode();
             $redisKeyCount = $this->diObj->getCommandRunner()->getOutput();
-            error_log('redisKeyCount: ' . json_encode($redisKeyCount).PHP_EOL, 3, '/tmp/php_error.log');
+            error_log('redisKeyCount: '.json_encode($redisKeyCount).PHP_EOL, 3, '/tmp/php_error.log');
 
             if ($retVal!==0) {
                 if ($this->diObj->getLogger()) {
                     $this->diObj->getLogger()->error(
-                        'Redis KEyCount cmd failed!, RETVAL: ' . $retVal
-                        . ', OUT: ' . implode('|', $redisKeyCount)
+                        'Redis KEyCount cmd failed!, RETVAL: '.$retVal
+                        . ', OUT: '.implode('|', $redisKeyCount)
                     );
                 }
                 return false;
             }
             if ($redisKeyCount[0]>0) {
-                $this->diObj->getCommandRunner()->execute($this->getRedisCliCmd() . ' --raw keys *');
+                $this->diObj->getCommandRunner()->execute($this->getRedisCliCmd().' --raw keys *');
                 $retVal = $this->diObj->getCommandRunner()->getReturnCode();
                 $redisKeyList = $this->diObj->getCommandRunner()->getOutput();
                 if ($retVal!==0) {
                     if ($this->diObj->getLogger()) {
                         $this->diObj->getLogger()->error(
-                            'Redis KeyList cmd failed!, RETVAL: ' . $retVal
-                            . ', OUT: ' . implode('|', $redisKeyList)
+                            'Redis KeyList cmd failed!, RETVAL: '.$retVal
+                            . ', OUT: '.implode('|', $redisKeyList)
                         );
                     }
                     return false;
@@ -115,7 +115,7 @@ 
             }
         } catch (\Exception $e) {
             if ($this->diObj->getLogger()) {
-                $this->diObj->getLogger()->error('Redis client thrown exception! ExcpMsg: ' . $e->getMessage());
+                $this->diObj->getLogger()->error('Redis client thrown exception! ExcpMsg: '.$e->getMessage());
             }
             return false;
         }
@@ -127,12 +127,12 @@ 
     public function getMetrics()
     {
         try {
-            $redisKeyList = count($this->keys)==0?$this->findKeys():$this->keys;
+            $redisKeyList = count($this->keys)==0 ? $this->findKeys() : $this->keys;
             $totalLen     = 0;
             if ($redisKeyList && is_array($redisKeyList)) {
                 foreach ($redisKeyList as $redisKey) {
                     $this->diObj->getCommandRunner()->execute(
-                        $this->getRedisCliCmd() . ' --raw llen ' . trim($redisKey)
+                        $this->getRedisCliCmd().' --raw llen '.trim($redisKey)
                     );
                     $retVal = $this->diObj->getCommandRunner()->getReturnCode();
                     $redisKeyLen = $this->diObj->getCommandRunner()->getOutput();
@@ -146,7 +146,7 @@ 
             ];
         } catch (\Exception $e) {
             if ($this->diObj->getLogger()) {
-                $this->diObj->getLogger()->error('Redis client thrown exception! ExcpMsg: ' . $e->getMessage());
+                $this->diObj->getLogger()->error('Redis client thrown exception! ExcpMsg: '.$e->getMessage());
             }
             return false;
         }