frictionlessdata / datapackage-php

src/Factory.php

Doc Comments +16 added lines, -1 removed lines

@@ -229,6 +229,8 @@ 
     /**
      * allows extending classes to add custom sources
      * used by unit tests to add a mock http source.
+     * @param string $source
+     * @return string
      */
     protected static function normalizeHttpSource($source)
     {
@@ -238,6 +240,7 @@ 
     /**
      * allows extending classes to add custom sources
      * used by unit tests to add a mock http source.
+     * @param string $source
      */
     protected static function isHttpSource($source)
     {
@@ -251,7 +254,7 @@ 
      *   - normalized basePath.
      *
      * @param $source
-     * @param $basePath
+     * @param null|string $basePath
      *
      * @return object
      *
@@ -321,16 +324,25 @@ 
         return (object) ['descriptor' => $descriptor, 'basePath' => $basePath];
     }
 
+    /**
+     * @param string $source
+     */
     protected static function isHttpZipSource($source)
     {
         return (strtolower(substr($source, -4)) == '.zip');
     }
 
+    /**
+     * @param string $source
+     */
     protected static function isFileZipSource($source)
     {
         return (strtolower(substr($source, -4)) == '.zip');
     }
 
+    /**
+     * @param string $source
+     */
     protected static function loadHttpZipSource($source)
     {
         $tempfile = tempnam(sys_get_temp_dir(), 'datapackage-php');
@@ -341,6 +353,9 @@ 
         return self::loadFileZipSource($tempfile);
     }
 
+    /**
+     * @param string $source
+     */
     protected static function loadFileZipSource($source)
     {
         $zippy = Zippy::load();

Spacing +3 added lines, -3 removed lines

@@ -335,9 +335,9 @@ 
     {
         $tempfile = tempnam(sys_get_temp_dir(), 'datapackage-php');
         unlink($tempfile);
-        $tempfile.='.zip';
+        $tempfile .= '.zip';
         stream_copy_to_stream(fopen($source, 'r'), fopen($tempfile, 'w'));
-        register_shutdown_function(function() use ($tempfile) {unlink($tempfile);});
+        register_shutdown_function(function() use ($tempfile) {unlink($tempfile); });
         return self::loadFileZipSource($tempfile);
     }
 
@@ -347,7 +347,7 @@ 
         $tempdir = tempnam(sys_get_temp_dir(), 'datapackage-php');
         unlink($tempdir);
         mkdir($tempdir);
-        register_shutdown_function(function() use ($tempdir) {Utils::removeDir($tempdir);});
+        register_shutdown_function(function() use ($tempdir) {Utils::removeDir($tempdir); });
         $zippy->open($source)->extract($tempdir);
         if (!file_exists($tempdir."/datapackage.json")) {
             throw new Exceptions\DatapackageInvalidSourceException("zip file must contain a datappackage.json file");

src/Resources/BaseResource.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
         return static::handlesProfile(Registry::getResourceValidationProfile($descriptor));
     }
 
-    public function read($readOptions=null)
+    public function read($readOptions = null)
     {
         $limit = ($readOptions && isset($readOptions["limit"])) ? $readOptions["limit"] : null;
         $rows = [];

Braces +9 added lines, -3 removed lines

@@ -48,7 +48,9 @@ 
                     $rows[] = $row;
                     if ($limit !== null) {
                         $limit--;
-                        if ($limit < 0) break;
+                        if ($limit < 0) {
+                            break;
+                        }
                     }
                 };
             } else {
@@ -56,11 +58,15 @@ 
                     $rows[] = $row;
                     if ($limit !== null) {
                         $limit--;
-                        if ($limit < 0) break;
+                        if ($limit < 0) {
+                            break;
+                        }
                     }
                 }
             }
-            if ($limit !== null && $limit < 0) break;
+            if ($limit !== null && $limit < 0) {
+                break;
+            }
         }
         return $rows;
     }