Completed
Push — master ( 1d37d4...bf8214 )
by Ori
01:34
created
src/Factory.php 1 patch
Doc Comments   +16 added lines, -1 removed lines patch added patch discarded remove patch
@@ -229,6 +229,8 @@  discard block
 block discarded – undo
229 229
     /**
230 230
      * allows extending classes to add custom sources
231 231
      * used by unit tests to add a mock http source.
232
+     * @param string $source
233
+     * @return string
232 234
      */
233 235
     protected static function normalizeHttpSource($source)
234 236
     {
@@ -238,6 +240,7 @@  discard block
 block discarded – undo
238 240
     /**
239 241
      * allows extending classes to add custom sources
240 242
      * used by unit tests to add a mock http source.
243
+     * @param string $source
241 244
      */
242 245
     protected static function isHttpSource($source)
243 246
     {
@@ -251,7 +254,7 @@  discard block
 block discarded – undo
251 254
      *   - normalized basePath.
252 255
      *
253 256
      * @param $source
254
-     * @param $basePath
257
+     * @param null|string $basePath
255 258
      *
256 259
      * @return object
257 260
      *
@@ -321,16 +324,25 @@  discard block
 block discarded – undo
321 324
         return (object) ['descriptor' => $descriptor, 'basePath' => $basePath];
322 325
     }
323 326
 
327
+    /**
328
+     * @param string $source
329
+     */
324 330
     protected static function isHttpZipSource($source)
325 331
     {
326 332
         return (strtolower(substr($source, -4)) == '.zip');
327 333
     }
328 334
 
335
+    /**
336
+     * @param string $source
337
+     */
329 338
     protected static function isFileZipSource($source)
330 339
     {
331 340
         return (strtolower(substr($source, -4)) == '.zip');
332 341
     }
333 342
 
343
+    /**
344
+     * @param string $source
345
+     */
334 346
     protected static function loadHttpZipSource($source)
335 347
     {
336 348
         $tempfile = tempnam(sys_get_temp_dir(), 'datapackage-php');
@@ -341,6 +353,9 @@  discard block
 block discarded – undo
341 353
         return self::loadFileZipSource($tempfile);
342 354
     }
343 355
 
356
+    /**
357
+     * @param string $source
358
+     */
344 359
     protected static function loadFileZipSource($source)
345 360
     {
346 361
         $zippy = Zippy::load();
Please login to merge, or discard this patch.