frictionlessdata / datapackage-php

src/Factory.php

Doc Comments +16 added lines, -1 removed lines

@@ -229,6 +229,8 @@ 
     /**
      * allows extending classes to add custom sources
      * used by unit tests to add a mock http source.
+     * @param string $source
+     * @return string
      */
     protected static function normalizeHttpSource($source)
     {
@@ -238,6 +240,7 @@ 
     /**
      * allows extending classes to add custom sources
      * used by unit tests to add a mock http source.
+     * @param string $source
      */
     protected static function isHttpSource($source)
     {
@@ -251,7 +254,7 @@ 
      *   - normalized basePath.
      *
      * @param $source
-     * @param $basePath
+     * @param null|string $basePath
      *
      * @return object
      *
@@ -326,16 +329,25 @@ 
         return (object) ['descriptor' => $descriptor, 'basePath' => $basePath];
     }
 
+    /**
+     * @param string $source
+     */
     protected static function isHttpZipSource($source)
     {
         return strtolower(substr($source, -4)) == '.zip';
     }
 
+    /**
+     * @param string $source
+     */
     protected static function isFileZipSource($source)
     {
         return strtolower(substr($source, -4)) == '.zip';
     }
 
+    /**
+     * @param string $source
+     */
     protected static function loadHttpZipSource($source)
     {
         $tempfile = tempnam(sys_get_temp_dir(), 'datapackage-php');
@@ -347,6 +359,9 @@ 
         return self::loadFileZipSource($tempfile);
     }
 
+    /**
+     * @param string $source
+     */
     protected static function loadFileZipSource($source)
     {
         $zipper = new Zipper();

Spacing +2 added lines, -2 removed lines

@@ -342,7 +342,7 @@ 
         unlink($tempfile);
         $tempfile .= '.zip';
         stream_copy_to_stream(fopen($source, 'r'), fopen($tempfile, 'w'));
-        register_shutdown_function(function () use ($tempfile) {unlink($tempfile); });
+        register_shutdown_function(function() use ($tempfile) {unlink($tempfile); });
 
         return self::loadFileZipSource($tempfile);
     }
@@ -353,7 +353,7 @@ 
         $tempdir = tempnam(sys_get_temp_dir(), 'datapackage-php');
         unlink($tempdir);
         mkdir($tempdir);
-        register_shutdown_function(function () use ($tempdir) {Utils::removeDir($tempdir); });
+        register_shutdown_function(function() use ($tempdir) {Utils::removeDir($tempdir); });
         try {
             $zipper->make($source)->extractTo($tempdir);
         } catch (\Exception $e) {