frictionlessdata / datapackage-php

src/Validators/BaseValidator.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace frictionlessdata\datapackage\Validators;
 
-use frictionlessdata\datapackage\Registry;
 use frictionlessdata\datapackage\Utils;
 use frictionlessdata\tableschema\SchemaValidator;
 use frictionlessdata\tableschema\SchemaValidationError;

Doc Comments +7 added lines, -1 removed lines

@@ -44,6 +44,9 @@ 
         return $this->descriptor->profile;
     }
 
+    /**
+     * @param boolean|string $filename
+     */
     protected function convertValidationSchemaFilenameToUrl($filename)
     {
         $filename = realpath($filename);
@@ -124,6 +127,9 @@ 
         $this->validateSchemaUrl($this->getValidationSchemaUrl());
     }
 
+    /**
+     * @param string $url
+     */
     protected function validateSchemaUrl($url)
     {
         $validator = new \JsonSchema\Validator();
@@ -143,7 +149,7 @@ 
      * Add an error to the validator object - errors are aggregated and returned by validate function.
      *
      * @param int        $code
-     * @param null|mixed $extraDetails
+     * @param string $extraDetails
      */
     protected function addError($code, $extraDetails = null)
     {

src/Validators/DatapackageValidator.php

Doc Comments +3 added lines

@@ -70,6 +70,9 @@
         return ResourceValidator::validate($resourceDescriptor, $this->basePath);
     }
 
+    /**
+     * @param string $profile
+     */
     protected function getJsonSchemaFileFromRegistry($profile)
     {
         if ($filename = Registry::getJsonSchemaFile($profile)) {

src/Datapackages/BaseDatapackage.php

Doc Comments +3 added lines

@@ -224,6 +224,9 @@
         return DatapackageValidator::validate($this->descriptor(), $this->basePath);
     }
 
+    /**
+     * @param string $profile
+     */
     protected static function handlesProfile($profile)
     {
         return false;

Spacing +1 added lines, -1 removed lines

@@ -204,7 +204,7 @@
         }
         $packageCopy->saveDescriptor($files['datapackage.json']);
 
-        register_shutdown_function(function () use ($base) {
+        register_shutdown_function(function() use ($base) {
             Utils::removeDir($base);
         });
         if ($zip->open($zip_filename, ZipArchive::CREATE | ZipArchive::OVERWRITE) === true) {

src/Resources/BaseResource.php

Doc Comments +3 added lines

@@ -251,6 +251,9 @@
 
     abstract protected function getInlineDataStream($data);
 
+    /**
+     * @param string $profile
+     */
     protected static function handlesProfile($profile)
     {
         return false;

src/Factory.php

Doc Comments +12 added lines, -6 removed lines

@@ -229,9 +229,9 @@ 
      * allows extending classes to add custom sources
      * used by unit tests to add a mock http source.
      *
-     * @param $source
+     * @param string $source
      *
-     * @return mixed
+     * @return string
      */
     protected static function normalizeHttpSource($source)
     {
@@ -241,7 +241,7 @@ 
     /**
      * allows extending classes to add custom sources
      * used by unit tests to add a mock http source.
-     * @param $source
+     * @param string $source
      * @return bool
      */
     protected static function isHttpSource($source)
@@ -256,7 +256,7 @@ 
      *   - normalized basePath.
      *
      * @param $source
-     * @param $basePath
+     * @param null|string $basePath
      *
      * @return object
      *
@@ -332,18 +332,24 @@ 
         return (object) ['descriptor' => $descriptor, 'basePath' => $basePath];
     }
 
+    /**
+     * @param string $source
+     */
     protected static function isHttpZipSource($source)
     {
         return strtolower(substr($source, -4)) == '.zip';
     }
 
+    /**
+     * @param string $source
+     */
     protected static function isFileZipSource($source)
     {
         return strtolower(substr($source, -4)) == '.zip';
     }
 
     /**
-     * @param $source
+     * @param string $source
      *
      * @return object
      * @throws \frictionlessdata\datapackage\Exceptions\DatapackageInvalidSourceException
@@ -364,7 +370,7 @@ 
     }
 
     /**
-     * @param $source
+     * @param string $source
      *
      * @return object
      * @throws \frictionlessdata\datapackage\Exceptions\DatapackageInvalidSourceException

Spacing +2 added lines, -2 removed lines

@@ -356,7 +356,7 @@ 
         unlink($tempfile);
         $tempfile .= '.zip';
         stream_copy_to_stream(fopen($source, 'r'), fopen($tempfile, 'w'));
-        register_shutdown_function(function () use ($tempfile) {
+        register_shutdown_function(function() use ($tempfile) {
             unlink($tempfile);
         });
 
@@ -377,7 +377,7 @@ 
         $tempdir = tempnam(sys_get_temp_dir(), 'datapackage-php');
         unlink($tempdir);
         mkdir($tempdir);
-        register_shutdown_function(function () use ($tempdir) {
+        register_shutdown_function(function() use ($tempdir) {
             Utils::removeDir($tempdir);
         });
         /* @noinspection PhpUnhandledExceptionInspection File existence is checked afterwards anyway */