francis94c / ci-rest

libraries/REST.php

Spacing +12 added lines, -12 removed lines

@@ -137,16 +137,16 @@ 
    * @param array|null $params Initialization parameters from the Slint system.
    *                           There's no use for this arg yet.
    */
-  function __construct(?array $params=null)
+  function __construct(?array $params = null)
   {
-    $this->ci =& get_instance();
+    $this->ci = & get_instance();
 
     if ($this->ci->input->is_cli_request()) return;
 
     // Load Config If Exists.
     //$this->ci->config->load('rest', true, true);
-    if (is_file(APPPATH . 'config/rest.php')) {
-      include APPPATH . 'config/rest.php';
+    if (is_file(APPPATH.'config/rest.php')) {
+      include APPPATH.'config/rest.php';
     }
 
     $this->config = $config;
@@ -162,7 +162,7 @@ 
 
     // Load Model.
     $this->ci->load->splint(self::PACKAGE, '*RESTModel', 'rest_model');
-    $this->rest_model =& $this->ci->rest_model;
+    $this->rest_model = & $this->ci->rest_model;
 
     $this->rest_model->init([
       'users_table'           => $config['basic_auth']['users_table'] ?? null,
@@ -262,14 +262,14 @@ 
    */
   private function auth_proceed(bool $success, int $flags):bool
   {
-    if ($flags & self::AUTH_GRAVITY) return $success;
+    if ($flags&self::AUTH_GRAVITY) return $success;
     if ($success) {
-      if ($flags & self::AUTH_FINAL) {
+      if ($flags&self::AUTH_FINAL) {
         $this->authPreempted = true;
         return true;
       }
     } else {
-      return $flags & self::AUTH_PASSIVE ? true : false;
+      return $flags&self::AUTH_PASSIVE ? true : false;
     }
   }
 
@@ -329,7 +329,7 @@ 
   /**
    * [api_key_auth description]
    */
-  private function api_key_auth(int $flags=self::AUTH_GRAVITY):void
+  private function api_key_auth(int $flags = self::AUTH_GRAVITY):void
   {
     if (uri_string() == '')  return;
     $shouldProceed = $this->auth_proceed(false, $flags);
@@ -376,7 +376,7 @@ 
     }
     // Should we acyually Limit?
     if ($this->per_hour > 0) {
-      $client = hash('md5', $this->ci->input->ip_address() . "%" . $apiKey);
+      $client = hash('md5', $this->ci->input->ip_address()."%".$apiKey);
       $limitData = $this->rest_model->getLimitData($client, '_api_keyed_user');
       if ($limitData == null) {
         $limitData = [];
@@ -460,7 +460,7 @@ 
    * [get_authorization_header description]
    * @return [type] [description]
    */
-  private function get_authorization_header():?string
+  private function get_authorization_header(): ?string
   {
     if (isset($_SERVER['Authorization'])) {
       return trim($_SERVER["Authorization"]);
@@ -483,7 +483,7 @@ 
    * [handle_response description]
    * @param int $code [description]
    */
-  private function handle_response(int $code, $auth=null, ?string $errorReason=null):void
+  private function handle_response(int $code, $auth = null, ?string $errorReason = null):void
   {
     http_response_code($code);
     header("Content-Type: application/json");

Braces +36 added lines, -11 removed lines

@@ -141,7 +141,9 @@ 
   {
     $this->ci =& get_instance();
 
-    if ($this->ci->input->is_cli_request()) return;
+    if ($this->ci->input->is_cli_request()) {
+     return;
+    }
 
     // Load Config If Exists.
     //$this->ci->config->load('rest', true, true);
@@ -212,9 +214,14 @@ 
   {
     $auths = null;
     $auths = $this->config['auth'] ?? null;
-    if ($auths) $auths = is_array($auths) ? $auths : [$auths];
+    if ($auths) {
+     $auths = is_array($auths) ? $auths : [$auths];
+    }
 
-    if (!$auths) return; // No authentication(s) to carry out.
+    if (!$auths) {
+     return;
+    }
+    // No authentication(s) to carry out.
 
     /**
      * $this->process_auth() terminates the script if authentication fails
@@ -225,7 +232,9 @@ 
      */
 
     foreach ($auths as $key => $auth) {
-      if ($this->authPreempted) break;
+      if ($this->authPreempted) {
+       break;
+      }
       if (is_numeric($key)) {
         $this->process_auth($auth, self::AUTH_GRAVITY);
       } else {
@@ -262,7 +271,9 @@ 
    */
   private function auth_proceed(bool $success, int $flags):bool
   {
-    if ($flags & self::AUTH_GRAVITY) return $success;
+    if ($flags & self::AUTH_GRAVITY) {
+     return $success;
+    }
     if ($success) {
       if ($flags & self::AUTH_FINAL) {
         $this->authPreempted = true;
@@ -323,15 +334,23 @@ 
   {
     $username = $_SERVER['PHP_AUTH_USER'] ?? null;
     $password = $_SERVER['PHP_AUTH_PW'] ?? null;
-    if (!$this->auth_proceed(!$username || !$password, $flags)) $this->handle_response(RESTResponse::BAD_REQUEST, RESTAuth::BASIC); // Exits.
-    if (!$this->auth_proceed($this->rest_model->basicAuth($this, $username, $password), $flags)) $this->handle_response(RESTResponse::UN_AUTHORIZED, RESTAuth::BASIC); // Exits.
+    if (!$this->auth_proceed(!$username || !$password, $flags)) {
+     $this->handle_response(RESTResponse::BAD_REQUEST, RESTAuth::BASIC);
+    }
+    // Exits.
+    if (!$this->auth_proceed($this->rest_model->basicAuth($this, $username, $password), $flags)) {
+     $this->handle_response(RESTResponse::UN_AUTHORIZED, RESTAuth::BASIC);
+    }
+    // Exits.
   }
   /**
    * [api_key_auth description]
    */
   private function api_key_auth(int $flags=self::AUTH_GRAVITY):void
   {
-    if (uri_string() == '')  return;
+    if (uri_string() == '') {
+     return;
+    }
     $shouldProceed = $this->auth_proceed(false, $flags);
 
     if (!$this->ci->input->get_request_header($this->apiKeyHeader, true) && !$shouldProceed) {
@@ -349,7 +368,9 @@ 
 
     $this->apiKey = $apiKey;
 
-    if (!$this->auth_proceed(true, $flags)) return;
+    if (!$this->auth_proceed(true, $flags)) {
+     return;
+    }
 
     // ==== API KEY Auth Passed ==== //
 
@@ -410,7 +431,9 @@ 
     // Trunctate Rate Limit Data.
     $this->rest_model->truncateRatelimitData();
     // Check Whitelist.
-    if (in_array($this->ci->input->ip_address(), $this->whitelist)) return;
+    if (in_array($this->ci->input->ip_address(), $this->whitelist)) {
+     return;
+    }
     // Should we acyually Limit?
     if ($this->ip_per_hour > 0) {
       $client = hash('md5', $this->ci->input->ip_address());
@@ -490,7 +513,9 @@ 
     if (isset($this->config['response_callbacks'][$code])) {
       $this->config['response_callbacks'][$code]($auth, $errorReason);
     }
-    if (ENVIRONMENT != 'testing') exit($code);
+    if (ENVIRONMENT != 'testing') {
+     exit($code);
+    }
     throw new Exception("Error $code in $auth", $code);
   }
 }