Inspection of "tests fix" - florinp/phpbb-messenger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 800f7e...f06e6b )

by Florin

created 2016-03-28 19:23 UTC

Status

Indentation +102 added lines, -102 removed lines patch added patch discarded remove patch

@@ -6,106 +6,106 @@
 block discarded – undo
 
 class main_test extends \phpbb_test_case {
 
-    /**
-     * @var \florinp\messenger\controller\main
-     */
-    protected $controller;
-
-    public function setUp() {
-        parent::setUp();
-        /**
-         * @var \phpbb\user $user Mock the user class
-         */
-        $user = $this->getMock('\phpbb\user', array(), array('\phpbb\datetime'));
-
-        /**
-         * @var \phpbb\request\request $request
-         */
-        $request = $this->getMockBuilder('\phpbb\request\request')
-            ->disableOriginalConstructor()
-            ->getMock();
-
-        /**
-         * @var \florinp\messenger\models\main_model $model
-         */
-        $model = $this->getMockBuilder('\florinp\messenger\models\main_model')
-            ->disableOriginalConstructor()
-            ->getMock();
-
-        /**
-         * @var \phpbb\notification\manager $notification_manager
-         */
-        $notification_manager = $this->getMockBuilder('\phpbb\notification\manager')
-            ->disableOriginalConstructor()
-            ->getMock();
-
-        /**
-         * @var \florinp\messenger\libs\upload $upload
-         */
-        $upload = $this->getMockBuilder('\florinp\messenger\libs\upload')
-            ->disableOriginalConstructor()
-            ->getMock();
-
-        /**
-         * @var \florinp\messenger\libs\download $download
-         */
-        $download = $this->getMockBuilder('\florinp\messenger\libs\download')
-            ->disableOriginalConstructor()
-            ->getMock();
-
-        $this->controller = new \florinp\messenger\controller\main(
-            $request,
-            $user,
-            $model,
-            $notification_manager,
-            $upload,
-            $download
-        );
-    }
-
-    public function tearDown() {
-        $this->controller = null;
-        parent::tearDown();
-    }
-
-    public function publish_data() {
-        return array(
-            array(200, json_encode(array()))
-        );
-    }
-    /**
-     * @dataProvider publish_data
-     */
-    public function test_publish($status_code, $page_content) {
-        $response = $this->controller->publish();
-        $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
-        $this->assertEquals($status_code, $response->getStatusCode());
-        $this->assertEquals($page_content, $response->getContent());
-    }
-
-
-    public function load_data() {
-        return array(
-            array(200, json_encode(array(
-                'success' => false,
-                'error' => 'The request is invalid'
-            )))
-        );
-    }
-    /**
-     * @dataProvider load_data
-     */
-    public function test_load($status_code, $page_content) {
-        $response = $this->controller->load();
-        $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
-        $this->assertEquals($status_code, $response->getStatusCode());
-        $this->assertEquals($page_content, $response->getContent());
-    }
-
-
-    public function updateMessages_data() {
-        return array(
-            array(200, json_encode(array('success' => false)))
-        );
-    }
+	/**
+	 * @var \florinp\messenger\controller\main
+	 */
+	protected $controller;
+
+	public function setUp() {
+		parent::setUp();
+		/**
+		 * @var \phpbb\user $user Mock the user class
+		 */
+		$user = $this->getMock('\phpbb\user', array(), array('\phpbb\datetime'));
+
+		/**
+		 * @var \phpbb\request\request $request
+		 */
+		$request = $this->getMockBuilder('\phpbb\request\request')
+			->disableOriginalConstructor()
+			->getMock();
+
+		/**
+		 * @var \florinp\messenger\models\main_model $model
+		 */
+		$model = $this->getMockBuilder('\florinp\messenger\models\main_model')
+			->disableOriginalConstructor()
+			->getMock();
+
+		/**
+		 * @var \phpbb\notification\manager $notification_manager
+		 */
+		$notification_manager = $this->getMockBuilder('\phpbb\notification\manager')
+			->disableOriginalConstructor()
+			->getMock();
+
+		/**
+		 * @var \florinp\messenger\libs\upload $upload
+		 */
+		$upload = $this->getMockBuilder('\florinp\messenger\libs\upload')
+			->disableOriginalConstructor()
+			->getMock();
+
+		/**
+		 * @var \florinp\messenger\libs\download $download
+		 */
+		$download = $this->getMockBuilder('\florinp\messenger\libs\download')
+			->disableOriginalConstructor()
+			->getMock();
+
+		$this->controller = new \florinp\messenger\controller\main(
+			$request,
+			$user,
+			$model,
+			$notification_manager,
+			$upload,
+			$download
+		);
+	}
+
+	public function tearDown() {
+		$this->controller = null;
+		parent::tearDown();
+	}
+
+	public function publish_data() {
+		return array(
+			array(200, json_encode(array()))
+		);
+	}
+	/**
+	 * @dataProvider publish_data
+	 */
+	public function test_publish($status_code, $page_content) {
+		$response = $this->controller->publish();
+		$this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
+		$this->assertEquals($status_code, $response->getStatusCode());
+		$this->assertEquals($page_content, $response->getContent());
+	}
+
+
+	public function load_data() {
+		return array(
+			array(200, json_encode(array(
+				'success' => false,
+				'error' => 'The request is invalid'
+			)))
+		);
+	}
+	/**
+	 * @dataProvider load_data
+	 */
+	public function test_load($status_code, $page_content) {
+		$response = $this->controller->load();
+		$this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
+		$this->assertEquals($status_code, $response->getStatusCode());
+		$this->assertEquals($page_content, $response->getContent());
+	}
+
+
+	public function updateMessages_data() {
+		return array(
+			array(200, json_encode(array('success' => false)))
+		);
+	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -6,106 +6,106 @@
		block discarded – undo
6	6
7	7	class main_test extends \phpbb_test_case {
8	8
9		- /**
10		- * @var \florinp\messenger\controller\main
11		- */
12		- protected $controller;
13		-
14		- public function setUp() {
15		- parent::setUp();
16		- /**
17		- * @var \phpbb\user $user Mock the user class
18		- */
19		- $user = $this->getMock('\phpbb\user', array(), array('\phpbb\datetime'));
20		-
21		- /**
22		- * @var \phpbb\request\request $request
23		- */
24		- $request = $this->getMockBuilder('\phpbb\request\request')
25		- ->disableOriginalConstructor()
26		- ->getMock();
27		-
28		- /**
29		- * @var \florinp\messenger\models\main_model $model
30		- */
31		- $model = $this->getMockBuilder('\florinp\messenger\models\main_model')
32		- ->disableOriginalConstructor()
33		- ->getMock();
34		-
35		- /**
36		- * @var \phpbb\notification\manager $notification_manager
37		- */
38		- $notification_manager = $this->getMockBuilder('\phpbb\notification\manager')
39		- ->disableOriginalConstructor()
40		- ->getMock();
41		-
42		- /**
43		- * @var \florinp\messenger\libs\upload $upload
44		- */
45		- $upload = $this->getMockBuilder('\florinp\messenger\libs\upload')
46		- ->disableOriginalConstructor()
47		- ->getMock();
48		-
49		- /**
50		- * @var \florinp\messenger\libs\download $download
51		- */
52		- $download = $this->getMockBuilder('\florinp\messenger\libs\download')
53		- ->disableOriginalConstructor()
54		- ->getMock();
55		-
56		- $this->controller = new \florinp\messenger\controller\main(
57		- $request,
58		- $user,
59		- $model,
60		- $notification_manager,
61		- $upload,
62		- $download
63		- );
64		- }
65		-
66		- public function tearDown() {
67		- $this->controller = null;
68		- parent::tearDown();
69		- }
70		-
71		- public function publish_data() {
72		- return array(
73		- array(200, json_encode(array()))
74		- );
75		- }
76		- /**
77		- * @dataProvider publish_data
78		- */
79		- public function test_publish($status_code, $page_content) {
80		- $response = $this->controller->publish();
81		- $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
82		- $this->assertEquals($status_code, $response->getStatusCode());
83		- $this->assertEquals($page_content, $response->getContent());
84		- }
85		-
86		-
87		- public function load_data() {
88		- return array(
89		- array(200, json_encode(array(
90		- 'success' => false,
91		- 'error' => 'The request is invalid'
92		- )))
93		- );
94		- }
95		- /**
96		- * @dataProvider load_data
97		- */
98		- public function test_load($status_code, $page_content) {
99		- $response = $this->controller->load();
100		- $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
101		- $this->assertEquals($status_code, $response->getStatusCode());
102		- $this->assertEquals($page_content, $response->getContent());
103		- }
104		-
105		-
106		- public function updateMessages_data() {
107		- return array(
108		- array(200, json_encode(array('success' => false)))
109		- );
110		- }
	9	+ /**
	10	+ * @var \florinp\messenger\controller\main
	11	+ */
	12	+ protected $controller;
	13	+
	14	+ public function setUp() {
	15	+ parent::setUp();
	16	+ /**
	17	+ * @var \phpbb\user $user Mock the user class
	18	+ */
	19	+ $user = $this->getMock('\phpbb\user', array(), array('\phpbb\datetime'));
	20	+
	21	+ /**
	22	+ * @var \phpbb\request\request $request
	23	+ */
	24	+ $request = $this->getMockBuilder('\phpbb\request\request')
	25	+ ->disableOriginalConstructor()
	26	+ ->getMock();
	27	+
	28	+ /**
	29	+ * @var \florinp\messenger\models\main_model $model
	30	+ */
	31	+ $model = $this->getMockBuilder('\florinp\messenger\models\main_model')
	32	+ ->disableOriginalConstructor()
	33	+ ->getMock();
	34	+
	35	+ /**
	36	+ * @var \phpbb\notification\manager $notification_manager
	37	+ */
	38	+ $notification_manager = $this->getMockBuilder('\phpbb\notification\manager')
	39	+ ->disableOriginalConstructor()
	40	+ ->getMock();
	41	+
	42	+ /**
	43	+ * @var \florinp\messenger\libs\upload $upload
	44	+ */
	45	+ $upload = $this->getMockBuilder('\florinp\messenger\libs\upload')
	46	+ ->disableOriginalConstructor()
	47	+ ->getMock();
	48	+
	49	+ /**
	50	+ * @var \florinp\messenger\libs\download $download
	51	+ */
	52	+ $download = $this->getMockBuilder('\florinp\messenger\libs\download')
	53	+ ->disableOriginalConstructor()
	54	+ ->getMock();
	55	+
	56	+ $this->controller = new \florinp\messenger\controller\main(
	57	+ $request,
	58	+ $user,
	59	+ $model,
	60	+ $notification_manager,
	61	+ $upload,
	62	+ $download
	63	+ );
	64	+ }
	65	+
	66	+ public function tearDown() {
	67	+ $this->controller = null;
	68	+ parent::tearDown();
	69	+ }
	70	+
	71	+ public function publish_data() {
	72	+ return array(
	73	+ array(200, json_encode(array()))
	74	+ );
	75	+ }
	76	+ /**
	77	+ * @dataProvider publish_data
	78	+ */
	79	+ public function test_publish($status_code, $page_content) {
	80	+ $response = $this->controller->publish();
	81	+ $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
	82	+ $this->assertEquals($status_code, $response->getStatusCode());
	83	+ $this->assertEquals($page_content, $response->getContent());
	84	+ }
	85	+
	86	+
	87	+ public function load_data() {
	88	+ return array(
	89	+ array(200, json_encode(array(
	90	+ 'success' => false,
	91	+ 'error' => 'The request is invalid'
	92	+ )))
	93	+ );
	94	+ }
	95	+ /**
	96	+ * @dataProvider load_data
	97	+ */
	98	+ public function test_load($status_code, $page_content) {
	99	+ $response = $this->controller->load();
	100	+ $this->assertInstanceOf('\Symfony\Component\HttpFoundation\Response', $response);
	101	+ $this->assertEquals($status_code, $response->getStatusCode());
	102	+ $this->assertEquals($page_content, $response->getContent());
	103	+ }
	104	+
	105	+
	106	+ public function updateMessages_data() {
	107	+ return array(
	108	+ array(200, json_encode(array('success' => false)))
	109	+ );
	110	+ }
111	111	}
112	112	\ No newline at end of file

florinp / phpbb-messenger

Push — master ( 800f7e...f06e6b )

Status

Category

Indentation +102 added lines, -102 removed lines patch added patch discarded remove patch