flipboxfactory / saml-sp

src/services/ProviderIdentity.php

Unused Use Statements +2 added lines, -3 removed lines

@@ -8,17 +8,16 @@
 
 namespace flipbox\saml\sp\services;
 
+use SAML2\Response as SamlResponse;
 use craft\elements\User;
 use flipbox\saml\core\exceptions\InvalidMessage;
 use flipbox\saml\core\helpers\MessageHelper;
 use flipbox\saml\core\records\ProviderInterface;
 use flipbox\saml\core\services\AbstractProviderIdentityService;
-use flipbox\saml\sp\records\ProviderIdentityRecord;
 use flipbox\saml\sp\Saml;
+use flipbox\saml\sp\records\ProviderIdentityRecord;
 use flipbox\saml\sp\services\login\AssertionTrait;
 use flipbox\saml\sp\traits\SamlPluginEnsured;
-use SAML2\Assertion;
-use SAML2\Response as SamlResponse;
 use yii\base\UserException;
 
 /**

src/controllers/LoginController.php

Doc Comments -1 removed lines

@@ -114,7 +114,6 @@
     }
 
     /**
-     * @param SamlResponse $response
      * @throws HttpException
      */
     protected function throwIdpNotFoundWithUid($uid)

Unused Use Statements +3 added lines, -3 removed lines

@@ -9,17 +9,17 @@
 namespace flipbox\saml\sp\controllers;
 
 use Craft;
+use SAML2\AuthnRequest;
+use SAML2\Response as SamlResponse;
 use flipbox\saml\core\controllers\messages\AbstractController;
 use flipbox\saml\core\exceptions\InvalidMetadata;
 use flipbox\saml\core\helpers\MessageHelper;
 use flipbox\saml\core\helpers\SerializeHelper;
 use flipbox\saml\core\services\bindings\Factory;
 use flipbox\saml\core\validators\Response as ResponseValidator;
-use flipbox\saml\sp\records\ProviderRecord;
 use flipbox\saml\sp\Saml;
+use flipbox\saml\sp\records\ProviderRecord;
 use flipbox\saml\sp\traits\SamlPluginEnsured;
-use SAML2\AuthnRequest;
-use SAML2\Response as SamlResponse;
 use yii\web\HttpException;
 
 class LoginController extends AbstractController

src/records/ProviderRecord.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -10,8 +10,8 @@
 
 use flipbox\saml\core\records\AbstractProvider;
 use flipbox\saml\core\records\ProviderInterface;
-use flipbox\saml\sp\models\Settings;
 use flipbox\saml\sp\Saml;
+use flipbox\saml\sp\models\Settings;
 
 class ProviderRecord extends AbstractProvider implements ProviderInterface
 {

src/services/login/UserGroups.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -6,12 +6,12 @@
 
 namespace flipbox\saml\sp\services\login;
 
+use SAML2\Assertion;
+use SAML2\Response;
 use craft\elements\User as UserElement;
 use craft\helpers\StringHelper;
 use craft\models\UserGroup;
 use flipbox\saml\sp\Saml;
-use SAML2\Assertion;
-use SAML2\Response;
 use yii\base\UserException;
 
 /**

src/services/messages/AuthnRequest.php

Doc Comments +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 
     /**
      * @param AbstractProvider $identityProvider
-     * @return \SAML2\XML\md\IndexedEndpointType|null
+     * @return EndpointType
      * @throws InvalidMetadata
      */
     private function firstIdpSsoService(AbstractProvider $identityProvider): EndpointType

Unused Use Statements +4 added lines, -4 removed lines

@@ -2,16 +2,16 @@
 
 namespace flipbox\saml\sp\services\messages;
 
+use SAML2\AuthnRequest as SamlAuthnRequest;
+use SAML2\Constants;
+use SAML2\XML\md\EndpointType;
 use craft\base\Component;
 use flipbox\keychain\records\KeyChainRecord;
 use flipbox\saml\core\exceptions\InvalidMetadata;
 use flipbox\saml\core\helpers\MessageHelper;
 use flipbox\saml\core\records\AbstractProvider;
-use flipbox\saml\sp\models\Settings;
 use flipbox\saml\sp\Saml;
-use SAML2\AuthnRequest as SamlAuthnRequest;
-use SAML2\Constants;
-use SAML2\XML\md\EndpointType;
+use flipbox\saml\sp\models\Settings;
 use yii\base\Event;
 
 class AuthnRequest extends Component

src/services/login/User.php

Doc Comments +2 added lines, -1 removed lines

@@ -267,6 +267,7 @@ 
 
     /**
      * @param UserElement $user
+     * @param string $fieldHandle
      * @return Field|null
      */
     protected function getFieldLayoutField(UserElement $user, $fieldHandle)
@@ -316,7 +317,7 @@ 
      **************************************************/
 
     /**
-     * @param $username
+     * @param string|null $username
      * @return UserElement
      * @throws UserException
      */

Unused Use Statements +2 added lines, -2 removed lines

@@ -6,16 +6,16 @@
 
 namespace flipbox\saml\sp\services\login;
 
+use SAML2\Response as SamlResponse;
 use craft\base\Field;
 use craft\elements\User as UserElement;
 use craft\models\FieldLayout;
 use flipbox\saml\core\exceptions\InvalidMessage;
 use flipbox\saml\core\helpers\MessageHelper;
 use flipbox\saml\core\helpers\ProviderHelper;
+use flipbox\saml\sp\Saml;
 use flipbox\saml\sp\helpers\UserHelper;
 use flipbox\saml\sp\records\ProviderIdentityRecord;
-use flipbox\saml\sp\Saml;
-use SAML2\Response as SamlResponse;
 use yii\base\UserException;
 
 /**

src/commands/MetadataController.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -4,8 +4,8 @@
 namespace flipbox\saml\sp\commands;
 
 use craft\console\Controller;
-use flipbox\saml\sp\records\ProviderRecord;
 use flipbox\saml\sp\Saml;
+use flipbox\saml\sp\records\ProviderRecord;
 use yii\console\ExitCode;
 use yii\console\widgets\Table;