Completed
Push — master ( f74ca7...ea85ac )
by Damien
10:39
created
src/controllers/LoginController.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,6 @@
 block discarded – undo
114 114
     }
115 115
 
116 116
     /**
117
-     * @param SamlResponse $response
118 117
      * @throws HttpException
119 118
      */
120 119
     protected function throwIdpNotFoundWithUid($uid)
Please login to merge, or discard this patch.
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -9,17 +9,17 @@
 block discarded – undo
9 9
 namespace flipbox\saml\sp\controllers;
10 10
 
11 11
 use Craft;
12
+use SAML2\AuthnRequest;
13
+use SAML2\Response as SamlResponse;
12 14
 use flipbox\saml\core\controllers\messages\AbstractController;
13 15
 use flipbox\saml\core\exceptions\InvalidMetadata;
14 16
 use flipbox\saml\core\helpers\MessageHelper;
15 17
 use flipbox\saml\core\services\bindings\Factory;
16 18
 use flipbox\saml\core\validators\Response as ResponseValidator;
19
+use flipbox\saml\sp\Saml;
17 20
 use flipbox\saml\sp\events\RelayState;
18 21
 use flipbox\saml\sp\records\ProviderRecord;
19
-use flipbox\saml\sp\Saml;
20 22
 use flipbox\saml\sp\traits\SamlPluginEnsured;
21
-use SAML2\AuthnRequest;
22
-use SAML2\Response as SamlResponse;
23 23
 use yii\base\Event;
24 24
 use yii\web\HttpException;
25 25
 
Please login to merge, or discard this patch.
src/records/ProviderRecord.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,8 +10,8 @@
 block discarded – undo
10 10
 
11 11
 use flipbox\saml\core\records\AbstractProvider;
12 12
 use flipbox\saml\core\records\ProviderInterface;
13
-use flipbox\saml\sp\models\Settings;
14 13
 use flipbox\saml\sp\Saml;
14
+use flipbox\saml\sp\models\Settings;
15 15
 
16 16
 class ProviderRecord extends AbstractProvider implements ProviderInterface
17 17
 {
Please login to merge, or discard this patch.
src/services/messages/AuthnRequest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
 
22 22
     /**
23 23
      * @param AbstractProvider $identityProvider
24
-     * @return \SAML2\XML\md\IndexedEndpointType|null
24
+     * @return EndpointType
25 25
      * @throws InvalidMetadata
26 26
      */
27 27
     private function firstIdpSsoService(AbstractProvider $identityProvider): EndpointType
Please login to merge, or discard this patch.
Unused Use Statements   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -2,18 +2,17 @@
 block discarded – undo
2 2
 
3 3
 namespace flipbox\saml\sp\services\messages;
4 4
 
5
+use SAML2\AuthnRequest as SamlAuthnRequest;
6
+use SAML2\Constants;
7
+use SAML2\XML\md\EndpointType;
8
+use SAML2\XML\saml\Issuer;
5 9
 use craft\base\Component;
6 10
 use flipbox\keychain\records\KeyChainRecord;
7 11
 use flipbox\saml\core\exceptions\InvalidMetadata;
8 12
 use flipbox\saml\core\helpers\MessageHelper;
9 13
 use flipbox\saml\core\records\AbstractProvider;
10
-use flipbox\saml\sp\models\Settings;
11 14
 use flipbox\saml\sp\Saml;
12
-use SAML2\AuthnRequest as SamlAuthnRequest;
13
-use SAML2\Constants;
14
-use SAML2\XML\md\EndpointType;
15
-use SAML2\XML\saml\Issuer;
16
-use yii\base\Event;
15
+use flipbox\saml\sp\models\Settings;
17 16
 
18 17
 class AuthnRequest extends Component
19 18
 {
Please login to merge, or discard this patch.
src/commands/MetadataController.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@
 block discarded – undo
4 4
 namespace flipbox\saml\sp\commands;
5 5
 
6 6
 use craft\console\Controller;
7
-use flipbox\saml\sp\records\ProviderRecord;
8 7
 use flipbox\saml\sp\Saml;
8
+use flipbox\saml\sp\records\ProviderRecord;
9 9
 use yii\console\ExitCode;
10 10
 use yii\console\widgets\Table;
11 11
 
Please login to merge, or discard this patch.
src/services/Login.php 1 patch
Unused Use Statements   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -8,17 +8,15 @@
 block discarded – undo
8 8
 
9 9
 namespace flipbox\saml\sp\services;
10 10
 
11
+use SAML2\Response as SamlResponse;
11 12
 use craft\base\Component;
12 13
 use craft\elements\User;
13
-use flipbox\saml\core\exceptions\InvalidMessage;
14
-use flipbox\saml\core\helpers\MessageHelper;
14
+use flipbox\saml\sp\Saml;
15 15
 use flipbox\saml\sp\events\UserLogin;
16 16
 use flipbox\saml\sp\models\Settings;
17 17
 use flipbox\saml\sp\records\ProviderIdentityRecord;
18 18
 use flipbox\saml\sp\records\ProviderRecord;
19
-use flipbox\saml\sp\Saml;
20 19
 use flipbox\saml\sp\services\login\AssertionTrait;
21
-use SAML2\Response as SamlResponse;
22 20
 use yii\base\UserException;
23 21
 
24 22
 /**
Please login to merge, or discard this patch.
src/services/login/UserGroups.php 1 patch
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -6,14 +6,14 @@
 block discarded – undo
6 6
 
7 7
 namespace flipbox\saml\sp\services\login;
8 8
 
9
+use SAML2\Assertion;
10
+use SAML2\Response;
9 11
 use craft\elements\User as UserElement;
10 12
 use craft\helpers\StringHelper;
11 13
 use craft\models\UserGroup;
14
+use flipbox\saml\sp\Saml;
12 15
 use flipbox\saml\sp\models\Settings;
13 16
 use flipbox\saml\sp\records\ProviderRecord;
14
-use flipbox\saml\sp\Saml;
15
-use SAML2\Assertion;
16
-use SAML2\Response;
17 17
 use yii\base\UserException;
18 18
 
19 19
 /**
Please login to merge, or discard this patch.
src/services/login/User.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -299,6 +299,7 @@
 block discarded – undo
299 299
 
300 300
     /**
301 301
      * @param UserElement $user
302
+     * @param string $fieldHandle
302 303
      * @return Field|null
303 304
      */
304 305
     protected function getFieldLayoutField(UserElement $user, $fieldHandle)
Please login to merge, or discard this patch.
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -6,18 +6,18 @@
 block discarded – undo
6 6
 
7 7
 namespace flipbox\saml\sp\services\login;
8 8
 
9
+use SAML2\Response as SamlResponse;
10
+use SAML2\XML\saml\Attribute;
9 11
 use craft\base\Field;
10 12
 use craft\elements\User as UserElement;
11 13
 use craft\models\FieldLayout;
12 14
 use flipbox\saml\core\exceptions\InvalidMessage;
13 15
 use flipbox\saml\core\helpers\ProviderHelper;
16
+use flipbox\saml\sp\Saml;
14 17
 use flipbox\saml\sp\helpers\UserHelper;
15 18
 use flipbox\saml\sp\models\Settings;
16 19
 use flipbox\saml\sp\records\ProviderIdentityRecord;
17 20
 use flipbox\saml\sp\records\ProviderRecord;
18
-use flipbox\saml\sp\Saml;
19
-use SAML2\Response as SamlResponse;
20
-use SAML2\XML\saml\Attribute;
21 21
 use yii\base\UserException;
22 22
 
23 23
 /**
Please login to merge, or discard this patch.
src/services/ProviderIdentity.php 1 patch
Unused Use Statements   +1 added lines, -4 removed lines patch added patch discarded remove patch
@@ -8,18 +8,15 @@
 block discarded – undo
8 8
 
9 9
 namespace flipbox\saml\sp\services;
10 10
 
11
+use SAML2\Response as SamlResponse;
11 12
 use craft\elements\User;
12 13
 use flipbox\saml\core\exceptions\InvalidMessage;
13
-use flipbox\saml\core\helpers\MessageHelper;
14 14
 use flipbox\saml\core\records\ProviderInterface;
15 15
 use flipbox\saml\core\services\AbstractProviderIdentityService;
16 16
 use flipbox\saml\sp\records\ProviderIdentityRecord;
17 17
 use flipbox\saml\sp\records\ProviderRecord;
18
-use flipbox\saml\sp\Saml;
19 18
 use flipbox\saml\sp\services\login\AssertionTrait;
20 19
 use flipbox\saml\sp\traits\SamlPluginEnsured;
21
-use SAML2\Assertion;
22
-use SAML2\Response as SamlResponse;
23 20
 use yii\base\UserException;
24 21
 
25 22
 /**
Please login to merge, or discard this patch.