flipboxfactory / saml-core

src/services/ProviderServiceInterface.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,6 @@ 
     public function save(AbstractProvider $record, $runValidation = true, $attributeNames = null);
 
     /**
-     * @param ProviderInterface $provider
      * @return bool|int
      */
     public function delete(ProviderInterface $record);
@@ -50,6 +49,7 @@ 
      * @param bool $runValidation
      * @param array|null $attributeNames
      * @throws \Exception
+     * @return void
      */
     public function linkToKey(
         AbstractProvider $provider,

Unused Use Statements +1 added lines, -1 removed lines

@@ -8,10 +8,10 @@
 
 namespace flipbox\saml\core\services;
 
+use SAML2\XML\md\EntityDescriptor;
 use flipbox\keychain\records\KeyChainRecord;
 use flipbox\saml\core\records\AbstractProvider;
 use flipbox\saml\core\records\ProviderInterface;
-use SAML2\XML\md\EntityDescriptor;
 use yii\db\Query;
 
 interface ProviderServiceInterface

src/controllers/AbstractSettingsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
     }
 
     /**
-     * @return mixed
+     * @return \yii\web\Response
      * @throws \yii\base\InvalidConfigException
      */
     public function actionSave()

src/services/AbstractProviderService.php

Doc Comments +1 added lines

@@ -69,6 +69,7 @@
 
     /**
      * @inheritdoc
+     * @param string $type
      */
     protected function findByType($type, $condition = [])
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -8,6 +8,7 @@ 
 
 namespace flipbox\saml\core\services;
 
+use SAML2\XML\md\EntityDescriptor;
 use craft\base\Component;
 use craft\helpers\Json;
 use flipbox\keychain\records\KeyChainRecord;
@@ -15,7 +16,6 @@ 
 use flipbox\saml\core\records\AbstractProvider;
 use flipbox\saml\core\records\LinkRecord;
 use flipbox\saml\core\records\ProviderInterface;
-use SAML2\XML\md\EntityDescriptor;
 
 abstract class AbstractProviderService extends Component implements ProviderServiceInterface, EnsureSAMLPlugin
 {

src/controllers/cp/view/metadata/AbstractDefaultController.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -9,8 +9,8 @@
 use Craft;
 use craft\helpers\UrlHelper;
 use flipbox\saml\core\AbstractPlugin;
-use flipbox\saml\core\controllers\cp\view\AbstractController;
 use flipbox\saml\core\EnsureSAMLPlugin;
+use flipbox\saml\core\controllers\cp\view\AbstractController;
 use flipbox\saml\core\models\SettingsInterface;
 
 /**

src/fields/AbstractExternalIdentity.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use craft\base\Field;
 use craft\elements\User;
 use craft\helpers\UrlHelper;
-use flipbox\saml\core\records\ProviderIdentityInterface;
 use yii\db\Query;
 
 abstract class AbstractExternalIdentity extends Field implements \flipbox\saml\core\EnsureSAMLPlugin

src/helpers/SecurityHelper.php

Doc Comments +5 added lines, -5 removed lines

@@ -43,7 +43,7 @@ 
 
     /**
      * @param string $certificate
-     * @return string|string[]|null
+     * @return string
      */
     public static function cleanCertificate(string $certificate)
     {
@@ -56,7 +56,7 @@ 
 
     /**
      * @param string $certificate
-     * @return string|string[]|null
+     * @return string
      */
     public static function cleanCertificateWhiteSpace(string $certificate)
     {
@@ -64,8 +64,8 @@ 
     }
 
     /**
-     * @param $pem
-     * @return mixed|string|null
+     * @param string $pem
+     * @return string
      * @throws \Exception
      * Thank you lightsaml/lightsaml
      */
@@ -115,7 +115,7 @@ 
 
     /**
      * @param EncryptedAssertion $encryptedAssertion
-     * @param $pemString
+     * @param boolean|string $pemString
      * @param array $blacklist
      * @return \SAML2\Assertion
      * @throws \Exception

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,10 +2,10 @@
 
 namespace flipbox\saml\core\helpers;
 
-use flipbox\saml\core\AbstractPlugin;
 use RobRichards\XMLSecLibs\XMLSecurityKey;
 use SAML2\EncryptedAssertion;
 use SAML2\Utilities\Certificate;
+use flipbox\saml\core\AbstractPlugin;
 
 class SecurityHelper
 {

src/records/traits/EntityDescriptor.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -3,9 +3,6 @@ 
 
 namespace flipbox\saml\core\records\traits;
 
-use flipbox\saml\core\helpers\EntityDescriptorHelper;
-use flipbox\saml\core\helpers\SecurityHelper;
-use flipbox\saml\core\records\AbstractProvider;
 use RobRichards\XMLSecLibs\XMLSecurityKey;
 use SAML2\Certificate\Key;
 use SAML2\Utilities\Certificate;
@@ -16,6 +13,9 @@ 
 use SAML2\XML\md\IndexedEndpointType;
 use SAML2\XML\md\KeyDescriptor;
 use SAML2\XML\md\SPSSODescriptor;
+use flipbox\saml\core\helpers\EntityDescriptorHelper;
+use flipbox\saml\core\helpers\SecurityHelper;
+use flipbox\saml\core\records\AbstractProvider;
 
 /**
  * Trait EntityDescriptor

src/validators/Response.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -3,13 +3,13 @@
 
 namespace flipbox\saml\core\validators;
 
-use flipbox\saml\core\records\AbstractProvider;
+use SAML2\Assertion\Validation\Result as AssertionResult;
 use SAML2\Configuration\Destination;
+use SAML2\Response as SamlResponse;
 use SAML2\Response\Validation\ConstraintValidator\DestinationMatches;
 use SAML2\Response\Validation\ConstraintValidator\IsSuccessful;
 use SAML2\Response\Validation\Result as ResponseResult;
-use SAML2\Assertion\Validation\Result as AssertionResult;
-use SAML2\Response as SamlResponse;
+use flipbox\saml\core\records\AbstractProvider;
 
 class Response
 {

src/controllers/cp/view/metadata/VariablesTrait.php

Unused Use Statements -2 removed lines

@@ -7,11 +7,9 @@
 namespace flipbox\saml\core\controllers\cp\view\metadata;
 
 use Craft;
-use craft\elements\User;
 use craft\helpers\UrlHelper;
 use flipbox\keychain\KeyChain;
 use flipbox\saml\core\AbstractPlugin;
-use flipbox\saml\core\helpers\MappingHelper;
 use flipbox\saml\core\models\SettingsInterface;
 use flipbox\saml\core\records\ProviderInterface;