SignedElement::validate() - Code Metrics - flipboxfactory/saml-core - Measure and Improve Code Quality continuously with Scrutinizer

SignedElement::validate() A
last analyzed 2021-04-19 18:56 UTC

↳ Parent: SignedElement

Complexity

Conditions	5
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.2408
c	0
b	0
f	0
cc	5
nc	7
nop	2

<?php


namespace flipbox\saml\core\validators;

use flipbox\saml\core\AbstractPlugin;
use RobRichards\XMLSecLibs\XMLSecurityKey;
use SAML2\SignedElement as SamlSignedElement;

class SignedElement
{
    /**
     * @var XMLSecurityKey[]
     */
    private $xmlSecurityKeyStore;

    /**
     * SignedElement constructor.
     * @param XMLSecurityKey[] $xmlSecurityKeyStore
     */
    public function __construct(array $xmlSecurityKeyStore)
    {
        $this->xmlSecurityKeyStore = $xmlSecurityKeyStore;
    }


    public function validate(SamlSignedElement $signedElement, $result)
    {
        /** @var \Exception $error */
        $errors = [];
        $success = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        foreach ($this->xmlSecurityKeyStore as $key) {
            try {
                if ($success = $signedElement->validate($key)) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    // return on success ... no need to continue
                    return $result;
                }
            } catch (\Exception $e) {
                $errors[] = $e;
                \Craft::info($e->getMessage(), AbstractPlugin::SAML_CORE_HANDLE);
            }
        }

        if (! empty($errors)) {
            throw $errors[0];
        }

        return $result;
    }
}


1			<?php
2
3
4			namespace flipbox\saml\core\validators;
5
6			use flipbox\saml\core\AbstractPlugin;
7			use RobRichards\XMLSecLibs\XMLSecurityKey;
8			use SAML2\SignedElement as SamlSignedElement;
9
10			class SignedElement
11			{
12			/**
13			* @var XMLSecurityKey[]
14			*/
15			private $xmlSecurityKeyStore;
16
17			/**
18			* SignedElement constructor.
19			* @param XMLSecurityKey[] $xmlSecurityKeyStore
20			*/
21			public function __construct(array $xmlSecurityKeyStore)
22			{
23			$this->xmlSecurityKeyStore = $xmlSecurityKeyStore;
24			}
25
26
27			public function validate(SamlSignedElement $signedElement, $result)
28			{
29			/** @var \Exception $error */
30			$errors = [];
31			$success = false;
			0 ignored issues – show Unused Code introduced 2019-11-08 06:23 UTC by Report Bug Copy Issue Report `$success` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
32			foreach ($this->xmlSecurityKeyStore as $key) {
33			try {
34			if ($success = $signedElement->validate($key)) {
			0 ignored issues – show Unused Code introduced 2019-11-08 06:23 UTC by Report Bug Copy Issue Report `$success` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			// return on success ... no need to continue
36			return $result;
37			}
38			} catch (\Exception $e) {
39			$errors[] = $e;
40			\Craft::info($e->getMessage(), AbstractPlugin::SAML_CORE_HANDLE);
41			}
42			}
43
44			if (! empty($errors)) {
45			throw $errors[0];
46			}
47
48			return $result;
49			}
50			}
51

flipboxfactory / saml-core

SignedElement::validate() A last analyzed 2021-04-19 18:56 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SignedElement::validate() A
last analyzed 2021-04-19 18:56 UTC