flipbox\saml\core\validators\SignedElement

Complexity

Total Complexity

6

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	validate()	0	23	5

<?php


namespace flipbox\saml\core\validators;

use flipbox\saml\core\AbstractPlugin;
use RobRichards\XMLSecLibs\XMLSecurityKey;
use SAML2\SignedElement as SamlSignedElement;

class SignedElement
{
    /**
     * @var XMLSecurityKey[]
     */
    private $xmlSecurityKeyStore;

    /**
     * SignedElement constructor.
     * @param XMLSecurityKey[] $xmlSecurityKeyStore
     */
    public function __construct(array $xmlSecurityKeyStore)
    {
        $this->xmlSecurityKeyStore = $xmlSecurityKeyStore;
    }


    public function validate(SamlSignedElement $signedElement, $result)
    {
        /** @var \Exception $error */
        $errors = [];
        $success = false;

$success is not used, you could remove the assignment.

        foreach ($this->xmlSecurityKeyStore as $key) {
            try {
                if ($success = $signedElement->validate($key)) {

$success is not used, you could remove the assignment.

                    // return on success ... no need to continue
                    return $result;
                }
            } catch (\Exception $e) {
                $errors[] = $e;
                \Craft::info($e->getMessage(), AbstractPlugin::SAML_CORE_HANDLE);
            }
        }

        if (! empty($errors)) {
            throw $errors[0];
        }

        return $result;
    }
}